- gerrit-log - lists.osmocom.org

[L] Change in ...osmo-s1gw[master]: doc/manuals: add overview, document running and configuration
by pespin 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email ) Change subject: doc/manuals: add overview, document running and configuration ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4ceca069866d7191ef2b153af95a20cb522bffeb Gerrit-Change-Number: 42364 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:19:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: transceiver: add optional Laurent burst LUT modulation (int16)
by pespin 16 Mar '26

16 Mar '26

Attention is currently required from: Hoernchen, Timur Davydov, laforge, tnt. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email ) Change subject: transceiver: add optional Laurent burst LUT modulation (int16) ...................................................................... Patch Set 13: (1 comment) Patchset: PS13: @dtv.comp@gmail.com afaict this patch is ortogonal to all the WebSDR transceiver stuff, so I'd advise to not have the WebSDR stuff as dependency so it can more easily be reviewed and merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2 Gerrit-Change-Number: 42248 Gerrit-PatchSet: 13 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:17:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmocore[master]: osmo_io: Rewrite iofd_handle_send_completion() to fix multiple issues
by jolly 16 Mar '26

16 Mar '26

Attention is currently required from: daniel, fixeria, laforge, pespin. jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/42354?usp=email ) Change subject: osmo_io: Rewrite iofd_handle_send_completion() to fix multiple issues ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia016e4df7be5e534a8212f7271caff9779e08eb1 Gerrit-Change-Number: 42354 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:16:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-trx[master]: device/websdr: add WebSDR transceiver backend and build target
by pespin 16 Mar '26

16 Mar '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email ) Change subject: device/websdr: add WebSDR transceiver backend and build target ...................................................................... Patch Set 3: (2 comments) File Transceiver52M/device/websdr/TransceiverWebSdr.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/3d1c750c_4ab71044?usp… : PS3, Line 50: : Transceiver(cfg, wTransmitLatency, wRadioInterface) I'm not really liking the patch. You are mixing tons of stuff in the same patch and changing/maningling the whole architecture of the file structure. device backends under Transcevier52/device/ are expected to have mostly only implementations/subclasses of radioDevice, not whole reimplementations of Transceiver, etc. Something is wrong here. File Transceiver52M/device/websdr/osmo-trx-websdr.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/0cd47618_c1a5e847?usp… : PS3, Line 151: g_trx_ctx->cfg.filler = FILLER_DUMMY; check indentation here and below. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42408?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO ...................................................................... gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO Change-Id: Ic1cbba2b2a746667b9920ed2ed19b3848185977d --- M include/osmocom/gsm/protocol/gsm_04_08.h M src/gsm/gsm48.c 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 27182b6..c3263be 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -1571,7 +1571,6 @@ #define GSM48_MT_RR_HANDO_COMPL 0x2c #define GSM48_MT_RR_HANDO_FAIL 0x28 #define GSM48_MT_RR_HANDO_INFO 0x2d -#define GSM48_MT_RR_HANDO_INFO 0x2d #define GSM48_MT_RR_DTM_ASS_CMD 0x4c #define GSM48_MT_RR_CELL_CHG_ORDER 0x08 diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 99d93ec..57e39ab 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -1572,7 +1572,6 @@ OSMO_VALUE_STRING(GSM48_MT_RR_HANDO_COMPL), OSMO_VALUE_STRING(GSM48_MT_RR_HANDO_FAIL), OSMO_VALUE_STRING(GSM48_MT_RR_HANDO_INFO), - OSMO_VALUE_STRING(GSM48_MT_RR_HANDO_INFO), OSMO_VALUE_STRING(GSM48_MT_RR_DTM_ASS_CMD), OSMO_VALUE_STRING(GSM48_MT_RR_CELL_CHG_ORDER), -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42408?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1cbba2b2a746667b9920ed2ed19b3848185977d Gerrit-Change-Number: 42408 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm48: fix missing/misspelled value-strings
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42407?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gsm48: fix missing/misspelled value-strings ...................................................................... gsm48: fix missing/misspelled value-strings Change-Id: I8d2333290c7715fd75ce7e7c759cb564a26b7461 --- M src/gsm/gsm48.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 71e0186..99d93ec 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -330,7 +330,7 @@ { GSM48_MT_CC_CONG_CTRL, "CONG_CTRL" }, { GSM48_MT_CC_FACILITY, "FACILITY" }, { GSM48_MT_CC_STATUS, "STATUS" }, - { GSM48_MT_CC_NOTIFY, "NOTFIY" }, + { GSM48_MT_CC_NOTIFY, "NOTIFY" }, { 0, NULL } }; @@ -346,7 +346,7 @@ { GSM48_MT_RR_INIT_REQ, "RR INITIALISATION REQUEST" }, { GSM48_MT_RR_ADD_ASS, "ADDITIONAL ASSIGNMENT" }, { GSM48_MT_RR_IMM_ASS, "IMMEDIATE ASSIGNMENT" }, - { GSM48_MT_RR_IMM_ASS_EXT, "MMEDIATE ASSIGNMENT EXTENDED" }, + { GSM48_MT_RR_IMM_ASS_EXT, "IMMEDIATE ASSIGNMENT EXTENDED" }, { GSM48_MT_RR_IMM_ASS_REJ, "IMMEDIATE ASSIGNMENT REJECT" }, { GSM48_MT_RR_DTM_ASS_FAIL, "DTM ASSIGNMENT FAILURE" }, { GSM48_MT_RR_DTM_REJECT, "DTM REJECT" }, @@ -433,7 +433,7 @@ /* VGCS uplink control messages */ { GSM48_MT_RR_VGCS_UPL_GRANT, "VGCS UPLINK GRANT" }, { GSM48_MT_RR_UPLINK_RELEASE, "UPLINK RELEASE" }, - { GSM48_MT_RR_UPLINK_FREE, "0c" }, + { GSM48_MT_RR_UPLINK_FREE, "UPLINK FREE" }, { GSM48_MT_RR_UPLINK_BUSY, "UPLINK BUSY" }, { GSM48_MT_RR_TALKER_IND, "TALKER INDICATION" }, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8d2333290c7715fd75ce7e7c759cb564a26b7461 Gerrit-Change-Number: 42407 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsmtap_util: gsmtap_gsm_channel_names[]: fix PTCCH string
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42409?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gsmtap_util: gsmtap_gsm_channel_names[]: fix PTCCH string ...................................................................... gsmtap_util: gsmtap_gsm_channel_names[]: fix PTCCH string Change-Id: Ic65668ae0363b991966bcf8ba4fb913940639964 --- M src/core/gsmtap_util.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c index b46f273..1bda690 100644 --- a/src/core/gsmtap_util.c +++ b/src/core/gsmtap_util.c @@ -598,7 +598,7 @@ { GSMTAP_CHANNEL_PACCH, "PACCH" }, { GSMTAP_CHANNEL_CBCH52, "CBCH" }, { GSMTAP_CHANNEL_PDCH, "PDCH" } , - { GSMTAP_CHANNEL_PTCCH, "PTTCH" }, + { GSMTAP_CHANNEL_PTCCH, "PTCCH" }, { GSMTAP_CHANNEL_CBCH51, "CBCH" }, { GSMTAP_CHANNEL_ACCH | GSMTAP_CHANNEL_SDCCH, "LSACCH" }, { GSMTAP_CHANNEL_ACCH | GSMTAP_CHANNEL_SDCCH4, "SACCH/4" }, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic65668ae0363b991966bcf8ba4fb913940639964 Gerrit-Change-Number: 42409 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmocore[master]: socket: osmo_sockaddr_from_str_and_uint(): fix memleak
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42404?usp=email ) Change subject: socket: osmo_sockaddr_from_str_and_uint(): fix memleak ...................................................................... socket: osmo_sockaddr_from_str_and_uint(): fix memleak `addrinfo_helper()` internally calls `getaddrinfo()`, whose result must be freed with `freeaddrinfo()`. On the size-check error path the function returns early without freeing. Fix this. Change-Id: Ib05e1b8f2465e0db79e7b45de151dc9945e27924 --- M src/core/socket.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/core/socket.c b/src/core/socket.c index 6cd82f0..3a2d7b7 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -1762,8 +1762,10 @@ if (!ai) return -EIO; - if (ai->ai_addrlen > sizeof(*osa_out)) + if (ai->ai_addrlen > sizeof(*osa_out)) { + freeaddrinfo(ai); return -ENOSPC; + } memcpy(&osa_out->u.sa, ai->ai_addr, ai->ai_addrlen); freeaddrinfo(ai); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42404?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib05e1b8f2465e0db79e7b45de151dc9945e27924 Gerrit-Change-Number: 42404 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsup: encode_pdp_info(): fix wrong pdp_address index
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42403?usp=email ) Change subject: gsup: encode_pdp_info(): fix wrong pdp_address index ...................................................................... gsup: encode_pdp_info(): fix wrong pdp_address index The `PDP_TYPE_N_IETF_IPv4v6` case encodes two addresses: IPv4 from `pdp_address[0]` and IPv6 from `pdp_address[1]`. The IPv4 part is encoded correctly, but the IPv6 part checks the wrong index. The decoder decode_pdp_address() correctly puts the IPv4 address in `pdp_address[0]` and the IPv6 address in `pdp_address[1]`. Because `pdp_address[0].sa_family` is `AF_INET` (not `AF_INET6`), the second condition is always false in a proper dual-stack context, so the IPv6 part is silently dropped from every outgoing dual-stack GSUP message. Change-Id: Ibc4a438ee7b06346839e78dc14d9d5b11b1c5bbd --- M src/gsm/gsup.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/gsm/gsup.c b/src/gsm/gsup.c index 4f0a1b5..1e4ee6a 100644 --- a/src/gsm/gsup.c +++ b/src/gsm/gsup.c @@ -689,7 +689,7 @@ pdp_addr.ietf.v4v6.v4 = pdp_info->pdp_address[0].u.sin.sin_addr.s_addr; pdp_addr_len += sizeof(pdp_addr.ietf.v4v6.v4); } - if (pdp_info->pdp_address[0].u.sa.sa_family == AF_INET6) { + if (pdp_info->pdp_address[1].u.sa.sa_family == AF_INET6) { memcpy(pdp_addr.ietf.v4v6.v6, &pdp_info->pdp_address[1].u.sin6.sin6_addr, sizeof(pdp_addr.ietf.v4v6.v6)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibc4a438ee7b06346839e78dc14d9d5b11b1c5bbd Gerrit-Change-Number: 42403 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: stats: osmo_stats_reporter_udp_open(): fix unconditional jump
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42405?usp=email ) Change subject: stats: osmo_stats_reporter_udp_open(): fix unconditional jump ...................................................................... stats: osmo_stats_reporter_udp_open(): fix unconditional jump Change-Id: Ifb4842ea11e4df0cae8733438b3812a086396b99 Fixes: cc3694b65 ("Fix build for OSX") --- M src/core/stats.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/core/stats.c b/src/core/stats.c index 16e6f62..617c1a5 100644 --- a/src/core/stats.c +++ b/src/core/stats.c @@ -471,7 +471,8 @@ static int val = 1; rc = setsockopt(sock, SOL_SOCKET, SO_NOSIGPIPE, (void*)&val, sizeof(val)); - goto failed; + if (rc == -1) + goto failed; } #endif if (srep->bind_addr_len > 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifb4842ea11e4df0cae8733438b3812a086396b99 Gerrit-Change-Number: 42405 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log