- gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: global_platform: fix typo in SupportedTlsCipherSuitesForScp81
by fixeria 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42373?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: global_platform: fix typo in SupportedTlsCipherSuitesForScp81 ...................................................................... global_platform: fix typo in SupportedTlsCipherSuitesForScp81 The attribute name is misspelled. The BER-TLV infrastructure looks for `_construct`; this typo means `SupportedTlsCipherSuitesForScp81` will never decode its content. Change-Id: I0f637951b0eeb7eca2a8b543baa737f216a935ed --- M pySim/global_platform/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/73/42373/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0f637951b0eeb7eca2a8b543baa737f216a935ed Gerrit-Change-Number: 42373 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: global_platform: fix typo in ApplicationTemplate
by fixeria 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42374?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: global_platform: fix typo in ApplicationTemplate ...................................................................... global_platform: fix typo in ApplicationTemplate The keyword argument should be `nested=`. As written `ApplicationAID` is silently ignored - `ApplicationTemplate` will not descend into its nested TLVs. Change-Id: If45dbb0c9b09fe53560d109957ce339267a9f2b0 --- M pySim/global_platform/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/74/42374/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If45dbb0c9b09fe53560d109957ce339267a9f2b0 Gerrit-Change-Number: 42374 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: osmo_io: Fix msgb memleak if iofd is unregistered during write_cb wit...
by pespin 16 Mar '26

16 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42412?usp=email ) Change subject: osmo_io: Fix msgb memleak if iofd is unregistered during write_cb with >1 io buffers ...................................................................... osmo_io: Fix msgb memleak if iofd is unregistered during write_cb with >1 io buffers The msgbs are not allocated under the msghdr, hence if user unregistered the iofd we need to manually free all remaining msgbs when freeing the msghdr. Change-Id: I579bc2142bba02947021c47d94bf2fe4f2040b01 --- M src/core/osmo_io.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/12/42412/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 2a20405..ddf77ec 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -553,7 +553,7 @@ /* The user can unregister/close the iofd during callback above. */ if (!IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED)) - break; + goto free_remaining_idx; } iofd_msghdr_free(msghdr); return; @@ -606,9 +606,18 @@ /* The user can unregister/close the iofd during callback above. */ if (!IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED)) - break; + goto free_remaining_idx; } iofd_msghdr_free(msghdr); + return; + +free_remaining_idx: + for (idx = idx + 1; idx < msghdr->io_len; idx++) { + msgb_free(msghdr->msg[idx]); + msghdr->msg[idx] = NULL; + } + iofd_msghdr_free(msghdr); + return; } /* Public functions */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42412?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I579bc2142bba02947021c47d94bf2fe4f2040b01 Gerrit-Change-Number: 42412 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Timur Davydov 16 Mar '26

16 Mar '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: transceiver: split control command handling from socket I/O ...................................................................... transceiver: split control command handling from socket I/O - move control command parsing/response generation into ctrl_cmd_handle() - keep ctrl_sock_handle_rx() focused on socket read/write - make command input read-only where applicable - switch response formatting from sprintf() to snprintf() Change-Id: I5413aa511e951522270c75635e89448395fc429e --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 67 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/10/42410/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Jenkins Builder 16 Mar '26

16 Mar '26

Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 2: (1 comment) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/b66ecadd_7d67bf53?usp… : PS2, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 16 Mar 2026 09:38:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Timur Davydov 16 Mar '26

16 Mar '26

Timur Davydov has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... transceiver: split control command handling from socket I/O - move control command parsing/response generation into ctrl_cmd_handle() - keep ctrl_sock_handle_rx() focused on socket read/write - make command input read-only where applicable - switch response formatting from sprintf() to snprintf() Change-Id: I5413aa511e951522270c75635e89448395fc429e --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 67 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/10/42410/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-CC: Jenkins Builder

1 0

[L] Change in osmo-trx[master]: device/websdr: add WebSDR transceiver backend and build target
by Timur Davydov 16 Mar '26

16 Mar '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: device/websdr: add WebSDR transceiver backend and build target ...................................................................... device/websdr: add WebSDR transceiver backend and build target - add libosmo-trx-websdr library and pkg-config file - integrate WebSDR device into the autotools build system - update .gitignore for wasm and pkg-config artifacts Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d --- M .gitignore M Transceiver52M/Makefile.am M Transceiver52M/device/Makefile.am A Transceiver52M/device/websdr/Makefile.am A Transceiver52M/device/websdr/TransceiverWebSdr.cpp A Transceiver52M/device/websdr/TransceiverWebSdr.h A Transceiver52M/device/websdr/libosmo-trx-websdr.pc.in A Transceiver52M/device/websdr/osmo-trx-websdr.cpp A Transceiver52M/device/websdr/osmo-trx-websdr.h A Transceiver52M/device/websdr/radioInterfaceWebSdr.cpp A Transceiver52M/device/websdr/radioInterfaceWebSdr.h M Transceiver52M/radioInterface.h M configure.ac 13 files changed, 852 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/42411/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables
by pespin 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email ) Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 Gerrit-Change-Number: 42406 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 09:31:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Jenkins Builder 16 Mar '26

16 Mar '26

Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 1: (2 comments) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/b704c931_da212c57?usp… : PS1, Line 220: int ctrl_cmd_handle(int chan, const char* buffer, char *response, size_t response_size); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/ce814b45_364a4bf4?usp… : PS1, Line 220: int ctrl_cmd_handle(int chan, const char* buffer, char *response, size_t response_size); "foo* bar" should be "foo *bar" -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 16 Mar 2026 09:23:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-trx[master]: device/websdr: add WebSDR transceiver backend and build target
by Jenkins Builder 16 Mar '26

16 Mar '26

Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email ) Change subject: device/websdr: add WebSDR transceiver backend and build target ...................................................................... Patch Set 1: (7 comments) File Transceiver52M/device/websdr/TransceiverWebSdr.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/86b87ddd_cba35547?usp… : PS1, Line 58: int post_tx_burst(size_t chan, char* buffer, int msgLen); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/173060ea_5f6bbf7d?usp… : PS1, Line 70: #endif /* TRANSCEIVER_WEBSDR_H */ adding a line without newline at end of file File Transceiver52M/device/websdr/osmo-trx-websdr.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/d11fd06b_d5bc9b1a?usp… : PS1, Line 31: int osmotrxlib_process_command(const char* buffer, char *response, size_t response_size); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/3753bf59_11d09060?usp… : PS1, Line 34: int osmotrxlib_push_rx_short_vector(short* buffers, int samples, int underrun, "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/f0b219d8_62b21ed0?usp… : PS1, Line 36: int osmotrxlib_get_rx_burst(char* buf, int maxLen); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b5b3c413_aa87627a?usp… : PS1, Line 40: int osmotrxlib_put_tx_burst(char* buffer, int msgLen); "foo* bar" should be "foo *bar" File Transceiver52M/device/websdr/radioInterfaceWebSdr.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/4d152116_94e19ef3?usp… : PS1, Line 27: int fillPullBuffer(short** buffers, int samples, "foo** bar" should be "foo **bar" -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 16 Mar 2026 09:19:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log