- gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs: make references to master branch consistent

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40441?usp=email ) Change subject: jobs: make references to master branch consistent ...................................................................... jobs: make references to master branch consistent Use "master" instead of: - "refs/remotes/origin/master" - "origin/master" - "*/master" This improves consistency and makes clear what should be used when adding new jobs. It also fixes the problem with */master that it may actually not only use the master branch, but also e.g. osmith/master which can lead to unintentionally building and publishing artifacts from the wrong branch. If we want to run a job on a different branch intentionally, such a job should have an extra argument for branch that can be changed when starting the job. Change-Id: I7389585165bf3a790c7a338d10f5f7fe2311ee69 --- M jobs/coverity-status.yml M jobs/coverity.yml M jobs/octsim_osmo-ccid-firmware.yml M jobs/osmo-gsm-manuals-trigger.yml M jobs/osmo-gsm-tester-runner.yml M jobs/osmocom-build-tags-against-master.yml M jobs/osmocom-depcheck.yml M jobs/osmocom-list-commits.yml M jobs/osmocom-obs-check-builders.yml M jobs/osmocom-obs-nightly-asan.yml M jobs/osmocom-obs.yml M jobs/registry-rebuild-upload-fpga-build.yml M jobs/registry-triggers.yml M jobs/simtester-sanitize.yml M jobs/ttcn3-testsuites-kernel-git.yml M jobs/ttcn3-testsuites.yml M jobs/update-containers-osmo-python-tests.yml M jobs/update-osmo-ci-on-slaves.yml 18 files changed, 18 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/jobs/coverity-status.yml b/jobs/coverity-status.yml index cb7522e..4e1ade8 100644 --- a/jobs/coverity-status.yml +++ b/jobs/coverity-status.yml @@ -30,7 +30,7 @@ - string: name: BRANCH description: osmo-ci.git branch - default: 'origin/master' + default: 'master' scm: - git: url: https://gerrit.osmocom.org/osmo-ci diff --git a/jobs/coverity.yml b/jobs/coverity.yml index d7492c4..c70f1d1 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -34,7 +34,7 @@ - string: name: BRANCH description: osmo-ci.git branch - default: 'origin/master' + default: 'master' scm: - git: url: https://gerrit.osmocom.org/osmo-ci diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 7db1039..24e8d3b 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -27,7 +27,7 @@ git-config-email: 'jenkins(a)osmocom.org' skip-tag: true branches: - - 'origin/master' + - 'master' properties: - build-blocker: block-level: GLOBAL diff --git a/jobs/osmo-gsm-manuals-trigger.yml b/jobs/osmo-gsm-manuals-trigger.yml index 29882e3..1f59de8 100644 --- a/jobs/osmo-gsm-manuals-trigger.yml +++ b/jobs/osmo-gsm-manuals-trigger.yml @@ -26,7 +26,7 @@ git-config-email: 'jenkins(a)osmocom.org' skip-tag: true branches: - - 'origin/master' + - 'master' triggers: - pollscm: cron: "H/5 * * * *" diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 57652ac..0a9d824 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -102,7 +102,7 @@ parameters: - string: name: "OSMO_GSM_TESTER_BRANCH" - default: "origin/master" + default: "master" description: "Which branch/sha should be used for testing" - string: name: "OSMO_GSM_TESTER_OPTS" diff --git a/jobs/osmocom-build-tags-against-master.yml b/jobs/osmocom-build-tags-against-master.yml index 39d4b2b..c3bbea2 100644 --- a/jobs/osmocom-build-tags-against-master.yml +++ b/jobs/osmocom-build-tags-against-master.yml @@ -21,7 +21,7 @@ name: BRANCH description: | osmo-ci.git branch where the osmocom-build-old-tags-against-master.sh gets pulled from - default: '*/master' + default: 'master' builders: - shell: | docker run \ diff --git a/jobs/osmocom-depcheck.yml b/jobs/osmocom-depcheck.yml index 5e9d247..f5cca1d 100644 --- a/jobs/osmocom-depcheck.yml +++ b/jobs/osmocom-depcheck.yml @@ -50,7 +50,7 @@ description: | Branch where the osmo-depcheck.py script gets pulled from. Only modify this if you are hacking on osmo-depcheck.py. - default: '*/master' + default: 'master' builders: - shell: | # Build the arguments diff --git a/jobs/osmocom-list-commits.yml b/jobs/osmocom-list-commits.yml index 5084879..482e3d0 100644 --- a/jobs/osmocom-list-commits.yml +++ b/jobs/osmocom-list-commits.yml @@ -21,7 +21,7 @@ name: BRANCH description: | osmo-ci.git branch where the osmocom-list-commits.sh gets pulled from - default: '*/master' + default: 'master' builders: - shell: | scripts/osmocom-list-commits.sh > commits.txt diff --git a/jobs/osmocom-obs-check-builders.yml b/jobs/osmocom-obs-check-builders.yml index 01fdba5..9069043 100644 --- a/jobs/osmocom-obs-check-builders.yml +++ b/jobs/osmocom-obs-check-builders.yml @@ -21,7 +21,7 @@ scm: - git: branches: - - 'origin/master' + - 'master' url: https://gerrit.osmocom.org/osmo-ci triggers: - timed: "@hourly" diff --git a/jobs/osmocom-obs-nightly-asan.yml b/jobs/osmocom-obs-nightly-asan.yml index bd5480e..7d4cf44 100644 --- a/jobs/osmocom-obs-nightly-asan.yml +++ b/jobs/osmocom-obs-nightly-asan.yml @@ -15,7 +15,7 @@ - string: name: BRANCH description: osmo-ci.git branch - default: 'refs/remotes/origin/master' + default: 'master' builders: - shell: | export PYTHONUNBUFFERED=1 diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index fd11055..fd0c1fe 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -43,7 +43,7 @@ - string: name: BRANCH description: osmo-ci.git branch - default: 'refs/remotes/origin/master' + default: 'master' - string: name: EMAIL_NOTIFICATIONS description: For failed job notifications, set to empty to disable diff --git a/jobs/registry-rebuild-upload-fpga-build.yml b/jobs/registry-rebuild-upload-fpga-build.yml index 9efa0ce..fc158c6 100644 --- a/jobs/registry-rebuild-upload-fpga-build.yml +++ b/jobs/registry-rebuild-upload-fpga-build.yml @@ -18,7 +18,7 @@ url: https://gerrit.osmocom.org/docker-playground skip-tag: true branches: - - 'origin/master' + - 'master' builders: - shell: | diff --git a/jobs/registry-triggers.yml b/jobs/registry-triggers.yml index 8154ff6..9a4dddc 100644 --- a/jobs/registry-triggers.yml +++ b/jobs/registry-triggers.yml @@ -20,7 +20,7 @@ - git: url: https://gerrit.osmocom.org/{repos} branches: - - 'origin/master' + - 'master' trigger: email: jenkins-notifications(a)lists.osmocom.org triggers: diff --git a/jobs/simtester-sanitize.yml b/jobs/simtester-sanitize.yml index fce678a..9c19665 100644 --- a/jobs/simtester-sanitize.yml +++ b/jobs/simtester-sanitize.yml @@ -20,7 +20,7 @@ - string: name: BRANCH description: pysim.git branch - default: 'origin/master' + default: 'master' - string: name: EMAIL_NOTIFICATIONS description: For failed build notifications, set to empty to disable diff --git a/jobs/ttcn3-testsuites-kernel-git.yml b/jobs/ttcn3-testsuites-kernel-git.yml index 6ce8fe8..f757628 100644 --- a/jobs/ttcn3-testsuites-kernel-git.yml +++ b/jobs/ttcn3-testsuites-kernel-git.yml @@ -67,7 +67,7 @@ Branch of <code>docker-playground.git</code> (for development of the test infrastructure, don't change this when testing kernel trees). - default: '*/master' + default: 'master' builders: - shell: |- diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 0ea8a96..5125038 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -92,7 +92,7 @@ description: | Branch of <code>docker-playground.git</code>. Only modify if you are hacking on the docker-playground scripts. - default: '*/master' + default: 'master' builders: - shell: |- export REGISTRY_HOST="registry.osmocom.org" diff --git a/jobs/update-containers-osmo-python-tests.yml b/jobs/update-containers-osmo-python-tests.yml index 63b2929..0994dc1 100644 --- a/jobs/update-containers-osmo-python-tests.yml +++ b/jobs/update-containers-osmo-python-tests.yml @@ -10,7 +10,7 @@ - git: url: https://gerrit.osmocom.org/python/osmo-python-tests branches: - - 'origin/master' + - 'master' skip-tag: true wipe-workspace: true triggers: diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 24e67b1..ea72086 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -73,7 +73,7 @@ git-config-email: 'jenkins(a)osmocom.org' skip-tag: true branches: - - 'origin/master' + - 'master' triggers: - pollscm: cron: "H/5 * * * *" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7389585165bf3a790c7a338d10f5f7fe2311ee69 Gerrit-Change-Number: 40441 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Implement NAS integrity check of DL messages

by pespin

Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, fixeria, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: 5gc: Implement NAS integrity check of DL messages ...................................................................... 5gc: Implement NAS integrity check of DL messages Change-Id: I118081af10f260513734550854c3a1751e32cbb4 --- M 5gc/C5G_Tests.ttcn M 5gc/gen_links.sh M 5gc/regen_makefile.sh M deps/Makefile M library/LTE_CryptoFunctions.ttcn M library/NGAP_Emulation.ttcn M library/NG_CryptoFunctionDefs.cc M library/NG_CryptoFunctions.ttcn M library/NG_NAS_Osmo_Templates.ttcn M library/ng_crypto/key_derivation.c M library/ng_crypto/key_derivation.h 11 files changed, 540 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/40440/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I118081af10f260513734550854c3a1751e32cbb4 Gerrit-Change-Number: 40440 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Implement NAS integrity check of DL messages

by pespin

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440?usp=email ) Change subject: 5gc: Implement NAS integrity check of DL messages ...................................................................... Patch Set 6: (5 comments) File 5gc/C5G_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/05bc2722_e209… : PS6, Line 44: NG_NAS_Osmo_Templates > duplicate, check above Acknowledged https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/5f99b440_44b1… : PS6, Line 91: "192.168.123.50" > idea: can probably be calculated from `imsi_suffix`? tbh I'm not even using it for now, and may be removed at some later point Not relevant to the steps I'm doing now, and I'm not really changing it in this commit. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/18206188_a115… : PS6, Line 310: abba > I hear "ABBA - Dancing Queen" in my head when reading this :D […] Indeed. That's supposed to be always 0x00000 in current release, so not really interesting. File library/NG_CryptoFunctions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/86d02e99_c0ba… : PS6, Line 175: if (nus.role == NG_NAS_ROLE_UE) { : return true; : } else { : return false; : } > `return nus. […] I just kept it the same as in LTE_CryptoFunctions.ttcn. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/235c02e3_80ae… : PS6, Line 264: make compiler happy about not returning > does `mtc.stop` really make compiler happy? […] Yes, but afaik ttcn3 doesn't have a way to tell the compiler that a function is not expected to ever return. Hence, the compiler only sees the flow returning from f_shutdown() and nothing being returned. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I118081af10f260513734550854c3a1751e32cbb4 Gerrit-Change-Number: 40440 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Jun 2025 11:16:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[S] Change in osmo-ci[master]: jobs: make references to master branch consistent

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40441?usp=email ) Change subject: jobs: make references to master branch consistent ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7389585165bf3a790c7a338d10f5f7fe2311ee69 Gerrit-Change-Number: 40441 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Jun 2025 11:08:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 5 days

1
0
0 0

[S] Change in osmo-ci[master]: jobs: make references to master branch consistent

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40441?usp=email ) Change subject: jobs: make references to master branch consistent ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7389585165bf3a790c7a338d10f5f7fe2311ee69 Gerrit-Change-Number: 40441 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Jun 2025 08:23:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 5 days

1
0
0 0

[S] Change in osmo-ci[master]: jobs: make references to master branch consistent

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40441?usp=email ) Change subject: jobs: make references to master branch consistent ...................................................................... jobs: make references to master branch consistent Use "master" instead of: - "refs/remotes/origin/master" - "origin/master" - "*/master" This improves consistency and makes clear what should be used when adding new jobs. It also fixes the problem with */master that it may actually not only use the master branch, but also e.g. osmith/master which can lead to unintentionally building and publishing artifacts from the wrong branch. If we want to run a job on a different branch intentionally, such a job should have an extra argument for branch that can be changed when starting the job. Change-Id: I7389585165bf3a790c7a338d10f5f7fe2311ee69 --- M jobs/coverity-status.yml M jobs/coverity.yml M jobs/octsim_osmo-ccid-firmware.yml M jobs/osmo-gsm-manuals-trigger.yml M jobs/osmo-gsm-tester-runner.yml M jobs/osmocom-build-tags-against-master.yml M jobs/osmocom-depcheck.yml M jobs/osmocom-list-commits.yml M jobs/osmocom-obs-check-builders.yml M jobs/osmocom-obs-nightly-asan.yml M jobs/osmocom-obs.yml M jobs/registry-rebuild-upload-fpga-build.yml M jobs/registry-triggers.yml M jobs/simtester-sanitize.yml M jobs/ttcn3-testsuites-kernel-git.yml M jobs/ttcn3-testsuites.yml M jobs/update-containers-osmo-python-tests.yml M jobs/update-osmo-ci-on-slaves.yml 18 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/41/40441/1 diff --git a/jobs/coverity-status.yml b/jobs/coverity-status.yml index cb7522e..4e1ade8 100644 --- a/jobs/coverity-status.yml +++ b/jobs/coverity-status.yml @@ -30,7 +30,7 @@ - string: name: BRANCH description: osmo-ci.git branch - default: 'origin/master' + default: 'master' scm: - git: url: https://gerrit.osmocom.org/osmo-ci diff --git a/jobs/coverity.yml b/jobs/coverity.yml index d7492c4..c70f1d1 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -34,7 +34,7 @@ - string: name: BRANCH description: osmo-ci.git branch - default: 'origin/master' + default: 'master' scm: - git: url: https://gerrit.osmocom.org/osmo-ci diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 7db1039..24e8d3b 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -27,7 +27,7 @@ git-config-email: 'jenkins(a)osmocom.org' skip-tag: true branches: - - 'origin/master' + - 'master' properties: - build-blocker: block-level: GLOBAL diff --git a/jobs/osmo-gsm-manuals-trigger.yml b/jobs/osmo-gsm-manuals-trigger.yml index 29882e3..1f59de8 100644 --- a/jobs/osmo-gsm-manuals-trigger.yml +++ b/jobs/osmo-gsm-manuals-trigger.yml @@ -26,7 +26,7 @@ git-config-email: 'jenkins(a)osmocom.org' skip-tag: true branches: - - 'origin/master' + - 'master' triggers: - pollscm: cron: "H/5 * * * *" diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 57652ac..0a9d824 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -102,7 +102,7 @@ parameters: - string: name: "OSMO_GSM_TESTER_BRANCH" - default: "origin/master" + default: "master" description: "Which branch/sha should be used for testing" - string: name: "OSMO_GSM_TESTER_OPTS" diff --git a/jobs/osmocom-build-tags-against-master.yml b/jobs/osmocom-build-tags-against-master.yml index 39d4b2b..c3bbea2 100644 --- a/jobs/osmocom-build-tags-against-master.yml +++ b/jobs/osmocom-build-tags-against-master.yml @@ -21,7 +21,7 @@ name: BRANCH description: | osmo-ci.git branch where the osmocom-build-old-tags-against-master.sh gets pulled from - default: '*/master' + default: 'master' builders: - shell: | docker run \ diff --git a/jobs/osmocom-depcheck.yml b/jobs/osmocom-depcheck.yml index 5e9d247..f5cca1d 100644 --- a/jobs/osmocom-depcheck.yml +++ b/jobs/osmocom-depcheck.yml @@ -50,7 +50,7 @@ description: | Branch where the osmo-depcheck.py script gets pulled from. Only modify this if you are hacking on osmo-depcheck.py. - default: '*/master' + default: 'master' builders: - shell: | # Build the arguments diff --git a/jobs/osmocom-list-commits.yml b/jobs/osmocom-list-commits.yml index 5084879..482e3d0 100644 --- a/jobs/osmocom-list-commits.yml +++ b/jobs/osmocom-list-commits.yml @@ -21,7 +21,7 @@ name: BRANCH description: | osmo-ci.git branch where the osmocom-list-commits.sh gets pulled from - default: '*/master' + default: 'master' builders: - shell: | scripts/osmocom-list-commits.sh > commits.txt diff --git a/jobs/osmocom-obs-check-builders.yml b/jobs/osmocom-obs-check-builders.yml index 01fdba5..9069043 100644 --- a/jobs/osmocom-obs-check-builders.yml +++ b/jobs/osmocom-obs-check-builders.yml @@ -21,7 +21,7 @@ scm: - git: branches: - - 'origin/master' + - 'master' url: https://gerrit.osmocom.org/osmo-ci triggers: - timed: "@hourly" diff --git a/jobs/osmocom-obs-nightly-asan.yml b/jobs/osmocom-obs-nightly-asan.yml index bd5480e..7d4cf44 100644 --- a/jobs/osmocom-obs-nightly-asan.yml +++ b/jobs/osmocom-obs-nightly-asan.yml @@ -15,7 +15,7 @@ - string: name: BRANCH description: osmo-ci.git branch - default: 'refs/remotes/origin/master' + default: 'master' builders: - shell: | export PYTHONUNBUFFERED=1 diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index fd11055..fd0c1fe 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -43,7 +43,7 @@ - string: name: BRANCH description: osmo-ci.git branch - default: 'refs/remotes/origin/master' + default: 'master' - string: name: EMAIL_NOTIFICATIONS description: For failed job notifications, set to empty to disable diff --git a/jobs/registry-rebuild-upload-fpga-build.yml b/jobs/registry-rebuild-upload-fpga-build.yml index 9efa0ce..fc158c6 100644 --- a/jobs/registry-rebuild-upload-fpga-build.yml +++ b/jobs/registry-rebuild-upload-fpga-build.yml @@ -18,7 +18,7 @@ url: https://gerrit.osmocom.org/docker-playground skip-tag: true branches: - - 'origin/master' + - 'master' builders: - shell: | diff --git a/jobs/registry-triggers.yml b/jobs/registry-triggers.yml index 8154ff6..9a4dddc 100644 --- a/jobs/registry-triggers.yml +++ b/jobs/registry-triggers.yml @@ -20,7 +20,7 @@ - git: url: https://gerrit.osmocom.org/{repos} branches: - - 'origin/master' + - 'master' trigger: email: jenkins-notifications(a)lists.osmocom.org triggers: diff --git a/jobs/simtester-sanitize.yml b/jobs/simtester-sanitize.yml index fce678a..9c19665 100644 --- a/jobs/simtester-sanitize.yml +++ b/jobs/simtester-sanitize.yml @@ -20,7 +20,7 @@ - string: name: BRANCH description: pysim.git branch - default: 'origin/master' + default: 'master' - string: name: EMAIL_NOTIFICATIONS description: For failed build notifications, set to empty to disable diff --git a/jobs/ttcn3-testsuites-kernel-git.yml b/jobs/ttcn3-testsuites-kernel-git.yml index 6ce8fe8..f757628 100644 --- a/jobs/ttcn3-testsuites-kernel-git.yml +++ b/jobs/ttcn3-testsuites-kernel-git.yml @@ -67,7 +67,7 @@ Branch of <code>docker-playground.git</code> (for development of the test infrastructure, don't change this when testing kernel trees). - default: '*/master' + default: 'master' builders: - shell: |- diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 0ea8a96..5125038 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -92,7 +92,7 @@ description: | Branch of <code>docker-playground.git</code>. Only modify if you are hacking on the docker-playground scripts. - default: '*/master' + default: 'master' builders: - shell: |- export REGISTRY_HOST="registry.osmocom.org" diff --git a/jobs/update-containers-osmo-python-tests.yml b/jobs/update-containers-osmo-python-tests.yml index 63b2929..0994dc1 100644 --- a/jobs/update-containers-osmo-python-tests.yml +++ b/jobs/update-containers-osmo-python-tests.yml @@ -10,7 +10,7 @@ - git: url: https://gerrit.osmocom.org/python/osmo-python-tests branches: - - 'origin/master' + - 'master' skip-tag: true wipe-workspace: true triggers: diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 24e67b1..ea72086 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -73,7 +73,7 @@ git-config-email: 'jenkins(a)osmocom.org' skip-tag: true branches: - - 'origin/master' + - 'master' triggers: - pollscm: cron: "H/5 * * * *" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7389585165bf3a790c7a338d10f5f7fe2311ee69 Gerrit-Change-Number: 40441 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 weeks, 5 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Implement NAS integrity check of DL messages

by fixeria

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440?usp=email ) Change subject: 5gc: Implement NAS integrity check of DL messages ...................................................................... Patch Set 6: Code-Review+1 (5 comments) File 5gc/C5G_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/ba61c8f9_ce64… : PS6, Line 44: NG_NAS_Osmo_Templates duplicate, check above https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/1356be67_5163… : PS6, Line 91: "192.168.123.50" idea: can probably be calculated from `imsi_suffix`? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/d436fac7_845d… : PS6, Line 310: abba I hear "ABBA - Dancing Queen" in my head when reading this :D https://www.youtube.com/watch?v=xFrGuyw1V8s File library/NG_CryptoFunctions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/b07c64d1_f4a7… : PS6, Line 175: if (nus.role == NG_NAS_ROLE_UE) { : return true; : } else { : return false; : } `return nus.role == NG_NAS_ROLE_UE`? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440/comment/4de3e160_8185… : PS6, Line 264: make compiler happy about not returning does `mtc.stop` really make compiler happy? `f_shutdown()` does this internally... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40440?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I118081af10f260513734550854c3a1751e32cbb4 Gerrit-Change-Number: 40440 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Jun 2025 18:24:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[M] Change in ...osmo-s1gw[master]: enft_kpi: make enb_set_addr/1 non-blocking

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40438?usp=email ) Change subject: enft_kpi: make enb_set_addr/1 non-blocking ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40438?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iacd380f66fc0249a6a645293abd5aac9cdba34d5 Gerrit-Change-Number: 40438 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Jun 2025 17:41:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[M] Change in ...osmo-s1gw[master]: enft_kpi: make enb_set_addr/1 non-blocking

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40438?usp=email ) Change subject: enft_kpi: make enb_set_addr/1 non-blocking ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40438/comment/974f451c_7e97… : PS2, Line 9: This function is called each time a new E-REB is established, while > E-RAB? Acknowledged -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40438?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iacd380f66fc0249a6a645293abd5aac9cdba34d5 Gerrit-Change-Number: 40438 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Jun 2025 17:39:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

[M] Change in ...osmo-s1gw[master]: enft_kpi: make enb_set_addr/1 non-blocking

by fixeria

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40438?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin Change subject: enft_kpi: make enb_set_addr/1 non-blocking ...................................................................... enft_kpi: make enb_set_addr/1 non-blocking This function is called each time a new E-RAB is established, while the result, be it success or failure, does not matter to s1ap_proxy. Use gen_server:cast/2 instead of gen_server:call/2 to avoid blocking. Change-Id: Iacd380f66fc0249a6a645293abd5aac9cdba34d5 Related: SYS#7307 --- M src/enft_kpi.erl 1 file changed, 29 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/38/40438/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40438?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iacd380f66fc0249a6a645293abd5aac9cdba34d5 Gerrit-Change-Number: 40438 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

2025

2024

2023

2022

gerrit-log