pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41572?usp=email )
Change subject: msc: Adapt testsuite to new OsmoCNI 202512 release
......................................................................
msc: Adapt testsuite to new OsmoCNI 202512 release
Change-Id: I9a393457eb5e57ca0a3f836b2c0366451c795097
---
M msc/BSC_ConnectionHandler.ttcn
M msc/MSC_Tests.ttcn
M msc/MSC_Tests_Iu.ttcn
3 files changed, 5 insertions(+), 18 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/41572/1
diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index dd285dd..98c9dce 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -1131,9 +1131,7 @@
cpars.got_osmux_count := 0;
/* MS <- MSC: Expect CC SETUP */
- /* Remove 'or Misc_Helpers.f_osmo_repo_is("latest")' after osmo-msc
- * 1.15.0 is released with I7046e9244fd9d4301ee2c4df1147a619f753739c */
- if (cpars.csd or Misc_Helpers.f_osmo_repo_is("latest")) {
+ if (cpars.csd) {
RAN_CONN.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_SETUP(cpars.transaction_id, *, cpars.called_party, *)));
} else {
/* Speech: check bearer capabilities against ts_Bcap_voice_mt
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 635e04f..013ecfd 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -8000,12 +8000,7 @@
execute( TC_lu_and_mo_call_reass_for_mt_codec() );
- /* This "nightly" if can be removed once libosmo-sigtran (osmo-stp) > 2.1.0 is released.
- * Currently released osmo-stp 2.1.0 ends up in in broken AS-ACTIVE+ASP-DOWN state when
- * restarting the ASP after exiting the related asp node through VTY: */
- if (Misc_Helpers.f_osmo_repo_is("nightly")) {
- execute( TC_stat_bsc_sctp_disconnected() );
- }
+ execute( TC_stat_bsc_sctp_disconnected() );
execute( TC_silent_call_start_stop() );
execute( TC_silent_call_active_conn() );
diff --git a/msc/MSC_Tests_Iu.ttcn b/msc/MSC_Tests_Iu.ttcn
index 75ecbe3..6c96041 100644
--- a/msc/MSC_Tests_Iu.ttcn
+++ b/msc/MSC_Tests_Iu.ttcn
@@ -712,17 +712,11 @@
execute( TC_iu_lu_with_invalid_mcc_mnc() );
execute( TC_iu_lu_and_expire_while_paging() );
- /* TODO: Iu + SGsAP related tests, e.g. paging on IuCS */
-
- /* Run this last: at the time of writing this test crashes the MSC */
execute( TC_mo_cc_iu_release() );
- /* This "nightly" if can be removed once libosmo-sigtran (osmo-stp) > 2.1.0 is released.
- * Currently released osmo-stp 2.1.0 ends up in in broken AS-ACTIVE+ASP-DOWN state when
- * restarting the ASP after exiting the related asp node through VTY: */
- if (Misc_Helpers.f_osmo_repo_is("nightly")) {
- execute( TC_stat_rnc_sctp_disconnected() );
- }
+ execute( TC_stat_rnc_sctp_disconnected() );
+
+ /* TODO: Iu + SGsAP related tests, e.g. paging on IuCS */
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41572?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9a393457eb5e57ca0a3f836b2c0366451c795097
Gerrit-Change-Number: 41572
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41573?usp=email )
Change subject: smlc: Adapt testsuite to new OsmoCNI 202512 release
......................................................................
smlc: Adapt testsuite to new OsmoCNI 202512 release
Change-Id: I61aaf5ae7b4975e68f573b1f432b74fab86d5355
---
M smlc/SMLC_Tests.ttcn
1 file changed, 3 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/41573/1
diff --git a/smlc/SMLC_Tests.ttcn b/smlc/SMLC_Tests.ttcn
index 393d69f..1d317bb 100644
--- a/smlc/SMLC_Tests.ttcn
+++ b/smlc/SMLC_Tests.ttcn
@@ -193,10 +193,8 @@
f_bssap_le_adapter_start(g_bssap_le[bssap_le_idx]);
}
- /* Remove nightly condition after osmo-smlc >= 0.4.x is released */
- if (Misc_Helpers.f_osmo_repo_is("nightly")) {
- f_init_statsd("SMLC_Test", vc_STATSD, mp_test_ip, mp_statsd_port, g_statd_timeout);
- }
+ f_init_statsd("SMLC_Test", vc_STATSD, mp_test_ip, mp_statsd_port, g_statd_timeout);
+
}
function f_init_vty(charstring id := "foo") runs on test_CT {
@@ -589,12 +587,7 @@
execute( TC_smlc_location_request_bsslap_abort() );
execute( TC_smlc_location_request_abort() );
- /* This "nightly" if can be removed once libosmo-sigtran (osmo-stp) > 2.1.0 is released.
- * Currently released osmo-stp 2.1.0 ends up in in broken AS-ACTIVE+ASP-DOWN state when
- * restarting the ASP after exiting the related asp node through VTY: */
- if (Misc_Helpers.f_osmo_repo_is("nightly")) {
- execute( TC_stat_bsc_sctp_disconnected() );
- }
+ execute( TC_stat_bsc_sctp_disconnected() );
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41573?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I61aaf5ae7b4975e68f573b1f432b74fab86d5355
Gerrit-Change-Number: 41573
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email )
Change subject: osmo-release.sh: Fix coloring output under bash
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
> Quick test for whoever. Under bash: […]
Hmm, the problem is that debian's "dash" behaves differently.
```
$ dash
$ echo -e "\033[1;32mBYE\033[1;0m"
-e BYE
```
```
$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Mar 31 2024 /bin/sh -> dash
```
In this case I would either recommend using POSIX shell compatible syntax instead with printf:
```
printf "\033[1;32m%s\033[1;0m\n" "BYE"
```
This one works as expected with dash, bash and zsh.
Or changing `#!/bin/sh` to `#!/bin/bash`, in addition with the changes you already have in this patch.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc
Gerrit-Change-Number: 41547
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Dec 2025 07:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>