pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email )
Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
......................................................................
gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
The pdp_status is actually encoded as little endian,
but there is no tlvp_val16le yet.
Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c
(cherry picked from commit b79797d0568ffd757540f6307d538135bdfa01b8)
---
M src/sgsn/gprs_gmm.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/75/41575/1
diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c
index 7a4ea20..d70ceec 100644
--- a/src/sgsn/gprs_gmm.c
+++ b/src/sgsn/gprs_gmm.c
@@ -2009,7 +2009,8 @@
/* Look at PDP Context Status IE and see if MS's view of
* activated/deactivated NSAPIs agrees with our view */
if (TLVP_PRESENT(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)) {
- uint16_t pdp_status = tlvp_val16be(&tp, GSM48_IE_GMM_PDP_CTX_STATUS);
+ /* TODO: Use tlvp_val16le when available */
+ uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS));
process_ms_ctx_status(ctx, pdp_status);
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-sgsn
Gerrit-Branch: pespin/rel-1.13.0
Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c
Gerrit-Change-Number: 41575
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41571?usp=email )
Change subject: hnbgw: Adapt testsuite to new OsmoCNI 202512 release
......................................................................
hnbgw: Adapt testsuite to new OsmoCNI 202512 release
Change-Id: Icf06dab1793418ad99fc340f8a0ea640970fe089
---
M hnbgw/HNBGW_Tests.ttcn
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index d4df7e2..2a55eb6 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -2767,12 +2767,7 @@
execute(TC_second_rab_assignment());
execute(TC_hnb_reregister_reuse_sctp_assoc());
- /* This "nightly" if can be removed once libosmo-sigtran (osmo-stp) > 2.1.0 is released.
- * Currently released osmo-stp 2.1.0 ends up in in broken AS-ACTIVE+ASP-DOWN state when
- * restarting the ASP after exiting the related asp node through VTY: */
- if (Misc_Helpers.f_osmo_repo_is("nightly")) {
- execute(TC_stat_stp_sctp_disconnected());
- }
+ execute(TC_stat_stp_sctp_disconnected());
/* Run at the end since it messes with the SCCP config */
execute( TC_apply_sccp() );
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41571?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icf06dab1793418ad99fc340f8a0ea640970fe089
Gerrit-Change-Number: 41571
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41572?usp=email )
Change subject: msc: Adapt testsuite to new OsmoCNI 202512 release
......................................................................
msc: Adapt testsuite to new OsmoCNI 202512 release
Change-Id: I9a393457eb5e57ca0a3f836b2c0366451c795097
---
M msc/BSC_ConnectionHandler.ttcn
M msc/MSC_Tests.ttcn
M msc/MSC_Tests_Iu.ttcn
3 files changed, 5 insertions(+), 18 deletions(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index dd285dd..98c9dce 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -1131,9 +1131,7 @@
cpars.got_osmux_count := 0;
/* MS <- MSC: Expect CC SETUP */
- /* Remove 'or Misc_Helpers.f_osmo_repo_is("latest")' after osmo-msc
- * 1.15.0 is released with I7046e9244fd9d4301ee2c4df1147a619f753739c */
- if (cpars.csd or Misc_Helpers.f_osmo_repo_is("latest")) {
+ if (cpars.csd) {
RAN_CONN.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_SETUP(cpars.transaction_id, *, cpars.called_party, *)));
} else {
/* Speech: check bearer capabilities against ts_Bcap_voice_mt
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 635e04f..013ecfd 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -8000,12 +8000,7 @@
execute( TC_lu_and_mo_call_reass_for_mt_codec() );
- /* This "nightly" if can be removed once libosmo-sigtran (osmo-stp) > 2.1.0 is released.
- * Currently released osmo-stp 2.1.0 ends up in in broken AS-ACTIVE+ASP-DOWN state when
- * restarting the ASP after exiting the related asp node through VTY: */
- if (Misc_Helpers.f_osmo_repo_is("nightly")) {
- execute( TC_stat_bsc_sctp_disconnected() );
- }
+ execute( TC_stat_bsc_sctp_disconnected() );
execute( TC_silent_call_start_stop() );
execute( TC_silent_call_active_conn() );
diff --git a/msc/MSC_Tests_Iu.ttcn b/msc/MSC_Tests_Iu.ttcn
index 75ecbe3..6c96041 100644
--- a/msc/MSC_Tests_Iu.ttcn
+++ b/msc/MSC_Tests_Iu.ttcn
@@ -712,17 +712,11 @@
execute( TC_iu_lu_with_invalid_mcc_mnc() );
execute( TC_iu_lu_and_expire_while_paging() );
- /* TODO: Iu + SGsAP related tests, e.g. paging on IuCS */
-
- /* Run this last: at the time of writing this test crashes the MSC */
execute( TC_mo_cc_iu_release() );
- /* This "nightly" if can be removed once libosmo-sigtran (osmo-stp) > 2.1.0 is released.
- * Currently released osmo-stp 2.1.0 ends up in in broken AS-ACTIVE+ASP-DOWN state when
- * restarting the ASP after exiting the related asp node through VTY: */
- if (Misc_Helpers.f_osmo_repo_is("nightly")) {
- execute( TC_stat_rnc_sctp_disconnected() );
- }
+ execute( TC_stat_rnc_sctp_disconnected() );
+
+ /* TODO: Iu + SGsAP related tests, e.g. paging on IuCS */
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41572?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9a393457eb5e57ca0a3f836b2c0366451c795097
Gerrit-Change-Number: 41572
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41574?usp=email )
Change subject: sgsn: Adapt testsuite to new OsmoCNI 202512 release
......................................................................
sgsn: Adapt testsuite to new OsmoCNI 202512 release
Change-Id: Icbb627831df236048e5f97617ff2ed6fc96d9cdf
---
M sgsn/SGSN_Tests_Iu.ttcn
1 file changed, 1 insertion(+), 7 deletions(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn
index 3400f43..aa4af49 100644
--- a/sgsn/SGSN_Tests_Iu.ttcn
+++ b/sgsn/SGSN_Tests_Iu.ttcn
@@ -494,13 +494,7 @@
execute( TC_attach_pdp_act_pmm_idle() );
execute( TC_pmm_idle_rx_mt_data() );
execute( TC_update_ctx_err_ind_from_ggsn() );
-
- /* This "nightly" if can be removed once libosmo-sigtran (osmo-stp) > 2.1.0 is released.
- * Currently released osmo-stp 2.1.0 ends up in in broken AS-ACTIVE+ASP-DOWN state when
- * restarting the ASP after exiting the related asp node through VTY: */
- if (Misc_Helpers.f_osmo_repo_is("nightly")) {
- execute( TC_stat_rnc_sctp_disconnected() );
- }
+ execute( TC_stat_rnc_sctp_disconnected() );
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41574?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icbb627831df236048e5f97617ff2ed6fc96d9cdf
Gerrit-Change-Number: 41574
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41574?usp=email )
Change subject: sgsn: Adapt testsuite to new OsmoCNI 202512 release
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41574?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icbb627831df236048e5f97617ff2ed6fc96d9cdf
Gerrit-Change-Number: 41574
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Dec 2025 12:57:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41573?usp=email )
Change subject: smlc: Adapt testsuite to new OsmoCNI 202512 release
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41573?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I61aaf5ae7b4975e68f573b1f432b74fab86d5355
Gerrit-Change-Number: 41573
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Dec 2025 12:57:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes