- gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables
by fixeria 16 Mar '26

16 Mar '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email ) Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The man documentation states the struct is passed, so imho looks like a good thing to set flags fiel […] The man-page for `mnl_nlmsg_put_extra_header()`: https://manpages.debian.org/experimental/libmnl-doc/mnl_nlmsg_put_extra_hea… states that "this function sets to zero the room that is required to put the extra header", so it does zero-initialize the extra header internally. I confirmed that by looking at the source code. However, I am fine with setting both fields to 0 explicitly. I'll update the patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 Gerrit-Change-Number: 42406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 09:03:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: mobile: gsm48_cc_tx_release_compl(): actually send the message
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email ) Change subject: mobile: gsm48_cc_tx_release_compl(): actually send the message ...................................................................... mobile: gsm48_cc_tx_release_compl(): actually send the message The message buffer is allocated, filled in, and then leaked when `trans_free(trans)` is called. The RELEASE COMPLETE message is never transmitted to the network. Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77 --- M src/host/layer23/src/mobile/gsm48_cc.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve jolly: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_cc.c b/src/host/layer23/src/mobile/gsm48_cc.c index 2a8823f..869f57a 100644 --- a/src/host/layer23/src/mobile/gsm48_cc.c +++ b/src/host/layer23/src/mobile/gsm48_cc.c @@ -1710,6 +1710,8 @@ if (rel->fields & MNCC_F_SSVERSION) gsm48_encode_ssversion(nmsg, &rel->ssversion); + gsm48_cc_to_mm(nmsg, trans, GSM48_MMCC_DATA_REQ); + /* release without sending MMCC_REL_REQ */ new_cc_state(trans, GSM_CSTATE_NULL); trans->callref = 0; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77 Gerrit-Change-Number: 42401 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: mobile: gsm48_mmxx_msg_names[]: fix some strings
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42402?usp=email ) Change subject: mobile: gsm48_mmxx_msg_names[]: fix some strings ...................................................................... mobile: gsm48_mmxx_msg_names[]: fix some strings Change-Id: Iab3e249acc18057416a5c1fc00322b597df403d4 --- M src/host/layer23/src/mobile/gsm48_mm.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_mm.c b/src/host/layer23/src/mobile/gsm48_mm.c index fad475e..14a68b0 100644 --- a/src/host/layer23/src/mobile/gsm48_mm.c +++ b/src/host/layer23/src/mobile/gsm48_mm.c @@ -749,8 +749,8 @@ { GSM48_MMGCC_DATA_IND, "MMGCC_DATA_IND" }, { GSM48_MMGCC_UNIT_DATA_REQ, "MMGCC_UNIT_DATA_REQ" }, { GSM48_MMGCC_UNIT_DATA_IND, "MMGCC_UNIT_DATA_IND" }, - { GSM48_MMGCC_REEST_REQ, "MMBCC_REEST_REQ" }, - { GSM48_MMGCC_REEST_CNF, "MMBCC_REEST_CNF" }, + { GSM48_MMGCC_REEST_REQ, "MMGCC_REEST_REQ" }, + { GSM48_MMGCC_REEST_CNF, "MMGCC_REEST_CNF" }, { GSM48_MMGCC_ERR_IND, "MMGCC_ERR_IND" }, { GSM48_MMGCC_NOTIF_IND, "MMGCC_NOTIF_IND" }, { GSM48_MMGCC_GROUP_REQ, "MMGCC_GROUP_REQ" }, @@ -758,7 +758,7 @@ { GSM48_MMGCC_UPLINK_REQ, "MMGCC_UPLINK_REQ" }, { GSM48_MMGCC_UPLINK_CNF, "MMGCC_UPLINK_CNF" }, { GSM48_MMGCC_UPLINK_REL_REQ, "MMGCC_UPLINK_REL_REQ" }, - { GSM48_MMGCC_UPLINK_REL_IND, "MMGCC_UPLINK_REL_CNF" }, + { GSM48_MMGCC_UPLINK_REL_IND, "MMGCC_UPLINK_REL_IND" }, { GSM48_MMGCC_UPLINK_FREE_IND, "MMGCC_UPLINK_FREE_IND" }, { GSM48_MMGCC_UPLINK_BUSY_IND, "MMGCC_UPLINK_BUSY_IND" }, { GSM48_MMBCC_EST_REQ, "MMBCC_EST_REQ" }, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab3e249acc18057416a5c1fc00322b597df403d4 Gerrit-Change-Number: 42402 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: mobile: gsm48_cc_tx_release_compl(): actually send the message
by fixeria 16 Mar '26

16 Mar '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email ) Change subject: mobile: gsm48_cc_tx_release_compl(): actually send the message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77 Gerrit-Change-Number: 42401 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 08:53:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: osmo_io: Rewrite iofd_handle_send_completion() to fix multiple issues
by pespin 16 Mar '26

16 Mar '26

Attention is currently required from: daniel, fixeria, jolly, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/42354?usp=email ) Change subject: osmo_io: Rewrite iofd_handle_send_completion() to fix multiple issues ...................................................................... Patch Set 1: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/42354/comment/09dea661_8d51b220?… : PS1, Line 556: break; > how do following msghdr->msg[idx] get freed after the break? would it maybe make more sense to only […] I still need to look more closely into this, but I think indeed msgbs were being leaked here in this early return (and one in line 608) also in the previous version of the code prior to this patch. Maybe @andreas@eversberg.eu can confirm the problem. I'll probably do a follow-up commit fixing that. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia016e4df7be5e534a8212f7271caff9779e08eb1 Gerrit-Change-Number: 42354 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 08:49:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO
by pespin 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42408?usp=email ) Change subject: gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42408?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1cbba2b2a746667b9920ed2ed19b3848185977d Gerrit-Change-Number: 42408 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 08:46:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: gsm48: fix missing/misspelled value-strings
by pespin 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42407?usp=email ) Change subject: gsm48: fix missing/misspelled value-strings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8d2333290c7715fd75ce7e7c759cb564a26b7461 Gerrit-Change-Number: 42407 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 08:45:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables
by pespin 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email ) Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: > maybe the point was to zero-initialize some part of the truct? AFter all, it doesn't look like we'r […] The man documentation states the struct is passed, so imho looks like a good thing to set flags field to 0. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 Gerrit-Change-Number: 42406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 08:45:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmocom-bb[master]: mobile: gsm48_cc_tx_release_compl(): actually send the message
by jolly 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email ) Change subject: mobile: gsm48_cc_tx_release_compl(): actually send the message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77 Gerrit-Change-Number: 42401 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 08:44:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: stats: osmo_stats_reporter_udp_open(): fix unconditional jump
by pespin 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42405?usp=email ) Change subject: stats: osmo_stats_reporter_udp_open(): fix unconditional jump ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifb4842ea11e4df0cae8733438b3812a086396b99 Gerrit-Change-Number: 42405 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 08:40:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log