pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41537?usp=email )
Change subject: tests/Makefile.am: Remove -static flag
......................................................................
tests/Makefile.am: Remove -static flag
We are not using that flag anywhere else in osmocom, and we don't have
any specific need for it here, so remove it.
Change-Id: If77ed04a3b5e0d6057c1aefa37e45aff38bbeca5
---
M tests/parse/Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
daniel: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
diff --git a/tests/parse/Makefile.am b/tests/parse/Makefile.am
index d464e2a..4a502b8 100644
--- a/tests/parse/Makefile.am
+++ b/tests/parse/Makefile.am
@@ -1,6 +1,6 @@
AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_srcdir)/src
AM_CFLAGS = -Wall
-AM_LDFLAGS = -static -no-install
+AM_LDFLAGS = -no-install
LDADD = $(top_builddir)/src/libosmo-asn1-tcap.la
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41537?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: If77ed04a3b5e0d6057c1aefa37e45aff38bbeca5
Gerrit-Change-Number: 41537
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41539?usp=email )
Change subject: tcap_as_loadshare_vty: Avoid possible NULL pointer dereference
......................................................................
tcap_as_loadshare_vty: Avoid possible NULL pointer dereference
argv[1]/as_name is always set so the `if (as_name)` guard can be
removed. This lets Coverity verify that as is never dereferenced if
NULL.
Related: Coverity CID#551555
Change-Id: Ia9151ae63be3977c2eccf246316b99c20284dbe2
---
M src/tcap_as_loadshare_vty.c
1 file changed, 8 insertions(+), 12 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/tcap_as_loadshare_vty.c b/src/tcap_as_loadshare_vty.c
index dcd8ccf..e6506e8 100644
--- a/src/tcap_as_loadshare_vty.c
+++ b/src/tcap_as_loadshare_vty.c
@@ -66,12 +66,10 @@
return CMD_WARNING;
}
- if (as_name) {
- as = osmo_ss7_as_find_by_name(inst, as_name);
- if (!as) {
- vty_out(vty, "No AS %s found%s", as_name, VTY_NEWLINE);
- return CMD_WARNING;
- }
+ as = osmo_ss7_as_find_by_name(inst, as_name);
+ if (!as) {
+ vty_out(vty, "No AS %s found%s", as_name, VTY_NEWLINE);
+ return CMD_WARNING;
}
vty_out(vty, "Tid Min Tid Max SSN PC ASP Name %s", VTY_NEWLINE);
@@ -108,12 +106,10 @@
return CMD_WARNING;
}
- if (as_name) {
- as = osmo_ss7_as_find_by_name(inst, as_name);
- if (!as) {
- vty_out(vty, "No AS %s found%s", as_name, VTY_NEWLINE);
- return CMD_WARNING;
- }
+ as = osmo_ss7_as_find_by_name(inst, as_name);
+ if (!as) {
+ vty_out(vty, "No AS %s found%s", as_name, VTY_NEWLINE);
+ return CMD_WARNING;
}
vty_out(vty, "Tid Min Tid Max SSN PC ASP Name %s", VTY_NEWLINE);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41539?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ia9151ae63be3977c2eccf246316b99c20284dbe2
Gerrit-Change-Number: 41539
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, osmith.
pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41539?usp=email )
Change subject: tcap_as_loadshare_vty: Avoid possible NULL pointer dereference
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41539?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ia9151ae63be3977c2eccf246316b99c20284dbe2
Gerrit-Change-Number: 41539
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Dec 2025 14:38:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41540?usp=email )
Change subject: debian: build with --enable-tcap-loadsharing
......................................................................
debian: build with --enable-tcap-loadsharing
Enable the feature by default in the Osmocom debian packaging, so we can
test it with osmo-ttcn3-hacks.
Change-Id: I898ea7be265c40e603c386925bdd7d10b06e2f88
---
M debian/control
M debian/rules
2 files changed, 8 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/debian/control b/debian/control
index 7a89ff0..1c821c6 100644
--- a/debian/control
+++ b/debian/control
@@ -13,6 +13,7 @@
git,
doxygen,
libdpkg-perl,
+ libosmo-asn1-tcap-dev,
libosmo-netif-dev (>= 1.6.0),
libsctp-dev,
osmo-gsm-manuals-dev (>= 1.6.0)
@@ -72,6 +73,7 @@
Depends: ${misc:Depends},
libosmo-sigtran11 (= ${binary:Version}),
libosmocore-dev,
+ libosmo-asn1-tcap-dev,
libosmo-netif-dev
Description: Development headers for the Osmocom SIGTRAN library
libosmo-sigtran is a shared library containing SS7/SIGTRAN related functionality,
diff --git a/debian/rules b/debian/rules
index 5f6af30..1fe2437 100755
--- a/debian/rules
+++ b/debian/rules
@@ -22,7 +22,12 @@
# enable-static: we require the tests to link to the static libosmo-sigtran
# library to access symbols not starting with osmo_*
override_dh_auto_configure:
- dh_auto_configure -- --enable-static --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals
+ dh_auto_configure -- \
+ --enable-manuals \
+ --enable-static \
+ --enable-tcap-loadsharing \
+ --with-systemdsystemunitdir=/lib/systemd/system \
+ $(NULL)
# Print test results in case of a failure
override_dh_auto_test:
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41540?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I898ea7be265c40e603c386925bdd7d10b06e2f88
Gerrit-Change-Number: 41540
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41540?usp=email )
Change subject: debian: build with --enable-tcap-loadsharing
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41540?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I898ea7be265c40e603c386925bdd7d10b06e2f88
Gerrit-Change-Number: 41540
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Dec 2025 14:37:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes