- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs/gerrit-verifications: add logger_gsmtap

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/40804?usp=email ) Change subject: jobs/gerrit-verifications: add logger_gsmtap ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4ffae01156caa467ec23f6b89185b8d65d4691a3 Gerrit-Change-Number: 40804 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 11:48:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 2 days

1
0
0 0

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.

by pespin

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email ) Change subject: Automatically increase io_uring, if too small. ...................................................................... Patch Set 9: (6 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/bf3fa1ff_1903038e?… : PS9, Line 23: to determine when all submissions are completed. Sounds like an easy thing to add right? It makes sense to implement this either her eor on a follow-up patch. File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/b34815a0_ee55ba5c?… : PS9, Line 110: bool read_enabled; (At some point it may make sense to properly put all these fields into a "read" and "write" substructs in here.) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/09634797_688ca5a4?… : PS9, Line 126: g_ring = talloc_zero(OTC_GLOBAL, struct osmo_io_uring); are you sure OTC_GLOBAL is defined at this point? Or is it actually NULL? If it's still NULL better pass NULL explicitly to avoid creating confusion. https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/afc5fac1_bb6d44e8?… : PS9, Line 175: g_io_uring_size *= 2; Once you move this to an unsigned, you can do "<< 1" here. BTW, I don't see you are making sure we don't go over the "maximum ring size allowed" in there, the one you are checking in previous commit. https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/6946c3e3_7a05083e?… : PS9, Line 208: /* All subsequent read SQEs must be on the same ring. */ This should imho go inside iofd_uring_get_sqe(), based on "current_ring" being passed to it. https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/a8053e18_abe26da4?… : PS9, Line 282: while (iofd->u.uring.reads_submitted < ((iofd->u.uring.num_read_sqes) ? : g_io_uring_read_sqes)) { why is the g_io_uring_read_sqes reference needed here? How can iofd have num_read_sqes = 0, and if it does, why are we overriding it? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 01 Aug 2025 11:46:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 2 days

1
0
0 0

[S] Change in libosmocore[master]: Add environment variable to set io_uring size

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email ) Change subject: Add environment variable to set io_uring size ...................................................................... Patch Set 2: (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/edd65e94_3043b14b?… : PS2, Line 66: static int g_io_uring_size = IOFD_URING_INITIAL_SIZE; size_t -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I55289d9282e13aa1bf82f3931c85c196752f1484 Gerrit-Change-Number: 40782 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Aug 2025 11:30:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-uecups[master]: gtp_endpoint: Avoid deadlocks logging while thread is cancelled

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email ) Change subject: gtp_endpoint: Avoid deadlocks logging while thread is cancelled ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-uecups/+/40788/comment/f4766ede_3ccffbf0?… : PS3, Line 9: garantee guarantee -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb Gerrit-Change-Number: 40788 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 11:24:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 2 days

1
0
0 0

[S] Change in libosmocore[master]: Add environment variable to set io_uring size

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email ) Change subject: Add environment variable to set io_uring size ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/2136ce09_fe2b3fda?… : PS2, Line 111: rc = osmo_str_to_int(&g_io_uring_size, env, 10, 1, 32768); I wonder where 32768 comes from :D https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/360a1e2e_952260c3?… : PS2, Line 116: if ((g_io_uring_size & (g_io_uring_size - 1))) { if (g_io_uring_size & 0x01) https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/c8e2b206_2c594a91?… : PS2, Line 117: fprintf(stderr, "Error: Initial io_uring size must be a positive power of two.\n"); Is this really needed as per io_uring API? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I55289d9282e13aa1bf82f3931c85c196752f1484 Gerrit-Change-Number: 40782 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 01 Aug 2025 11:23:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-uecups[master]: doc/examples: populate the config file example

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40806?usp=email ) Change subject: doc/examples: populate the config file example ...................................................................... doc/examples: populate the config file example Change-Id: I5c7b32903e2e205eb43b389292fe9bfceea36d30 --- M doc/examples/osmo-uecups-daemon.cfg 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/doc/examples/osmo-uecups-daemon.cfg b/doc/examples/osmo-uecups-daemon.cfg index e69de29..f170e20 100644 --- a/doc/examples/osmo-uecups-daemon.cfg +++ b/doc/examples/osmo-uecups-daemon.cfg @@ -0,0 +1,14 @@ +log stderr + logging filter all 1 + logging color 1 + logging print file basename last + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging level set-all info +! +line vty + no login +! +uecups + local-ip 127.0.0.1 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I5c7b32903e2e205eb43b389292fe9bfceea36d30 Gerrit-Change-Number: 40806 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

[XS] Change in osmo-uecups[master]: README.md: fix wrong project's homepage URL

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40805?usp=email ) Change subject: README.md: fix wrong project's homepage URL ...................................................................... README.md: fix wrong project's homepage URL Change-Id: I3cb43506144df71647d655995392446feb776e83 --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/README.md b/README.md index 5025bc0..ba1d9bb 100644 --- a/README.md +++ b/README.md @@ -23,7 +23,7 @@ -------- The official homepage of the project is -https://osmocom.org/projects/osmo-ggsn/wiki/osmo-uecups +https://osmocom.org/projects/osmo-uecups/wiki GIT Repository -------------- -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I3cb43506144df71647d655995392446feb776e83 Gerrit-Change-Number: 40805 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

[S] Change in osmo-uecups[master]: doc/examples: populate the config file example

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40806?usp=email ) Change subject: doc/examples: populate the config file example ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I5c7b32903e2e205eb43b389292fe9bfceea36d30 Gerrit-Change-Number: 40806 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 11:18:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 2 days

1
0
0 0

[XS] Change in osmo-uecups[master]: README.md: fix wrong project's homepage URL

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40805?usp=email ) Change subject: README.md: fix wrong project's homepage URL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I3cb43506144df71647d655995392446feb776e83 Gerrit-Change-Number: 40805 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 11:18:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 2 days

1
0
0 0

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.

by jolly

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Automatically increase io_uring, if too small. ...................................................................... Automatically increase io_uring, if too small. The ring may be too small to store all SQEs before the kernel can handle them. If this happens, a new ring is allocated with twice of the size of the old ring. The old ring will not be destroyed, as it still contains uncompleted elements. Some of them may never be completed. A pointer to the current ring will be stored within the msghdr structure. It is used when cancelling an SQE. The cancellation must be performed in the same ring where it was created. It is quite unlikely that the old ring cannot store the cancellation SQE. If this happens, the cancellation is queued and submitted, once the ring can store it. The old ring will not be removed, because there is currently no counter to determine when all submissions are completed. Related: OS#6705 Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca --- M src/core/osmo_io_internal.h M src/core/osmo_io_uring.c 2 files changed, 143 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/40725/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

2 weeks, 2 days

1
0
0 0

2025

2024

2023

2022

gerrit-log