Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42352?usp=email )
Change subject: mme_registry: add backwards compat for old sctp_client config
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42352?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ia97fb61bbb5ace6f43d1a6768fb5fb6883158532
Gerrit-Change-Number: 42352
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 10:58:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Timur Davydov.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O
......................................................................
Patch Set 3:
(1 comment)
File Transceiver52M/Transceiver.h:
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/26cb7e84_4d8f0a9e?usp… :
PS3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size);
> The file uses 2-space indentation, but when using 2 spaces Jenkins fails the build. […]
It's fine if CI fails in this file, we wan overwrite it manually.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Mon, 16 Mar 2026 10:58:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42352?usp=email )
Change subject: mme_registry: add backwards compat for old sctp_client config
......................................................................
Patch Set 1:
(1 comment)
File src/osmo_s1gw_sup.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42352/comment/0a79e835_bfe6… :
PS1, Line 75: osmo_s1gw:set_env(sctp_client, ClientCfg),
> shouldn't this be set only if the mme_pool is missing?
It does not make a big difference. Having a normalized `sctp_client` in the environment does not hurt and may later be used e.g. by the REST interface to print the current configuration.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42352?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ia97fb61bbb5ace6f43d1a6768fb5fb6883158532
Gerrit-Change-Number: 42352
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 10:51:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O
......................................................................
Patch Set 3:
(1 comment)
File Transceiver52M/Transceiver.h:
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/763b3a18_632265e6?usp… :
PS3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size);
> wrong indentation related to all other lines in this file.
The file uses 2-space indentation, but when using 2 spaces Jenkins fails the build. To make the CI pass I had to adjust the indentation accordingly.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 10:47:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: dexter, fixeria.
daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42389?usp=email )
Change subject: esim/saip: raise an exception properly
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42389?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia3749c02120fdc16e556214d0461cbeca032447b
Gerrit-Change-Number: 42389
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 10:44:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter, fixeria.
daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42379?usp=email )
Change subject: ara_m: fix exceptions not being raised properly
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
I wonder what might break now that you have to properly catch stuff
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42379?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id799c264447e22887edcd2dc7eb991cf0af1bbfc
Gerrit-Change-Number: 42379
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 10:40:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes