fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41614?usp=email )
Change subject: sctp_proxy: fix wrong operator in connecting/3
......................................................................
sctp_proxy: fix wrong operator in connecting/3
We need to update the map, thus the update operation (`=>`) needs
to be used, not the matching (`:=`). We're lucky that eNBs usually
do not send anything before the MME responds to the S1Setup request;
otherwise the S1GW would crash here due to a mismatch.
Change-Id: I26d8a8da5cce89324a9e1150e4ecdf2084d097c8
---
M src/sctp_proxy.erl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/14/41614/1
diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl
index ad58d4b..458c53a 100644
--- a/src/sctp_proxy.erl
+++ b/src/sctp_proxy.erl
@@ -133,7 +133,7 @@
#{tx_queue := Pending} = S) ->
s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_UPLINK_PACKETS_QUEUED),
s1gw_metrics:gauge_inc(?S1GW_GAUGE_S1AP_PROXY_UPLINK_PACKETS_QUEUED),
- {keep_state, S#{tx_queue := [Data | Pending]}};
+ {keep_state, S#{tx_queue => [Data | Pending]}};
%% Handle an #sctp_assoc_change event (connection state)
connecting(info, {sctp, _Socket, MmeAddr, MmePort,
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41614?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I26d8a8da5cce89324a9e1150e4ecdf2084d097c8
Gerrit-Change-Number: 41614
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email )
Change subject: s2b: allow to set the restart counter/recovery field
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
I'm not following here.
1- You are adding a default value which is basically rand()%256, which defeats the purpose of restart_counter.
2- AFAIU you can configure the restart_counter from config file, but then that means everytime osmo-epdg restarts a user needs to manually edit the file and start osmo-epdg again?
I don't see how is this improving the situation over last commit, actually it's worse afaiu.
File src/epdg_gtpc_s2b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/3dc38dfb_1c6e… :
PS5, Line 111: % Use system_time in order to ensure a fresh system wouldn't re-use always the same restart_counter
AFAIU this is not true, you have 1/256 chance to get the same restart_counter every time you start osmo-epdg.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81
Gerrit-Change-Number: 41588
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 05 Dec 2025 10:35:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email )
Change subject: osmo-release.sh: Fix coloring output under bash
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File osmo-release.sh:
https://gerrit.osmocom.org/c/libosmocore/+/41547/comment/c82f1b8e_ff47f228?… :
PS2, Line 39: printf "${GREEN}OK:${RESET} $@\n"
> the first argument to printf is the format string, just like in C it would be better practice to use […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc
Gerrit-Change-Number: 41547
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Dec 2025 10:29:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: osmo-release.sh: Fix coloring output under bash
......................................................................
osmo-release.sh: Fix coloring output under bash
Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc
---
M osmo-release.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/41547/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc
Gerrit-Change-Number: 41547
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>