- gerrit-log - lists.osmocom.org

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Timur Davydov 16 Mar '26

16 Mar '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 3: (1 comment) File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/763b3a18_632265e6?usp… : PS3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size); > wrong indentation related to all other lines in this file. The file uses 2-space indentation, but when using 2 spaces Jenkins fails the build. To make the CI pass I had to adjust the indentation accordingly. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:47:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: esim/saip: raise an exception properly
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42389?usp=email ) Change subject: esim/saip: raise an exception properly ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia3749c02120fdc16e556214d0461cbeca032447b Gerrit-Change-Number: 42389 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:44:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: cdma_ruim: fix inaccurate comment for EF_AD
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42388?usp=email ) Change subject: cdma_ruim: fix inaccurate comment for EF_AD ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71ea27fd30e44685ff35f49843072ca392995973 Gerrit-Change-Number: 42388 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:44:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: utils: DataObjectCollection.encode(): fix TypeError
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42384?usp=email ) Change subject: utils: DataObjectCollection.encode(): fix TypeError ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7e0c09aa7303f1506fe3a025fdc3779919dd0e6c Gerrit-Change-Number: 42384 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:42:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: utils: dec_plmn(): remove redundant call
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42383?usp=email ) Change subject: utils: dec_plmn(): remove redundant call ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic95c3992ed57eb8fee952ec2dc7f092dd7689579 Gerrit-Change-Number: 42383 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:42:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ota: OtaAlgo{Crypt,Auth}: fix algo_auth vs algo_crypt
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42382?usp=email ) Change subject: ota: OtaAlgo{Crypt,Auth}: fix algo_auth vs algo_crypt ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia636fffaeadc68e3f6d5b65d477e753834c95895 Gerrit-Change-Number: 42382 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:41:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: ara_m: fix exceptions not being raised properly
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42379?usp=email ) Change subject: ara_m: fix exceptions not being raised properly ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: I wonder what might break now that you have to properly catch stuff -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42379?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id799c264447e22887edcd2dc7eb991cf0af1bbfc Gerrit-Change-Number: 42379 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:40:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ara_m: fix undefined variable used in a format-string
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42380?usp=email ) Change subject: ara_m: fix undefined variable used in a format-string ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42380?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I310a5d461bae2b5e4d8e07097000b079c23aa0f6 Gerrit-Change-Number: 42380 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:36:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: f_TC_fh_params_gen_tr_ma(): simplify ma_mask calculation
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42395?usp=email ) Change subject: bsc: f_TC_fh_params_gen_tr_ma(): simplify ma_mask calculation ...................................................................... bsc: f_TC_fh_params_gen_tr_ma(): simplify ma_mask calculation Commented out code did not work back in 2020, but recent TITAN versions (we use 11.1.0) have no problems compiling/running it. Change-Id: I1892366af13b80844bcda3f84d18578284c35e08 --- M bsc/BSC_Tests.ttcn 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 17f2326..e97ecb0 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -9907,22 +9907,12 @@ if (full_mask[i] != '1'B) { continue; } - /* FIXME: ma_mask := ma_mask & slot_mask[i]; // triggers a bug in TITAN */ - if (slot_mask[i] == '1'B) { - ma_mask := ma_mask & '1'B; - } else { - ma_mask := ma_mask & '0'B; - } + ma_mask := ma_mask & slot_mask[i]; } /* ARFCN 0 (if present) goes to the last position of the bit-mask */ if (full_mask[0] == '1'B) { - /* FIXME: ma_mask := ma_mask & slot_mask[0]; // triggers a bug in TITAN */ - if (slot_mask[0] == '1'B) { - ma_mask := ma_mask & '1'B; - } else { - ma_mask := ma_mask & '0'B; - } + ma_mask := ma_mask & slot_mask[0]; } /* Ensure that ma_mask is octet-aligned */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1892366af13b80844bcda3f84d18578284c35e08 Gerrit-Change-Number: 42395 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: pre-compute RACH RA using oct2int() early
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42394?usp=email ) Change subject: bts: pre-compute RACH RA using oct2int() early ...................................................................... bts: pre-compute RACH RA using oct2int() early Change-Id: I03e8748cf56fa1aa9b598d237d325989d91ca372 --- M bts/BTS_Tests_ASCI.ttcn 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/bts/BTS_Tests_ASCI.ttcn b/bts/BTS_Tests_ASCI.ttcn index 85ef39c..0eb4a05 100644 --- a/bts/BTS_Tests_ASCI.ttcn +++ b/bts/BTS_Tests_ASCI.ttcn @@ -201,7 +201,7 @@ private function f_vgcs_talker_detect() runs on ConnHdlr { var octetstring uplink_free := '082B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B'O; - var octetstring uplink_access := 'C0'O; + var uint8_t ra := oct2int('C0'O); var RSL_Message rm; var GsmFrameNumber fn; @@ -223,10 +223,10 @@ /* Send UPLINK ACCESS on VGCS channel. */ log("Send UPLINK ACCESS."); - fn := f_L1CTL_RACH(L1CTL, oct2int(uplink_access), chan_nr := g_pars.chan_nr); + fn := f_L1CTL_RACH(L1CTL, ra, chan_nr := g_pars.chan_nr); /* Receive UPLINK GRANT by the MS. */ - var RequestReference req_ref := f_compute_ReqRef(oct2int(uplink_access), fn); + var RequestReference req_ref := f_compute_ReqRef(ra, fn); var template (present) GsmRrL3Message uplink_grant := tr_VGCS_UplinkGrant(req_ref); f_l1_exp_lapdm(tr_LAPDm_UI(0, cr_MT_CMD, decmatch uplink_grant)); log("Received VGCS UPLINK GRANT."); @@ -343,7 +343,7 @@ private function f_TC_vgcs_listener_det(charstring id) runs on ConnHdlr { - var octetstring uplink_access := '25'O; + var uint8_t ra := oct2int('25'O); var RSL_Message rm; var GsmFrameNumber fn; @@ -359,7 +359,7 @@ /* Send UPLINK ACCESS on VGCS channel. */ log("Send UPLINK ACCESS."); - fn := f_L1CTL_RACH(L1CTL, oct2int(uplink_access), chan_nr := g_pars.chan_nr); + fn := f_L1CTL_RACH(L1CTL, ra, chan_nr := g_pars.chan_nr); /* Wait for listener detection. */ timer T := 2.0; @@ -381,7 +381,7 @@ /* Send UPLINK ACCESS on VGCS channel. */ log("Send second UPLINK ACCESS."); - fn := f_L1CTL_RACH(L1CTL, oct2int(uplink_access), chan_nr := g_pars.chan_nr); + fn := f_L1CTL_RACH(L1CTL, ra, chan_nr := g_pars.chan_nr); /* Wait for listener detection. */ T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I03e8748cf56fa1aa9b598d237d325989d91ca372 Gerrit-Change-Number: 42394 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log