- gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: build: add WebSDR configure option and Emscripten detection
by Timur Davydov 27 Apr '26

27 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42700?usp=email ) Change subject: build: add WebSDR configure option and Emscripten detection ...................................................................... build: add WebSDR configure option and Emscripten detection Detect Emscripten toolchain and introduce --with-websdr configure option When enabled, check for libosmo-trx-websdr and required symbol modulateBits, failing configure if missing Change-Id: Iff4b76e339e2873686c8c15885dd498458ceb546 --- M configure.ac 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/00/42700/1 diff --git a/configure.ac b/configure.ac index 8f8e0d9..a3c22c6 100644 --- a/configure.ac +++ b/configure.ac @@ -24,6 +24,18 @@ AC_PROG_INSTALL LT_INIT +dnl Detect emscripten compiler +case "$CC" in +*emcc*) + emscripten=yes + ;; +*) + emscripten=no + ;; +esac +AM_CONDITIONAL(HAVE_EMSCRIPTEN, test "x$emscripten" = "xyes") +AC_SUBST([HAVE_EMSCRIPTEN], [$emscripten]) + dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang AS_CASE(["$LD"],[*clang*], [AS_CASE(["${host_os}"], @@ -321,6 +333,31 @@ AM_CONDITIONAL(ENABLE_ORTP, test "x$ENABLE_ORTP" = "xyes") AC_SUBST(ENABLE_ORTP) +AC_ARG_WITH(websdr, [ + AS_HELP_STRING([--with-websdr], + [enable WebUSB based transceiver]) +]) + +AM_CONDITIONAL(ENABLE_WEBSDR, [test "x$with_websdr" = "xyes"]) + +if test "x$with_websdr" = "xyes"; then + AC_DEFINE(ENABLE_WEBSDR, 1, Define to 1 for enable WebUSB based transceiver) + + PKG_CHECK_MODULES(LIBOSMOTRX, libosmo-trx-websdr >= 1.7.2) + + # Check whether libosmo-trx-websdr provides modulateBits + save_LIBS="$LIBS" + LIBS="$LIBS $LIBOSMOTRX_LIBS" + AC_CHECK_FUNCS([modulateBits]) + + # modulateBits is required — fail configuration if it's missing + if test "x$ac_cv_func_modulateBits" != "xyes"; then + AC_MSG_ERROR([libosmo-trx-websdr does not provide the required function 'modulateBits'. Please rebuild osmo-trx with both --with-burst-lut and --with-websdr enabled.]) + fi + + LIBS="$save_LIBS" +fi + AC_CHECK_HEADER([linux/if_packet.h], [linux_if_packet_header="yes"], []) if test "x$linux_if_packet_header" = "xyes" ; then AC_DEFINE(HAVE_LINUX_IF_PACKET_H, 1, [Define if we found linux/if_packet.h]) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42700?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iff4b76e339e2873686c8c15885dd498458ceb546 Gerrit-Change-Number: 42700 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in osmo-bts[master]: bts: guard AMR RTP decoder stub with HAVE_LIBOSMOCODEC_STATIC
by Timur Davydov 27 Apr '26

27 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42701?usp=email ) Change subject: bts: guard AMR RTP decoder stub with HAVE_LIBOSMOCODEC_STATIC ...................................................................... bts: guard AMR RTP decoder stub with HAVE_LIBOSMOCODEC_STATIC Disable dummy osmo_amr_rtp_dec() implementation when linking against static libosmocodec to avoid symbol conflicts Apply to omldummy and virtual BTS models Change-Id: Ie19ae2013893575a2f74a87af2151034abf57870 --- M configure.ac M src/osmo-bts-omldummy/bts_model.c M src/osmo-bts-virtual/bts_model.c 3 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/01/42701/1 diff --git a/configure.ac b/configure.ac index a3c22c6..947e431 100644 --- a/configure.ac +++ b/configure.ac @@ -345,6 +345,13 @@ PKG_CHECK_MODULES(LIBOSMOTRX, libosmo-trx-websdr >= 1.7.2) + # Check whether libosmo-trx-websdr is static + osmocodec_libdir="$($PKG_CONFIG --variable=libdir libosmocodec 2>/dev/null)" + if test -n "$osmocodec_libdir" && test -f "$osmocodec_libdir/libosmocodec.a" ; then + AC_MSG_NOTICE([found static libosmocodec.a]) + AC_DEFINE([HAVE_LIBOSMOCODEC_STATIC], [1], [Found static libosmocodec]) + fi + # Check whether libosmo-trx-websdr provides modulateBits save_LIBS="$LIBS" LIBS="$LIBS $LIBOSMOTRX_LIBS" diff --git a/src/osmo-bts-omldummy/bts_model.c b/src/osmo-bts-omldummy/bts_model.c index 8abca39..b3ca3c4 100644 --- a/src/osmo-bts-omldummy/bts_model.c +++ b/src/osmo-bts-omldummy/bts_model.c @@ -44,6 +44,7 @@ return -1; } +#ifndef HAVE_LIBOSMOCODEC_STATIC /* TODO: check if dummy method is sufficient, else implement */ int osmo_amr_rtp_dec(const uint8_t *rtppayload, int payload_len, uint8_t *cmr, int8_t *cmi, enum osmo_amr_type *ft, enum osmo_amr_quality *bfi, int8_t *sti) @@ -51,6 +52,7 @@ LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); return -1; } +#endif /* HAVE_LIBOSMOCODEC_STATIC */ void bts_model_trx_close(struct gsm_bts_trx *trx) { diff --git a/src/osmo-bts-virtual/bts_model.c b/src/osmo-bts-virtual/bts_model.c index a70abfb..8212ee7 100644 --- a/src/osmo-bts-virtual/bts_model.c +++ b/src/osmo-bts-virtual/bts_model.c @@ -46,6 +46,7 @@ return -1; } +#ifndef HAVE_LIBOSMOCODEC_STATIC /* TODO: check if dummy method is sufficient, else implement */ int osmo_amr_rtp_dec(const uint8_t *rtppayload, int payload_len, uint8_t *cmr, int8_t *cmi, enum osmo_amr_type *ft, enum osmo_amr_quality *bfi, int8_t *sti) @@ -53,6 +54,7 @@ LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); return -1; } +#endif /* HAVE_LIBOSMOCODEC_STATIC */ void bts_model_trx_close(struct gsm_bts_trx *trx) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie19ae2013893575a2f74a87af2151034abf57870 Gerrit-Change-Number: 42701 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-bts[master]: smux: allow lchan lookup without remote address
by Timur Davydov 27 Apr '26

27 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42702?usp=email ) Change subject: smux: allow lchan lookup without remote address ...................................................................... smux: allow lchan lookup without remote address Make rem_addr optional in osmux_lchan_find() by skipping address comparison when it is NULL This allows callers without socket-based addressing to locate lchans by CID only (e.g. callback-based transports) Change-Id: I7a275dad2353241c7b04cdb5d6cc1436a175c1f3 --- M src/common/osmux.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/02/42702/1 diff --git a/src/common/osmux.c b/src/common/osmux.c index 9513bdc..52885eb 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -267,7 +267,7 @@ if (lchan->abis_ip.osmux.local_cid != osmux_cid) continue; h = osmux_xfrm_input_get_deliver_cb_data(lchan->abis_ip.osmux.in); - if (osmo_sockaddr_cmp(&h->rem_addr, rem_addr) != 0) + if (rem_addr && osmo_sockaddr_cmp(&h->rem_addr, rem_addr) != 0) continue; return lchan; /* Found it! */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7a275dad2353241c7b04cdb5d6cc1436a175c1f3 Gerrit-Change-Number: 42702 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-bts[master]: build: make linux/if_packet.h usage optional
by Timur Davydov 27 Apr '26

27 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42688?usp=email ) Change subject: build: make linux/if_packet.h usage optional ...................................................................... build: make linux/if_packet.h usage optional Check for presence of linux/if_packet.h in configure and guard its usage with HAVE_LINUX_IF_PACKET_H. This avoids build failures on non-Linux platforms or environments where the header is unavailable. Change-Id: I8a02b0676e65fa4b6191073c84e0646a2e67a010 --- M configure.ac M include/osmo-bts/phy_link.h 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/42688/1 diff --git a/configure.ac b/configure.ac index fe69954..d18d8b3 100644 --- a/configure.ac +++ b/configure.ac @@ -321,6 +321,11 @@ AM_CONDITIONAL(ENABLE_ORTP, test "x$ENABLE_ORTP" = "xyes") AC_SUBST(ENABLE_ORTP) +AC_CHECK_HEADER([linux/if_packet.h], [linux_if_packet_header="yes"], []) +if test "x$linux_if_packet_header" = "xyes" ; then + AC_DEFINE(HAVE_LINUX_IF_PACKET_H, 1, [Define if we found linux/if_packet.h]) +fi + # Generate manuals AC_ARG_ENABLE(manuals, [AS_HELP_STRING( diff --git a/include/osmo-bts/phy_link.h b/include/osmo-bts/phy_link.h index 719c329..8692889 100644 --- a/include/osmo-bts/phy_link.h +++ b/include/osmo-bts/phy_link.h @@ -8,7 +8,9 @@ #include <osmo-bts/scheduler.h> #include <osmo-bts/bts_trx.h> +#ifdef HAVE_LINUX_IF_PACKET_H #include <linux/if_packet.h> +#endif /* HAVE_LINUX_IF_PACKET_H */ #include "btsconfig.h" @@ -64,8 +66,10 @@ struct virt_um_inst *virt_um; } virt; struct { +#ifdef HAVE_LINUX_IF_PACKET_H /* MAC address of the PHY */ struct sockaddr_ll phy_addr; +#endif /* HAVE_LINUX_IF_PACKET_H */ /* Network device name */ char *netdev_name; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8a02b0676e65fa4b6191073c84e0646a2e67a010 Gerrit-Change-Number: 42688 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-bts[master]: build: make sched_* usage optional
by Timur Davydov 27 Apr '26

27 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email ) Change subject: build: make sched_* usage optional ...................................................................... build: make sched_* usage optional Add configure checks for sched_* APIs and guard usage of sched_setscheduler with HAVE_SCHED_SETSCHEDULER. This avoids build/runtime issues on platforms without scheduler support. Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906 --- M configure.ac M src/common/main.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/90/42690/1 diff --git a/configure.ac b/configure.ac index 1d69bc3..8f8e0d9 100644 --- a/configure.ac +++ b/configure.ac @@ -331,6 +331,10 @@ AC_DEFINE(HAVE_SYS_TIMERFD_H, 1, [Define if we found sys/timerfd.h]) fi +dnl Check the scheduller functions +AC_CHECK_HEADERS([sched.h]) +AC_CHECK_FUNCS([sched_setaffinity sched_setscheduler]) + # Generate manuals AC_ARG_ENABLE(manuals, [AS_HELP_STRING( diff --git a/src/common/main.c b/src/common/main.c index 2bdd8ce..8327b57 100644 --- a/src/common/main.c +++ b/src/common/main.c @@ -305,6 +305,7 @@ exit(1); } +#ifdef HAVE_SCHED_SETSCHEDULER /* enable realtime priority for us */ if (rt_prio != -1) { struct sched_param param; @@ -318,6 +319,7 @@ exit(1); } } +#endif /* HAVE_SCHED_SETSCHEDULER */ if (bts_init(g_bts) < 0) { fprintf(stderr, "unable to open bts\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906 Gerrit-Change-Number: 42690 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-bts[master]: build: make timerfd usage optional
by Timur Davydov 27 Apr '26

27 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email ) Change subject: build: make timerfd usage optional ...................................................................... build: make timerfd usage optional Check for sys/timerfd.h in configure and guard its usage with HAVE_SYS_TIMERFD_H. This avoids build failures on platforms where timerfd is not available. Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a --- M configure.ac M src/osmo-bts-trx/scheduler_trx.c 2 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/42689/1 diff --git a/configure.ac b/configure.ac index d18d8b3..1d69bc3 100644 --- a/configure.ac +++ b/configure.ac @@ -326,6 +326,11 @@ AC_DEFINE(HAVE_LINUX_IF_PACKET_H, 1, [Define if we found linux/if_packet.h]) fi +AC_CHECK_HEADER([sys/timerfd.h], [sys_timerfd_header="yes"], []) +if test "x$sys_timerfd_header" = "xyes" ; then + AC_DEFINE(HAVE_SYS_TIMERFD_H, 1, [Define if we found sys/timerfd.h]) +fi + # Generate manuals AC_ARG_ENABLE(manuals, [AS_HELP_STRING( diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index a9a53f6..99efdf6 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -28,7 +28,9 @@ #include <stdint.h> #include <ctype.h> #include <inttypes.h> +#ifdef HAVE_SYS_TIMERFD_H #include <sys/timerfd.h> +#endif #include <osmocom/core/msgb.h> #include <osmocom/core/talloc.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a Gerrit-Change-Number: 42689 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-e1d[master]: HDLC timeslots: fix Rx of maximum-sized frames
by fixeria 26 Apr '26

26 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-e1d/+/42681?usp=email ) Change subject: HDLC timeslots: fix Rx of maximum-sized frames ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/42681?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I479e8fe5118c8eb7d4e6b16b49047a3278bc9808 Gerrit-Change-Number: 42681 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sun, 26 Apr 2026 21:31:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: personalization audit: optionally audit all (unknown) SD keys
by fixeria 26 Apr '26

26 Apr '26

Attention is currently required from: laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40209?usp=email ) Change subject: personalization audit: optionally audit all (unknown) SD keys ...................................................................... Patch Set 12: (1 comment) File pySim/esim/saip/batch.py: https://gerrit.osmocom.org/c/pysim/+/40209/comment/62416cc8_3359fbc9?usp=em… : PS10, Line 186: upp_audit[audit_key] = set((audit_val, )) > looks good, yes! […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icaf6f7b589f117868633c0968a99f2f0252cf612 Gerrit-Change-Number: 40209 Gerrit-PatchSet: 12 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 26 Apr 2026 19:51:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: lapd_sap_stop(): fix use of uninitialized stack memory
by fixeria 26 Apr '26

26 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/42680?usp=email ) Change subject: lapd_sap_stop(): fix use of uninitialized stack memory ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic1469698ee8edf9b6fb55df8f79cc062be711f61 Gerrit-Change-Number: 42680 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sun, 26 Apr 2026 18:55:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: cosmetic: fix white space in lapd_sap_{start,stop}()
by fixeria 26 Apr '26

26 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/42679?usp=email ) Change subject: cosmetic: fix white space in lapd_sap_{start,stop}() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iadf8629bc3bdf18260b1b83290ce95483d8aac2c Gerrit-Change-Number: 42679 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sun, 26 Apr 2026 18:54:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log