- gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Don't fill in PC from M3UA
by lynxis lazus 26 Apr '26

26 Apr '26

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email ) Change subject: tcap_as_loadshare: Don't fill in PC from M3UA ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684/comment/5bb8e63e_80d6b… : PS1, Line 11: otid/dtid. > Comment removed by: lynxis lazus; Reason: . Could you explain the problem more in detail please? (asymmetric MTP paths and it was a "hack" anyways). -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Apr 2026 11:58:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Don't fill in PC from M3UA
by lynxis lazus 26 Apr '26

26 Apr '26

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: tcap_as_loadshare: Don't fill in PC from M3UA ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684/comment/9cccb1d5_cfcec… : PS1, Line 11: otid/dtid. Explain the problem lies in asymmetric MTP paths are taken and this was a "hack" anyways. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Apr 2026 11:56:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Don't fill in PC from M3UA
by lynxis lazus 26 Apr '26

26 Apr '26

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email ) Change subject: tcap_as_loadshare: Don't fill in PC from M3UA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Apr 2026 11:54:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Don't fill in PC from M3UA
by lynxis lazus 26 Apr '26

26 Apr '26

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email ) Change subject: tcap_as_loadshare: Don't fill in PC from M3UA ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Apr 2026 11:54:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Use tcap_trans_track_begin instead of *_entry_create
by lynxis lazus 26 Apr '26

26 Apr '26

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42685?usp=email ) Change subject: tcap_as_loadshare: Use tcap_trans_track_begin instead of *_entry_create ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icbaab976ed8207843129291494176679db574304 Gerrit-Change-Number: 42685 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Apr 2026 11:53:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails
by lynxis lazus 26 Apr '26

26 Apr '26

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email ) Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ...................................................................... Patch Set 1: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686/comment/46130b13_ba194… : PS1, Line 551: if (!asp) { You should also create the session tracking entry otherwise you will always look it up. `tcap_trans_track_entry_create()` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Apr 2026 11:53:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails
by lynxis lazus 26 Apr '26

26 Apr '26

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email ) Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: it is not a cache, more a session tracking. But in the end I'm not sure if we still want to keep the code. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Apr 2026 11:51:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Clarify name of tcap asp selection function
by lynxis lazus 26 Apr '26

26 Apr '26

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42687?usp=email ) Change subject: tcap_as_loadshare: Clarify name of tcap asp selection function ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I327ad282d2689be2bcf7d3da23026717923c9325 Gerrit-Change-Number: 42687 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 26 Apr 2026 11:50:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails
by daniel 26 Apr '26

26 Apr '26

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email ) Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ...................................................................... tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails Related: SYS#5423 Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 --- M src/tcap_as_loadshare.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/86/42686/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index c549610..61cf25f 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -548,6 +548,10 @@ } asp = tcap_trans_track_continue(as, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); + if (!asp) { + LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for dtid %u/otid %u, using tcap route", parsed.dtid, parsed.otid); + asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); + } rc = asp ? 0 : -ENOKEY; break; case TCAP_TCMessage_PR_abort: @@ -559,6 +563,10 @@ } asp = tcap_trans_track_end(as, &called_addr, &parsed.dtid, &calling_addr, NULL); + if (!asp) { + LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for dtid %u/otid %u, using tcap route", parsed.dtid, parsed.otid); + asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); + } rc = asp ? 0 : -ENOKEY; break; case TCAP_TCMessage_PR_unidirectional: -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Don't fill in PC from M3UA
by daniel 26 Apr '26

26 Apr '26

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email ) Change subject: tcap_as_loadshare: Don't fill in PC from M3UA ...................................................................... tcap_as_loadshare: Don't fill in PC from M3UA If both calling and called_addr are not point codes then the compare in tcap_trans_track_entry_find() will ignore them. It still matches on otid/dtid. Related: SYS#5423 Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 --- M src/tcap_as_loadshare.c 1 file changed, 0 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/84/42684/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index f7ae3b8..635fd73 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -330,18 +330,6 @@ return 0; } - /* TCAP transaction tracking requires point codes */ - if (!(calling_addr.presence & OSMO_SCCP_ADDR_T_PC)) { - /* use M3UA OPC instead */ - calling_addr.pc = opc; - calling_addr.presence |= OSMO_SCCP_ADDR_T_PC; - } - if (!(called_addr.presence & OSMO_SCCP_ADDR_T_PC)) { - /* use M3UA DPC instead */ - called_addr.pc = dpc; - called_addr.presence |= OSMO_SCCP_ADDR_T_PC; - } - /* retrieve the SCCP payload (actual encoded TCAP data) */ ie_data = xua_msg_find_tag(sua, SUA_IEI_DATA); if (!ie_data) @@ -505,18 +493,6 @@ goto out_free_sua; } - /* TCAP transaction tracking requires point codes */ - if (!(calling_addr.presence & OSMO_SCCP_ADDR_T_PC)) { - /* use M3UA OPC instead */ - calling_addr.pc = mtp->opc; - calling_addr.presence |= OSMO_SCCP_ADDR_T_PC; - } - if (!(called_addr.presence & OSMO_SCCP_ADDR_T_PC)) { - /* use M3UA DPC instead */ - called_addr.pc = mtp->dpc; - called_addr.presence |= OSMO_SCCP_ADDR_T_PC; - } - /* retrieve the SCCP payload (TCAP data) */ ie_data = xua_msg_find_tag(sua, SUA_IEI_DATA); if (!ie_data) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log