- gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: ara_m: fix undefined variable used in a format-string
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42380?usp=email ) Change subject: ara_m: fix undefined variable used in a format-string ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42380?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I310a5d461bae2b5e4d8e07097000b079c23aa0f6 Gerrit-Change-Number: 42380 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:36:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: f_TC_fh_params_gen_tr_ma(): simplify ma_mask calculation
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42395?usp=email ) Change subject: bsc: f_TC_fh_params_gen_tr_ma(): simplify ma_mask calculation ...................................................................... bsc: f_TC_fh_params_gen_tr_ma(): simplify ma_mask calculation Commented out code did not work back in 2020, but recent TITAN versions (we use 11.1.0) have no problems compiling/running it. Change-Id: I1892366af13b80844bcda3f84d18578284c35e08 --- M bsc/BSC_Tests.ttcn 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 17f2326..e97ecb0 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -9907,22 +9907,12 @@ if (full_mask[i] != '1'B) { continue; } - /* FIXME: ma_mask := ma_mask & slot_mask[i]; // triggers a bug in TITAN */ - if (slot_mask[i] == '1'B) { - ma_mask := ma_mask & '1'B; - } else { - ma_mask := ma_mask & '0'B; - } + ma_mask := ma_mask & slot_mask[i]; } /* ARFCN 0 (if present) goes to the last position of the bit-mask */ if (full_mask[0] == '1'B) { - /* FIXME: ma_mask := ma_mask & slot_mask[0]; // triggers a bug in TITAN */ - if (slot_mask[0] == '1'B) { - ma_mask := ma_mask & '1'B; - } else { - ma_mask := ma_mask & '0'B; - } + ma_mask := ma_mask & slot_mask[0]; } /* Ensure that ma_mask is octet-aligned */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1892366af13b80844bcda3f84d18578284c35e08 Gerrit-Change-Number: 42395 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: pre-compute RACH RA using oct2int() early
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42394?usp=email ) Change subject: bts: pre-compute RACH RA using oct2int() early ...................................................................... bts: pre-compute RACH RA using oct2int() early Change-Id: I03e8748cf56fa1aa9b598d237d325989d91ca372 --- M bts/BTS_Tests_ASCI.ttcn 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/bts/BTS_Tests_ASCI.ttcn b/bts/BTS_Tests_ASCI.ttcn index 85ef39c..0eb4a05 100644 --- a/bts/BTS_Tests_ASCI.ttcn +++ b/bts/BTS_Tests_ASCI.ttcn @@ -201,7 +201,7 @@ private function f_vgcs_talker_detect() runs on ConnHdlr { var octetstring uplink_free := '082B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B'O; - var octetstring uplink_access := 'C0'O; + var uint8_t ra := oct2int('C0'O); var RSL_Message rm; var GsmFrameNumber fn; @@ -223,10 +223,10 @@ /* Send UPLINK ACCESS on VGCS channel. */ log("Send UPLINK ACCESS."); - fn := f_L1CTL_RACH(L1CTL, oct2int(uplink_access), chan_nr := g_pars.chan_nr); + fn := f_L1CTL_RACH(L1CTL, ra, chan_nr := g_pars.chan_nr); /* Receive UPLINK GRANT by the MS. */ - var RequestReference req_ref := f_compute_ReqRef(oct2int(uplink_access), fn); + var RequestReference req_ref := f_compute_ReqRef(ra, fn); var template (present) GsmRrL3Message uplink_grant := tr_VGCS_UplinkGrant(req_ref); f_l1_exp_lapdm(tr_LAPDm_UI(0, cr_MT_CMD, decmatch uplink_grant)); log("Received VGCS UPLINK GRANT."); @@ -343,7 +343,7 @@ private function f_TC_vgcs_listener_det(charstring id) runs on ConnHdlr { - var octetstring uplink_access := '25'O; + var uint8_t ra := oct2int('25'O); var RSL_Message rm; var GsmFrameNumber fn; @@ -359,7 +359,7 @@ /* Send UPLINK ACCESS on VGCS channel. */ log("Send UPLINK ACCESS."); - fn := f_L1CTL_RACH(L1CTL, oct2int(uplink_access), chan_nr := g_pars.chan_nr); + fn := f_L1CTL_RACH(L1CTL, ra, chan_nr := g_pars.chan_nr); /* Wait for listener detection. */ timer T := 2.0; @@ -381,7 +381,7 @@ /* Send UPLINK ACCESS on VGCS channel. */ log("Send second UPLINK ACCESS."); - fn := f_L1CTL_RACH(L1CTL, oct2int(uplink_access), chan_nr := g_pars.chan_nr); + fn := f_L1CTL_RACH(L1CTL, ra, chan_nr := g_pars.chan_nr); /* Wait for listener detection. */ T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I03e8748cf56fa1aa9b598d237d325989d91ca372 Gerrit-Change-Number: 42394 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: f_vgcs_talker_detect(): check received req. reference
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42393?usp=email ) Change subject: bts: f_vgcs_talker_detect(): check received req. reference ...................................................................... bts: f_vgcs_talker_detect(): check received req. reference Change-Id: Ie988408a4c13af72d93e2d29137c9e1ae9a0d408 --- M bts/BTS_Tests_ASCI.ttcn M library/GSM_RR_Types.ttcn 2 files changed, 26 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved jolly: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/bts/BTS_Tests_ASCI.ttcn b/bts/BTS_Tests_ASCI.ttcn index b982236..85ef39c 100644 --- a/bts/BTS_Tests_ASCI.ttcn +++ b/bts/BTS_Tests_ASCI.ttcn @@ -202,7 +202,6 @@ { var octetstring uplink_free := '082B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B'O; var octetstring uplink_access := 'C0'O; - var template octetstring uplink_grant := '0609C0*'O; var RSL_Message rm; var GsmFrameNumber fn; @@ -227,7 +226,9 @@ fn := f_L1CTL_RACH(L1CTL, oct2int(uplink_access), chan_nr := g_pars.chan_nr); /* Receive UPLINK GRANT by the MS. */ - f_l1_exp_lapdm(tr_LAPDm_UI(0, cr_MT_CMD, uplink_grant)); + var RequestReference req_ref := f_compute_ReqRef(oct2int(uplink_access), fn); + var template (present) GsmRrL3Message uplink_grant := tr_VGCS_UplinkGrant(req_ref); + f_l1_exp_lapdm(tr_LAPDm_UI(0, cr_MT_CMD, decmatch uplink_grant)); log("Received VGCS UPLINK GRANT."); /* Wait for talker detection. */ diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn index 3dc1cd5..2ea8d6a 100644 --- a/library/GSM_RR_Types.ttcn +++ b/library/GSM_RR_Types.ttcn @@ -881,6 +881,29 @@ } }; + template (value) GsmRrL3Message + ts_VGCS_UplinkGrant(template (value) RequestReference req_ref, + template (value) TimingAdvance ta) := { + header := ts_RrL3Header(VGCS_UPLINK_GRANT), + payload := { + vgcs_ul_grant := { + req_ref := req_ref, + ta := ta + } + } + }; + template (present) GsmRrL3Message + tr_VGCS_UplinkGrant(template (present) RequestReference req_ref := ?, + template (present) TimingAdvance ta := ?) := { + header := tr_RrL3Header(VGCS_UPLINK_GRANT), + payload := { + vgcs_ul_grant := { + req_ref := req_ref, + ta := ta + } + } + }; + template (value) MeasurementResults ts_MeasurementResults(template (value) uint6_t rxl_f := 63, template (value) uint6_t rxl_s := 63, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie988408a4c13af72d93e2d29137c9e1ae9a0d408 Gerrit-Change-Number: 42393 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: f_vgcs_talker_detect(): check received req. reference
by fixeria 16 Mar '26

16 Mar '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42393?usp=email ) Change subject: bts: f_vgcs_talker_detect(): check received req. reference ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie988408a4c13af72d93e2d29137c9e1ae9a0d408 Gerrit-Change-Number: 42393 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:35:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: global_platform: fix docstring for Scp03SessionKeys._get_icv()
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42377?usp=email ) Change subject: global_platform: fix docstring for Scp03SessionKeys._get_icv() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8983bc27f581295544360ba8b4ae1d28b3ea850f Gerrit-Change-Number: 42377 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:35:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: global_platform: fix store_data() returning last chunk only
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria, laforge. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42375?usp=email ) Change subject: global_platform: fix store_data() returning last chunk only ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42375?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3e15c8004d1e366e8c3896e559656622f48bb1a2 Gerrit-Change-Number: 42375 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:35:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: f_vgcs_talker_detect(): check received req. reference
by jolly 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42393?usp=email ) Change subject: bts: f_vgcs_talker_detect(): check received req. reference ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie988408a4c13af72d93e2d29137c9e1ae9a0d408 Gerrit-Change-Number: 42393 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:33:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested
by fixeria 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email ) Change subject: global_platform: install_cap_parser: argument groups cannot be nested ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579 Gerrit-Change-Number: 42310 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:31:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: sms: fix flags_construct in SMS_DELIVER
by daniel 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, fixeria. daniel has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42381?usp=email ) Change subject: sms: fix flags_construct in SMS_DELIVER ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0274849f0fa07281b5e050af429ffda7d249f9e8 Gerrit-Change-Number: 42381 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:29:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log