- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs/gerrit-verifications: add logger_gsmtap

by fixeria

Attention is currently required from: osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/40804?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: jobs/gerrit-verifications: add logger_gsmtap ...................................................................... jobs/gerrit-verifications: add logger_gsmtap Change-Id: I4ffae01156caa467ec23f6b89185b8d65d4691a3 Related: logger_gsmtap.git e06a0b9b3506e8ab1a7cfeeae72e32b2d6186989 --- M jobs/gerrit-verifications.yml 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/04/40804/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4ffae01156caa467ec23f6b89185b8d65d4691a3 Gerrit-Change-Number: 40804 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit-verifications: add logger_gsmtap

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/40804?usp=email ) Change subject: jobs/gerrit-verifications: add logger_gsmtap ...................................................................... Patch Set 1: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/40804/comment/23aaa614_41f95f1c?usp=… : PS1, Line 245: pipeline_binpkgs: "debian:12" > It doesn't have a debian dir, so let's disable test-building for debian 12: […] Oh, indeed. Thanks. Done. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4ffae01156caa467ec23f6b89185b8d65d4691a3 Gerrit-Change-Number: 40804 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 09:09:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.

by jolly

Attention is currently required from: laforge. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email ) Change subject: Automatically increase io_uring, if too small. ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 01 Aug 2025 08:05:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

2 weeks, 2 days

1
0
0 0

[S] Change in libosmocore[master]: Add environment variable to set io_uring size

by jolly

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: Add environment variable to set io_uring size ...................................................................... Add environment variable to set io_uring size The term "LIBOSMO_IO_URING_INITIAL_SIZE" is related to the following patch, which will increment the size of the io_uring automatically if the initial size is too small. Related: OS#6705 Change-Id: I55289d9282e13aa1bf82f3931c85c196752f1484 --- M src/core/osmo_io_uring.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/40782/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I55289d9282e13aa1bf82f3931c85c196752f1484 Gerrit-Change-Number: 40782 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.

by jolly

Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email ) Change subject: Automatically increase io_uring, if too small. ...................................................................... Patch Set 6: (6 comments) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/552ae731_981cd2ff?… : PS6, Line 116: /* ! array of rings the submitted read SQEs have been submitted */ > "have been submitted to" Done File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/26394b77_0fcf72bf?… : PS6, Line 115: g_ring = calloc(1, sizeof(*g_ring)); > use talloc. Done https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/4e4bec31_ca323694?… : PS6, Line 164: LOGP(DLIO, LOGL_NOTICE, "increasing io_uring size to %d.\n", g_io_uring_size); > Please put this into 1 single LOGP. Done https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/916ef134_960c9bdd?… : PS6, Line 172: sqe = io_uring_get_sqe(&g_ring->ring); > so here we end up with 2 read SQEs on 2 different queues. […] I added a check, so subsequent read SQEs are never spread over different rings. https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/66a64478_c9e53bf8?… : PS6, Line 527: while ((sqe = io_uring_get_sqe(iofd->u.uring.read_ring[idx])) == NULL); > that looks like a really nice tight non-blocking loop filling the CPU? Done https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/3f85a947_de8c504b?… : PS6, Line 543: while ((sqe = io_uring_get_sqe(iofd->u.uring.write_ring)) == NULL); > that looks like a really nice tight non-blocking loop filling the CPU? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 07:49:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.

by jolly

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review-1 by laforge, Verified+1 by Jenkins Builder Change subject: Automatically increase io_uring, if too small. ...................................................................... Automatically increase io_uring, if too small. The ring may be too small to store all SQEs before the kernel can handle them. If this happens, a new ring is allocated with twice of the size of the old ring. The old ring will not be destroyed, as it still contains uncompleted elements. Some of them may never be completed. A pointer to the current ring will be stored within the msghdr structure. It is used when cancelling an SQE. The cancellation must be performed in the same ring where it was created. It is quite unlikely that the old ring cannot store the cancellation SQE. If this happens, the kernel is given some time to handle the SQEs. The initial size of the ring can be changed via environment variable. Related: OS#6705 Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca --- M src/core/osmo_io_internal.h M src/core/osmo_io_uring.c 2 files changed, 148 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/40725/7 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org>

2 weeks, 2 days

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master-builds: add logger_gsmtap and enftables

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40803?usp=email ) Change subject: jobs/master-builds: add logger_gsmtap and enftables ...................................................................... jobs/master-builds: add logger_gsmtap and enftables Change-Id: I88d8e03770e7effb49e59493d0e9ba59f75e8ddd Related: logger_gsmtap.git e06a0b9b3506e8ab1a7cfeeae72e32b2d6186989 Related: enftables.git 735602e15471eab82c93f9e2e044a4d69031ced8 --- M jobs/master-builds.yml 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 4b34eb2..af8432a 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -317,6 +317,14 @@ repos_url: '{gerrit_url}/erlang/{repos}' cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' + - logger_gsmtap: + repos_url: '{gerrit_url}/erlang/{repos}' + cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' + + - enftables: + repos_url: '{gerrit_url}/erlang/{repos}' + cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' + - osmo-e1-hardware: a2_name: JOB_TYPE a2: !!python/tuple ["firmware", "gateware", "manuals", "software"] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88d8e03770e7effb49e59493d0e9ba59f75e8ddd Gerrit-Change-Number: 40803 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

[XS] Change in osmo-ci[master]: osmo_git_clone_url(): add logger_gsmtap and enftables

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40802?usp=email ) Change subject: osmo_git_clone_url(): add logger_gsmtap and enftables ...................................................................... osmo_git_clone_url(): add logger_gsmtap and enftables Change-Id: I495f3334a8d61a325fe6540043b07b8dababd8c6 --- M scripts/common.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/common.sh b/scripts/common.sh index 46bf9c3..fb06d70 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -149,7 +149,7 @@ libosmo-sccp-legacy) echo "$OSMO_GIT_URL_GITEA"/osmocom/"$1" ;; - osmo_dia2gsup|osmo-epdg|osmo-s1gw) + osmo_dia2gsup|osmo-epdg|osmo-s1gw|logger_gsmtap|enftables) echo "$OSMO_GIT_URL_GERRIT"/erlang/"$1" ;; pyosmocom) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40802?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I495f3334a8d61a325fe6540043b07b8dababd8c6 Gerrit-Change-Number: 40802 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master-builds: add logger_gsmtap and enftables

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/40803?usp=email ) Change subject: jobs/master-builds: add logger_gsmtap and enftables ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/40803/comment/b729f4a6_7fb6c3d7?usp=… : PS1, Line 10: e06a0b9b3506e8ab1a7cfeeae72e32b2d6186989 > This patch (https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40800) needs to be merged. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88d8e03770e7effb49e59493d0e9ba59f75e8ddd Gerrit-Change-Number: 40803 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 07:31:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

[XS] Change in ...logger_gsmtap[master]: contrib/jenkins.sh: add build verification script

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40800?usp=email ) Change subject: contrib/jenkins.sh: add build verification script ...................................................................... contrib/jenkins.sh: add build verification script Change-Id: I3183112c96c92716edb4fb485621d14d531166cc --- A contrib/jenkins.sh 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..d58398d --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,5 @@ +#!/bin/sh -ex + +rebar3 clean +rebar3 compile +rebar3 dialyzer -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I3183112c96c92716edb4fb485621d14d531166cc Gerrit-Change-Number: 40800 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 2 days

1
0
0 0

2025

2024

2023

2022

gerrit-log