Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42293?usp=email )
Change subject: pfcp_peer: replace watchdog process with a timer
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42293?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8d71ad8300feefb0aecbf690a825a2b4e9f1102c
Gerrit-Change-Number: 42293
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Mar 2026 09:41:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42285?usp=email )
Change subject: hlr: pyhss: run the pyhss_hss service
......................................................................
hlr: pyhss: run the pyhss_hss service
Database preparations used to be done in PyHSS by all services if they
noticed that this was needed. The time between checking and creating the
tables caused a race condition where two services attempting to create
tables at the same time will result at one of them failing, we have seen
this in our ttcn3-hlr-test-pyhss jobs sometimes:
[Database] [DEBUG] Table apn already exists
[Database] [DEBUG] Table auc already exists
[Database] [DEBUG] Table subscriber already exists
…
[testenv][pyhss] pyhss_gsup: setup script failed
I have fixed this upstream by letting only the main service (pyhss_hss)
prepare the database:
https://github.com/nickvsnetworking/pyhss/commit/8b8a2202c345fbb7262c9d07d0…
This means that we now need to run the pyhss_hss service in the HLR
tests, so pyhss_gsup doesn't fail with:
[Database] [INFO] Waiting for the main service to prepare the database
ERROR: 127.0.0.1:4222 did not become available within 5s!
[testenv][pyhss] pyhss_gsup: setup script failed
Change-Id: I4fe689c8d8617432175ba403b45021c0f646970b
---
M hlr/testenv_pyhss.cfg
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/hlr/testenv_pyhss.cfg b/hlr/testenv_pyhss.cfg
index 7a70872..2e81987 100644
--- a/hlr/testenv_pyhss.cfg
+++ b/hlr/testenv_pyhss.cfg
@@ -10,6 +10,11 @@
package=no
copy=pyhss/redis.conf
+[pyhss_hss]
+program=cd ../pyhss_gsup && ./run_in_venv.sh pyhss_hss
+make=pyhss
+package=pyhss
+
[pyhss_gsup]
program=./run_in_venv.sh pyhss_gsup
setup=wait_for_port.py -p 4222
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42285?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4fe689c8d8617432175ba403b45021c0f646970b
Gerrit-Change-Number: 42285
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42286?usp=email )
Change subject: {hlr,hss}/pyhss/config: remove unused options
......................................................................
{hlr,hss}/pyhss/config: remove unused options
PyHSS had several unused config options. They have been removed
upstream, remove them from the osmo-ttcn3-hacks configs as well.
Related: https://github.com/nickvsnetworking/pyhss/pull/284
Change-Id: I87cf01e00fe0a3b32be9eaa4cf4c1ddf02cddc0b
---
M hlr/pyhss/config.yaml
M hss/pyhss/config.yaml
2 files changed, 0 insertions(+), 52 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/hlr/pyhss/config.yaml b/hlr/pyhss/config.yaml
index 87e6c53..61b819e 100644
--- a/hlr/pyhss/config.yaml
+++ b/hlr/pyhss/config.yaml
@@ -8,12 +8,6 @@
site_name: "TTCN3"
MCC: "001"
MNC: "01"
- SLh_enabled: False
- #IMSI of Test Subscriber for Unit Checks (Optional)
- test_sub_imsi: '001021234567890'
-
- #The maximum time to wait, in seconds, before disconnecting a client when no data is received.
- client_socket_timeout: 120
#The maximum time to wait, in seconds, before disconnecting a client when no data is received.
client_socket_timeout: 300
@@ -39,13 +33,6 @@
#If enabled sends CLRs to old MME when new MME attaches active sub
CancelLocationRequest_Enabled: False
- #Workaround for some MMEs to force an Insert Subscriber Data request to be sent immediately after ULA
- Insert_Subscriber_Data_Force: False
-
- #Default Initial Filter Criteria for IMS Subscribers
- #Jinja Formatted Template, see the example for variables passed to it.
- Default_iFC: 'default_ifc.xml'
-
#Default Sh User Data
Default_Sh_UserData: 'default_sh_user_data.xml'
@@ -124,11 +111,7 @@
database:
db_type: sqlite
server: 127.0.0.1
- username: dbeaver
- password: password
database: pyhss.db
- readCacheEnabled: True
- readCacheInterval: 60
## External Webhook Notifications
webhooks:
@@ -160,18 +143,6 @@
unixSocketPath: '/var/run/redis/redis-server.sock'
host: localhost
port: 6379
- sentinel:
- masterName: exampleMaster
- hosts:
- - exampleSentinel.mnc001.mcc001.3gppnetwork.org:
- port: 6379
- password: ''
-
-
-prometheus:
- enabled: False
- port: 8081 #If the API is run the API runs on the next port number up from this
- async_subscriber_count: False #If enabled the subscriber count will be updated asynchronously for Prometheus
influxdb:
enabled: False
diff --git a/hss/pyhss/config.yaml b/hss/pyhss/config.yaml
index 3114820..c951beb 100644
--- a/hss/pyhss/config.yaml
+++ b/hss/pyhss/config.yaml
@@ -8,12 +8,6 @@
site_name: "TTCN3"
MCC: "001"
MNC: "01"
- SLh_enabled: False
- #IMSI of Test Subscriber for Unit Checks (Optional)
- test_sub_imsi: '001021234567890'
-
- #The maximum time to wait, in seconds, before disconnecting a client when no data is received.
- client_socket_timeout: 120
#The maximum time to wait, in seconds, before disconnecting a client when no data is received.
client_socket_timeout: 300
@@ -39,13 +33,6 @@
#If enabled sends CLRs to old MME when new MME attaches active sub
CancelLocationRequest_Enabled: False
- #Workaround for some MMEs to force an Insert Subscriber Data request to be sent immediately after ULA
- Insert_Subscriber_Data_Force: False
-
- #Default Initial Filter Criteria for IMS Subscribers
- #Jinja Formatted Template, see the example for variables passed to it.
- Default_iFC: 'default_ifc.xml'
-
#Default Sh User Data
Default_Sh_UserData: 'default_sh_user_data.xml'
@@ -121,11 +108,7 @@
database:
db_type: sqlite
server: 127.0.0.1
- username: dbeaver
- password: password
database: pyhss.db
- readCacheEnabled: True
- readCacheInterval: 60
## External Webhook Notifications
webhooks:
@@ -157,12 +140,6 @@
unixSocketPath: '/var/run/redis/redis-server.sock'
host: localhost
port: 6379
- sentinel:
- masterName: exampleMaster
- hosts:
- - exampleSentinel.mnc001.mcc001.3gppnetwork.org:
- port: 6379
- password: ''
influxdb:
enabled: False
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42286?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I87cf01e00fe0a3b32be9eaa4cf4c1ddf02cddc0b
Gerrit-Change-Number: 42286
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42283?usp=email )
Change subject: repo-install-test: ignore pyhss
......................................................................
repo-install-test: ignore pyhss
PyHSS listens on the same port as OsmoHLR, which causes the test to fail
with debian 13 because OsmoHLR can't start up properly. PyHSS wasn't
built for earlier debian versions in the Osmocom binary repositories.
Change-Id: I796e85a212dff94fbf9b8ef563eba47418c221cc
---
M scripts/repo-install-test/run-inside.sh
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh
index 88dcdda..493c29f 100755
--- a/scripts/repo-install-test/run-inside.sh
+++ b/scripts/repo-install-test/run-inside.sh
@@ -364,6 +364,9 @@
# Breaks the ssh connection to QEMU
charon-systemd*) ;;
+ # Conflicts with OsmoHLR (127.0.0.1:4222: Address already in use)
+ pyhss*) ;;
+
# All other packages are not filtered
*) echo "$i" ;;
esac
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42283?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I796e85a212dff94fbf9b8ef563eba47418c221cc
Gerrit-Change-Number: 42283
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42282?usp=email )
Change subject: repo-install-test: ignore charon-systemd
......................................................................
repo-install-test: ignore charon-systemd
This package from strongswan-epdg causes the SSH connection to QEMU to
break when installed in debian 13. Don't install it. Use the wildcard,
because there is also a debug symbols package that pulls in
charon-systemd.
Change-Id: Ic641d5361c51df147a8cef5d49eb1e0f07b72e87
---
M scripts/repo-install-test/run-inside.sh
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh
index 94bfa0e..88dcdda 100755
--- a/scripts/repo-install-test/run-inside.sh
+++ b/scripts/repo-install-test/run-inside.sh
@@ -361,6 +361,9 @@
# this test as downloading FPGA bitstream fails.
*bladerf*) ;;
+ # Breaks the ssh connection to QEMU
+ charon-systemd*) ;;
+
# All other packages are not filtered
*) echo "$i" ;;
esac
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42282?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ic641d5361c51df147a8cef5d49eb1e0f07b72e87
Gerrit-Change-Number: 42282
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42280?usp=email )
Change subject: repo-install-test: fix test_conflict for debian 13
......................................................................
repo-install-test: fix test_conflict for debian 13
Two changes are necessary to make this test work with debian 13:
* Installing libosmocore from osmocom-latest, then switching to
osmocom-nightly and attempting to install another package is not
enough anymore to trigger a conflict. apt is now able to resolve this
by uninstalling the osmocom-latest package and upgrading libosmocore
to the nightly version. Force the conflict by explicitly marking
osmocom-latest (osmocom-$FEED) as installed and for hold.
* The apt conflict message has been reworked, so the string to look for
needs to be adjusted.
Change-Id: Ibdcd583e48b97ced11ad4939974dccea3e139480
---
M scripts/repo-install-test/run-inside.sh
1 file changed, 14 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh
index 6937dac..836d59d 100755
--- a/scripts/repo-install-test/run-inside.sh
+++ b/scripts/repo-install-test/run-inside.sh
@@ -242,7 +242,8 @@
return
fi
- apt-get -y install libosmocore
+ apt-get -y install libosmocore osmocom-"$FEED"
+ apt-mark hold osmocom-"$FEED"
configure_osmocom_repo_debian_remove "$PROJ"
configure_osmocom_repo_debian "$PROJ_CONFLICT"
@@ -259,9 +260,18 @@
"requested an impossible situation" \
"^The following packages have unmet dependencies:"
- find_patterns_or_exit \
- /tmp/out \
- "Conflicts: osmocom-"
+ case "$DISTRO" in
+ debian11|debian12)
+ find_patterns_or_exit \
+ /tmp/out \
+ "Conflicts: osmocom-"
+ ;;
+ *)
+ find_patterns_or_exit \
+ /tmp/out \
+ "Conflicts osmocom-"
+ ;;
+ esac
configure_osmocom_repo_debian_remove "$PROJ_CONFLICT"
configure_osmocom_repo_debian "$PROJ"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42280?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ibdcd583e48b97ced11ad4939974dccea3e139480
Gerrit-Change-Number: 42280
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>