September 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[master]: gsm48_tx_gmm_ra_upd_ack: add some comments to unencoded TLVs
by pespin 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43468?usp=email ) Change subject: gsm48_tx_gmm_ra_upd_ack: add some comments to unencoded TLVs ...................................................................... Patch Set 9: Code-Review-1 (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/43468/comment/0a0c65fd_2989d3e5?us… : PS8, Line 1418: /* MS identity */ > this is already 2 lines above? I'd welcome if you addressed all the comments before pushing a new version to gerrit. Otherwise please push in a separate personal branch. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc83186da4fa562bac716c3c7f4448ab46439c3c Gerrit-Change-Number: 43468 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Sep 2026 18:17:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by pespin 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 17: (3 comments) Patchset: PS17: Some of my comments were still not addressed. File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/36f8c672_76331287?us… : PS17, Line 2602: osmo_vlr_set_log_cat(OSMO_VLR_LOGC_VLR, DVLR); If we can set the log category here, I wonder why it does use the SGS category hardcoded as you mentioned in the other file... File src/sgsn/gprs_rau_fsm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/7bb93854_f7104f99?us… : PS16, Line 76: static void gmm_rau_fsm_s_init(struct osmo_fsm_inst *fi, uint32_t event, void *data) > Why is the file called "gprs_rau_fsm" vs all the types/functions being called "gmm_rau_fsm"? Please […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 17 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Sep 2026 18:16:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: cosmetic
by lynxis lazus 09 Sep '26

09 Sep '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email ) Change subject: gprs_gmm: cosmetic ...................................................................... Patch Set 2: (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/43596/comment/37aa6611_dd549f80?us… : PS1, Line 1775: * foreign TLLI to local TLLI */ > You ctually forgot to move the "*" one char, but it's fine :) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8f3e647cb7dc3a1b59a560e0301e4d4db1f94f8b Gerrit-Change-Number: 43596 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Sep 2026 17:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by lynxis lazus 09 Sep '26

09 Sep '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email to look at the new patch set (#17). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Rework SGSN code to use new libvlr code ...................................................................... Rework SGSN code to use new libvlr code The libvlr code will take most of the logic of the Routing Area handling. By using the new libvlr code, the ACL and usage of the SGSN without the HLR has been removed. Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 --- M include/osmocom/sgsn/Makefile.am M include/osmocom/sgsn/debug.h M include/osmocom/sgsn/gprs_gmm.h M include/osmocom/sgsn/gprs_gmm_attach.h M include/osmocom/sgsn/gprs_gmm_fsm.h A include/osmocom/sgsn/gprs_rau_fsm.h M include/osmocom/sgsn/gprs_subscriber.h M include/osmocom/sgsn/mmctx.h M include/osmocom/sgsn/sgsn.h M src/sgsn/Makefile.am M src/sgsn/gprs_gmm.c M src/sgsn/gprs_gmm_attach.c M src/sgsn/gprs_gmm_fsm.c M src/sgsn/gprs_ranap.c A src/sgsn/gprs_rau_fsm.c M src/sgsn/gprs_subscriber.c M src/sgsn/mmctx.c M src/sgsn/sgsn.c M src/sgsn/sgsn_auth.c M src/sgsn/sgsn_libgtp.c M src/sgsn/sgsn_main.c M src/sgsn/sgsn_vty.c M tests/gprs_routing_area/Makefile.am M tests/sgsn/Makefile.am M tests/sgsn/sgsn_test.c M tests/sgsn/sgsn_test.ok M tests/vty_test_runner.py 27 files changed, 1,308 insertions(+), 3,835 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/62/39562/17 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 17 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f
by Jenkins Builder 09 Sep '26

09 Sep '26

Attention is currently required from: laforge, osmith. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f ...................................................................... Patch Set 9: (1 comment) File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/98ada025_b7efbf2e?us… : PS9, Line 265: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 09 Sep 2026 17:39:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f
by Jenkins Builder 09 Sep '26

09 Sep '26

Attention is currently required from: laforge, osmith. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f ...................................................................... Patch Set 8: (1 comment) File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/1f930ac8_46db32e5?us… : PS8, Line 265: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 09 Sep 2026 17:39:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: cosmetic
by pespin 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email ) Change subject: gprs_gmm: cosmetic ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8f3e647cb7dc3a1b59a560e0301e4d4db1f94f8b Gerrit-Change-Number: 43596 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Sep 2026 17:21:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Attach Complete: add TODO for follow-on request
by pespin 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43597?usp=email ) Change subject: gprs_gmm: Attach Complete: add TODO for follow-on request ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I136ff28262b5caec139765881ba2efd64ab75dcc Gerrit-Change-Number: 43597 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Sep 2026 17:21:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: cosmetic
by lynxis lazus 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: gprs_gmm: cosmetic ...................................................................... gprs_gmm: cosmetic Change-Id: I8f3e647cb7dc3a1b59a560e0301e4d4db1f94f8b --- M src/sgsn/gprs_gmm.c 1 file changed, 4 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/96/43596/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8f3e647cb7dc3a1b59a560e0301e4d4db1f94f8b Gerrit-Change-Number: 43596 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght
by lynxis lazus 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43599?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght ...................................................................... gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght Change-Id: Ic9560108ee424634e15a5af1424ea44df491a474 --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/99/43599/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic9560108ee424634e15a5af1424ea44df491a474 Gerrit-Change-Number: 43599 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026