September 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: proxy: implement TRXC SETSLOT
by pespin 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43609?usp=email ) Change subject: proxy: implement TRXC SETSLOT ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0f038fc453336e60d41641ec490907cddf259c3f Gerrit-Change-Number: 43609 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 09:07:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: proxy: make path_sim values configurable via VTY
by pespin 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43608?usp=email ) Change subject: proxy: make path_sim values configurable via VTY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I969e9df1ab394e631da3da9b3044fab1446db40e Gerrit-Change-Number: 43608 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 09:06:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: proxy: implement power measurement emulation
by pespin 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43607?usp=email ) Change subject: proxy: implement power measurement emulation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9be028ae9c1a20caf24327b7ee81eeeabbda0634 Gerrit-Change-Number: 43607 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 09:04:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-trx[master]: proxy: implement RF path simulation
by pespin 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43606?usp=email ) Change subject: proxy: implement RF path simulation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iefa51d6b0e0bba1f12bdbcdf576528e7d3588b8f Gerrit-Change-Number: 43606 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 09:03:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: proxy: implement burst forwarding (proxying) logic
by pespin 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43605?usp=email ) Change subject: proxy: implement burst forwarding (proxying) logic ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1df0389ef523a59402081deb8f74b84e136ea7dd Gerrit-Change-Number: 43605 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 09:01:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-trx[master]: proxy: add TDMA clock generator and basic TRXC handler
by pespin 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43604?usp=email ) Change subject: proxy: add TDMA clock generator and basic TRXC handler ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File proxy/include/osmocom/proxy/trx.h: https://gerrit.osmocom.org/c/osmo-trx/+/43604/comment/ef102cbf_7c682808?usp… : PS1, Line 43: /*! Change the number of channels; must be called before proxy_trx_open(). */ You probably want to have these comments in the .c file. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8c0757f15961bf0574f1305a6a8836853b66afcf Gerrit-Change-Number: 43604 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 08:59:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-trx[master]: osmo-trx-proxy: initial app skeleton
by pespin 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43603?usp=email ) Change subject: osmo-trx-proxy: initial app skeleton ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File proxy/include/osmocom/proxy/proxy.h: https://gerrit.osmocom.org/c/osmo-trx/+/43603/comment/aaf1d5e6_fbda5d3a?usp… : PS1, Line 23: struct proxy_ctx *proxy_ctx_alloc(void *talloc_ctx); no _free()? File proxy/src/proxy.c: https://gerrit.osmocom.org/c/osmo-trx/+/43603/comment/908f74c7_a1519c75?usp… : PS1, Line 56: bool proxy_ctx_add_defaults_if_empty(struct proxy_ctx *proxy) weird returning a bool here instead of return code. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id2b12e5e7d053eea53338fbabc48131b9c46c82a Gerrit-Change-Number: 43603 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 08:52:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-trx[master]: .checkpatch.c++.conf: --ignore LEADING_SPACE
by pespin 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43602?usp=email ) Change subject: .checkpatch.c++.conf: --ignore LEADING_SPACE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I542cd4e393c218979e78f56c7d3f9d2ed6d6f379 Gerrit-Change-Number: 43602 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 08:47:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: libosmo-trx/ep: allow ctrl socket to accept/reply to any peer
by pespin 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43601?usp=email ) Change subject: libosmo-trx/ep: allow ctrl socket to accept/reply to any peer ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43601/comment/bc9a7cf7_2a08ed15?usp… : PS1, Line 462: getpeername(osmo_iofd_get_fd(chan->ctrl_iofd), &peer->u.sa, &peer_len); missing return code check -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I97075eb350e4270f4e909d493ba692e6b65be750 Gerrit-Change-Number: 43601 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 08:45:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown
by pespin 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email ) Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown ...................................................................... Patch Set 6: Code-Review+1 (5 comments) Patchset: PS6: As mentioned I don't think trying to hide the asynchronous close of ctrl socket by outliving the object is a good idea, and I think that will come up with problems later on. But if you are happy with it, I don't want to block this. File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/0a46363a_36fd5a71?usp… : PS6, Line 310: LOGEPCH(flush->ep, flush->chan_num, LOGL_DEBUG, This should be inside the if above, since no flush can complete if res <=0. https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/92f193ad_fc428d07?usp… : PS6, Line 348: flush = talloc(iofd, struct trx_ep_ctrl_flush); I really fail to see why do we need a separate object to handle the flushing, but ok... https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/d6d319f0_97e7d2cb?usp… : PS6, Line 552: * finish flushing on its own, since it may outlive the endpoint. */ I don't really see why would you like the ctrl socket to outlive the endpoint. If the ctrl socket needs more time to close, then closing the endpoint should also be an asynchronous operation, with a closed_cb. https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/95453248_97e6d59f?usp… : PS6, Line 581: return !llist_empty(&ep->closing_flushes); I really wonder why do you need this list of closing flushes. IMHO it's much more simple: if CTRL socket in any chan is_closing(), then osmo_trx_ep is_closing(). -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56 Gerrit-Change-Number: 43112 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 08:40:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026