Attention is currently required from: fixeria.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email )
Change subject: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request
......................................................................
Patch Set 1:
(1 comment)
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43595/comment/ca36968b_8168a2dc?us… :
PS1, Line 1320: LOGPC(DMM, LOGL_INFO, "\n");
> Are you sure this is no longer needed? Previous `LOGPC` statement does not print `\n`.
good catch. Will integrate it into upper log line
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64
Gerrit-Change-Number: 43595
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Sep 2026 21:21:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43461?usp=email )
Change subject: libvlr: Remove MSC specific parts
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I guess this needs to be squashed into the previous commit, the one adding libvlr? Alternatively, it should be integrated into the build system only when it's in a state it compiles...
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43461?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I35e3edc56c7c64ac2a4462dec8ea684b00ab3881
Gerrit-Change-Number: 43461
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 09 Sep 2026 20:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email )
Change subject: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request
......................................................................
Patch Set 1:
(1 comment)
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43595/comment/1180e231_69ed9d1d?us… :
PS1, Line 1320: LOGPC(DMM, LOGL_INFO, "\n");
Are you sure this is no longer needed? Previous `LOGPC` statement does not print `\n`.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64
Gerrit-Change-Number: 43595
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 09 Sep 2026 20:11:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No