September 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-dev[master]: gen_makefile: allow passing opts to cmake, meson
by osmith 10 Sep '26

10 Sep '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-dev/+/43614?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gen_makefile: allow passing opts to cmake, meson ...................................................................... gen_makefile: allow passing opts to cmake, meson We need to always build the cmake program onomondo-ipa with a specific option when building it through testenv with osmo-dev. Extend gen_makefile so we can pass options not only to autotools based projects, but also to cmake and while at it meson too. For example usage, see the related patch. Related: osmo-ttcn3-hacks I6e9dfb6baf9cd0d760f0ea3d18983b56ed64f9be Change-Id: I2572ae781dd4d57e614813c90f5ed8bc76caf033 --- M gen_makefile.py 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/14/43614/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/43614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I2572ae781dd4d57e614813c90f5ed8bc76caf033 Gerrit-Change-Number: 43614 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ipa: build with -DMEM_EMIT_DEBUG=ON
by osmith 10 Sep '26

10 Sep '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43615?usp=email ) Change subject: ipa: build with -DMEM_EMIT_DEBUG=ON ...................................................................... ipa: build with -DMEM_EMIT_DEBUG=ON As requested by Andreas, always build onomondo-ipa with this option when building it with testenv. Depends: osmo-dev I2572ae781dd4d57e614813c90f5ed8bc76caf033 Change-Id: I6e9dfb6baf9cd0d760f0ea3d18983b56ed64f9be --- M _testenv/data/osmo-dev/testenv.opts 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/43615/1 diff --git a/_testenv/data/osmo-dev/testenv.opts b/_testenv/data/osmo-dev/testenv.opts index 15ab331..4ee524b 100644 --- a/_testenv/data/osmo-dev/testenv.opts +++ b/_testenv/data/osmo-dev/testenv.opts @@ -1,2 +1,3 @@ osmo-bts --enable-trx osmo-remsim --disable-remsim-client-ifdhandler +onomondo-ipa -DMEM_EMIT_DEBUG=ON -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e9dfb6baf9cd0d760f0ea3d18983b56ed64f9be Gerrit-Change-Number: 43615 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-dev[master]: gen_makefile: allow passing opts to cmake, meson
by osmith 10 Sep '26

10 Sep '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/43614?usp=email ) Change subject: gen_makefile: allow passing opts to cmake, meson ...................................................................... gen_makefile: allow passing opts to cmake, meson We need to always build the cmake program onomondo-ipa with a specific option when building it through testenv with osmo-dev. Extend gen_makefile so we can pass options not only to autotools based projects, but also to cmake and while at it meson too. For example usage, see the related patch. Related: osmo-ttcn3-hacks I6e9dfb6baf9cd0d760f0ea3d18983b56ed64f9be Change-Id: I2572ae781dd4d57e614813c90f5ed8bc76caf033 --- M gen_makefile.py 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/14/43614/1 diff --git a/gen_makefile.py b/gen_makefile.py index 203c7f5..9457804 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -378,7 +378,8 @@ -rm -rf {build_proj} mkdir -p {build_proj} cd {build_proj}; {cflags}meson setup {build_to_src} . \\ - --prefix {shlex.quote(args.install_prefix)} + --prefix {shlex.quote(args.install_prefix)} \\ + {configure_opts} touch $@ ''' elif buildsystem == "cmake": @@ -389,7 +390,8 @@ -rm -rf {build_proj} mkdir -p {build_proj} cd {build_proj}; cmake -S {build_to_src} -B . \\ - -DCMAKE_INSTALL_PREFIX={shlex.quote(args.install_prefix)} + -DCMAKE_INSTALL_PREFIX={shlex.quote(args.install_prefix)} \\ + {configure_opts} touch $@ ''' elif buildsystem in ["erlang", "python"]: @@ -753,9 +755,15 @@ content += 'all-install: \\\n\t' + ' \\\n\t'.join([ '.make.%s.install' % p for p, d in projects_deps.items() ]) + '\n\n' for proj, deps in projects_deps.items(): + # Build a project-specific list of configure optons all_config_opts = [] - all_config_opts.extend(configure_opts.get('ALL') or []) + if projects_buildsystems.get(proj, "autotools") == "autotools": + # Options for ALL are only applied to projects with the autotools build + # system. When applying unknown options to ./configure, they simply get + # ignored whereas other build systems will fail. + all_config_opts.extend(configure_opts.get('ALL') or []) all_config_opts.extend(configure_opts.get(proj) or []) + content += gen_make(proj, deps, all_config_opts, make_dir, src_dir, build_dir) # Replace spaces with tabs to avoid the common pitfall of inserting spaces -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/43614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I2572ae781dd4d57e614813c90f5ed8bc76caf033 Gerrit-Change-Number: 43614 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[L] Change in pysim[master]: ota: add TS 102 226 5.2 Expanded Remote Application data format
by Hoernchen 10 Sep '26

10 Sep '26

Attention is currently required from: dexter. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43541?usp=email ) Change subject: ota: add TS 102 226 5.2 Expanded Remote Application data format ...................................................................... Patch Set 2: (2 comments) File pySim/ota.py: https://gerrit.osmocom.org/c/pysim/+/43541/comment/df49afa9_28d0043b?usp=em… : PS2, Line 323: > I would recommend to add API docstrings for the other parameters, in particular the apdu parameter, […] The type literally tells me in the most expressive way what apdu is? This is in line with the previous code, no docs for obscure internal en/decoding methods. https://gerrit.osmocom.org/c/pysim/+/43541/comment/f0f9ff10_3435f242?usp=em… : PS2, Line 333: > same here, I think we should document all parameters. Ok, but this is not related to this patchset, the comments are in line with the existing code. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43541?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idec00d16fd1a7d4a7129b2a3b6f0ef37dabcecb7 Gerrit-Change-Number: 43541 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 12:00:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in pysim[master]: bip: move the BIP relay into pySim.bip
by Hoernchen 10 Sep '26

10 Sep '26

Attention is currently required from: dexter. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43540?usp=email ) Change subject: bip: move the BIP relay into pySim.bip ...................................................................... Patch Set 2: (2 comments) File tests/unittests/test_bip_relay.py: https://gerrit.osmocom.org/c/pysim/+/43540/comment/1b7e0c4f_ab8270a6?usp=em… : PS1, Line 28: with a card that sends one, and one that has one must get the PDU.""" > I only see sms_sink? Were there crashes before, did you change the code when moving it to the bip mo […] No idea see the make bip commit for handlers. These commits are mostly made up and were not tested (beyond running the related tests) independently as usual but split and rearranged from the actual commits to make them pretty/work with our rebase workflow, so all of this is just intermediate steps to what works in the end at the top of this pile of commits. Reviewing the intermediate commits is basically pointless unless we want to spend forever exercising half finished features for no benefit, there is not much I can do about this. In any case, these tests currently pass with this move change, and the make bip work commit adds its own more specific tests, so I dont see a reason to change much here. I could squash related commits, but then we would discuss splitting them instead... https://gerrit.osmocom.org/c/pysim/+/43540/comment/33a0e6cb_469959f3?usp=em… : PS1, Line 40: Proact(sms_sink=seen.append).send_sms_via_smpp(self._submit()) > maybe create the Proact object first and use it then. […] No idea, this was originally part of the make bip work changes until the changes and file move/rename were split, does it matter? Some of the tests were just experiments to figure something out while I was working on the actual features. I guess we can clean up outdated tests later. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43540?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifd8a15684939977d29ea83a6b669daee14484e88 Gerrit-Change-Number: 43540 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 11:40:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: crypto_utils: fix sourcecode formatting
by dexter 10 Sep '26

10 Sep '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43613?usp=email ) Change subject: crypto_utils: fix sourcecode formatting ...................................................................... crypto_utils: fix sourcecode formatting Related: SYS#8100 Change-Id: Ie4d6b4d44a015e97606f6ca6e01398bcf385f542 --- M src/crypto_utils.erl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/13/43613/1 diff --git a/src/crypto_utils.erl b/src/crypto_utils.erl index 4a43407..49f5a25 100644 --- a/src/crypto_utils.erl +++ b/src/crypto_utils.erl @@ -40,7 +40,7 @@ % Read the AssociationToken {ok, AssociationToken} = mnesia_db_euicc:state_get(EidValue, associationToken), - %Format message to be signed + % Format message to be signed {ok, EuiccPackageSignedEnc} = 'SGP32Definitions':encode( 'EuiccPackageSigned', EuiccPackageSigned ), @@ -48,13 +48,13 @@ EuiccPackageSignedEnc, enc_association_token(AssociationToken) ]), - %Load private key from eIM certificate + % Load private key from eIM certificate {ok, EimKeyPath} = utils:get_env_priv_file_path(onomondo_eim, eim_key), {ok, EimKeyPem} = file:read_file(EimKeyPath), [EimKeyPemEntry] = public_key:pem_decode(EimKeyPem), EimKeyECPrivateKey = public_key:pem_entry_decode(EimKeyPemEntry), - %Sign message + % Sign message % We use SHA-256 as signature hash/digest, see also GSMA SGP.22, section 2.6.5 and % https://www.erlang.org/doc/apps/public_key/public_key#sign/4 der_to_plain(public_key:sign(MsgToBeSigned, sha256, EimKeyECPrivateKey)). -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ie4d6b4d44a015e97606f6ca6e01398bcf385f542 Gerrit-Change-Number: 43613 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: proxy: implement freq. hopping
by laforge 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43611?usp=email ) Change subject: proxy: implement freq. hopping ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43611?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I574b4d4dc337f771b044bd868088b29db9902de9 Gerrit-Change-Number: 43611 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 09:43:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: proxy: implement TRXC SETFORMAT
by laforge 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43610?usp=email ) Change subject: proxy: implement TRXC SETFORMAT ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43610?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9c453e7ba2a799a8c4ce037afef14037b596a29d Gerrit-Change-Number: 43610 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 09:42:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: proxy: implement TRXC SETSLOT
by laforge 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43609?usp=email ) Change subject: proxy: implement TRXC SETSLOT ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43609?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0f038fc453336e60d41641ec490907cddf259c3f Gerrit-Change-Number: 43609 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 09:42:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: proxy: make path_sim values configurable via VTY
by laforge 10 Sep '26

10 Sep '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43608?usp=email ) Change subject: proxy: make path_sim values configurable via VTY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I969e9df1ab394e631da3da9b3044fab1446db40e Gerrit-Change-Number: 43608 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Sep 2026 09:41:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026