Attention is currently required from: dexter.

fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/43637?usp=email )

Change subject: pySim-shell: use verify_adm command for commandline ADM auth ......................................................................

Patch Set 2:

(2 comments)

File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/43637/comment/367e52f1_dba9f557?usp=ema... : PS2, Line 1132: PIN_ADM1 also remove `1` here?

https://gerrit.osmocom.org/c/pysim/+/43637/comment/81b52dc4_61c570b2?usp=ema... : PS2, Line 1188: pin_adm_type = "" : if opts.pin_adm_type: : pin_adm_type = "--adm-type %s" % opts.pin_adm_type : if opts.pin_adm: : app.onecmd_plus_hooks("verify_adm %s %s" % : (opts.pin_adm, pin_adm_type), add_to_history = False) : elif opts.pin_adm_hex: : app.onecmd_plus_hooks("verify_adm %s --pin-is-hex %s" % : Why don't you just call `app.do_verify_adm()` directly here, passing it a `Namespace` object with the parameters? This way there's no need to compose an argv string at all.