Attention is currently required from: dexter.

View Change

2 comments:

• File pySim-shell.py:

  • Patch Set #2, Line 1132: PIN_ADM1

    also remove `1` here?

  • Patch Set #2, Line 1188:

        pin_adm_type = ""
        if opts.pin_adm_type:
            pin_adm_type = "--adm-type %s" % opts.pin_adm_type
        if opts.pin_adm:
            app.onecmd_plus_hooks("verify_adm %s %s" %
                                  (opts.pin_adm, pin_adm_type), add_to_history = False)
        elif opts.pin_adm_hex:
            app.onecmd_plus_hooks("verify_adm %s --pin-is-hex %s" %
      
    

    Why don't you just call `app.do_verify_adm()` directly here, passing it a `Namespace` object with the parameters? This way there's no need to compose an argv string at all.

To view, visit change 43637. To unsubscribe, or for help writing mail filters, visit settings.