September 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-trx[master]: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown
by fixeria 09 Sep '26

09 Sep '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email ) Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown ...................................................................... Patch Set 5: (4 comments) This change is ready for review. File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/f930184d_65a54552?usp… : PS2, Line 245: if (res > 0 && osmo_iofd_txqueue_len(iofd) > 0) > in io_uring backend, with asynchronous write operations, the fact that the userspace iofd txqueue is […] Acknowledged https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/09201978_8f638352?usp… : PS2, Line 269: talloc_steal(OTC_GLOBAL, iofd); > This patch is set Work-in-Progress and I never marked this thread as resolved, so no surprise here. Done File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/d4024963_e50ae451?usp… : PS4, Line 285: if (res > 0 && flush->wr_completed < flush->wr_offset) > FIXME: take into account variable wrap around (feel free to submit to osmo-pcap too ;). I've changed the logic to use a single counter instead. It gets incremented when `osmo_iofd_write_msgb()` is called, and decremented in `trx_ep_ctrl_write_cb()`/`trx_ep_ctrl_flush_write_cb()`. This way, and given the low volumes of TRXC traffic, a wrap around is unlikely to happen. https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/b185cf44_5564dbf2?usp… : PS4, Line 305: if (chan->ctrl_wr_completed >= chan->ctrl_wr_offset) { > FIXME: take into account variable wrap around (feel free to submit to osmo-pcap too ;). See my other comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56 Gerrit-Change-Number: 43112 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Sep 2026 16:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: refactor handling of GMM Detach Accept into own function
by pespin 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43600?usp=email ) Change subject: gprs_gmm: refactor handling of GMM Detach Accept into own function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iae846bbff0df04295a1579017117b3e84fa29157 Gerrit-Change-Number: 43600 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Sep 2026 16:01:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght
by pespin 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43599?usp=email ) Change subject: gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic9560108ee424634e15a5af1424ea44df491a474 Gerrit-Change-Number: 43599 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Sep 2026 16:01:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Service Request: add FIXME to check authentication
by pespin 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email ) Change subject: gprs_gmm: Service Request: add FIXME to check authentication ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icab4a223ec9a7987ede38772339f544312d950c2 Gerrit-Change-Number: 43598 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Sep 2026 16:01:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Attach Complete: add TODO for follow-on request
by pespin 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43597?usp=email ) Change subject: gprs_gmm: Attach Complete: add TODO for follow-on request ...................................................................... Patch Set 1: (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/43597/comment/cfc72014_cbf148c0?us… : PS1, Line 1421: /* TODO: check follow-on request */ follow-up -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I136ff28262b5caec139765881ba2efd64ab75dcc Gerrit-Change-Number: 43597 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Sep 2026 16:01:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: cosmetic
by pespin 09 Sep '26

09 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email ) Change subject: gprs_gmm: cosmetic ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/43596/comment/661c541b_67872db7?us… : PS1, Line 1775: * foreign TLLI to local TLLI */ You ctually forgot to move the "*" one char, but it's fine :) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8f3e647cb7dc3a1b59a560e0301e4d4db1f94f8b Gerrit-Change-Number: 43596 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Sep 2026 16:00:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request
by pespin 09 Sep '26

09 Sep '26

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email ) Change subject: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64 Gerrit-Change-Number: 43595 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 09 Sep 2026 16:00:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by lynxis lazus 09 Sep '26

09 Sep '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 16: (10 comments) File include/osmocom/sgsn/debug.h: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/eb74b128_1d55f32f?us… : PS16, Line 31: DSGS, /* only as placeholder, SGS isn't used by the SGSN */ > I don't get it, if it's not used why adding it here? because libvlr is using it. I improved the comment. File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a6505a92_bf14b998?us… : PS16, Line 199: Remove whitespace into cosmetic commit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/7852c6f0_d348ceb0?us… : PS16, Line 1443: TODO: cosmetic https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/2989f426_d43e78f6?us… : PS16, Line 742: /* FIXME: the VLR should check the auth and not here a second time! */ > what about all these FIXMEs? Because I noticed issues and problems with the code and might not fix it, because it gets more and more into a single commit. The rework is working much better than the current state. https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a34c85e6_755ea298?us… : PS16, Line 893: move into cosmetic commit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/6fbbe15e_00b099b8?us… : PS16, Line 1092: rc = gprs_gmm_parse_att_req(msg, &req); > Looks like addition of this parsing functin could be done easily in a preparation patch... Done https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/5f80e1b4_d3d0da84?us… : PS16, Line 1735: if (TLVP_PRES_LEN(&req.tlv, GSM48_IE_GMM_PDP_CTX_STATUS, 2)) { > This line could have been easily a separate preparation commit... Done https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/61975f75_76773983?us… : PS16, Line 2106: rc = gsm48_rx_gmm_det_accept(mmctx, msg); > The change to a function could have been done in a previous separate commit... not completely. but did so far as possible https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/b9267f65_d5c0bb8a?us… : PS16, Line 2327: static int vlr_tx_auth_req_cb(void *ref, struct vlr_auth_tuple *at, bool send_autn) > I think it makes sense to have all this VLR code in a separate file, there's already too much conten […] But the libvlr is very connected to the GMM layer. If we move it, I would like to have the discussion in a separate commit. https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/7e168356_449322d9?us… : PS16, Line 2577: int gmm_vlr_init(struct sgsn_instance *sgi) > This is not really related to a given GMM session, but global one, so it totally makes sense to move […] I would like to keep it as it is atm. I'm happy to review the refactoring of this. But it is related to libvlr and -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Sep 2026 15:54:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Attach Complete: add TODO for follow-on request
by lynxis lazus 09 Sep '26

09 Sep '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43597?usp=email ) Change subject: gprs_gmm: Attach Complete: add TODO for follow-on request ...................................................................... gprs_gmm: Attach Complete: add TODO for follow-on request Iu supports a follow-up request after an Attach Req. Currently unsupported. Change-Id: I136ff28262b5caec139765881ba2efd64ab75dcc --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/97/43597/1 diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index a324066..c9d5401 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1418,6 +1418,7 @@ LOGMMCTXP(LOGL_INFO, mmctx, "-> GMM ATTACH COMPLETE\n"); #ifdef BUILD_IU + /* TODO: check follow-on request */ if (mmctx->iu.ue_ctx) { sgsn_ranap_iu_tx_release(mmctx->iu.ue_ctx, NULL); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I136ff28262b5caec139765881ba2efd64ab75dcc Gerrit-Change-Number: 43597 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Service Request: add FIXME to check authentication
by lynxis lazus 09 Sep '26

09 Sep '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email ) Change subject: gprs_gmm: Service Request: add FIXME to check authentication ...................................................................... gprs_gmm: Service Request: add FIXME to check authentication Before parsing the PDP status of an Service Request, the Service Request has to be authenticated, otherwise it is possible to close a UEs PDP context by sending a fake Service Request. Change-Id: Icab4a223ec9a7987ede38772339f544312d950c2 --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/98/43598/1 diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index c9d5401..c8b2671 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1946,6 +1946,7 @@ /* TODO: Use tlvp_val16le when available */ uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)); + /* FIXME: this should be done after the connection has been authenticated! */ process_ms_ctx_status(ctx, pdp_status); /* 3GPP TS 24.008 § 4.7.13.4 Service request procedure not -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icab4a223ec9a7987ede38772339f544312d950c2 Gerrit-Change-Number: 43598 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026