September 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-trx[master]: build: probe UHD version with PKG_CHECK_EXISTS
by fixeria 09 Sep '26

09 Sep '26

Attention is currently required from: Andrei G. fixeria has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-trx/+/43580?usp=email ) Change subject: build: probe UHD version with PKG_CHECK_EXISTS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icbd8af94f258128ea75c0268e0a240dc423ff69e Gerrit-Change-Number: 43580 Gerrit-PatchSet: 1 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Sep 2026 11:49:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ggsn[master]: configure: search libresolv for res_9_init
by fixeria 09 Sep '26

09 Sep '26

Attention is currently required from: Andrei G. fixeria has posted comments on this change by Andrei G. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/43584?usp=email ) Change subject: configure: search libresolv for res_9_init ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/43584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I97787b051c712c5cfdb241cb7931a214d5a87630 Gerrit-Change-Number: 43584 Gerrit-PatchSet: 1 Gerrit-Owner: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Andrei G <andrei.gosman(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Sep 2026 11:46:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in simtrace2[master]: build: do distcheck for the host tools
by fixeria 09 Sep '26

09 Sep '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43530?usp=email ) Change subject: build: do distcheck for the host tools ...................................................................... build: do distcheck for the host tools This allows to detect missing files in the release tarballs. Change-Id: I2352d99a91079e027ca9827c10663212a3f6292f --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index deaeea5..fdb61ea 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -87,7 +87,7 @@ autoreconf --install --force ./configure --enable-sanitize --enable-werror $MAKE $PARALLEL_MAKE -#$MAKE distcheck || cat-testlogs.sh +$MAKE distcheck || cat-testlogs.sh make dist #if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43530?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I2352d99a91079e027ca9827c10663212a3f6292f Gerrit-Change-Number: 43530 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in simtrace2[master]: build: include version.h.tpl in the release tarballs
by fixeria 09 Sep '26

09 Sep '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43529?usp=email ) Change subject: build: include version.h.tpl in the release tarballs ...................................................................... build: include version.h.tpl in the release tarballs simtrace2-host-0.9.1.tar.bz2 does not compile because this file is missing. Add it to EXTRA_DIST. make all-recursive make[1]: Entering directory '/build/simtrace2/src/simtrace2-0.9.1' Making all in include make[2]: Entering directory '/build/simtrace2/src/simtrace2-0.9.1/include' make[2]: *** No rule to make target 'osmocom/simtrace2/version.h.tpl', needed by 'osmocom/simtrace2/version.h'. Stop. make[2]: Leaving directory '/build/simtrace2/src/simtrace2-0.9.1/include' make[1]: *** [Makefile:452: all-recursive] Error 1 make[1]: Leaving directory '/build/simtrace2/src/simtrace2-0.9.1' make: *** [Makefile:376: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting... Change-Id: I8c50c8df012b2b7eb5ee6046f14ccc4d2c07194e Fixes: d0ad985e ("Generate a version.h file") --- M host/include/Makefile.am 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/host/include/Makefile.am b/host/include/Makefile.am index 3a9722c..eba4978 100644 --- a/host/include/Makefile.am +++ b/host/include/Makefile.am @@ -16,3 +16,5 @@ osmocom/simtrace2/gsmtap.h \ osmocom/simtrace2/version.h \ $(NULL) + +EXTRA_DIST = osmocom/simtrace2/version.h.tpl -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I8c50c8df012b2b7eb5ee6046f14ccc4d2c07194e Gerrit-Change-Number: 43529 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[L] Change in pysim[master]: sms/smpp-ota-tool: reassemble multi part response SMS
by dexter 09 Sep '26

09 Sep '26

Attention is currently required from: Hoernchen. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43544?usp=email ) Change subject: sms/smpp-ota-tool: reassemble multi part response SMS ...................................................................... Patch Set 2: Code-Review+1 (7 comments) Patchset: PS2: I think this patch should be ok, also there are comprehenive testcases which show that it works. But as far as I can see it is possible to send incomplete message sets, which then pile up in the ConcatenatedSmsReassembler. This may be a problem for long running instances. This is something you should check back. File pySim/sms.py: https://gerrit.osmocom.org/c/pysim/+/43544/comment/e78dd65e_4450d2b0?usp=em… : PS2, Line 99: # TS 23.040 9.2.3.24.1/.8 IEI of the concat IE You are referencing to 9.2.3.24.1 and 9.2.3.24.8, this is 100% correct, but It sent me a bit off track when I wanted to lookup the IEI hex values. Those are in the table at 9.2.3.24 I would recommend to put the reference like so: ``` # IEI: Concatenated short messages, 8-bit reference number # (see 3GPP TS 23.040 section 9.2.3.24 and section 9.2.3.24.1) CONCAT_8BIT = 0x00 # IEI: Concatenated short message, 16-bit reference number # (see 3GPP TS 23.040 section 9.2.3.24 and section 9.2.3.24.8) CONCAT_16BIT = 0x08 ``` https://gerrit.osmocom.org/c/pysim/+/43544/comment/73fd2e5d_07688ec7?usp=em… : PS2, Line 132: # TS 23.040 9.2.3.24.1.8 , total zero or seqno zero / > total: Did you mean TS 23.040 9.2.3.24.1/8 ? https://gerrit.osmocom.org/c/pysim/+/43544/comment/0a8acfcc_f6caee7d?usp=em… : PS2, Line 153: if len(s['parts']) < total: I wonder what happens when someone keeps sending incomplete sets. For example a set of three messages is expected, but only two arrive. Then the incomplete set is stuck forever, creating a memory leak. I don't know if this is an issue or not, but as far as I understand, the API user creates an ConcatenatedSmsReassembler object once and then passes all incoming messages through it. The object exists as long as the process runs. If this is a problem I would suggest to put a timestamp when the set is created. When the .add method is called, the sets are checked for expired timestamps. This way incomplete sets can never pile up over time. File tests/unittests/test_sms.py: https://gerrit.osmocom.org/c/pysim/+/43544/comment/ab35adfa_9b02834f?usp=em… : PS2, Line 109: """TS 23.040 9.2.3.24 reassembly of multi-part SMS. I would recommend to reference the spac as "3GPP TS 23.040" and not only "TS ..." (sure, you could look at the dots and the number of digits, but I think its better to be verbose) https://gerrit.osmocom.org/c/pysim/+/43544/comment/6c369a12_667cd48c?usp=em… : PS2, Line 113: form before decoding.""" I would rephrase it a bit: An OTA response that exceeds a single SHORT MESSAGE is delivered in several parts using the SEND SHORT MESSAGE proactive command. The receiver must recombine the individual parts into a single part before decoding. https://gerrit.osmocom.org/c/pysim/+/43544/comment/d50a58dc_0767571a?usp=em… : PS2, Line 137: self.assertEqual(b2h(built), '0700030102017100') maybe move test_ground_truth_udh above test_single_part_passthrough? It seems to be just a precursor that verifies that the _concat methods work correctly. How about a similar test to test _concat16 as well? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43544?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8c81097e607e0d055c4f031bbcc8a74d5c24a0e7 Gerrit-Change-Number: 43544 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Sep 2026 10:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in onomondo-eim[master]: es9p_client: use SGP.32 specific AuthenticateServerResponse type
by laforge 09 Sep '26

09 Sep '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43429?usp=email ) Change subject: es9p_client: use SGP.32 specific AuthenticateServerResponse type ...................................................................... es9p_client: use SGP.32 specific AuthenticateServerResponse type SGP.32 re-defines the AuthenticateServerResponse type. This is in particular due to the SGP.32 specific EUICCInfo2 type, which is contained in this struct. This means we have to use the re-defined type for encoding. Since the RSPDefinitions have "EXTENSIBILITY IMPLIED", the extra fields added to EUICCInfo2 are ignored by the SM-DP+. Change-Id: Ia550804d1d73f9704aa3135819926c7615379d1a Related: SYS#8100 --- M src/es9p_client.erl 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/es9p_client.erl b/src/es9p_client.erl index ac89456..8a901e8 100644 --- a/src/es9p_client.erl +++ b/src/es9p_client.erl @@ -224,9 +224,11 @@ request_json({authenticateClientRequest, AuthClientReq}, BaseUrl) -> Json = #{ <<"transactionId">> => utils:binary_to_hex(maps:get(transactionId, AuthClientReq)), + % The AuthenticateServerResponse type has been re-defined by SGP.32, in particular to accommodate for the SGP.32 + % specific EUICCInfo2 type (see also SGP.32, section 5.6.1). <<"authenticateServerResponse">> => enc_asn1_b64( - 'RSPDefinitions', - 'AuthenticateServerResponse', + 'SGP32Definitions', + 'SGP32-AuthenticateServerResponse', maps:get(authenticateServerResponse, AuthClientReq) ) }, -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ia550804d1d73f9704aa3135819926c7615379d1a Gerrit-Change-Number: 43429 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in onomondo-eim[master]: es9p_client: make asn.1 encoder/decoder functions more flexible
by laforge 09 Sep '26

09 Sep '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43428?usp=email ) Change subject: es9p_client: make asn.1 encoder/decoder functions more flexible ...................................................................... es9p_client: make asn.1 encoder/decoder functions more flexible The encoder and decoder functions we currently use have the spec name hardcoded in the function body. Let's change the functions so that we have the spec name as a parameter for more flexibility Related: SYS#8100 Change-Id: Idfb280d3863998dd0387c65c478d9c765eadf106 --- M src/es9p_client.erl 1 file changed, 33 insertions(+), 22 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/es9p_client.erl b/src/es9p_client.erl index 9bf3856..ac89456 100644 --- a/src/es9p_client.erl +++ b/src/es9p_client.erl @@ -157,17 +157,14 @@ {ok, 503, ""} end. -% encode RSP ASN.1 data of given type + base64-encode it -rsp_enc_asn1_b64(TypeName, Data) -> - {ok, Bin} = 'RSPDefinitions':encode(TypeName, Data), +% encode ASN.1 data of given type + base64-encode it +enc_asn1_b64(SpecName, TypeName, Data) -> + {ok, Bin} = SpecName:encode(TypeName, Data), base64:encode(Bin). -% base64-decode and RSP ASN.1 decode data of given type -rsp_dec_b64_asn1(TypeName, Data) -> - {ok, Dec} = 'RSPDefinitions':decode(TypeName, base64:decode(Data)), - Dec. -pki_dec_b64_asn1(TypeName, Data) -> - {ok, Dec} = 'PKIX1Explicit88':decode(TypeName, base64:decode(Data)), +% base64-decode and ASN.1 decode data of given type +dec_asn1_b64(SpecName, TypeName, Data) -> + {ok, Dec} = SpecName:decode(TypeName, base64:decode(Data)), Dec. % convert from RemoteProfileProvisioningRequest to weird ASN.1-base64-in-JSON @@ -182,7 +179,9 @@ Json = #{ <<"euiccChallenge">> => base64:encode(maps:get(euiccChallenge, InitAuthReq)), <<"smdpAddress">> => maps:get(smdpAddress, InitAuthReq), - <<"euiccInfo1">> => rsp_enc_asn1_b64('EUICCInfo1', maps:get(euiccInfo1, InitAuthReq)) + <<"euiccInfo1">> => enc_asn1_b64( + 'RSPDefinitions', 'EUICCInfo1', maps:get(euiccInfo1, InitAuthReq) + ) }, {ok, _HtppStatus, JsonResp} = make_req_json(BaseUrl, "initiateAuthentication", Json), @@ -195,14 +194,17 @@ } -> R = #{ transactionId => utils:hex_to_binary(maps:get(<<"transactionId">>, JsonResp)), - serverSigned1 => rsp_dec_b64_asn1( - 'ServerSigned1', maps:get(<<"serverSigned1">>, JsonResp) + serverSigned1 => dec_asn1_b64( + 'RSPDefinitions', + 'ServerSigned1', + maps:get(<<"serverSigned1">>, JsonResp) ), serverSignature1 => base64:decode(maps:get(<<"serverSignature1">>, JsonResp)), euiccCiPKIdToBeUsed => base64:decode( maps:get(<<"euiccCiPKIdToBeUsed">>, JsonResp) ), - serverCertificate => pki_dec_b64_asn1( + serverCertificate => dec_asn1_b64( + 'PKIX1Explicit88', 'Certificate', maps:get( <<"serverCertificate">>, @@ -222,7 +224,8 @@ request_json({authenticateClientRequest, AuthClientReq}, BaseUrl) -> Json = #{ <<"transactionId">> => utils:binary_to_hex(maps:get(transactionId, AuthClientReq)), - <<"authenticateServerResponse">> => rsp_enc_asn1_b64( + <<"authenticateServerResponse">> => enc_asn1_b64( + 'RSPDefinitions', 'AuthenticateServerResponse', maps:get(authenticateServerResponse, AuthClientReq) ) @@ -237,18 +240,22 @@ } -> R = #{ transactionId => utils:hex_to_binary(maps:get(<<"transactionId">>, JsonResp)), - profileMetaData => rsp_dec_b64_asn1( + profileMetaData => dec_asn1_b64( + 'RSPDefinitions', 'StoreMetadataRequest', maps:get( <<"profileMetadata">>, JsonResp ) ), - smdpSigned2 => rsp_dec_b64_asn1( - 'SmdpSigned2', maps:get(<<"smdpSigned2">>, JsonResp) + smdpSigned2 => dec_asn1_b64( + 'RSPDefinitions', + 'SmdpSigned2', + maps:get(<<"smdpSigned2">>, JsonResp) ), smdpSignature2 => base64:decode(maps:get(<<"smdpSignature2">>, JsonResp)), - smdpCertificate => pki_dec_b64_asn1( + smdpCertificate => dec_asn1_b64( + 'PKIX1Explicit88', 'Certificate', maps:get(<<"smdpCertificate">>, JsonResp) ) @@ -263,7 +270,8 @@ request_json({getBoundProfilePackageRequest, GetBppReq}, BaseUrl) -> Json = #{ <<"transactionId">> => utils:binary_to_hex(maps:get(transactionId, GetBppReq)), - <<"prepareDownloadResponse">> => rsp_enc_asn1_b64( + <<"prepareDownloadResponse">> => enc_asn1_b64( + 'RSPDefinitions', 'PrepareDownloadResponse', maps:get(prepareDownloadResponse, GetBppReq) ) @@ -278,7 +286,8 @@ } -> R = #{ transactionId => utils:hex_to_binary(maps:get(<<"transactionId">>, JsonResp)), - boundProfilePackage => rsp_dec_b64_asn1( + boundProfilePackage => dec_asn1_b64( + 'RSPDefinitions', 'BoundProfilePackage', maps:get(<<"boundProfilePackage">>, JsonResp) ) @@ -293,7 +302,8 @@ request_json({cancelSessionRequestEs9, CancelSessReq}, BaseUrl) -> Json = #{ <<"transactionId">> => utils:binary_to_hex(maps:get(transactionId, CancelSessReq)), - <<"cancelSessionResponse">> => rsp_enc_asn1_b64( + <<"cancelSessionResponse">> => enc_asn1_b64( + 'RSPDefinitions', 'CancelSessionResponse', maps:get(cancelSessionResponse, CancelSessReq) ) @@ -316,7 +326,8 @@ % GSMA SGP.22, section 6.5.2.9 and section 6.6.2.4 request_json({handleNotification, HandleNotifReq}, BaseUrl) -> Json = #{ - <<"pendingNotification">> => rsp_enc_asn1_b64( + <<"pendingNotification">> => enc_asn1_b64( + 'RSPDefinitions', 'PendingNotification', maps:get(pendingNotification, HandleNotifReq) ) -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Idfb280d3863998dd0387c65c478d9c765eadf106 Gerrit-Change-Number: 43428 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in onomondo-eim[master]: esipa_asn1_handler: set ecallIndication and fallbackAllowed
by laforge 09 Sep '26

09 Sep '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43430?usp=email ) Change subject: esipa_asn1_handler: set ecallIndication and fallbackAllowed ...................................................................... esipa_asn1_handler: set ecallIndication and fallbackAllowed SGP.32 adds two new fields (ecallIndication and fallbackAllowed) to the StoreMetadataRequest. Those fields have to be added to the StoreMetadataRequest before it is sent to the IPAd via the AuthenticateClientResponseEsipa. Change-Id: I4b7673007018d32d062e238d811f655d332f7195 Related: SYS#8100 --- M priv/rest_api_resource_schema.json M src/esipa_asn1_handler.erl 2 files changed, 26 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/priv/rest_api_resource_schema.json b/priv/rest_api_resource_schema.json index 4ddbb8e..69b0060 100644 --- a/priv/rest_api_resource_schema.json +++ b/priv/rest_api_resource_schema.json @@ -21,6 +21,14 @@ "activationCode": { "description": "see GSMA SGP.22, section 4.1", "type": "string" + }, + "ecallIndication": { + "description": "see GSMA SGP.32, section 4.4", + "type": "boolean" + }, + "fallbackAllowed": { + "description": "see GSMA SGP.32, section 4.4", + "type": "boolean" } }, "required": [ diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl index df208cf..c006a7a 100644 --- a/src/esipa_asn1_handler.erl +++ b/src/esipa_asn1_handler.erl @@ -58,7 +58,7 @@ %GSMA SGP.32, section 6.3.2.2 handle_asn1(Pid, {authenticateClientRequestEsipa, EsipaReq}) -> TransactionId = maps:get(transactionId, EsipaReq), - {EidValue, _, WorkState} = mnesia_db_work:pickup(Pid, TransactionId), + {EidValue, Order, WorkState} = mnesia_db_work:pickup(Pid, TransactionId), BaseUrl = maps:get(smdpAddress, WorkState), % setup ES9+ request message @@ -91,7 +91,21 @@ EsipaResp = case Es9Resp of {authenticateClientOk, AuthClntRespEs9} -> - {authenticateClientOkDPEsipa, AuthClntRespEs9}; + % Populate ecallIndication and fallbackAllowed of SGP32-StoreMetadataRequest + {[{<<"download">>, {Download}}]} = Order, + EcallIndication = proplists:get_value(<<"ecallIndication">>, Download, false), + FallbackAllowed = proplists:get_value(<<"fallbackAllowed">>, Download, false), + StoreMetadataRequest = maps:merge( + maps:get(profileMetaData, AuthClntRespEs9), + #{ + ecallIndication => EcallIndication, + fallbackAllowed => FallbackAllowed + } + ), + AuthenticateClientOkDPEsipa = AuthClntRespEs9#{ + profileMetaData => StoreMetadataRequest + }, + {authenticateClientOkDPEsipa, AuthenticateClientOkDPEsipa}; {authenticateClientError, AuthClntErr} -> OutcomeEs9p = [{[{authenticateClientError, AuthClntErr}]}], ok = mnesia_db_work:finish(Pid, OutcomeEs9p, EsipaReq), @@ -277,7 +291,8 @@ EimTransactionId = rand:bytes(16), mnesia_db_work:bind(Pid, EimTransactionId), mnesia_db_work:update(Pid, #{}), - {[{<<"download">>, {[{<<"activationCode">>, ActivationCode}]}}]} = Order, + {[{<<"download">>, {Download}}]} = Order, + ActivationCode = proplists:get_value(<<"activationCode">>, Download), {profileDownloadTriggerRequest, #{ profileDownloadData => {activationCode, ActivationCode}, eimTransactionId => EimTransactionId -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I4b7673007018d32d062e238d811f655d332f7195 Gerrit-Change-Number: 43430 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in onomondo-eim[master]: esipa_asn_handler: add TODO about missing download options
by laforge 09 Sep '26

09 Sep '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43449?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: esipa_asn_handler: add TODO about missing download options ...................................................................... esipa_asn_handler: add TODO about missing download options SGP.32 also defines other download trigger options next to the commonly used activationCode method. Let's add a related TODO to the code. Related: SYS#8100 Change-Id: I5e72416284027731627c264fa81c62a4a9a0d407 --- M src/esipa_asn1_handler.erl 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl index c006a7a..f1be50a 100644 --- a/src/esipa_asn1_handler.erl +++ b/src/esipa_asn1_handler.erl @@ -292,6 +292,9 @@ mnesia_db_work:bind(Pid, EimTransactionId), mnesia_db_work:update(Pid, #{}), {[{<<"download">>, {Download}}]} = Order, + % TODO: Add missing download options: This eIM currently only allows to trigger a profile download using + % an activationCode (option a) It still lacks download triggers via SM-DS (option b) and downloads from + % the default SM-DP+ (option c). See also GSMA SGP.32, section 3.2.3.2 ActivationCode = proplists:get_value(<<"activationCode">>, Download), {profileDownloadTriggerRequest, #{ profileDownloadData => {activationCode, ActivationCode}, -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43449?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I5e72416284027731627c264fa81c62a4a9a0d407 Gerrit-Change-Number: 43449 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in onomondo-eim[master]: crypto_utils: extend TODO for better understanding
by laforge 09 Sep '26

09 Sep '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43502?usp=email ) Change subject: crypto_utils: extend TODO for better understanding ...................................................................... crypto_utils: extend TODO for better understanding Related: SYS#8100 Change-Id: I411a3b4216b3c0d707d571b7a0c178e001931139 --- M src/crypto_utils.erl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/crypto_utils.erl b/src/crypto_utils.erl index cb50415..4a43407 100644 --- a/src/crypto_utils.erl +++ b/src/crypto_utils.erl @@ -31,7 +31,7 @@ %Encode the association token as BER TLV IE enc_association_token(AssociationToken) -> - %TODO: replace this with a proper ASN.1 encoding function. + %TODO: Define an ASN.1 type for the AssociationToken and use it to get rid of this half-baked encoder function. AssociationTokenBinary = utils:integer_to_bytes(AssociationToken), AssociationTokenLength = utils:integer_to_bytes(byte_size(AssociationTokenBinary)), utils:join_binary_list([<<132>>, AssociationTokenLength, AssociationTokenBinary]). -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I411a3b4216b3c0d707d571b7a0c178e001931139 Gerrit-Change-Number: 43502 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026