Attention is currently required from: Hoernchen, fixeria, tnt.

Hello Hoernchen, Jenkins Builder, laforge, pespin, tnt,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-trx/+/43161?usp=email

to look at the new patch set (#8).

The following approvals got outdated and were removed: Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.

Change subject: Transceiver52M: use lround() for TRXD toa/ci rounding ......................................................................

Transceiver52M: use lround() for TRXD toa/ci rounding

trxd_fill_v0_specific() and trxd_fill_v1_specific() rounded bi->toa and bi->ci to the nearest integer using the "+ 0.5, then truncate" idiom. That only rounds correctly for non-negative inputs: for negative values (toa can be negative for an early burst, ci can be negative under poor C/I conditions) it biases towards zero instead of rounding to nearest, e.g. -1.3 + 0.5 = -0.8, truncated to 0 instead of the correct -1.

Use lround() instead, which rounds-half-away-from-zero correctly for both signs.

Change-Id: I0c52f1b91070e4750a8a0ffbccb222454e694c3b Related: OS#5283 --- M Transceiver52M/proto_trxd.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/61/43161/8