August 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: xua_msg: return M3UA_ERR in xua_dialect_check_all_ies()
by osmith 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email ) Change subject: xua_msg: return M3UA_ERR in xua_dialect_check_all_ies() ...................................................................... Patch Set 2: -Code-Review (1 comment) File src/xua_msg.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389/comment/54c527f8_4b59e… : PS2, Line 549: return 0; This is unexpected to me. I would expect: * Ensure beforehand that msg_class is in the proper range to be used with dialect->class and log an error + reject the message if not. * OSMO_ASSERT(xmc) here. Otherwise I guess a message could be crafted to bypass xua_dialect_check_all_ies by setting msg_class to a value that results in !xmc being true. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9df00f9b10f7341171912cf32e8ba57344ae8b4a Gerrit-Change-Number: 43389 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 07:29:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: xua_rkm: Validate IE lengths of RKM inner messages
by osmith 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43394?usp=email ) Change subject: xua_rkm: Validate IE lengths of RKM inner messages ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibe7e446b1a537c0c09f8049add3460e37cdd58e8 Gerrit-Change-Number: 43394 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 07:18:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_msg: return M3UA_ERR in xua_dialect_check_all_ies()
by osmith 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email ) Change subject: xua_msg: return M3UA_ERR in xua_dialect_check_all_ies() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9df00f9b10f7341171912cf32e8ba57344ae8b4a Gerrit-Change-Number: 43389 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 07:11:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: xua_msg: Constify input xua_msg param
by osmith 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43388?usp=email ) Change subject: xua_msg: Constify input xua_msg param ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3641f9b2ab487ac32faa1872831ca249ce41ffb8 Gerrit-Change-Number: 43388 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 07:06:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: m3ua: Validate IE lengths of ASPTM & ASPSM messages
by osmith 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43387?usp=email ) Change subject: m3ua: Validate IE lengths of ASPTM & ASPSM messages ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43387/comment/b2daea73_1edc5… : PS2, Line 342: /* M3UA_ASPSM_BEAT_ACK has not IEs */ ```suggestion /* M3UA_ASPSM_BEAT_ACK has no IEs */ ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I27406eac5b82c1e6702961bb3482b0bf7fe4ff15 Gerrit-Change-Number: 43387 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 07:05:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: xua: Validate IE lengths of incoming messages
by osmith 26 Aug '26

26 Aug '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email ) Change subject: xua: Validate IE lengths of incoming messages ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9b1ae0dbc324123790942c9e6068f6822e3bb957 Gerrit-Change-Number: 43386 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 07:03:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach
by lynxis lazus 25 Aug '26

25 Aug '26

Attention is currently required from: fixeria, osmith, pespin. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email ) Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach ...................................................................... Patch Set 4: (2 comments) Patchset: PS1: > @lynxis@fe80. […] Please take a look at the gerrit branch lynxis/gn_2g_to_4g_v5 (52 files changed, 9075 insertions(+), 2651 deletions(-)) Patchset: PS4: Please see the branch lynxis/gn_2g_to_4g_v5 (52 files changed, 9075 insertions(+), 2651 deletions(-)) I would like to postpone this commit until the branch has been merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Gerrit-Change-Number: 42594 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 22:48:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: build: drop unused libosmo-abis dependency
by pespin 25 Aug '26

25 Aug '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43391?usp=email ) Change subject: build: drop unused libosmo-abis dependency ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I5548e8e952cd57ea4268067e3f3e4d2f731911c1 Gerrit-Change-Number: 43391 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 20:59:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: sua: Do SUA specific SNM msg validation
by pespin 25 Aug '26

25 Aug '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43399?usp=email ) Change subject: sua: Do SUA specific SNM msg validation ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: TODO: I still need to add: * SUA ASP ACT has extra: TID Label Optional DRN Label Optional * Check differences in SUA vs M3UA on "[SUA_MSGC_RKM] = &m3ua_msg_class_rkm," -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iba32835035867175fa83f3c1e0639918b37432b5 Gerrit-Change-Number: 43399 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 17:19:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: sua: Do SUA specific SNM msg validation
by pespin 25 Aug '26

25 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43399?usp=email ) Change subject: sua: Do SUA specific SNM msg validation ...................................................................... sua: Do SUA specific SNM msg validation SUA SNM messages contain IEs different than those of related M3UA SNM messages. Until now it was fine because we only checked for mandatory IEs, but it's not the case anymore. Change-Id: Iba32835035867175fa83f3c1e0639918b37432b5 --- M src/sua.c 1 file changed, 80 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/99/43399/1 diff --git a/src/sua.c b/src/sua.c index fdd2275..58dc7aa 100644 --- a/src/sua.c +++ b/src/sua.c @@ -188,6 +188,12 @@ #define SUA_MSG_PART_CLASS_DATA(mandatory) \ XUA_MSG_PART_CLASS(SUA_IEI_DATA, (mandatory), 0, UINT16_MAX) +#define SUA_MSG_PART_CLASS_USER_CAUSE(mandatory) \ + XUA_MSG_PART_CLASS_U32(SUA_IEI_USER_CAUSE, (mandatory)) + +#define SUA_MSG_PART_CLASS_SMI(mandatory) \ + XUA_MSG_PART_CLASS_U32(SUA_IEI_SMI, (mandatory)) + #define SUA_MSG_PART_CLASS_IMPORTANCE(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_IMPORTANCE, (mandatory)) @@ -200,6 +206,75 @@ #define SUA_MSG_PART_CLASS_SEGMENTATION(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_SEGMENTATION, (mandatory)) +#define SUA_MSG_PART_CLASS_CONG_LEVEL(mandatory) \ + XUA_MSG_PART_CLASS_U32(SUA_IEI_CONG_LEVEL, (mandatory)) + +#define SUA_MSG_PART_CLASS_SSN(mandatory) \ + XUA_MSG_PART_CLASS_U32(SUA_IEI_SSN, (mandatory)) + +/* SNM */ +static const struct xua_msg_part_class duna_ies[] = { + SUA_MSG_PART_CLASS_ROUTE_CTX(false), + SUA_MSG_PART_CLASS_AFFECTED_PC(true), + SUA_MSG_PART_CLASS_SSN(false), + SUA_MSG_PART_CLASS_SMI(false), + SUA_MSG_PART_CLASS_INFO_STRING(false), + XUA_MSG_PART_CLASS_EOF +}; +static const struct xua_msg_part_class dava_ies[] = { + SUA_MSG_PART_CLASS_ROUTE_CTX(false), + SUA_MSG_PART_CLASS_AFFECTED_PC(true), + SUA_MSG_PART_CLASS_SSN(false), + SUA_MSG_PART_CLASS_SMI(false), + SUA_MSG_PART_CLASS_INFO_STRING(false), + XUA_MSG_PART_CLASS_EOF +}; +static const struct xua_msg_part_class daud_ies[] = { + SUA_MSG_PART_CLASS_ROUTE_CTX(false), + SUA_MSG_PART_CLASS_AFFECTED_PC(true), + SUA_MSG_PART_CLASS_SSN(false), + SUA_MSG_PART_CLASS_USER_CAUSE(false), + SUA_MSG_PART_CLASS_INFO_STRING(false), + XUA_MSG_PART_CLASS_EOF +}; +static const struct xua_msg_part_class scon_ies[] = { + SUA_MSG_PART_CLASS_ROUTE_CTX(false), + SUA_MSG_PART_CLASS_AFFECTED_PC(true), + SUA_MSG_PART_CLASS_SSN(false), + SUA_MSG_PART_CLASS_CONG_LEVEL(true), + SUA_MSG_PART_CLASS_SMI(false), + SUA_MSG_PART_CLASS_INFO_STRING(false), + XUA_MSG_PART_CLASS_EOF +}; +static const struct xua_msg_part_class dupu_ies[] = { + SUA_MSG_PART_CLASS_ROUTE_CTX(false), + SUA_MSG_PART_CLASS_AFFECTED_PC(true), + SUA_MSG_PART_CLASS_USER_CAUSE(true), + SUA_MSG_PART_CLASS_INFO_STRING(false), + XUA_MSG_PART_CLASS_EOF +}; +static const struct xua_msg_part_class drst_ies[] = { + SUA_MSG_PART_CLASS_ROUTE_CTX(false), + SUA_MSG_PART_CLASS_AFFECTED_PC(true), + SUA_MSG_PART_CLASS_SSN(false), + SUA_MSG_PART_CLASS_SMI(false), + SUA_MSG_PART_CLASS_INFO_STRING(false), + XUA_MSG_PART_CLASS_EOF +}; +const struct xua_msg_class sua_msg_class_snm = { + .name = "SNM", + /* message types are same as m3ua: */ + .msgt_names = m3ua_snm_msgt_names, + .ies = { + IES(SUA_SNM_DUNA, duna_ies), + IES(SUA_SNM_DAVA, dava_ies), + IES(SUA_SNM_DAUD, daud_ies), + IES(SUA_SNM_SCON, scon_ies), + IES(SUA_SNM_DUPU, dupu_ies), + IES(SUA_SNM_DRST, drst_ies), + }, +}; + static const struct xua_msg_part_class cldt_ies[] = { SUA_MSG_PART_CLASS_ROUTE_CTX(true), SUA_MSG_PART_CLASS_PROTO_CLASS(true), @@ -232,7 +307,7 @@ { SUA_CL_CLDR, "CLDR" }, { 0, NULL } }; -static const struct xua_msg_class msg_class_cl = { +static const struct xua_msg_class sua_msg_class_cl = { .name = "CL", .msgt_names = sua_cl_msgt_names, .iei_names = sua_iei_names, @@ -357,7 +432,7 @@ { SUA_CO_COIT, "COIT" }, { 0, NULL } }; -static const struct xua_msg_class msg_class_co = { +static const struct xua_msg_class sua_msg_class_co = { .name = "CO", .msgt_names = sua_co_msgt_names, .iei_names = sua_iei_names, @@ -383,11 +458,11 @@ .log_subsys = DLSUA, .class = { [SUA_MSGC_MGMT] = &m3ua_msg_class_mgmt, - [SUA_MSGC_SNM] = &m3ua_msg_class_snm, + [SUA_MSGC_SNM] = &sua_msg_class_snm, [SUA_MSGC_ASPSM] = &m3ua_msg_class_aspsm, [SUA_MSGC_ASPTM] = &m3ua_msg_class_asptm, - [SUA_MSGC_CL] = &msg_class_cl, - [SUA_MSGC_CO] = &msg_class_co, + [SUA_MSGC_CL] = &sua_msg_class_cl, + [SUA_MSGC_CO] = &sua_msg_class_co, [SUA_MSGC_RKM] = &m3ua_msg_class_rkm, }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iba32835035867175fa83f3c1e0639918b37432b5 Gerrit-Change-Number: 43399 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026