August 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-iuh[master]: ranap: Introduce new APIs to encode rab_ass for gtp and rtp
by lynxis lazus 18 Aug '26

18 Aug '26

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email ) Change subject: ranap: Introduce new APIs to encode rab_ass for gtp and rtp ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3a8800afd03b94349c8acec778ab7003819e80af Gerrit-Change-Number: 43258 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:49:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in onomondo-ipa[master]: V1.2: Add function ES10b.GetConnectivityParameters
by jolly 18 Aug '26

18 Aug '26

Attention is currently required from: dexter, laforge. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email ) Change subject: V1.2: Add function ES10b.GetConnectivityParameters ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > btw, do we somewhere specify which exact asn1c version / repo / commit we're using to generate the C […] Refer to Change-Id: I1ac4cf8980af501bb119208213242468ee4f3c06 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:48:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-iuh[master]: ranap_msg_factory: Fix API documentation regarding ip param endianness
by lynxis lazus 18 Aug '26

18 Aug '26

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email ) Change subject: ranap_msg_factory: Fix API documentation regarding ip param endianness ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I0a909019875714d35c27aa38dd5520a82d46e8f2 Gerrit-Change-Number: 43257 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:47:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-iuh[master]: ranap_msg_factory: Fix API documentation regarding ip param endianness
by pespin 18 Aug '26

18 Aug '26

Attention is currently required from: laforge, lynxis lazus. Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by lynxis lazus Change subject: ranap_msg_factory: Fix API documentation regarding ip param endianness ...................................................................... ranap_msg_factory: Fix API documentation regarding ip param endianness The param is clearly being expected as host-byte order because it converts it when storing it into the sockaddr, which contains a net-byte order. Both users of these APIs, ie. osmo-sgsn and osmo-msc, actually end up passing a host-byte order addr despite wrongly using htonl() instead of ntohl(), but taking advantage of the fact that both functions do the same: * osmo-sgsn: sgsn_pdp_ctx_iu_rab_activate() does "htonl(pdp->lib->gsnru.v)", where "v" is stored as network-byte order. * osmo-msc: ran_iu_make_rab_assignment() does "osmo_htonl(inet_addr(ac->cn_rtp->ip))", where clearly inet_addr returns a network-byte order. Change-Id: I0a909019875714d35c27aa38dd5520a82d46e8f2 --- M src/ranap_msg_factory.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/57/43257/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I0a909019875714d35c27aa38dd5520a82d46e8f2 Gerrit-Change-Number: 43257 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-iuh[master]: ranap: Introduce new APIs to encode rab_ass for gtp and rtp
by pespin 18 Aug '26

18 Aug '26

Attention is currently required from: laforge, lynxis lazus. Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by lynxis lazus, Verified+1 by Jenkins Builder Change subject: ranap: Introduce new APIs to encode rab_ass for gtp and rtp ...................................................................... ranap: Introduce new APIs to encode rab_ass for gtp and rtp This allows passing IPv6 addresses, which are already supported in internal functions being called. While at it, also check that sockaddr encoding succeeds and otherwise return an error. Related: OS#7066 Change-Id: I3a8800afd03b94349c8acec778ab7003819e80af --- M TODO-RELEASE M include/osmocom/ranap/ranap_msg_factory.h M src/ranap_msg_factory.c M tests/test-ranap.c 4 files changed, 96 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/58/43258/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3a8800afd03b94349c8acec778ab7003819e80af Gerrit-Change-Number: 43258 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-iuh[master]: ranap: Introduce new APIs to encode rab_ass for gtp and rtp
by pespin 18 Aug '26

18 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email ) Change subject: ranap: Introduce new APIs to encode rab_ass for gtp and rtp ...................................................................... Patch Set 1: (3 comments) File include/osmocom/ranap/ranap_msg_factory.h: https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/174d22e8_6748b511?usp… : PS1, Line 47: struct msgb *ranap_new_msg_rab_assign_voice2(uint8_t rab_id, const struct osmo_sockaddr *rtp_addr, > the indention of the args looks weird, but fine. Done https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/c1370eed_0e7f576d?usp… : PS1, Line 56: uint32_t gtp_tei, > the indention of the args looks weird, but fine. Done File src/ranap_msg_factory.c: https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/af9ca08c_0e732f72?usp… : PS1, Line 975: .sin_port = htons(2152), > You set a port here, which the old code doesn't. […] I know it's not necessary, it doesn't harm either though. I can leave it as a 0. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3a8800afd03b94349c8acec778ab7003819e80af Gerrit-Change-Number: 43258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-iuh[master]: ranap: Introduce new APIs to encode rab_ass for gtp and rtp
by lynxis lazus 18 Aug '26

18 Aug '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email ) Change subject: ranap: Introduce new APIs to encode rab_ass for gtp and rtp ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File include/osmocom/ranap/ranap_msg_factory.h: https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/f5839ec9_b34aae84?usp… : PS1, Line 47: struct msgb *ranap_new_msg_rab_assign_voice2(uint8_t rab_id, const struct osmo_sockaddr *rtp_addr, the indention of the args looks weird, but fine. https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/1c4e422d_a3c77756?usp… : PS1, Line 56: uint32_t gtp_tei, the indention of the args looks weird, but fine. File src/ranap_msg_factory.c: https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/e3800d28_a7c94227?usp… : PS1, Line 975: .sin_port = htons(2152), You set a port here, which the old code doesn't. However the port is ignored later by ranap_new_transp_layer_addr() -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3a8800afd03b94349c8acec778ab7003819e80af Gerrit-Change-Number: 43258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-iuh[master]: ranap_msg_factory: Fix API documentation regarding ip param endianness
by pespin 18 Aug '26

18 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email ) Change subject: ranap_msg_factory: Fix API documentation regarding ip param endianness ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/c14f0955_6cbdd037?usp… : PS1, Line 20: an > missing space Done File src/ranap_msg_factory.c: https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/a421604e_9528d09e?usp… : PS1, Line 794: * \param rtp_ip MGW's RTP IPv4 address in *network* byte order. > you may add a comment about the rtp_port as well. I'll better improve the doc on the next patch where I'm adding the new API. https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/bdf0275c_53d4cc4f?usp… : PS1, Line 870: uint32_t gtp_tei, bool use_x213_nsap) > same as for rtp_port: optional: tei is also in host byte order Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I0a909019875714d35c27aa38dd5520a82d46e8f2 Gerrit-Change-Number: 43257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:27:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-iuh[master]: iu_helpers: Constify osmo_sockaddr input param
by pespin 18 Aug '26

18 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43256?usp=email ) Change subject: iu_helpers: Constify osmo_sockaddr input param ...................................................................... iu_helpers: Constify osmo_sockaddr input param Change-Id: I86040373c075bbd84c2a21abc61a880e307fd4f8 --- M include/osmocom/ranap/iu_helpers.h M src/iu_helpers.c 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/ranap/iu_helpers.h b/include/osmocom/ranap/iu_helpers.h index 3a06c4b..f6140a0 100644 --- a/include/osmocom/ranap/iu_helpers.h +++ b/include/osmocom/ranap/iu_helpers.h @@ -17,7 +17,7 @@ const RANAP_TransportLayerAddress_t *trasp_layer_addr); int ranap_transp_layer_addr_decode2(struct osmo_sockaddr *addr, bool *uses_x213_nsap, const RANAP_TransportLayerAddress_t *trasp_layer_addr); -RANAP_TransportLayerInformation_t *ranap_new_transp_info_rtp(struct osmo_sockaddr *addr, bool use_x213_nsap); -RANAP_TransportLayerInformation_t *ranap_new_transp_info_gtp(struct osmo_sockaddr *addr, uint32_t tei, +RANAP_TransportLayerInformation_t *ranap_new_transp_info_rtp(const struct osmo_sockaddr *addr, bool use_x213_nsap); +RANAP_TransportLayerInformation_t *ranap_new_transp_info_gtp(const struct osmo_sockaddr *addr, uint32_t tei, bool use_x213_nsap); -int ranap_new_transp_layer_addr(BIT_STRING_t *out, struct osmo_sockaddr *addr, bool use_x213_nsap); +int ranap_new_transp_layer_addr(BIT_STRING_t *out, const struct osmo_sockaddr *addr, bool use_x213_nsap); diff --git a/src/iu_helpers.c b/src/iu_helpers.c index 705af31..07b6085 100644 --- a/src/iu_helpers.c +++ b/src/iu_helpers.c @@ -194,12 +194,12 @@ return 0; } -int ranap_new_transp_layer_addr(BIT_STRING_t *out, struct osmo_sockaddr *addr, bool use_x213_nsap) +int ranap_new_transp_layer_addr(BIT_STRING_t *out, const struct osmo_sockaddr *addr, bool use_x213_nsap) { uint8_t *buf; unsigned int len; size_t ip_len; - uint8_t *ip_addr; + const uint8_t *ip_addr; uint16_t icp; switch (addr->u.sa.sa_family) { @@ -244,7 +244,7 @@ return 0; } -RANAP_TransportLayerInformation_t *ranap_new_transp_info_rtp(struct osmo_sockaddr *addr, bool use_x213_nsap) +RANAP_TransportLayerInformation_t *ranap_new_transp_info_rtp(const struct osmo_sockaddr *addr, bool use_x213_nsap) { RANAP_TransportLayerInformation_t *tli; uint8_t binding_id[4] = { 0 }; @@ -275,7 +275,7 @@ return tli; } -RANAP_TransportLayerInformation_t *ranap_new_transp_info_gtp(struct osmo_sockaddr *addr, uint32_t tei, +RANAP_TransportLayerInformation_t *ranap_new_transp_info_gtp(const struct osmo_sockaddr *addr, uint32_t tei, bool use_x213_nsap) { RANAP_TransportLayerInformation_t *tli = CALLOC(1, sizeof(*tli)); -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I86040373c075bbd84c2a21abc61a880e307fd4f8 Gerrit-Change-Number: 43256 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-iuh[master]: ranap_msg_factory: Fix API documentation regarding ip param endianness
by lynxis lazus 18 Aug '26

18 Aug '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email ) Change subject: ranap_msg_factory: Fix API documentation regarding ip param endianness ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/84db183d_177d7ae1?usp… : PS1, Line 20: an missing space File src/ranap_msg_factory.c: https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/bedf84d0_7d5bb27e?usp… : PS1, Line 794: * \param rtp_ip MGW's RTP IPv4 address in *network* byte order. you may add a comment about the rtp_port as well. https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/bb74ba7f_0051a45c?usp… : PS1, Line 870: uint32_t gtp_tei, bool use_x213_nsap) same as for rtp_port: optional: tei is also in host byte order -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I0a909019875714d35c27aa38dd5520a82d46e8f2 Gerrit-Change-Number: 43257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:24:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026