August 2026 - gerrit-log - lists.osmocom.org

[M] Change in onomondo-ipa[master]: Introduce 'operation' parameters to main file
by jolly 18 Aug '26

18 Aug '26

jolly has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email ) Change subject: Introduce 'operation' parameters to main file ...................................................................... Introduce 'operation' parameters to main file Instead of having several command line options to trigger various operations, operational argument(s) are used. Because an operation runs exclusively, arguments for only one operation can be given at the same time. New operations are added in later patches, so they can use the operational arguments as well and do not need to introduce new command line options. Revert from getopt_long() back to getopt(), because long options are not required for this approach. Related: SYS#8101 Change-Id: I6b960f840820990de40fb07332669ddbfcdf1e7d --- M src/ipa/main.c 1 file changed, 70 insertions(+), 49 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/src/ipa/main.c b/src/ipa/main.c index fae8476..93e8c60 100644 --- a/src/ipa/main.c +++ b/src/ipa/main.c @@ -24,6 +24,12 @@ #define DEFAULT_NVSTATE_PATH "./nvstate.bin" #define DEFAULT_ESIPA_REQ_RETRIES 3 +enum operation { + OPER_GET_EIM_PACKAGE, + OPER_ADD_INITIAL_EIM, + OPER_EUICC_MEMORY_RESET, +}; + bool running = true; bool prfle_inst_consent(char *sm_dp_plus_address, char *ac_token) @@ -39,26 +45,29 @@ return false; } -static void print_help(void) +static void print_help(const char *prog_name) { + printf("Usage: %s [OPTIONS] [OPERATION]\n", prog_name); printf("options:\n"); - printf(" -h ......................... print this text.\n"); - printf(" -t TAC ..................... set TAC (default: %s)\n", DEFAULT_TAC); - printf(" -e eimId ................... set preferred eIM (in case the eUICC has multiple)\n"); - printf(" -r N ....................... set reader number (default: %d)\n", DEFAULT_READER_NUMBER); - printf(" -c N ....................... set logical channel number (default: %d)\n", DEFAULT_CHANNEL_NUMBER); - printf(" -f PATH .................... set initial eIM configuration\n"); - printf(" -m ......................... reset eUICC memory\n"); - printf(" --refresh-flag.............. Make eUICC send a CAT refresh after switching profile\n"); - printf(" -n PATH .................... path to nvstate file (default: %s)\n", DEFAULT_NVSTATE_PATH); - printf(" -y NUM ..................... number of retries for ESipa requests (default: %u)\n", + printf(" -h .......................... print this text.\n"); + printf(" -t TAC ...................... set TAC (default: %s)\n", DEFAULT_TAC); + printf(" -e eimId .................... set preferred eIM (in case the eUICC has multiple)\n"); + printf(" -r N ........................ set reader number (default: %d)\n", DEFAULT_READER_NUMBER); + printf(" -c N ........................ set logical channel number (default: %d)\n", DEFAULT_CHANNEL_NUMBER); + printf(" -R .......................... Make eUICC send a CAT refresh after switching profile\n"); + printf(" -n PATH ..................... path to nvstate file (default: %s)\n", DEFAULT_NVSTATE_PATH); + printf(" -y NUM ...................... number of retries for ESipa requests (default: %u)\n", DEFAULT_ESIPA_REQ_RETRIES); - printf(" -a ......................... ask end user for consent\n"); - printf(" -C ......................... CA (Certificate Authority) Bundle file\n"); - printf(" -S ......................... disable HTTPS\n"); - printf(" -I ......................... disable SSL certificate verification (insecure)\n"); - printf(" -E ......................... emulate IoT eUICC (compatibility mode to use consumer eUICCs)\n"); - printf(" -1 ......................... force the IPAd to process only one eUICC package (debug, use with caution)\n"); + printf(" -a .......................... ask end user for consent\n"); + printf(" -C .......................... CA (Certificate Authority) Bundle file\n"); + printf(" -S .......................... disable HTTPS\n"); + printf(" -I .......................... disable SSL certificate verification (insecure)\n"); + printf(" -E .......................... emulate IoT eUICC (compatibility mode to use consumer eUICCs)\n"); + printf(" -1 .......................... force the IPAd to process only one eUICC package (debug, use with caution)\n"); + printf("operation:\n"); + printf(" get-eim-package ............. Ask eIM for eIM package and process it (default operation)\n"); + printf(" add-initial-eim PATH ........ set initial eIM configuration from given file\n"); + printf(" euicc-memory-reset .......... reset eUICC memory\n"); } struct ipa_buf *load_ber_from_file(char *dir, char *file) @@ -141,13 +150,12 @@ struct ipa_context *ctx = NULL; int opt; int rc; - char *getopt_initial_eim_cfg_file = NULL; - bool getopt_euicc_memory_reset = false; + enum operation operation = OPER_GET_EIM_PACKAGE; + char *initial_eim_cfg_file = NULL; char *getopt_nvstate_path = DEFAULT_NVSTATE_PATH; struct ipa_buf *nvstate_load = NULL; struct ipa_buf *nvstate_save = NULL; bool getopt_one_euicc_pkg_only = false; - int option_index = 0; signal(SIGUSR1, sig_usr1); @@ -159,24 +167,15 @@ ipa_binary_from_hexstr(cfg.tac, sizeof(cfg.tac), DEFAULT_TAC); cfg.esipa_req_retries = DEFAULT_ESIPA_REQ_RETRIES; - enum { - OPT_REFRESHFLAG = 256, - }; - - struct option long_options[] = { - { "refresh-flag", no_argument, NULL, OPT_REFRESHFLAG}, - { NULL, 0, NULL, 0} - }; - /* Overwrite configuration values with user defined parameters */ while (1) { - opt = getopt_long(argc, argv, "ht:e:r:c:f:mn:C:SIEy:a1", long_options, &option_index); + opt = getopt(argc, argv, "ht:e:r:c:Rn:C:SIEy:a1"); if (opt == -1) break; switch (opt) { case 'h': - print_help(); + print_help(argv[0]); exit(0); break; case 't': @@ -191,13 +190,7 @@ case 'c': cfg.euicc_channel = atoi(optarg); break; - case 'f': - getopt_initial_eim_cfg_file = optarg; - break; - case 'm': - getopt_euicc_memory_reset = true; - break; - case OPT_REFRESHFLAG: + case 'R': cfg.refresh_flag = true; break; case 'n': @@ -225,9 +218,33 @@ getopt_one_euicc_pkg_only = true; break; default: - printf("unhandled option: %c!\n", opt); + printf("unsupported option: %c!\n", opt); + opt = -1; break; - }; + } + if (opt == -1) + exit(opt); + } + + if (optind < argc) { + if (!strcmp(argv[optind], "add-initial-eim")) { + if (optind + 1 >= argc) { + printf("operation requires two parameters: %s PATH\n", argv[optind]); + exit(-1); + } + operation = OPER_ADD_INITIAL_EIM; + initial_eim_cfg_file = argv[++optind]; + } else if (!strcmp(argv[optind], "euicc-memory-reset")) { + operation = OPER_EUICC_MEMORY_RESET; + } else if (!!strcmp(argv[optind], "get-eim-package")) { + printf("unknown operation: %s\n", argv[optind]); + exit(-1); + } + optind++; + if (optind < argc) { + printf("illegal extra operation parameter: %s\n", argv[optind]); + exit(-1); + } } /* Display current config */ @@ -273,15 +290,8 @@ goto leave; } - if (getopt_initial_eim_cfg_file) { - /* Load initial eIM configuration */ - struct ipa_buf *eim_cfg = load_ber_from_file(NULL, getopt_initial_eim_cfg_file); - ipa_add_init_eim_cfg(ctx, eim_cfg); - IPA_FREE(eim_cfg); - } else if (getopt_euicc_memory_reset) { - /* Perform an eUICC memory reset */ - ipa_euicc_mem_rst(ctx, true, true, true, true, true); - } else { + switch (operation) { + case OPER_GET_EIM_PACKAGE: IPA_LOGP(SMAIN, LINFO, "-----------------------------8<-----------------------------\n"); rc = eim_init(ctx); if (rc < 0) { @@ -326,6 +336,17 @@ goto leave; } } + break; + case OPER_ADD_INITIAL_EIM: + /* Load initial eIM configuration */ + struct ipa_buf *eim_cfg = load_ber_from_file(NULL, initial_eim_cfg_file); + ipa_add_init_eim_cfg(ctx, eim_cfg); + IPA_FREE(eim_cfg); + break; + case OPER_EUICC_MEMORY_RESET: + /* Perform an eUICC memory reset */ + ipa_euicc_mem_rst(ctx, true, true, true, true, true); + break; } leave: -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6b960f840820990de40fb07332669ddbfcdf1e7d Gerrit-Change-Number: 43202 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: fixup Add close function to HTTP_Server_Emulation
by jolly 18 Aug '26

18 Aug '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43282?usp=email ) Change subject: fixup Add close function to HTTP_Server_Emulation ...................................................................... fixup Add close function to HTTP_Server_Emulation Change-Id: I8c82f0063770cd6d6a1a98c229d4122c5aa2b4bd --- M library/HTTP_Server_Emulation.ttcn 1 file changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/43282/1 diff --git a/library/HTTP_Server_Emulation.ttcn b/library/HTTP_Server_Emulation.ttcn index d604dd3..73a93bc 100644 --- a/library/HTTP_Server_Emulation.ttcn +++ b/library/HTTP_Server_Emulation.ttcn @@ -33,9 +33,9 @@ port HTTPmsg_PT HTTP_server_port; /* Communication with Clients */ - port HTTP_SRV_PT CLIENT; - port HTTP_SRV_PROC_PT CLIENT_PROC; - port HTTP_SRV_PT CLIENT_DEFAULT; + port HTTP_CLNT_PT CLIENT; + port HTTP_CLNT_PROC_PT CLIENT_PROC; + port HTTP_CLNT_PT CLIENT_DEFAULT; /* Configuration by the user */ var HttpServerEmulationCfg g_http_cfg; @@ -122,7 +122,13 @@ * Interaction between Main and Client Components ***********************************************************************/ type port HTTP_SRV_PT message { - inout HTTPMessage, Close; + inout HTTPMessage; + out Close; +} with { extension "internal" }; + +type port HTTP_CLNT_PT message { + inout HTTPMessage; + in Close; } with { extension "internal" }; signature HTTPEM_register(); @@ -131,6 +137,10 @@ inout HTTPEM_register; } with { extension "internal" }; +type port HTTP_CLNT_PROC_PT procedure { + inout HTTPEM_register; +} with { extension "internal" }; + /*********************************************************************** * Client Component -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43282?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c82f0063770cd6d6a1a98c229d4122c5aa2b4bd Gerrit-Change-Number: 43282 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: IPAd: A test to verify PSMO forwarding
by jolly 18 Aug '26

18 Aug '26

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43276?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: IPAd: A test to verify PSMO forwarding ...................................................................... IPAd: A test to verify PSMO forwarding Related: SYS#8101 Change-Id: I38cccc34456eb7654b15582d952b6a1957305a74 --- M eim/eIM_Tests.ttcn M ipad/IPAd_Tests.ttcn M library/euicc/RSPDefinitions_Templates.ttcn M library/euicc/SGP32Definitions_Templates.ttcn M library/euicc/SGP32Definitions_Types.ttcn 5 files changed, 85 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/43276/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I38cccc34456eb7654b15582d952b6a1957305a74 Gerrit-Change-Number: 43276 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in simtrace2[master]: contrib/jenkins.sh: pin libosmocore to the last release
by osmith 18 Aug '26

18 Aug '26

Attention is currently required from: laforge, lynxis lazus, pespin. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43281?usp=email ) Change subject: contrib/jenkins.sh: pin libosmocore to the last release ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I753d634674f76c50e1a9cf67e5adc43201d54f0c Gerrit-Change-Number: 43281 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Aug 2026 11:33:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in simtrace2[master]: contrib/jenkins.sh: pin libosmocore to the last release
by lynxis lazus 18 Aug '26

18 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/43281?usp=email ) Change subject: contrib/jenkins.sh: pin libosmocore to the last release ...................................................................... contrib/jenkins.sh: pin libosmocore to the last release Ensure the libosmocore version doesn't move while building firmwares which are published. This improve reproducible builds. Change-Id: I753d634674f76c50e1a9cf67e5adc43201d54f0c --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/81/43281/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index e53a450..adbc412 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -19,7 +19,8 @@ mkdir "$deps" || true -osmo-build-dep.sh libosmocore "" '--disable-doxygen --enable-gnutls' +# pin the libosmocore to have more reproducible builds of our published firmwares +osmo-build-dep.sh libosmocore "1.14.1" '--disable-doxygen --enable-gnutls' # verify only after building the dependency (to ensure we have most recent source of dependency) verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]") -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I753d634674f76c50e1a9cf67e5adc43201d54f0c Gerrit-Change-Number: 43281 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in simtrace2[master]: cosmetic: fix typo in comment
by lynxis lazus 18 Aug '26

18 Aug '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43204?usp=email ) Change subject: cosmetic: fix typo in comment ...................................................................... cosmetic: fix typo in comment Change-Id: I7df27ebf9137ca60d6d7cd45dcf1be2d766c4f44 --- M firmware/libcommon/include/simtrace_prot.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/firmware/libcommon/include/simtrace_prot.h b/firmware/libcommon/include/simtrace_prot.h index 50042a0..ffcd061 100644 --- a/firmware/libcommon/include/simtrace_prot.h +++ b/firmware/libcommon/include/simtrace_prot.h @@ -54,7 +54,7 @@ SIMTRACE_MSGT_BD_CEMU_STATUS, /* Request / Confirm emulated card insert */ SIMTRACE_MSGT_DT_CEMU_CARDINSERT, - /* TPDU Data received from phomne */ + /* TPDU Data received from phone */ SIMTRACE_MSGT_DO_CEMU_RX_DATA, /* Indicate PTS request from phone */ SIMTRACE_MSGT_DO_CEMU_PTS, -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43204?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I7df27ebf9137ca60d6d7cd45dcf1be2d766c4f44 Gerrit-Change-Number: 43204 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: sim: fix APDU case detection for EMV commands under CLA=0x80
by lynxis lazus 18 Aug '26

18 Aug '26

Attention is currently required from: dexter, laforge. lynxis lazus has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/43238?usp=email ) Change subject: sim: fix APDU case detection for EMV commands under CLA=0x80 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think the proper way to address this is not to "pollute" the ETSI UICC tables for CLA=0x80, but to […] I agree with laforge. About the GET DATA mis-detection, this is currently under review here: https://gerrit.osmocom.org/c/simtrace2/+/43185 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6424397cb888f372fb44b4e984adf3ab8f4cd40b Gerrit-Change-Number: 43238 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Aug 2026 11:21:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in simtrace2[master]: firmware: Drop CEMU_TX_DATA when emulated sim is in-active
by lynxis lazus 18 Aug '26

18 Aug '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email ) Change subject: firmware: Drop CEMU_TX_DATA when emulated sim is in-active ...................................................................... firmware: Drop CEMU_TX_DATA when emulated sim is in-active When the emulated sim is in reset or without power, drop CEMU_TX_DATA. Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f --- M firmware/libcommon/include/card_emu.h M firmware/libcommon/source/card_emu.c M firmware/libcommon/source/mode_cardemu.c 3 files changed, 20 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/firmware/libcommon/include/card_emu.h b/firmware/libcommon/include/card_emu.h index c2d3b68..a5e4d97 100644 --- a/firmware/libcommon/include/card_emu.h +++ b/firmware/libcommon/include/card_emu.h @@ -72,6 +72,7 @@ void card_emu_uart_interrupt(uint8_t uart_chan); int card_emu_get_vcc(uint8_t uart_chan); +bool card_emu_ch_ready(const struct card_handle *ch); struct cardemu_usb_msg_config; int card_emu_set_config(struct card_handle *ch, const struct cardemu_usb_msg_config *scfg, diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c index 72da9d8..cda8cf9 100644 --- a/firmware/libcommon/source/card_emu.c +++ b/firmware/libcommon/source/card_emu.c @@ -215,6 +215,19 @@ } stats; }; +/* if the card emu is ready to handle TPDUs */ +bool card_emu_ch_ready(const struct card_handle *ch) +{ + switch (ch->state) { + case ISO_S_IN_PTS: + case ISO_S_WAIT_TPDU: + case ISO_S_IN_TPDU: + return true; + default: + return false; + } +} + /* reset all the 'dynamic' state of the card handle to the initial/default values */ static void card_handle_reset(struct card_handle *ch) { diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c index 6c1ac8d..215cd45 100644 --- a/firmware/libcommon/source/mode_cardemu.c +++ b/firmware/libcommon/source/mode_cardemu.c @@ -736,6 +736,12 @@ hdr = (struct simtrace_msg_hdr *) msg->l1h; switch (hdr->msg_type) { case SIMTRACE_MSGT_DT_CEMU_TX_DATA: + /* drop message when the card emu channel is in-active */ + if (!card_emu_ch_ready(ci->ch)) { + /* FIXME: enqueue an error message for IN */ + usb_buf_free(msg); + return; + } queue = card_emu_get_uart_tx_queue(ci->ch); /* drained from the USART IRQ handler at highest NVIC prio */ llist_add_tail_irqsafe(&msg->list, queue); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f Gerrit-Change-Number: 43003 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in simtrace2[master]: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
by lynxis lazus 18 Aug '26

18 Aug '26

Attention is currently required from: dexter, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email ) Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ...................................................................... Patch Set 9: (1 comment) File host/lib/apdu_dispatch.c: https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/113807df_c2712dd1?us… : PS3, Line 120: ac->hdr.cla & 0x80 && /* check for GP */ > From what I can see the behavior is not GP specific. The ETSI TS 102 221 Table 7. […] for the record: I removed the dependency on GP and on the GET DATA APDU to have it more generic. Instead I exclude it, if the last APDU was a case 4. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 Gerrit-Change-Number: 43185 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Aug 2026 11:06:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in simtrace2[master]: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
by lynxis lazus 18 Aug '26

18 Aug '26

Attention is currently required from: dexter, laforge, lynxis lazus. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Code-Review+1 by dexter, Verified+1 by Jenkins Builder Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ...................................................................... Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA osmo_apdu_segment_in() doesn't have the context of the previous APDU, for nearly all calls this is fine, except for GP GET DATA, which can be a case 2 or case 4 APDU. GP GET DATA defines the Le field as 0x00 which is used by osmo_apdu_segment_in to detect if it is a case 2 or case 4. However a card can respond with the SW 6cXX, which means the previous command must be resend with a Le field XX, which got misinterpreted by the osmo_apdu_segment_in() as a case 4 resulting in a timeout waiting for more data. Modem <-> Card 81cadf2000 -> <- 6c0b 81cadf200b -> -- Simtrace waits for more data because it wrongly decodes it as APDU case 4 instead of case 2. Related: SYS#8147 Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 --- M TODO-RELEASE M host/Makefile.am M host/configure.ac M host/include/osmocom/simtrace2/apdu_dispatch.h M host/lib/apdu_dispatch.c A host/tests/Makefile.am A host/tests/apdu_dispatch/Makefile.am A host/tests/apdu_dispatch/apdu_dispatch_test.c A host/tests/apdu_dispatch/apdu_dispatch_test.ok A host/tests/testsuite.at 10 files changed, 197 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/85/43185/9 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247 Gerrit-Change-Number: 43185 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026