dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43210?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: contrib: remove onomondo-eim.service systemd example
......................................................................
contrib: remove onomondo-eim.service systemd example
The file onomondo-eim.service is is an example to illustrate how
onomondo-eim could be started using systemd. However, this file
is outdated and we do not use it anywhere. So let's remove it.
If required, we can always add a new, working example at some
later point.
Related: SYS#8100
Change-Id: I78edeeb88fc1003483db996dce8e42f149ed5aff
---
D contrib/onomondo-eim.service
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
jolly: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/contrib/onomondo-eim.service b/contrib/onomondo-eim.service
deleted file mode 100644
index 35d8335..0000000
--- a/contrib/onomondo-eim.service
+++ /dev/null
@@ -1,9 +0,0 @@
-[Unit]
-Description=onomondo-eim
-
-[Service]
-Type=simple
-ExecStart=/path/to/my/onomondo_eim/_rel/onomondo_eim_release/bin/onomondo_eim_release foreground
-
-[Install]
-WantedBy=multi-user.target
\ No newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43210?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I78edeeb88fc1003483db996dce8e42f149ed5aff
Gerrit-Change-Number: 43210
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/43209?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: config: update sys.dev.config
......................................................................
config: update sys.dev.config
The config file sys.dev.config still has outdated SSL certificate
paths in it. Let's fix it up so that it has the correct paths.
Related: SYS#8100
Change-Id: I4d8c91d787e6932fbcab7f0dcbdea620894a61c2
---
M config/sys.dev.config
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/09/43209/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43209?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I4d8c91d787e6932fbcab7f0dcbdea620894a61c2
Gerrit-Change-Number: 43209
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/43210?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: contrib: remove onomondo-eim.service systemd example
......................................................................
contrib: remove onomondo-eim.service systemd example
The file onomondo-eim.service is is an example to illustrate how
onomondo-eim could be started using systemd. However, this file
is outdated and we do not use it anywhere. So let's remove it.
If required, we can always add a new, working example at some
later point.
Related: SYS#8100
Change-Id: I78edeeb88fc1003483db996dce8e42f149ed5aff
---
D contrib/onomondo-eim.service
1 file changed, 0 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/10/43210/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43210?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I78edeeb88fc1003483db996dce8e42f149ed5aff
Gerrit-Change-Number: 43210
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/43088?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: rest_handler, cosmetic: clean up order of variable assignments
......................................................................
rest_handler, cosmetic: clean up order of variable assignments
We assign a couple of varibales before we output them to InfoList,
let's make sure the order is consistent with the order in InfoList.
Related: SYS#8100
Change-Id: I2b998a619cf1db5532bcfe671d6d451d095c37f8
---
M src/rest_handler.erl
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/88/43088/7
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43088?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I2b998a619cf1db5532bcfe671d6d451d095c37f8
Gerrit-Change-Number: 43088
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/43087?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: onomondo_eim_app: unify HTTP/HTTPs server startup
......................................................................
onomondo_eim_app: unify HTTP/HTTPs server startup
The REST API also makes use of the cowboy HTTP server in the same
way as the ESipa API does when running without SSL/TLS. Let's unify
the code in such a way that both HTTP servers call the same startup
helper functions.
Related: SYS#8100
Change-Id: Ie63a97b7ca6873d02866a11226733b37017504cd
---
M src/onomondo_eim_app.erl
1 file changed, 19 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/87/43087/7
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43087?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ie63a97b7ca6873d02866a11226733b37017504cd
Gerrit-Change-Number: 43087
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43015?usp=email )
(
7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: esipa_asn1_handler_utils: use eimTransactionId in EuiccPackageErrorUnsigned
......................................................................
esipa_asn1_handler_utils: use eimTransactionId in EuiccPackageErrorUnsigned
EuiccPackageErrorUnsigned contains an eimTransactionId, let's make sure that
it is used (if it is present).
Change-Id: Ibfbc6debcd36d2aae1f4530a608db823caf3a394
Related: SYS#8100
---
M src/esipa_asn1_handler_utils.erl
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
jolly: Looks good to me, but someone else must approve
diff --git a/src/esipa_asn1_handler_utils.erl b/src/esipa_asn1_handler_utils.erl
index 2e4295c..8ad9cb6 100644
--- a/src/esipa_asn1_handler_utils.erl
+++ b/src/esipa_asn1_handler_utils.erl
@@ -20,6 +20,8 @@
euiccPackageErrorDataSigned, EuiccPackageErrorSigned
),
maps:get(eimTransactionId, EuiccPackageErrorDataSigned, none);
+ {euiccPackageErrorUnsigned, EuiccPackageErrorUnsigned} ->
+ maps:get(eimTransactionId, EuiccPackageErrorUnsigned, none);
_ ->
none
end.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43015?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ibfbc6debcd36d2aae1f4530a608db823caf3a394
Gerrit-Change-Number: 43015
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/43015?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: esipa_asn1_handler_utils: use eimTransactionId in EuiccPackageErrorUnsigned
......................................................................
esipa_asn1_handler_utils: use eimTransactionId in EuiccPackageErrorUnsigned
EuiccPackageErrorUnsigned contains an eimTransactionId, let's make sure that
it is used (if it is present).
Change-Id: Ibfbc6debcd36d2aae1f4530a608db823caf3a394
Related: SYS#8100
---
M src/esipa_asn1_handler_utils.erl
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/15/43015/8
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43015?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ibfbc6debcd36d2aae1f4530a608db823caf3a394
Gerrit-Change-Number: 43015
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>