Attention is currently required from: laforge, lynxis lazus.
dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email )
Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
......................................................................
Patch Set 9: Code-Review+2 Verified+1
(2 comments)
Patchset:
PS9:
To be sure it really works and that it does not break anything I have done a test with simtrace2-cardem-pcsc.c (you still have to fix this caller since it still calls the old API. For the test I have quickly hacked-in a static variable to capture the prev_ac).
Without your patch I can clearly see that the trace hangs for a second when the GET DATA happens. Then a strange status word appears and the transaction fails.
With your patch the GET DATA goes through as expected. The trace also does not hang anymore.
So I think we can now merge this patch.
File host/lib/apdu_dispatch.c:
https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/618ac047_3e4d5315?us… :
PS3, Line 120: ac->hdr.cla & 0x80 && /* check for GP */
> for the record: I removed the dependency on GP and on the GET DATA APDU to have it more generic. […]
I think this makes sense. This should work fine.
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247
Gerrit-Change-Number: 43185
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 18 Aug 2026 14:09:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: laforge, osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43283?usp=email )
Change subject: ansible: build-host: configure email sending
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I have no clue about exim, so letting @laforge@gnumonks.org review it :)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43283?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I22ea83de3417cbbb578345d34f18095c47441610
Gerrit-Change-Number: 43283
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 18 Aug 2026 13:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43281?usp=email )
Change subject: contrib/jenkins.sh: pin libosmocore to the last release
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> s/osmocom master/libosmocore master/
What I feat is that this will simply become stuck at that libosmocore version, and then we have an extra step to the already long list of steps when releasing a new version.
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43281?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I753d634674f76c50e1a9cf67e5adc43201d54f0c
Gerrit-Change-Number: 43281
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 18 Aug 2026 13:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>