August 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: linuxlist: fix false-positive UBSan misaligned-access reports
by fixeria 25 Aug '26

25 Aug '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/43150?usp=email ) Change subject: linuxlist: fix false-positive UBSan misaligned-access reports ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > @vyanitskiy@sysmocom. […] I've compared our implementation against `include/linux/list.h` (linux v7.1.8). Our older version is not 1:1 with the upstream anymore. I've already mentioned the removal of `prefetch()` in the next patch. Apart from that, the upstream has fancy macros like `list_entry_is_head`/`list_is_head` and `list_next_entry`. All those macros in the kernel are still doing `pos->member` (via `list_entry_is_head`), so I believe this has not been solved upstream. And unfortunately, I could not find any related discussions in the mailing lists... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0424e76e76d8aa9402bd1a5aefe789de16e72fae Gerrit-Change-Number: 43150 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 15:50:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eIM: add profileInfoList fields for ecall and fallback
by dexter 25 Aug '26

25 Aug '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43392?usp=email ) Change subject: eIM: add profileInfoList fields for ecall and fallback ...................................................................... eIM: add profileInfoList fields for ecall and fallback SGP.32 V.1.2 adds three (important) new boolean fields to the profileInfoList, which are ecallIndication, fallbackAllowed and fallbackAttribute. This patch adds support for those fields so that they can be queried via the REST API. Related: SYS8100 Change-Id: Ieb820082d0e61bad8e5dd3813fb3296be2e5f72e --- M eim/REST_Types_JSON.ttcn 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/43392/1 diff --git a/eim/REST_Types_JSON.ttcn b/eim/REST_Types_JSON.ttcn index 0a34939..3bbf4d7 100644 --- a/eim/REST_Types_JSON.ttcn +++ b/eim/REST_Types_JSON.ttcn @@ -112,12 +112,15 @@ charstring profileName optional, charstring iconType optional, charstring icon optional, - charstring profileClass optional + charstring profileClass optional, //TODO: notificationConfigurationInfo //TODO: profileOwner //TODO: dpProprietaryData //TODO: profilePolicyRules //TODO: serviceSpecificDataStoredInEuicc + boolean ecallIndication optional, + boolean fallbackAttribute optional, + boolean fallbackAllowed optional }; type record JSON_REST_EimIdList { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieb820082d0e61bad8e5dd3813fb3296be2e5f72e Gerrit-Change-Number: 43392 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: eIM: re-align REST API JSON types
by dexter 25 Aug '26

25 Aug '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43393?usp=email ) Change subject: eIM: re-align REST API JSON types ...................................................................... eIM: re-align REST API JSON types The data types of the REST API responses (outcome) have been changed. This patch re-alignes the related record definitions. Depends: onomondo-eim.git Change-Id I16cc063c185727e1b30f26d656bd15154504b087 Change-Id: I078916dd83cf9114ad5d491cb7ecc54babb957cf Related: SYS#8100 --- M eim/REST_Types_JSON.ttcn M eim/eIM_Tests.ttcn 2 files changed, 39 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/43393/1 diff --git a/eim/REST_Types_JSON.ttcn b/eim/REST_Types_JSON.ttcn index 3bbf4d7..b3a74b7 100644 --- a/eim/REST_Types_JSON.ttcn +++ b/eim/REST_Types_JSON.ttcn @@ -146,49 +146,57 @@ charstring enableResult, charstring disableResult, charstring deleteResult, - record { - charstring finalResult, - record of JSON_REST_ProfileInfo profileInfoList optional - } listProfileInfoResult, + record of JSON_REST_ProfileInfo listProfileInfoResult, record of JSON_REST_ProfilePolicyAuthorisationRule getRATResult, charstring configureImmediateEnableResult, - charstring setFallbackAttributeResult, - charstring unsetFallbackAttributeResult, - charstring setDefaultDpAddressResult, record { - charstring addEimResultCode, + charstring addEimResultCode optional, integer associationToken optional } addEimResult, charstring deleteEimResult, charstring updateEimResult, - record { - charstring finalResult, - record of JSON_REST_EimIdList eimIdList optional - } listEimResult, + record of JSON_REST_EimIdList listEimResult, charstring rollbackResult, + charstring setFallbackAttributeResult, + charstring unsetFallbackAttributeResult, charstring processingTerminated, - charstring notificationResult, - charstring cancelSessionResult, + charstring setDefaultDpAddressResult, record { - charstring finalResult, - charstring iccid optional + charstring defaultSmdpAddress optional, + octetstring euiccInfo1 optional, + octetstring euiccInfo2 optional, + charstring rootSmdsAddress optional, + integer associationToken optional, + octetstring eumCertificate optional, + octetstring euiccCertificate optional, + octetstring ipaCapabilities optional, + octetstring deviceInfo optional, + octetstring notificationsList optional + } euiccDataResult, + record { + charstring iccid, + charstring aid, + charstring simaResponse } profileInstallationResult, record of JSON_REST_Euicc_State euiccStateResult, + charstring cancelSessionReason, + charstring euiccPackageError, + charstring ipaEuiccDataError, + charstring eimPackageResultError, + charstring initiateAuthenticationError, + charstring authenticateResponseError, + charstring authenticateClientError, + charstring downloadResponseError, + charstring getBoundProfilePackageError, + charstring cancelSessionResponseError, + charstring profileInfoListError, + charstring listEimError, record { - charstring edrResult, - record { - charstring defaultSmdpAddress optional, - octetstring euiccInfo1 optional, - octetstring euiccInfo2 optional, - charstring rootSmdsAddress optional, - integer associationToken optional, - octetstring eumCertificate optional, - octetstring euiccCertificate optional, - octetstring ipaCapabilities optional, - octetstring deviceInfo optional, - octetstring notificationsList optional - } euiccData optional - } euiccDataResult + charstring BppCommandId, + charstring ErrorReason, + charstring simaResponse + } profileInstallationError, + charstring eimProcedureError } type record of JSON_REST_Result JSON_REST_Results; diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn index 8d845b2..2e036ba 100644 --- a/eim/eIM_Tests.ttcn +++ b/eim/eIM_Tests.ttcn @@ -952,7 +952,7 @@ var template EsipaMessageFromEimToIpa esipa_res; var template octetstring eimTransactionId; var template JSON_REST_Results expected_outcome := - { { euiccDataResult := { edrResult := "undefinedError", euiccData := omit } } }; + { { ipaEuiccDataError := "undefinedError" } }; f_http_register(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I078916dd83cf9114ad5d491cb7ecc54babb957cf Gerrit-Change-Number: 43393 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_snm: constify xua_msg param in xua_snm_rx_*
by pespin 25 Aug '26

25 Aug '26

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43225?usp=email ) Change subject: xua_snm: constify xua_msg param in xua_snm_rx_* ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @laforge@gnumonks.org can we at least merge this patch for now? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43225?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e5844a6f0d40c1df3ae31955bb8b24d891d86b1 Gerrit-Change-Number: 43225 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Aug 2026 15:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-sgsn[master]: build: drop unused libosmo-abis dependency
by fixeria 25 Aug '26

25 Aug '26

fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43391?usp=email ) Change subject: build: drop unused libosmo-abis dependency ...................................................................... build: drop unused libosmo-abis dependency No code in this tree includes any <osmocom/abis/*> header anymore. The last use, <osmocom/abis/ipa.h> in sgsn_vty.c, was already unneeded and dropped in 7a45b5748. LIBOSMOABIS_CFLAGS was still added to several AM_CFLAGS, and LIBOSMOABIS_LIBS was never referenced by any LDADD at all, so the library wasn't even linked despite configure.ac and debian/control requiring it. Change-Id: I5548e8e952cd57ea4268067e3f3e4d2f731911c1 Related: 7a45b5748 ("sgsn_vty: Drop unneeded use of abis/ipa.h header") Related: OS#6535 --- M configure.ac M debian/control M src/gprs/Makefile.am M src/sgsn/Makefile.am M tests/gprs/Makefile.am M tests/gprs_routing_area/Makefile.am M tests/gtphub/Makefile.am M tests/sgsn/Makefile.am 8 files changed, 1 insertion(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/91/43391/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I5548e8e952cd57ea4268067e3f3e4d2f731911c1 Gerrit-Change-Number: 43391 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in osmo-sgsn[master]: build: drop unused libosmo-abis dependency
by fixeria 25 Aug '26

25 Aug '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43391?usp=email ) Change subject: build: drop unused libosmo-abis dependency ...................................................................... build: drop unused libosmo-abis dependency No code in this tree includes any <osmocom/abis/*> header anymore. The last use, <osmocom/abis/ipa.h> in sgsn_vty.c, was already unneeded and dropped in 08c1ba313. LIBOSMOABIS_CFLAGS was still added to several AM_CFLAGS, and LIBOSMOABIS_LIBS was never referenced by any LDADD at all, so the library wasn't even linked despite configure.ac and debian/control requiring it. Change-Id: I5548e8e952cd57ea4268067e3f3e4d2f731911c1 Related: 08c1ba313 ("sgsn_vty: Drop unneeded use of abis/ipa.h header") Related: OS#6535 --- M configure.ac M debian/control M src/gprs/Makefile.am M src/sgsn/Makefile.am M tests/gprs/Makefile.am M tests/gprs_routing_area/Makefile.am M tests/gtphub/Makefile.am M tests/sgsn/Makefile.am 8 files changed, 1 insertion(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/91/43391/1 diff --git a/configure.ac b/configure.ac index 17a0236..74e0640 100644 --- a/configure.ac +++ b/configure.ac @@ -43,7 +43,6 @@ PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.10.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.10.0) PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.10.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.8.0) PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.12.0) diff --git a/debian/control b/debian/control index 2a3d427..1c066ff 100644 --- a/debian/control +++ b/debian/control @@ -13,7 +13,6 @@ libc-ares-dev, libgtp-dev (>= 1.12.0), libosmocore-dev (>= 1.10.0), - libosmo-abis-dev (>= 1.6.0), libosmo-gsup-client-dev (>= 1.8.0), libasn1c-dev (>= 0.9.30), libosmo-ranap-dev (>= 1.6.0), diff --git a/src/gprs/Makefile.am b/src/gprs/Makefile.am index 1533dc0..c2387b1 100644 --- a/src/gprs/Makefile.am +++ b/src/gprs/Makefile.am @@ -11,7 +11,6 @@ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOCTRL_CFLAGS) \ - $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOGB_CFLAGS) \ $(LIBOSMOGSUPCLIENT_CFLAGS) \ $(COVERAGE_CFLAGS) \ diff --git a/src/sgsn/Makefile.am b/src/sgsn/Makefile.am index e64fe94..75df1e5 100644 --- a/src/sgsn/Makefile.am +++ b/src/sgsn/Makefile.am @@ -11,7 +11,6 @@ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOCTRL_CFLAGS) \ - $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOGB_CFLAGS) \ $(LIBOSMOGSUPCLIENT_CFLAGS) \ $(COVERAGE_CFLAGS) \ diff --git a/tests/gprs/Makefile.am b/tests/gprs/Makefile.am index ddfd2ae..7e0f464 100644 --- a/tests/gprs/Makefile.am +++ b/tests/gprs/Makefile.am @@ -1,5 +1,5 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOABIS_CFLAGS) +AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) AM_LDFLAGS = -no-install EXTRA_DIST = gprs_test.ok diff --git a/tests/gprs_routing_area/Makefile.am b/tests/gprs_routing_area/Makefile.am index 380d946..4f6524d 100644 --- a/tests/gprs_routing_area/Makefile.am +++ b/tests/gprs_routing_area/Makefile.am @@ -8,7 +8,6 @@ -ggdb3 \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOCTRL_CFLAGS) \ - $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOGSUPCLIENT_CFLAGS) \ $(LIBCARES_CFLAGS) \ diff --git a/tests/gtphub/Makefile.am b/tests/gtphub/Makefile.am index 22b2a52..e41b4a4 100644 --- a/tests/gtphub/Makefile.am +++ b/tests/gtphub/Makefile.am @@ -7,7 +7,6 @@ -Wall \ -ggdb3 \ $(LIBOSMOCORE_CFLAGS) \ - $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBGTP_CFLAGS) \ $(NULL) diff --git a/tests/sgsn/Makefile.am b/tests/sgsn/Makefile.am index 77c1dd7..ab3bb0a 100644 --- a/tests/sgsn/Makefile.am +++ b/tests/sgsn/Makefile.am @@ -8,7 +8,6 @@ -ggdb3 \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOCTRL_CFLAGS) \ - $(LIBOSMOABIS_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOGSUPCLIENT_CFLAGS) \ $(LIBCARES_CFLAGS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I5548e8e952cd57ea4268067e3f3e4d2f731911c1 Gerrit-Change-Number: 43391 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-remsim[master]: client: simtrace2: Use the new API osmo_apdu_segment_in2()
by fixeria 25 Aug '26

25 Aug '26

Attention is currently required from: dexter, lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43351?usp=email ) Change subject: client: simtrace2: Use the new API osmo_apdu_segment_in2() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I432c96c8cdbcb78bc3e4f135ebd51c4077aa9007 Gerrit-Change-Number: 43351 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 15:09:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach
by fixeria 25 Aug '26

25 Aug '26

Attention is currently required from: lynxis lazus, osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email ) Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: > @vyanitskiy@sysmocom.de shouldn't this be covered by […] No, `process_ms_ctx_status()` does not apply here. It's wired up only for RA Update Request and Service Request, where it reads the `GSM48_IE_GMM_PDP_CTX_STATUS` IE and checks NSAPIs the MS reports as inactive against what the SGSN still holds. GMM Attach Request does not have that IE at all. File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/42594/comment/b9e075c7_11a39478?us… : PS3, Line 1348: sgsn_pdp_ctx_terminate(pdp); > calling […] Acknowledged. See https://gerrit.osmocom.org/c/osmo-sgsn/+/43390. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Gerrit-Change-Number: 42594 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Aug 2026 15:00:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach
by fixeria 25 Aug '26

25 Aug '26

Attention is currently required from: fixeria, lynxis lazus, osmith. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach ...................................................................... gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach When an MS sends an Attach Request with a known IMSI or P-TMSI, it implies the MS has restarted and lost all its PDP context state. The SGSN must clean up any PDP contexts it still holds for that subscriber; otherwise it will not create new ones upon subsequent PDP Context Activation, causing data connectivity failure after a device reboot. Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Related: OS#6922 --- M src/sgsn/gprs_gmm.c M tests/sgsn/sgsn_test.c M tests/sgsn/sgsn_test.ok 3 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/94/42594/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Gerrit-Change-Number: 42594 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: pdpctx: sgsn_pdp_ctx_terminate(): free PDP context if GTP side is det...
by fixeria 25 Aug '26

25 Aug '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43390?usp=email ) Change subject: pdpctx: sgsn_pdp_ctx_terminate(): free PDP context if GTP side is detached ...................................................................... pdpctx: sgsn_pdp_ctx_terminate(): free PDP context if GTP side is detached When pdp->ggsn is NULL, sgsn_pdp_ctx_terminate() detached the PDP context from its MM context but never freed it: sgsn_delete_pdp_ctx() (which normally triggers the eventual free via the GTP delete confirmation callback) was only called when pdp->ggsn was set. This leaked the PDP context. pdp->ggsn becomes NULL while the PDP context is still attached to a live MM context in sgsn_ggsn_ctx_remove_pdp(), e.g. when a GGSN recovers/disappears while the MS stays GPRS attached. Any later termination of that PDP context (e.g. Detach, or dropping stale PDP contexts on re-Attach) would then leak it instead of freeing it. Mirror the pattern already used in process_ms_ctx_status(): if the GTP side is already detached, free the PDP context right away instead of leaving it dangling. Change-Id: Ia74407c34576bfcc1f4ab9d1940b500da86cfbab Related: OS#6922 --- M src/sgsn/pdpctx.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/90/43390/1 diff --git a/src/sgsn/pdpctx.c b/src/sgsn/pdpctx.c index da825e6..d65ca4d 100644 --- a/src/sgsn/pdpctx.c +++ b/src/sgsn/pdpctx.c @@ -126,6 +126,8 @@ pdp_ctx_detach_mm_ctx(pdp); if (pdp->ggsn) sgsn_delete_pdp_ctx(pdp); + else /* GTP side already detached, freeing */ + sgsn_pdp_ctx_free(pdp); } /* -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43390?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia74407c34576bfcc1f4ab9d1940b500da86cfbab Gerrit-Change-Number: 43390 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026