August 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-iuh[master]: ranap: Introduce new APIs to encode rab_ass for gtp and rtp
by pespin 18 Aug '26

18 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email ) Change subject: ranap: Introduce new APIs to encode rab_ass for gtp and rtp ...................................................................... Patch Set 1: (3 comments) File include/osmocom/ranap/ranap_msg_factory.h: https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/174d22e8_6748b511?usp… : PS1, Line 47: struct msgb *ranap_new_msg_rab_assign_voice2(uint8_t rab_id, const struct osmo_sockaddr *rtp_addr, > the indention of the args looks weird, but fine. Done https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/c1370eed_0e7f576d?usp… : PS1, Line 56: uint32_t gtp_tei, > the indention of the args looks weird, but fine. Done File src/ranap_msg_factory.c: https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/af9ca08c_0e732f72?usp… : PS1, Line 975: .sin_port = htons(2152), > You set a port here, which the old code doesn't. […] I know it's not necessary, it doesn't harm either though. I can leave it as a 0. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3a8800afd03b94349c8acec778ab7003819e80af Gerrit-Change-Number: 43258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-iuh[master]: ranap: Introduce new APIs to encode rab_ass for gtp and rtp
by lynxis lazus 18 Aug '26

18 Aug '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email ) Change subject: ranap: Introduce new APIs to encode rab_ass for gtp and rtp ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File include/osmocom/ranap/ranap_msg_factory.h: https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/f5839ec9_b34aae84?usp… : PS1, Line 47: struct msgb *ranap_new_msg_rab_assign_voice2(uint8_t rab_id, const struct osmo_sockaddr *rtp_addr, the indention of the args looks weird, but fine. https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/1c4e422d_a3c77756?usp… : PS1, Line 56: uint32_t gtp_tei, the indention of the args looks weird, but fine. File src/ranap_msg_factory.c: https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/e3800d28_a7c94227?usp… : PS1, Line 975: .sin_port = htons(2152), You set a port here, which the old code doesn't. However the port is ignored later by ranap_new_transp_layer_addr() -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3a8800afd03b94349c8acec778ab7003819e80af Gerrit-Change-Number: 43258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-iuh[master]: ranap_msg_factory: Fix API documentation regarding ip param endianness
by pespin 18 Aug '26

18 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email ) Change subject: ranap_msg_factory: Fix API documentation regarding ip param endianness ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/c14f0955_6cbdd037?usp… : PS1, Line 20: an > missing space Done File src/ranap_msg_factory.c: https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/a421604e_9528d09e?usp… : PS1, Line 794: * \param rtp_ip MGW's RTP IPv4 address in *network* byte order. > you may add a comment about the rtp_port as well. I'll better improve the doc on the next patch where I'm adding the new API. https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/bdf0275c_53d4cc4f?usp… : PS1, Line 870: uint32_t gtp_tei, bool use_x213_nsap) > same as for rtp_port: optional: tei is also in host byte order Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I0a909019875714d35c27aa38dd5520a82d46e8f2 Gerrit-Change-Number: 43257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:27:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-iuh[master]: iu_helpers: Constify osmo_sockaddr input param
by pespin 18 Aug '26

18 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43256?usp=email ) Change subject: iu_helpers: Constify osmo_sockaddr input param ...................................................................... iu_helpers: Constify osmo_sockaddr input param Change-Id: I86040373c075bbd84c2a21abc61a880e307fd4f8 --- M include/osmocom/ranap/iu_helpers.h M src/iu_helpers.c 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/ranap/iu_helpers.h b/include/osmocom/ranap/iu_helpers.h index 3a06c4b..f6140a0 100644 --- a/include/osmocom/ranap/iu_helpers.h +++ b/include/osmocom/ranap/iu_helpers.h @@ -17,7 +17,7 @@ const RANAP_TransportLayerAddress_t *trasp_layer_addr); int ranap_transp_layer_addr_decode2(struct osmo_sockaddr *addr, bool *uses_x213_nsap, const RANAP_TransportLayerAddress_t *trasp_layer_addr); -RANAP_TransportLayerInformation_t *ranap_new_transp_info_rtp(struct osmo_sockaddr *addr, bool use_x213_nsap); -RANAP_TransportLayerInformation_t *ranap_new_transp_info_gtp(struct osmo_sockaddr *addr, uint32_t tei, +RANAP_TransportLayerInformation_t *ranap_new_transp_info_rtp(const struct osmo_sockaddr *addr, bool use_x213_nsap); +RANAP_TransportLayerInformation_t *ranap_new_transp_info_gtp(const struct osmo_sockaddr *addr, uint32_t tei, bool use_x213_nsap); -int ranap_new_transp_layer_addr(BIT_STRING_t *out, struct osmo_sockaddr *addr, bool use_x213_nsap); +int ranap_new_transp_layer_addr(BIT_STRING_t *out, const struct osmo_sockaddr *addr, bool use_x213_nsap); diff --git a/src/iu_helpers.c b/src/iu_helpers.c index 705af31..07b6085 100644 --- a/src/iu_helpers.c +++ b/src/iu_helpers.c @@ -194,12 +194,12 @@ return 0; } -int ranap_new_transp_layer_addr(BIT_STRING_t *out, struct osmo_sockaddr *addr, bool use_x213_nsap) +int ranap_new_transp_layer_addr(BIT_STRING_t *out, const struct osmo_sockaddr *addr, bool use_x213_nsap) { uint8_t *buf; unsigned int len; size_t ip_len; - uint8_t *ip_addr; + const uint8_t *ip_addr; uint16_t icp; switch (addr->u.sa.sa_family) { @@ -244,7 +244,7 @@ return 0; } -RANAP_TransportLayerInformation_t *ranap_new_transp_info_rtp(struct osmo_sockaddr *addr, bool use_x213_nsap) +RANAP_TransportLayerInformation_t *ranap_new_transp_info_rtp(const struct osmo_sockaddr *addr, bool use_x213_nsap) { RANAP_TransportLayerInformation_t *tli; uint8_t binding_id[4] = { 0 }; @@ -275,7 +275,7 @@ return tli; } -RANAP_TransportLayerInformation_t *ranap_new_transp_info_gtp(struct osmo_sockaddr *addr, uint32_t tei, +RANAP_TransportLayerInformation_t *ranap_new_transp_info_gtp(const struct osmo_sockaddr *addr, uint32_t tei, bool use_x213_nsap) { RANAP_TransportLayerInformation_t *tli = CALLOC(1, sizeof(*tli)); -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I86040373c075bbd84c2a21abc61a880e307fd4f8 Gerrit-Change-Number: 43256 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-iuh[master]: ranap_msg_factory: Fix API documentation regarding ip param endianness
by lynxis lazus 18 Aug '26

18 Aug '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email ) Change subject: ranap_msg_factory: Fix API documentation regarding ip param endianness ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/84db183d_177d7ae1?usp… : PS1, Line 20: an missing space File src/ranap_msg_factory.c: https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/bedf84d0_7d5bb27e?usp… : PS1, Line 794: * \param rtp_ip MGW's RTP IPv4 address in *network* byte order. you may add a comment about the rtp_port as well. https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/bb74ba7f_0051a45c?usp… : PS1, Line 870: uint32_t gtp_tei, bool use_x213_nsap) same as for rtp_port: optional: tei is also in host byte order -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I0a909019875714d35c27aa38dd5520a82d46e8f2 Gerrit-Change-Number: 43257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:24:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-iuh[master]: iu_helpers: Constify osmo_sockaddr input param
by lynxis lazus 18 Aug '26

18 Aug '26

Attention is currently required from: fixeria, osmith, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43256?usp=email ) Change subject: iu_helpers: Constify osmo_sockaddr input param ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I86040373c075bbd84c2a21abc61a880e307fd4f8 Gerrit-Change-Number: 43256 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:21:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in simtrace2[master]: firmware: Implement debug command via USB control vendor class
by pespin 18 Aug '26

18 Aug '26

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email ) Change subject: firmware: Implement debug command via USB control vendor class ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6 Gerrit-Change-Number: 43005 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:19:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in simtrace2[master]: firmware: Add talloc_report_buf() encode the allocation by bits
by pespin 18 Aug '26

18 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email ) Change subject: firmware: Add talloc_report_buf() encode the allocation by bits ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3a8ddbe4100f342db2c59ad1fb9aa0014efc62b8 Gerrit-Change-Number: 43004 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:18:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in simtrace2[master]: firmware: Drop CEMU_TX_DATA when emulated sim is in-active
by pespin 18 Aug '26

18 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email ) Change subject: firmware: Drop CEMU_TX_DATA when emulated sim is in-active ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I796e548225a742cddfde12bd6a60e4d2e5c04c8f Gerrit-Change-Number: 43003 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Aug 2026 09:16:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: tests/sms: Validate gsm_septet_pack2() succeeds
by pespin 18 Aug '26

18 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/43265?usp=email ) Change subject: tests/sms: Validate gsm_septet_pack2() succeeds ...................................................................... tests/sms: Validate gsm_septet_pack2() succeeds Related: Coverity CID#562694 Change-Id: I12583ce07e7885974225ce0118f737c4a5f9bcfd --- M tests/sms/sms_test.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/43265/1 diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c index dda3c56..d9c1c8f 100644 --- a/tests/sms/sms_test.c +++ b/tests/sms/sms_test.c @@ -381,6 +381,7 @@ /* In our case: test_multiple_decode[0].ud_hdr_ind equals number of padding bits*/ octet_length = gsm_septet_pack2(coded, sizeof(coded), tmp, concatenated_part1_septet_length, test_multiple_encode[0].ud_hdr_ind); + OSMO_ASSERT(octet_length == 134); /* copy header */ memset(tmp, 0x42, sizeof(tmp)); @@ -399,6 +400,7 @@ /* In our case: test_multiple_decode[1].ud_hdr_ind equals number of padding bits*/ octet_length = gsm_septet_pack2(coded, sizeof(coded), tmp, concatenated_part2_septet_length, test_multiple_encode[1].ud_hdr_ind); + OSMO_ASSERT(octet_length == 36); /* copy header */ memset(tmp, 0x42, sizeof(tmp)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I12583ce07e7885974225ce0118f737c4a5f9bcfd Gerrit-Change-Number: 43265 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026