fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/43103?usp=email )
Change subject: tests: speed up InterthreadTest by shrinking the fuzz sleep
......................................................................
tests: speed up InterthreadTest by shrinking the fuzz sleep
qWriter()/mapWriter() each had a 50% chance per iteration (20
iterations) of sleep(1), making the test take up to ~13s just to
exercise thread interleaving. The delay only needs to be long enough
to encourage preemption, not a full second.
Change-Id: Id6bc453f9217ae392dcd3288dfa6784c533f8eb6
---
M tests/CommonLibs/InterthreadTest.cpp
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/tests/CommonLibs/InterthreadTest.cpp b/tests/CommonLibs/InterthreadTest.cpp
index a00980f..523a5bd 100644
--- a/tests/CommonLibs/InterthreadTest.cpp
+++ b/tests/CommonLibs/InterthreadTest.cpp
@@ -30,6 +30,7 @@
#include "Interthread.h"
#include <iostream>
#include <mutex>
+#include <unistd.h>
std::mutex dbg_cout;
@@ -52,7 +53,7 @@
CERR("queue write " << *p);
gQ.write(p);
q_last_write_val = i;
- if (random()%2) sleep(1);
+ if (random()%2) usleep(1000);
}
p = new int;
*p = -1;
@@ -88,7 +89,7 @@
CERR("map write " << *p);
gMap.write(i,p);
m_last_write_val = i;
- if (random()%2) sleep(1);
+ if (random()%2) usleep(1000);
}
return NULL;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43103?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Id6bc453f9217ae392dcd3288dfa6784c533f8eb6
Gerrit-Change-Number: 43103
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42934?usp=email )
Change subject: deps: use a fork of titan.ProtocolEmulations.SCCP
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Well, yes and no. In order to test we want to generate a UDTS manually. […]
This has been sorted out by modifying the test to inject the SCCP UDTS over M3UA directly here: https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/commit/15d8f6f6c9e52e1635a…
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42934?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8c0de4dab088930d5d7a9febcbebcb5e1f9411e8
Gerrit-Change-Number: 42934
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Aug 2026 15:35:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: fixeria.
daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42934?usp=email )
Change subject: deps: use a fork of titan.ProtocolEmulations.SCCP
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> @vyanitskiy@sysmocom. […]
Well, yes and no. In order to test we want to generate a UDTS manually. In reality it is generated from the SCCP protocol stack when it encounters an error.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42934?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8c0de4dab088930d5d7a9febcbebcb5e1f9411e8
Gerrit-Change-Number: 42934
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Aug 2026 15:09:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43105?usp=email )
Change subject: libosmo-trx/trxd: support NOPE.{ind,req} in TRXDv0/v1 PDUs
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43105?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1a59f31d0f00c8509a016dc2bac71b6aa467f3a4
Gerrit-Change-Number: 43105
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Aug 2026 14:59:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes