Attention is currently required from: dexter, laforge.
lynxis lazus has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/43238?usp=email )
Change subject: sim: fix APDU case detection for EMV commands under CLA=0x80
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I think the proper way to address this is not to "pollute" the ETSI UICC tables for CLA=0x80, but to […]
I agree with laforge. About the GET DATA mis-detection, this is currently under review here: https://gerrit.osmocom.org/c/simtrace2/+/43185
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43238?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6424397cb888f372fb44b4e984adf3ab8f4cd40b
Gerrit-Change-Number: 43238
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Aug 2026 11:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter, laforge.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email )
Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
......................................................................
Patch Set 9:
(1 comment)
File host/lib/apdu_dispatch.c:
https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/113807df_c2712dd1?us… :
PS3, Line 120: ac->hdr.cla & 0x80 && /* check for GP */
> From what I can see the behavior is not GP specific. The ETSI TS 102 221 Table 7. […]
for the record: I removed the dependency on GP and on the GET DATA APDU to have it more generic.
Instead I exclude it, if the last APDU was a case 4.
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247
Gerrit-Change-Number: 43185
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Aug 2026 11:06:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, laforge, lynxis lazus.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Code-Review+1 by dexter, Verified+1 by Jenkins Builder
Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
......................................................................
Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
osmo_apdu_segment_in() doesn't have the context of the previous APDU,
for nearly all calls this is fine, except for GP GET DATA, which can be
a case 2 or case 4 APDU.
GP GET DATA defines the Le field as 0x00 which is used by osmo_apdu_segment_in
to detect if it is a case 2 or case 4.
However a card can respond with the SW 6cXX, which means the previous
command must be resend with a Le field XX, which got misinterpreted by
the osmo_apdu_segment_in() as a case 4 resulting in a timeout waiting for
more data.
Modem <-> Card
81cadf2000 ->
<- 6c0b
81cadf200b ->
-- Simtrace waits for more data because it wrongly decodes it as APDU case 4
instead of case 2.
Related: SYS#8147
Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247
---
M TODO-RELEASE
M host/Makefile.am
M host/configure.ac
M host/include/osmocom/simtrace2/apdu_dispatch.h
M host/lib/apdu_dispatch.c
A host/tests/Makefile.am
A host/tests/apdu_dispatch/Makefile.am
A host/tests/apdu_dispatch/apdu_dispatch_test.c
A host/tests/apdu_dispatch/apdu_dispatch_test.ok
A host/tests/testsuite.at
10 files changed, 197 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/85/43185/9
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247
Gerrit-Change-Number: 43185
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, jolly.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42969?usp=email )
Change subject: IPAd: Update nvstate.bin to SGP.32 Version 1.2
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42969?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3d22980f5f8be546f0d80423b3bd80d197aa8872
Gerrit-Change-Number: 42969
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Aug 2026 10:11:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43266?usp=email )
Change subject: Add start and stop functions to PIPEasp
......................................................................
Add start and stop functions to PIPEasp
In order to start a process in the background, add a start function that
does not wait for the process to terminate. Also add a stop function
that kills the process and flushes the receive buffer.
Related: SYS#8101
Change-Id: I5be804e5fa7b9a135cceaf07ac4157895a222b40
---
M library/PIPEasp_Templates.ttcn
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/43266/1
diff --git a/library/PIPEasp_Templates.ttcn b/library/PIPEasp_Templates.ttcn
index 0775a5e..85a8656 100644
--- a/library/PIPEasp_Templates.ttcn
+++ b/library/PIPEasp_Templates.ttcn
@@ -70,4 +70,22 @@
return f_PIPEasp_exec_sync_PResult(pt, cmdline, tr_PResult(?, ?, rc));
}
+function f_PIPEasp_exec_async_start(PIPEasp_PT pt,
+ charstring cmdline,
+ charstring stdin := "") {
+ pt.send(ts_PExecute(cmdline, stdin));
+}
+
+function f_PIPEasp_exec_async_stop(PIPEasp_PT pt,
+ charstring progname) {
+ timer t_flush := 0.5;
+
+ pt.send(ts_PExecute("pkill -f " & progname, ""))
+
+ t_flush.start;
+ alt {
+ [] pt.receive { repeat; }
+ [] t_flush.timeout { }
+ }
+}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43266?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5be804e5fa7b9a135cceaf07ac4157895a222b40
Gerrit-Change-Number: 43266
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43267?usp=email )
Change subject: Add log message for unexpected result in PIPEasp function
......................................................................
Add log message for unexpected result in PIPEasp function
If the expected result is not received by the exec function, the test
case will fail with a log message of the unexpected result, rather than
waiting for the timeout.
Related: SYS#8101
Change-Id: Ic20f4b23050940348879512d6c8b78c1ae70e75d
---
M library/PIPEasp_Templates.ttcn
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/43267/1
diff --git a/library/PIPEasp_Templates.ttcn b/library/PIPEasp_Templates.ttcn
index 85a8656..738bf57 100644
--- a/library/PIPEasp_Templates.ttcn
+++ b/library/PIPEasp_Templates.ttcn
@@ -55,6 +55,10 @@
alt {
[] pt.receive(res_exp) -> value res;
+ [] pt.receive(tr_PResult(?,?,?)) -> value res {
+ setverdict(fail, "Unexpected result: ", res);
+ mtc.stop;
+ }
[time_out > 0.0] t.timeout {
setverdict(fail, "Timeout: ", cmdline);
mtc.stop;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43267?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic20f4b23050940348879512d6c8b78c1ae70e75d
Gerrit-Change-Number: 43267
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>