Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email )
Change subject: ranap_msg_factory: Fix API documentation regarding ip param endianness ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/c14f0955_6cbdd037?usp=... : PS1, Line 20: an
missing space
Done
File src/ranap_msg_factory.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/a421604e_9528d09e?usp=... : PS1, Line 794: * \param rtp_ip MGW's RTP IPv4 address in *network* byte order.
you may add a comment about the rtp_port as well.
I'll better improve the doc on the next patch where I'm adding the new API.
https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/bdf0275c_53d4cc4f?usp=... : PS1, Line 870: uint32_t gtp_tei, bool use_x213_nsap)
same as for rtp_port: optional: tei is also in host byte order
Done