Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43258?usp=email )

Change subject: ranap: Introduce new APIs to encode rab_ass for gtp and rtp ......................................................................

Patch Set 1: Code-Review+1

(3 comments)

File include/osmocom/ranap/ranap_msg_factory.h:

https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/f5839ec9_b34aae84?usp=... : PS1, Line 47: struct msgb *ranap_new_msg_rab_assign_voice2(uint8_t rab_id, const struct osmo_sockaddr *rtp_addr, the indention of the args looks weird, but fine.

https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/1c4e422d_a3c77756?usp=... : PS1, Line 56: uint32_t gtp_tei, the indention of the args looks weird, but fine.

File src/ranap_msg_factory.c:

https://gerrit.osmocom.org/c/osmo-iuh/+/43258/comment/e3800d28_a7c94227?usp=... : PS1, Line 975: .sin_port = htons(2152), You set a port here, which the old code doesn't. However the port is ignored later by ranap_new_transp_layer_addr()