Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

3 comments:

• File include/osmocom/ranap/ranap_msg_factory.h:

  • Patch Set #1, Line 47: struct msgb *ranap_new_msg_rab_assign_voice2(uint8_t rab_id, const struct osmo_sockaddr *rtp_addr,

    the indention of the args looks weird, but fine.

  • Patch Set #1, Line 56: uint32_t gtp_tei,

    the indention of the args looks weird, but fine.

• File src/ranap_msg_factory.c:

  • Patch Set #1, Line 975: .sin_port = htons(2152),

    You set a port here, which the old code doesn't.
    However the port is ignored later by ranap_new_transp_layer_addr()

To view, visit change 43258. To unsubscribe, or for help writing mail filters, visit settings.