June 2026 - gerrit-log - lists.osmocom.org

[XS] Change in onomondo-ipa[master]: utils: ignore Waddress in IPA_STR_FROM_ASN
by osmith 22 Jun '26

22 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42861?usp=email ) Change subject: utils: ignore Waddress in IPA_STR_FROM_ASN ...................................................................... utils: ignore Waddress in IPA_STR_FROM_ASN When building with -Werror, GCC complains about this assert in the macro: #define IPA_STR_FROM_ASN(asn1_obj) ({ \ char *__str; \ assert(asn1_obj); \ <----------------------------------------------- __str = IPA_ALLOC_N((asn1_obj)->size + 1); \ assert(__str); \ memcpy(__str, (asn1_obj)->buf, (asn1_obj)->size); \ __str[(asn1_obj)->size] = '\0'; \ __str; \ }) For example: …/src/ipa/libipa/es10b_get_eim_cfg_data.c:48:21: error: the comparison will always evaluate as ‘true’ for the address of ‘eimId’ will never be NULL [-Werror=address] 48 | IPA_STR_FROM_ASN(&res->res->eimConfigurationDataList.list.array[i]->eimId); Add pragmas to ignore the error, so it can still assert if somebody should pass NULL to the macro. Change-Id: Ia2ef30880dd3e5b2ab90eedd0046a95a22614a81 --- M src/ipa/libipa/utils.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/61/42861/1 diff --git a/src/ipa/libipa/utils.h b/src/ipa/libipa/utils.h index 8ae5b66..2f95ecd 100644 --- a/src/ipa/libipa/utils.h +++ b/src/ipa/libipa/utils.h @@ -100,7 +100,10 @@ * \returns null terminated char array with contents of asn1_obj. */ #define IPA_STR_FROM_ASN(asn1_obj) ({ \ char *__str; \ + _Pragma("GCC diagnostic push") \ + _Pragma("GCC diagnostic ignored \"-Waddress\"") \ assert(asn1_obj); \ + _Pragma("GCC diagnostic pop") \ __str = IPA_ALLOC_N((asn1_obj)->size + 1); \ assert(__str); \ memcpy(__str, (asn1_obj)->buf, (asn1_obj)->size); \ -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ia2ef30880dd3e5b2ab90eedd0046a95a22614a81 Gerrit-Change-Number: 42861 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: gitignore: add build dir
by osmith 22 Jun '26

22 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42863?usp=email ) Change subject: gitignore: add build dir ...................................................................... gitignore: add build dir Change-Id: Iea8f79b4094ed79f64b0ed6d6e34212ebaea0c43 --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/63/42863/1 diff --git a/.gitignore b/.gitignore index 5d00c85..1e00c3b 100644 --- a/.gitignore +++ b/.gitignore @@ -94,3 +94,5 @@ # Application src/ipa/ipa +# CMake builddir +build/ -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Iea8f79b4094ed79f64b0ed6d6e34212ebaea0c43 Gerrit-Change-Number: 42863 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: contrib/jenkins: build with -Werror
by osmith 22 Jun '26

22 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42862?usp=email ) Change subject: contrib/jenkins: build with -Werror ...................................................................... contrib/jenkins: build with -Werror Now that all warnings are fixed, let's build with Werror in CI. Change-Id: I8a8a7bc8a10e8d86a09fbd289b00641c19c3be6e --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/62/42862/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 736d3e3..f74de3d 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -3,6 +3,9 @@ mkdir build cd build -cmake -DENABLE_SANITIZE=ON ../ +cmake \ + -DENABLE_SANITIZE=ON \ + -DCMAKE_COMPILE_WARNING_AS_ERROR=ON \ + ../ make -j$(nproc) make test -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I8a8a7bc8a10e8d86a09fbd289b00641c19c3be6e Gerrit-Change-Number: 42862 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: contrib/jenkins: new script
by osmith 22 Jun '26

22 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42858?usp=email ) Change subject: contrib/jenkins: new script ...................................................................... contrib/jenkins: new script Add a script for build verifications on https://jenkins.osmocom.org. Related: SYS#8103 Change-Id: I0305c3196896667f4963853099d0767e0acbdb30 --- A contrib/jenkins.sh 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/58/42858/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..736d3e3 --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,8 @@ +#!/bin/sh -ex +# Build script for https://jenkins.osmocom.org/ + +mkdir build +cd build +cmake -DENABLE_SANITIZE=ON ../ +make -j$(nproc) +make test -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42858?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I0305c3196896667f4963853099d0767e0acbdb30 Gerrit-Change-Number: 42858 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: contrib/jenkins: new script
by osmith 22 Jun '26

22 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42857?usp=email ) Change subject: contrib/jenkins: new script ...................................................................... contrib/jenkins: new script Add a script for build verifications on https://jenkins.osmocom.org. Related: SYS#8103 Change-Id: Id5f282fd1e3403be3b5d2fcb962c2dda62bae905 --- A contrib/jenkins.sh 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/57/42857/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..e39a69a --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,5 @@ +#!/bin/sh -ex +# Build script for https://jenkins.osmocom.org/ + +rebar3 compile +rebar3 eunit -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42857?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Id5f282fd1e3403be3b5d2fcb962c2dda62bae905 Gerrit-Change-Number: 42857 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: euicc: extend get_profiles_info to retrieve all known tags
by dexter 22 Jun '26

22 Jun '26

Attention is currently required from: lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/42057?usp=email ) Change subject: euicc: extend get_profiles_info to retrieve all known tags ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42057?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia6878519a480bd625bb1fa2567c1fd2e0e89b071 Gerrit-Change-Number: 42057 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 22 Jun 2026 09:55:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: euicc: get_profiles_info: add additional tags
by dexter 22 Jun '26

22 Jun '26

Attention is currently required from: lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/42058?usp=email ) Change subject: euicc: get_profiles_info: add additional tags ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File pySim/euicc.py: https://gerrit.osmocom.org/c/pysim/+/42058/comment/f2615427_1bbf8013?usp=em… : PS1, Line 232: _construct = GreedyBytes > in rsp.asn ProfileInfo the NotificationConfigurationInfo comes before the ProfilePolicyRules. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I727dbe34d87a42bb3b526bd7a8accd687d20a208 Gerrit-Change-Number: 42058 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 22 Jun 2026 09:55:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Check if reader times out after first status word
by jolly 22 Jun '26

22 Jun '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42856?usp=email ) Change subject: CCID: Check if reader times out after first status word ...................................................................... CCID: Check if reader times out after first status word A case 1 APDU is sent towards the reader. The reader expects two status words. If only the first word is sent by the SIM, the reader must timeout and send an error message back to the host. Change-Id: Ic5b892e356c13808555d75746c48c6d8c96ec462 --- M ccid/CCID_Tests.ttcn 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/42856/1 diff --git a/ccid/CCID_Tests.ttcn b/ccid/CCID_Tests.ttcn index a06c878..0988ae7 100644 --- a/ccid/CCID_Tests.ttcn +++ b/ccid/CCID_Tests.ttcn @@ -1045,6 +1045,44 @@ f_start_and_wait(); } +/* The SIM responds with one status word only. */ +private function f_TC_status_word_incomplete() runs on CardemSlot_CT +{ + var octetstring req := c_UICC_MANAGE_CHANNEL; + var octetstring res := '62'O; + var CCID_PDU ccid_pdu; + + f_cardem_manager(); + + f_ccid_power_on(CCID_PWRSEL_3V0); + + /* Send a request towards reader. */ + CCID.send(ts_CCID_XfrBlock(g_slot_nr, req, 0)); + /* Receive the request by SIM. */ + f_cardem_receive(tr_SIMTRACE_CEMU_RX_DATA(?, req)); + /* Transmit the response by SIM. */ + f_cardem_transmit(ts_SIMTRACE_CEMU_TX_DATA(ts_CardEmu_DataFlags(pb_and_tx := true, final := true), + res)); + /* Receive the response from reader. */ + ccid_pdu := f_ccid_receive(tr_CCID_DataBlock(g_slot_nr, ?, ?, ?)); + if (ccid_pdu.hdr_in.bError != CCID_ERR_ICC_MUTE) { + setverdict(fail, "Unexpected Response or error code"); + mtc.stop; + } + + /* Stop simtrace emulation, to prevent race condition. */ + vc_Cardem.stop; + vc_Cardem.done; +} +testcase TC_status_word_incomplete() runs on Test_CT +{ + f_init(); + + f_start_handler(refers(f_TC_status_word_timeout), mp_simtrace_slot, true); + + f_start_and_wait(); +} + /* TODO */ /* IccPowerOn with wrong voltage (> 0x04) */ @@ -1093,6 +1131,7 @@ execute( TC_truncated_response() ); execute( TC_empty_slot() ); execute( TC_status_word_timeout() ); + execute( TC_status_word_incomplete() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic5b892e356c13808555d75746c48c6d8c96ec462 Gerrit-Change-Number: 42856 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Send a wrong procedure byte towards the reader
by jolly 22 Jun '26

22 Jun '26

Attention is currently required from: Hoernchen, jolly, laforge. Hello Hoernchen, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42796?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: CCID: Send a wrong procedure byte towards the reader ...................................................................... CCID: Send a wrong procedure byte towards the reader A case 3 request is send and a response with data is expected, but the first byte replied by the sim is not a procedure byte, nor a valid status byte. This text expects the reader to return an error that states an incorrect received procedure byte. Change-Id: Iaa0bd8845b3408fba309874fe41c855d8e7efccc --- M ccid/CCID_Tests.ttcn 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/42796/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa0bd8845b3408fba309874fe41c855d8e7efccc Gerrit-Change-Number: 42796 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: param_source: use random.SystemRandom as random nr source
by laforge 22 Jun '26

22 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/40829?usp=email ) Change subject: param_source: use random.SystemRandom as random nr source ...................................................................... param_source: use random.SystemRandom as random nr source Python's random module uses a PRNG (Mersenne Twister) which is utterly insecure for key generation - it was so far only used for testing. Replace it with random.SystemRandom(), which draws from /dev/urandom and is suitable for generating cryptographic key material. Change-Id: I6de38c14ac6dd55bc84d53974192509c18d02bfa Jenkins: skip-card-test --- M pySim/esim/saip/param_source.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/saip/param_source.py b/pySim/esim/saip/param_source.py index 04a44fed..d3c98a6 100644 --- a/pySim/esim/saip/param_source.py +++ b/pySim/esim/saip/param_source.py @@ -124,7 +124,7 @@ return "%0*d" % (self.num_digits, val) # pylint: disable=consider-using-f-string class RandomSourceMixin: - random_impl = random # TODO secure random source? + random_impl = random.SystemRandom() class RandomDigitSource(DecimalRangeSource, RandomSourceMixin): """return a different sequence of random decimal digits each""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6de38c14ac6dd55bc84d53974192509c18d02bfa Gerrit-Change-Number: 40829 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026