June 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Add test case to verify proper DSCP settings
by laforge 05 Jun '26

05 Jun '26

Attention is currently required from: jolly, pespin. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email ) Change subject: Add test case to verify proper DSCP settings ...................................................................... Removed Code-Review-1 by pespin <pespin(a)sysmocom.de> -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 Gerrit-Change-Number: 42809 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Add DSCP configuration support for server transport role
by laforge 05 Jun '26

05 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email ) Change subject: Add DSCP configuration support for server transport role ...................................................................... Add DSCP configuration support for server transport role Introduce VTY command to configure the Differentiated Services Code Point (DSCP) values for transport "role" server. The configured DSCP value is applied to the listener socket. Incoming socket connections will then automatically inherit these DSCP settings from the listener socket. It is not (yet) possible to configure DSCP values for individual active server connections. The setting applies globally via the listener. A later patch will allow DSCP configuration of each individual ASP. Related: SYS#8071 Depends: libosmo-netif.git Change-Id Ic70422ec73c753b61843444582f8665ca42e7a6d Change-Id: I35eab3672157c318616f51ee3042243aed263d4e --- M TODO-RELEASE M src/ss7_vty.h M src/ss7_xua_srv.c M src/ss7_xua_srv.h M src/ss7_xua_srv_vty.c 5 files changed, 46 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index ef38361..7c51822 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmo-asn1-tcap >0.2.1 osmo_asn1_tcap_TCMessage_decode() +libosmo-netif >1.7.0 Stream-Server: Also apply DSCP settings on listening socket diff --git a/src/ss7_vty.h b/src/ss7_vty.h index 18dc5a6..1d99cad 100644 --- a/src/ss7_vty.h +++ b/src/ss7_vty.h @@ -37,6 +37,9 @@ "SCTP (Stream Control Transmission Protocol)\n" \ "TCP (Transmission Control Protocol)\n" +#define IP_DSCP_RANGE_STR "<0-63>" +#define IP_DSCP_RANGE_HELP_STR "IP Differentiated Service Code Point\n" + #define QOS_CLASS_RANGE_STR "<0-7>" #define QOS_CLASS_RANGE_HELP_STR "QoS Class\n" #define QOS_CLASS_VAR_STR "(" QOS_CLASS_RANGE_STR "|default)" diff --git a/src/ss7_xua_srv.c b/src/ss7_xua_srv.c index c080f63..96a20bc 100644 --- a/src/ss7_xua_srv.c +++ b/src/ss7_xua_srv.c @@ -402,6 +402,15 @@ return false; } +bool ss7_xua_server_set_ip_dscp(struct osmo_xua_server *xs) +{ + if (!xs->server) + return false; + if (xs->cfg.ip_dscp != 0) + osmo_stream_srv_link_set_ip_dscp(xs->server, xs->cfg.ip_dscp); + return true; +} + void ss7_xua_server_destroy(struct osmo_xua_server *xs) { struct osmo_ss7_asp *asp, *asp2; diff --git a/src/ss7_xua_srv.h b/src/ss7_xua_srv.h index 1eaf754..7eb00c2 100644 --- a/src/ss7_xua_srv.h +++ b/src/ss7_xua_srv.h @@ -27,6 +27,7 @@ struct { bool accept_dyn_reg; struct osmo_ss7_asp_peer local; + uint8_t ip_dscp; enum osmo_ss7_asp_protocol proto; struct { bool num_ostreams_present; @@ -70,6 +71,7 @@ ss7_xua_server_set_local_hosts(struct osmo_xua_server *xs, const char **local_hosts, size_t local_host_cnt); int ss7_xua_server_add_local_host(struct osmo_xua_server *xs, const char *local_host); int ss7_xua_server_del_local_host(struct osmo_xua_server *xs, const char *local_host); +bool ss7_xua_server_set_ip_dscp(struct osmo_xua_server *oxs); void ss7_xua_server_destroy(struct osmo_xua_server *xs); bool ss7_xua_server_set_default_local_hosts(struct osmo_xua_server *oxs); diff --git a/src/ss7_xua_srv_vty.c b/src/ss7_xua_srv_vty.c index 3a5e4ae..5ee395b 100644 --- a/src/ss7_xua_srv_vty.c +++ b/src/ss7_xua_srv_vty.c @@ -148,6 +148,33 @@ return CMD_SUCCESS; } +DEFUN_ATTR(xua_init_ip_dscp, xua_init_ip_dscp_cmd, + "init-ip-dscp " IP_DSCP_RANGE_STR, + "Specify IP DSCP of Listener\n" + IP_DSCP_RANGE_HELP_STR, + CMD_ATTR_IMMEDIATE) +{ + struct osmo_xua_server *xs = vty->index; + + xs->cfg.ip_dscp = atoi(argv[0]); + ss7_xua_server_set_ip_dscp(xs); + + return CMD_SUCCESS; +} + +DEFUN_ATTR(xua_no_init_ip_dscp, xua_no_init_ip_dscp_cmd, + "no init-ip-dscp", + NO_STR "Specify IP DSCP of Listener\n", + CMD_ATTR_IMMEDIATE) +{ + struct osmo_xua_server *xs = vty->index; + + xs->cfg.ip_dscp = 0; + ss7_xua_server_set_ip_dscp(xs); + + return CMD_SUCCESS; +} + DEFUN_ATTR(xua_accept_dyn_asp, xua_accept_dyn_asp_cmd, "accept-asp-connections (pre-configured|dynamic-permitted)", "Define what kind of ASP connections to accept\n" @@ -225,6 +252,8 @@ if (xs->cfg.local.host[i]) vty_out(vty, " local-ip %s%s", xs->cfg.local.host[i], VTY_NEWLINE); } + if (xs->cfg.ip_dscp) + vty_out(vty, " init-ip-dscp %u%s", xs->cfg.ip_dscp, VTY_NEWLINE); if (xs->cfg.accept_dyn_reg) vty_out(vty, " accept-asp-connections dynamic-permitted%s", VTY_NEWLINE); if (xs->cfg.sctp_init.num_ostreams_present) @@ -341,6 +370,8 @@ install_lib_element(L_CS7_NODE, &no_cs7_xua_cmd); install_lib_element(L_CS7_XUA_NODE, &xua_local_ip_cmd); install_lib_element(L_CS7_XUA_NODE, &xua_no_local_ip_cmd); + install_lib_element(L_CS7_XUA_NODE, &xua_init_ip_dscp_cmd); + install_lib_element(L_CS7_XUA_NODE, &xua_no_init_ip_dscp_cmd); install_lib_element(L_CS7_XUA_NODE, &xua_accept_dyn_asp_cmd); install_lib_element(L_CS7_XUA_NODE, &xua_sctp_param_init_cmd); install_lib_element(L_CS7_XUA_NODE, &xua_no_sctp_param_init_cmd); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e Gerrit-Change-Number: 42807 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Add DSCP configuration support for each individual ASP
by laforge 05 Jun '26

05 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email ) Change subject: Add DSCP configuration support for each individual ASP ...................................................................... Add DSCP configuration support for each individual ASP Introduce VTY command to configure the Differentiated Services Code Point (DSCP) values for each Application Server Process. If the ASP connection has the role "server", it will inherit the DSCP settings of the listener, unless it is configured at the ASP connection. Related: SYS#8071 Change-Id: Ia125a392eec5605553809774162675b5249b8494 --- M src/ss7_asp.c M src/ss7_asp.h M src/ss7_asp_vty.c M src/ss7_xua_srv.c M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty 6 files changed, 59 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/ss7_asp.c b/src/ss7_asp.c index c1739f3..c47ee7c 100644 --- a/src/ss7_asp.c +++ b/src/ss7_asp.c @@ -374,6 +374,23 @@ return osmo_sock_multiaddr_del_local_addr(fd, &new_loc_addr, 1); } +int ss7_asp_apply_ip_dscp(const struct osmo_ss7_asp *asp) +{ + int fd = -1; + + LOGPASP(asp, DLSS7, LOGL_INFO, "Set IP DSCP %d\n", asp->cfg.ip_dscp); + + if (asp->cfg.is_server && asp->server) + fd = osmo_stream_srv_get_fd(asp->server); + else if (asp->client) + fd = osmo_stream_cli_get_fd(asp->client); + + if (fd < 0) + return fd; + + return osmo_sock_set_dscp(fd, asp->cfg.ip_dscp); +} + int ss7_asp_apply_peer_primary_address(const struct osmo_ss7_asp *asp) { struct osmo_sockaddr_str addr_str; @@ -816,6 +833,8 @@ osmo_stream_cli_set_local_addrs(asp->client, (const char **)asp->cfg.local.host, asp->cfg.local.host_cnt); osmo_stream_cli_set_local_port(asp->client, asp->cfg.local.port); osmo_stream_cli_set_proto(asp->client, asp->cfg.trans_proto); + if (asp->cfg.ip_dscp != 0) + osmo_stream_cli_set_ip_dscp(asp->client, asp->cfg.ip_dscp); osmo_stream_cli_set_reconnect_timeout(asp->client, 5); osmo_stream_cli_set_connect_cb(asp->client, xua_cli_connect_cb); osmo_stream_cli_set_disconnect_cb(asp->client, xua_cli_disconnect_cb); diff --git a/src/ss7_asp.h b/src/ss7_asp.h index a4e0e2f..a7e8978 100644 --- a/src/ss7_asp.h +++ b/src/ss7_asp.h @@ -138,6 +138,7 @@ struct osmo_ss7_asp_peer local; struct osmo_ss7_asp_peer remote; + uint8_t ip_dscp; uint8_t qos_class; uint32_t quirks; @@ -191,6 +192,7 @@ int ss7_asp_apply_primary_address(const struct osmo_ss7_asp *asp); int ss7_asp_apply_new_local_address(const struct osmo_ss7_asp *asp, unsigned int loc_idx); int ss7_asp_apply_drop_local_address(const struct osmo_ss7_asp *asp, unsigned int loc_idx); +int ss7_asp_apply_ip_dscp(const struct osmo_ss7_asp *asp); void ss7_asp_set_blocked(struct osmo_ss7_asp *asp, bool blocked); void ss7_asp_restart_after_reconfigure(struct osmo_ss7_asp *asp); diff --git a/src/ss7_asp_vty.c b/src/ss7_asp_vty.c index 89fb949..c38b5b8 100644 --- a/src/ss7_asp_vty.c +++ b/src/ss7_asp_vty.c @@ -410,6 +410,29 @@ return CMD_SUCCESS; } +DEFUN_ATTR(asp_ip_dscps, asp_ip_dscp_cmd, + "ip-dscp " IP_DSCP_RANGE_STR, + "Specify IP DSCP of ASP\n" + IP_DSCP_RANGE_HELP_STR, + CMD_ATTR_NODE_EXIT) +{ + struct osmo_ss7_asp *asp = vty->index; + asp->cfg.ip_dscp = atoi(argv[0]); + ss7_asp_apply_ip_dscp(asp); + return CMD_SUCCESS; +} + +DEFUN_ATTR(asp_no_ip_dscps, asp_no_ip_dscp_cmd, + "no ip-dscp", + NO_STR "Reset IP DSCP of ASP to default\n", + CMD_ATTR_NODE_EXIT) +{ + struct osmo_ss7_asp *asp = vty->index; + asp->cfg.ip_dscp = 0; + ss7_asp_apply_ip_dscp(asp); + return CMD_SUCCESS; +} + DEFUN_ATTR(asp_qos_clas, asp_qos_class_cmd, "qos-class " QOS_CLASS_RANGE_STR, "Specify QoS Class of ASP\n" @@ -1381,6 +1404,8 @@ vty_out(vty, " remote-ip %s%s%s", asp->cfg.remote.host[i], asp->cfg.remote.idx_primary == i ? " primary" : "", VTY_NEWLINE); } + if (asp->cfg.ip_dscp != 0) + vty_out(vty, " ip-dscp %u%s", asp->cfg.ip_dscp, VTY_NEWLINE); if (asp->cfg.qos_class) vty_out(vty, " qos-class %u%s", asp->cfg.qos_class, VTY_NEWLINE); vty_out(vty, " role %s%s", osmo_str_tolower(get_value_string(osmo_ss7_asp_role_names, asp->cfg.role)), @@ -1490,6 +1515,8 @@ install_lib_element(L_CS7_ASP_NODE, &asp_no_remote_ip_cmd); install_lib_element(L_CS7_ASP_NODE, &asp_local_ip_cmd); install_lib_element(L_CS7_ASP_NODE, &asp_no_local_ip_cmd); + install_lib_element(L_CS7_ASP_NODE, &asp_ip_dscp_cmd); + install_lib_element(L_CS7_ASP_NODE, &asp_no_ip_dscp_cmd); install_lib_element(L_CS7_ASP_NODE, &asp_qos_class_cmd); install_lib_element(L_CS7_ASP_NODE, &asp_role_cmd); install_lib_element(L_CS7_ASP_NODE, &asp_transport_role_cmd); diff --git a/src/ss7_xua_srv.c b/src/ss7_xua_srv.c index 96a20bc..3d9332d 100644 --- a/src/ss7_xua_srv.c +++ b/src/ss7_xua_srv.c @@ -105,6 +105,9 @@ /* Dynamic ASPs (transport-role=server) may be destroyed as a consequence, re-fetch the ASP: */ asp = ss7_asp_find_by_socket_addr(fd, oxs->cfg.trans_proto); } + /* If ASP uses individual DSCP setting, override the setting from the listener socket. */ + if (asp->cfg.ip_dscp > 0) + osmo_sock_set_dscp(fd, asp->cfg.ip_dscp); } if (!asp && !oxs->cfg.accept_dyn_reg) { diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 359d65e..1b452c8 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -285,6 +285,8 @@ no remote-ip (A.B.C.D|X:X::X:X) local-ip (A.B.C.D|X:X::X:X) [primary] no local-ip (A.B.C.D|X:X::X:X) + ip-dscp <0-63> + no ip-dscp qos-class <0-7> role (sg|asp|ipsp) transport-role (client|server) @@ -315,6 +317,7 @@ no Negate a command or set its defaults remote-ip Specify Remote IP Address of ASP local-ip Specify Local IP Address from which to contact ASP + ip-dscp Specify IP DSCP of ASP qos-class Specify QoS Class of ASP role Specify the xUA role for this ASP transport-role Specify the transport layer role for this ASP @@ -329,6 +332,7 @@ OsmoSTP(config-cs7-asp)# no ? ... + ip-dscp Reset IP DSCP of ASP to default sctp-param Configure SCTP parameters tcp-param Configure TCP parameters destination-audit Configure ASP Auditing (xUA DAUD) diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty index 0b8f4fd..e93e037 100644 --- a/tests/vty/ss7_asp_test.vty +++ b/tests/vty/ss7_asp_test.vty @@ -281,6 +281,8 @@ no remote-ip (A.B.C.D|X:X::X:X) local-ip (A.B.C.D|X:X::X:X) [primary] no local-ip (A.B.C.D|X:X::X:X) + ip-dscp <0-63> + no ip-dscp qos-class <0-7> role (sg|asp|ipsp) transport-role (client|server) @@ -311,6 +313,7 @@ no Negate a command or set its defaults remote-ip Specify Remote IP Address of ASP local-ip Specify Local IP Address from which to contact ASP + ip-dscp Specify IP DSCP of ASP qos-class Specify QoS Class of ASP role Specify the xUA role for this ASP transport-role Specify the transport layer role for this ASP @@ -327,6 +330,7 @@ ... remote-ip Specify Remote IP Address of ASP local-ip Specify Local IP Address from which to contact ASP + ip-dscp Reset IP DSCP of ASP to default sctp-param Configure SCTP parameters tcp-param Configure TCP parameters destination-audit Configure ASP Auditing (xUA DAUD) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia125a392eec5605553809774162675b5249b8494 Gerrit-Change-Number: 42808 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: Also apply DSCP settings on listening socket
by laforge 05 Jun '26

05 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42810?usp=email ) Change subject: Also apply DSCP settings on listening socket ...................................................................... Also apply DSCP settings on listening socket The TOS values should be packets that are sent during handshake. Therefore the DSCP setting must be applied to the listening socket also. Related: SYS#8071 Change-Id: Ic70422ec73c753b61843444582f8665ca42e7a6d --- M src/stream_srv.c 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/stream_srv.c b/src/stream_srv.c index 6c4eada..3c8921e 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -614,6 +614,18 @@ if (ret < 0) return ret; + if (link->ip_dscp > 0) { + int rc; + rc = osmo_sock_set_dscp(ret, link->ip_dscp); + if (rc < 0) { + LOGSLNK(link, LOGL_ERROR, "set_ip_dscp(%u): failed setsockopt err=%d\n", + link->ip_dscp, errno); + close(ret); + link->ofd.fd = -1; + return -EIO; + } + } + link->ofd.fd = ret; if (osmo_fd_register(&link->ofd) < 0) { close(ret); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic70422ec73c753b61843444582f8665ca42e7a6d Gerrit-Change-Number: 42810 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: Also apply DSCP settings on listening socket
by laforge 05 Jun '26

05 Jun '26

Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42810?usp=email ) Change subject: Also apply DSCP settings on listening socket ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic70422ec73c753b61843444582f8665ca42e7a6d Gerrit-Change-Number: 42810 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 05 Jun 2026 07:58:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Add test case to verify proper DSCP settings
by laforge 05 Jun '26

05 Jun '26

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email ) Change subject: Add test case to verify proper DSCP settings ...................................................................... Patch Set 9: Code-Review+2 (1 comment) File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/ef09728a_141ae… : PS7, Line 32: AT_CHECK([python3 -u $abs_top_builddir/tests/vty/vty_test_runner.py -w $abs_top_builddir -p $abs_srcdir -v TestDSCP],, [ignore], [ignore]) > I think that this test is unrelated to vty, so i want to keep it in tests/dscp. […] merging this now as-is, we can always change the way we execute a test after it has been merged. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 Gerrit-Change-Number: 42809 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jun 2026 07:57:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Add DSCP configuration support for each individual ASP
by laforge 05 Jun '26

05 Jun '26

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email ) Change subject: Add DSCP configuration support for each individual ASP ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia125a392eec5605553809774162675b5249b8494 Gerrit-Change-Number: 42808 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jun 2026 07:57:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: Add DSCP configuration support for server transport role
by laforge 05 Jun '26

05 Jun '26

Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email ) Change subject: Add DSCP configuration support for server transport role ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e Gerrit-Change-Number: 42807 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 05 Jun 2026 07:56:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: move podman_extra to testsrcdir.cfg
by osmith 05 Jun '26

05 Jun '26

Attention is currently required from: fixeria, jolly, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42816?usp=email ) Change subject: testenv: move podman_extra to testsrcdir.cfg ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I fail to see why this option has to be set (inconditionally) for all .cfg files. […] The current implementation already sets it once for all cfg files, `testenv.testenv_cfg.get_podman_extra_first_cfg()` gets used when the container starts. But you have a good point, I'll take another look at this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12e187726673e1ca1b1ecfff6b34b1803127be86 Gerrit-Change-Number: 42816 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jun 2026 07:45:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Add VTY test for "listen" node of osmo-stp VTY config
by jolly 05 Jun '26

05 Jun '26

Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817?usp=email ) Change subject: Add VTY test for "listen" node of osmo-stp VTY config ...................................................................... Patch Set 2: (1 comment) File tests/vty/osmo_stp_test.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817/comment/7082afe1_8aebe… : PS1, Line 405: local-ip (A.B.C.D|X:X::X:X) > AFAIU you should only be explicitly expecting the commands added by libosmo-sgitran here, ie. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia1ceb5f0374f47ff269b557be30fc4d59550d1a6 Gerrit-Change-Number: 42817 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jun 2026 07:44:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026