June 2026 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: add test_param_src.py
by laforge 22 Jun '26

22 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/40828?usp=email ) ( 9 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: add test_param_src.py ...................................................................... add test_param_src.py Change-Id: I03087b84030fddae98b965e0075d44e04ec6ba5c Jenkins: skip-card-test --- A tests/unittests/test_param_src.py A tests/unittests/xo/test_param_src 2 files changed, 215 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/unittests/test_param_src.py b/tests/unittests/test_param_src.py new file mode 100755 index 0000000..a230367 --- /dev/null +++ b/tests/unittests/test_param_src.py @@ -0,0 +1,206 @@ +#!/usr/bin/env python3 + +# (C) 2025 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> +# +# Author: Neels Hofmeyr +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +import sys +import math +from importlib import resources +import unittest +from pySim.esim.saip import param_source + +import xo +update_expected_output = False + +class D: + mandatory = set() + optional = set() + + def __init__(self, **kwargs): + if (set(kwargs.keys()) - set(self.optional)) != set(self.mandatory): + raise RuntimeError(f'{self.__class__.__name__}.__init__():' + f' {set(kwargs.keys())=!r} - {self.optional=!r} != {self.mandatory=!r}') + for k, v in kwargs.items(): + setattr(self, k, v) + for k in self.optional: + if not hasattr(self, k): + setattr(self, k, None) + +decimals = '0123456789' +hexadecimals = '0123456789abcdefABCDEF' + +class FakeRandom: + vals = b'\xab\xcfm\xf0\x98J_\xcf\x96\x87fp5l\xe7f\xd1\xd6\x97\xc1\xf9]\x8c\x86+\xdb\t^ke\xc1r' + i = 0 + + @classmethod + def next(cls): + cls.i = (cls.i + 1) % len(cls.vals) + return cls.vals[cls.i] + + @staticmethod + def randint(a, b): + d = b - a + n_bytes = math.ceil(math.log(d, 2)) + r = int.from_bytes( bytes(FakeRandom.next() for i in range(n_bytes)) ) + return a + (r % (b - a)) + + @staticmethod + def randbytes(n): + return bytes(FakeRandom.next() for i in range(n)) + + +class ParamSourceTest(unittest.TestCase): + + def test_param_source(self): + + class Paramtest(D): + mandatory = ( + 'param_source', + 'n', + 'expect', + ) + optional = ( + 'expect_arg', + 'csv_rows', + ) + param_source: param_source.ParamSource + n: int + expect: object + expect_arg: object + csv_rows: object + + def expect_const(t, vals): + return tuple(t.expect_arg) == tuple(vals) + + def expect_random(t, vals): + chars = t.expect_arg.get('digits') + repetitions = (t.n - len(set(vals))) + if repetitions: + raise RuntimeError(f'expect_random: there are {repetitions} repetitions in the returned values: {vals}') + for val_i in range(len(vals)): + v = vals[val_i] + val_minlen = t.expect_arg.get('val_minlen') + val_maxlen = t.expect_arg.get('val_maxlen') + if len(v) < val_minlen or len(v) > val_maxlen: + raise RuntimeError(f'expect_random: invalid length {len(v)} for value [{val_i}]: {v!r}, expecting' + f' {val_minlen}..{val_maxlen}') + + if chars is not None and not all(c in chars for c in v): + raise RuntimeError(f'expect_random: invalid char in value [{val_i}]: {v!r}') + return True + + param_source_tests = [ + Paramtest(param_source=param_source.ConstantSource.from_str('123'), + n=3, + expect=expect_const, + expect_arg=('123', '123', '123')), + Paramtest(param_source=param_source.RandomDigitSource.from_str('12345'), + n=3, + expect=expect_random, + expect_arg={'digits': decimals, + 'val_minlen': 5, + 'val_maxlen': 5}), + Paramtest(param_source=param_source.RandomDigitSource.from_str('1..999'), + n=10, + expect=expect_random, + expect_arg={'digits': decimals, + 'val_minlen': 1, + 'val_maxlen': 3}), + Paramtest(param_source=param_source.RandomDigitSource.from_str('001..999'), + n=10, + expect=expect_random, + expect_arg={'digits': decimals, + 'val_minlen': 3, + 'val_maxlen': 3}), + Paramtest(param_source=param_source.RandomHexDigitSource.from_str('12345678'), + n=3, + expect=expect_random, + expect_arg={'digits': hexadecimals, + 'val_minlen': 8, + 'val_maxlen': 8}), + Paramtest(param_source=param_source.RandomHexDigitSource.from_str('0*8'), + n=3, + expect=expect_random, + expect_arg={'digits': hexadecimals, + 'val_minlen': 8, + 'val_maxlen': 8}), + Paramtest(param_source=param_source.RandomHexDigitSource.from_str('00*4'), + n=3, + expect=expect_random, + expect_arg={'digits': hexadecimals, + 'val_minlen': 8, + 'val_maxlen': 8}), + Paramtest(param_source=param_source.IncDigitSource.from_str('10001'), + n=3, + expect=expect_const, + expect_arg=('10001', '10002', '10003')), + Paramtest(param_source=param_source.CsvSource('column_name'), + n=3, + expect=expect_const, + expect_arg=('first val', 'second val', 'third val'), + csv_rows=( + {'column_name': 'first val'}, + {'column_name': 'second val'}, + {'column_name': 'third val'}, + )), + ] + + outputs = [] + + for t in param_source_tests: + try: + if hasattr(t.param_source, 'random_impl'): + t.param_source.random_impl = FakeRandom + + vals = [] + for i in range(t.n): + csv_row = None + if t.csv_rows is not None: + csv_row = t.csv_rows[i] + vals.append( t.param_source.get_next(csv_row=csv_row) ) + if not t.expect(t, vals): + raise RuntimeError(f'invalid values returned: returned {vals}') + output = f'ok: {t.param_source.__class__.__name__} {vals=!r}' + outputs.append(output) + print(output) + except RuntimeError as e: + raise RuntimeError(f'{t.param_source.__class__.__name__} {t.n=} {t.expect.__name__}({t.expect_arg!r}): {e}') from e + + output = '\n'.join(outputs) + '\n' + xo_name = 'test_param_src' + if update_expected_output: + with resources.path(xo, xo_name) as xo_path: + with open(xo_path, 'w', encoding='utf-8') as f: + f.write(output) + else: + xo_str = resources.read_text(xo, xo_name) + if xo_str != output: + at = 0 + while at < len(output): + if output[at] == xo_str[at]: + at += 1 + continue + break + + raise RuntimeError(f'output differs from expected output at position {at}: {xo_str[at:at+128]!r}') + +if __name__ == "__main__": + if '-u' in sys.argv: + update_expected_output = True + sys.argv.remove('-u') + unittest.main() diff --git a/tests/unittests/xo/test_param_src b/tests/unittests/xo/test_param_src new file mode 100644 index 0000000..d4a947c --- /dev/null +++ b/tests/unittests/xo/test_param_src @@ -0,0 +1,9 @@ +ok: ConstantSource vals=['123', '123', '123'] +ok: RandomDigitSource vals=['13987', '49298', '55670'] +ok: RandomDigitSource vals=['650', '580', '49', '885', '497', '195', '320', '137', '245', '663'] +ok: RandomDigitSource vals=['638', '025', '232', '779', '826', '972', '650', '580', '049', '885'] +ok: RandomHexDigitSource vals=['6b65c172', 'abcf6df0', '984a5fcf'] +ok: RandomHexDigitSource vals=['96876670', '356ce766', 'd1d697c1'] +ok: RandomHexDigitSource vals=['f95d8c86', '2bdb095e', '6b65c172'] +ok: IncDigitSource vals=['10001', '10002', '10003'] +ok: CsvSource vals=['first val', 'second val', 'third val'] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I03087b84030fddae98b965e0075d44e04ec6ba5c Gerrit-Change-Number: 40828 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: personalization.ConfigurableParameter: fix BytesIO() input
by laforge 22 Jun '26

22 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/40824?usp=email ) ( 10 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: personalization.ConfigurableParameter: fix BytesIO() input ...................................................................... personalization.ConfigurableParameter: fix BytesIO() input Change-Id: I0ad160eef9015e76eef10baee7c6b606fe249123 Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py M tests/unittests/test_configurable_parameters.py M tests/unittests/xo/test_configurable_parameters 3 files changed, 43 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 54c8f26..c60a7c2 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -187,6 +187,9 @@ if cls.allow_chars is not None: if any(c not in cls.allow_chars for c in val): raise ValueError(f"invalid characters in input value {val!r}, valid chars are {cls.allow_chars}") + elif isinstance(val, io.BytesIO): + val = val.getvalue() + if cls.allow_len is not None: l = cls.allow_len # cls.allow_len could be one int, or a tuple of ints. Wrap a single int also in a tuple. diff --git a/tests/unittests/test_configurable_parameters.py b/tests/unittests/test_configurable_parameters.py index 3388753..5a8f9d3 100755 --- a/tests/unittests/test_configurable_parameters.py +++ b/tests/unittests/test_configurable_parameters.py @@ -144,6 +144,10 @@ val=bytearray(b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16'), expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', expect_val='01020304050607080910111213141516'), + Paramtest(param_cls=p13n.K, + val=io.BytesIO(b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16'), + expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', + expect_val='01020304050607080910111213141516'), Paramtest(param_cls=p13n.Opc, val='01020304050607080910111213141516', @@ -157,6 +161,10 @@ val=bytearray(b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16'), expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', expect_val='01020304050607080910111213141516'), + Paramtest(param_cls=p13n.Opc, + val=io.BytesIO(b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16'), + expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', + expect_val='01020304050607080910111213141516'), ] # SdKey classes don't make sense yet, will come in Ic92ddea6e1fad8167ea75baf78ffc3eb419838c4 diff --git a/tests/unittests/xo/test_configurable_parameters b/tests/unittests/xo/test_configurable_parameters index 38b4f38..c16a2c8 100644 --- a/tests/unittests/xo/test_configurable_parameters +++ b/tests/unittests/xo/test_configurable_parameters @@ -71,6 +71,10 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.1A_NoBERTLV.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':BytesIO) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + ok: TS48v5_SAIP2.1A_NoBERTLV.der Opc(val= '01020304050607080910111213141516':str) clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} @@ -83,6 +87,10 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.1A_NoBERTLV.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':BytesIO) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Imsi(val= '123456':str) clean_val= '123456':str read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} @@ -155,6 +163,10 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':BytesIO) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Opc(val= '01020304050607080910111213141516':str) clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} @@ -167,6 +179,10 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':BytesIO) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + ok: TS48v5_SAIP2.1B_NoBERTLV.der Imsi(val= '123456':str) clean_val= '123456':str read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} @@ -239,6 +255,10 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.1B_NoBERTLV.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':BytesIO) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + ok: TS48v5_SAIP2.1B_NoBERTLV.der Opc(val= '01020304050607080910111213141516':str) clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} @@ -251,6 +271,10 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.1B_NoBERTLV.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':BytesIO) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + ok: TS48v5_SAIP2.3_NoBERTLV.der Imsi(val= '123456':str) clean_val= '123456':str read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} @@ -323,6 +347,10 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.3_NoBERTLV.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':BytesIO) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + ok: TS48v5_SAIP2.3_NoBERTLV.der Opc(val= '01020304050607080910111213141516':str) clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} @@ -334,3 +362,7 @@ ok: TS48v5_SAIP2.3_NoBERTLV.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytearray) clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':BytesIO) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0ad160eef9015e76eef10baee7c6b606fe249123 Gerrit-Change-Number: 40824 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: ConfigurableParameter: do not magically overwrite the 'name' attribute
by laforge 22 Jun '26

22 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41918?usp=email ) Change subject: ConfigurableParameter: do not magically overwrite the 'name' attribute ...................................................................... ConfigurableParameter: do not magically overwrite the 'name' attribute The ClassVarMeta metaclass used to derive each ConfigurableParameter's 'name' attribute automatically from the Python class name (via camel_to_snake()). Stop doing this, for three reasons: 1) Python class names follow constraints that do not fit the naming commonly used in CSV files. For example, a name like "5GS-SUCI-CalcInfo" starts with a digit and contains dashes, neither of which is permissible in a class name. 2) Python class names live in their own namespace, distinct from the one used to present eSIM parameters to end users. Deriving the UI name from the class name couples these two namespaces together. Taken together, (1) and (2) mean that automatic naming both imposes class-name constraints on the user-visible names and merges the internal Python namespace with the publicly shown one - a layer violation from the perspective of UI design. 3) Overriding 'name' from __new__() makes manual naming impossible: a subclass that sets 'name = "bar"' as a class attribute would still end up with the value computed by the metaclass, which is surprising and hard to track down: class MySuper(metaclass=...): # __new__ sets name = 'foo' ... class MySub(MySuper): name = 'bar' print(MySub().name) # 'foo', not 'bar' as one would expect Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169 Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index eb81934..4799d12 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -52,7 +52,6 @@ x = super().__new__(metacls, name, bases, namespace) for k, v in kwargs.items(): setattr(x, k, v) - setattr(x, 'name', camel_to_snake(name)) return x class ConfigurableParameter(abc.ABC, metaclass=ClassVarMeta): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169 Gerrit-Change-Number: 41918 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in pysim[master]: add test_configurable_parameters.py
by laforge 22 Jun '26

22 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/40823?usp=email ) ( 11 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: add test_configurable_parameters.py ...................................................................... add test_configurable_parameters.py Add ConfigurableParameterTest, which applies each parameter to a real UPP DER template and reads it back, comparing results against a stored expected-output snapshot (xo/test_configurable_parameters). Add TestValidateVal covering validate_val() for Iccid, Imsi, Pin1, Puk1 and K, testing both valid inputs and invalid ones expected to raise ValueError. Add TestEnumParam covering the EnumParam methods (validate_val, map_name_to_val, map_val_to_name, name_normalize, clean_name_str) using AlgorithmID as the concrete subclass, including fuzzy name matching. Also add get_value_from_pes() to ConfigurableParameter as a convenience wrapper around get_values_from_pes() that asserts all returned values are identical and returns the single result. Change-Id: Ia55f0d11f8197ca15a948a83a34b3488acf1a0b4 Co-authored-by: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py A tests/unittests/smdpp_data A tests/unittests/test_configurable_parameters.py A tests/unittests/xo/test_configurable_parameters 4 files changed, 801 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 4799d12..54c8f26 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -209,6 +209,26 @@ pass @classmethod + def get_value_from_pes(cls, pes: ProfileElementSequence): + """Same as get_values_from_pes() but expecting a single value. + get_values_from_pes() may return values like this: + [{ 'AlgorithmID': 'Milenage' }, { 'AlgorithmID': 'Milenage' }] + This ensures that all these entries are identical and would return only + { 'AlgorithmID': 'Milenage' }. + + This is relevant for any profile element that may appear multiple times in the same PES (only a few), + where each occurrence should reflect the same value (all currently known parameters). + """ + + val = None + for v in cls.get_values_from_pes(pes): + if val is None: + val = v + elif val != v: + raise ValueError(f'get_value_from_pes(): got distinct values: {val!r} != {v!r}') + return val + + @classmethod @abc.abstractmethod def get_values_from_pes(cls, pes: ProfileElementSequence) -> Generator: """This is what subclasses implement: yield all values from a decoded profile package. diff --git a/tests/unittests/smdpp_data b/tests/unittests/smdpp_data new file mode 120000 index 0000000..a2d60f8 --- /dev/null +++ b/tests/unittests/smdpp_data @@ -0,0 +1 @@ +../../smdpp-data \ No newline at end of file diff --git a/tests/unittests/test_configurable_parameters.py b/tests/unittests/test_configurable_parameters.py new file mode 100755 index 0000000..3388753 --- /dev/null +++ b/tests/unittests/test_configurable_parameters.py @@ -0,0 +1,444 @@ +#!/usr/bin/env python3 + +# (C) 2025 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> +# +# Author: Neels Hofmeyr +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +import enum +import io +import sys +import unittest +from importlib import resources +from osmocom.utils import hexstr +from pySim.esim.saip import ProfileElementSequence +import pySim.esim.saip.personalization as p13n +import smdpp_data.upp + +import xo +update_expected_output = False + +def valstr(val): + if isinstance(val, io.BytesIO): + val = val.getvalue() + if isinstance(val, bytearray): + val = bytes(val) + return f'{val!r}' + +def valtypestr(val): + if isinstance(val, dict): + types = [] + for v in val.values(): + types.append(f'{type(v).__name__}') + + val_type = '{' + ', '.join(types) + '}' + else: + val_type = f'{type(val).__name__}' + return f'{valstr(val)}:{val_type}' + +class ConfigurableParameterTest(unittest.TestCase): + + def test_parameters(self): + + upp_fnames = ( + 'TS48v5_SAIP2.1A_NoBERTLV.der', + 'TS48v5_SAIP2.3_BERTLV_SUCI.der', + 'TS48v5_SAIP2.1B_NoBERTLV.der', + 'TS48v5_SAIP2.3_NoBERTLV.der', + ) + + class Paramtest: + def __init__(self, param_cls, val, expect_val, expect_clean_val=None): + self.param_cls = param_cls + self.val = val + self.expect_clean_val = expect_clean_val + self.expect_val = expect_val + + param_tests = [ + Paramtest(param_cls=p13n.Imsi, val='123456', + expect_clean_val=str('123456'), + expect_val={'IMSI': hexstr('123456'), + 'IMSI-ACC': '0040'}), + Paramtest(param_cls=p13n.Imsi, val=int(123456), + expect_val={'IMSI': hexstr('123456'), + 'IMSI-ACC': '0040'}), + + Paramtest(param_cls=p13n.Imsi, val='123456789012345', + expect_clean_val=str('123456789012345'), + expect_val={'IMSI': hexstr('123456789012345'), + 'IMSI-ACC': '0020'}), + Paramtest(param_cls=p13n.Imsi, val=int(123456789012345), + expect_val={'IMSI': hexstr('123456789012345'), + 'IMSI-ACC': '0020'}), + + Paramtest(param_cls=p13n.Puk1, + val='12345678', + expect_clean_val=b'12345678', + expect_val='12345678'), + + Paramtest(param_cls=p13n.Puk2, + val='12345678', + expect_clean_val=b'12345678', + expect_val='12345678'), + + Paramtest(param_cls=p13n.Pin1, + val='1234', + expect_clean_val=b'1234\xff\xff\xff\xff', + expect_val='1234'), + Paramtest(param_cls=p13n.Pin1, + val='123456', + expect_clean_val=b'123456\xff\xff', + expect_val='123456'), + Paramtest(param_cls=p13n.Pin1, + val='12345678', + expect_clean_val=b'12345678', + expect_val='12345678'), + + Paramtest(param_cls=p13n.Adm1, + val='1234', + expect_clean_val=b'1234\xff\xff\xff\xff', + expect_val='1234'), + Paramtest(param_cls=p13n.Adm1, + val='123456', + expect_clean_val=b'123456\xff\xff', + expect_val='123456'), + Paramtest(param_cls=p13n.Adm1, + val='12345678', + expect_clean_val=b'12345678', + expect_val='12345678'), + + Paramtest(param_cls=p13n.AlgorithmID, + val='Milenage', + expect_clean_val=1, + expect_val='Milenage'), + Paramtest(param_cls=p13n.AlgorithmID, + val='TUAK', + expect_clean_val=2, + expect_val='TUAK'), + Paramtest(param_cls=p13n.AlgorithmID, + val='usim-test', + expect_clean_val=3, + expect_val='usim_test'), + + Paramtest(param_cls=p13n.K, + val='01020304050607080910111213141516', + expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', + expect_val='01020304050607080910111213141516'), + Paramtest(param_cls=p13n.K, + val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', + expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', + expect_val='01020304050607080910111213141516'), + Paramtest(param_cls=p13n.K, + val=bytearray(b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16'), + expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', + expect_val='01020304050607080910111213141516'), + + Paramtest(param_cls=p13n.Opc, + val='01020304050607080910111213141516', + expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', + expect_val='01020304050607080910111213141516'), + Paramtest(param_cls=p13n.Opc, + val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', + expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', + expect_val='01020304050607080910111213141516'), + Paramtest(param_cls=p13n.Opc, + val=bytearray(b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16'), + expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', + expect_val='01020304050607080910111213141516'), + ] + + # SdKey classes don't make sense yet, will come in Ic92ddea6e1fad8167ea75baf78ffc3eb419838c4 + + outputs = [] + + for upp_fname in upp_fnames: + test_idx = -1 + try: + + der = resources.read_binary(smdpp_data.upp, upp_fname) + + for t in param_tests: + test_idx += 1 + logloc = f'{upp_fname} {t.param_cls.__name__}(val={valtypestr(t.val)})' + + param = None + try: + param = t.param_cls() + param.input_value = t.val + param.validate() + except ValueError as e: + raise ValueError(f'{logloc}: {e}') from e + + clean_val = param.value + logloc = f'{logloc} clean_val={valtypestr(clean_val)}' + if t.expect_clean_val is not None and t.expect_clean_val != clean_val: + raise ValueError(f'{logloc}: expected' + f' expect_clean_val={valtypestr(t.expect_clean_val)}') + + # on my laptop, deepcopy is about 30% slower than decoding the DER from scratch: + # pes = copy.deepcopy(orig_pes) + pes = ProfileElementSequence.from_der(der) + try: + param.apply(pes) + except ValueError as e: + raise ValueError(f'{logloc} apply_val(clean_val): {e}') from e + + changed_der = pes.to_der() + + pes2 = ProfileElementSequence.from_der(changed_der) + + read_back_val = t.param_cls.get_value_from_pes(pes2) + + # compose log string to show the precise type of dict values + if isinstance(read_back_val, dict): + types = set() + for v in read_back_val.values(): + types.add(f'{type(v).__name__}') + + read_back_val_type = '{' + ', '.join(types) + '}' + else: + read_back_val_type = f'{type(read_back_val).__name__}' + + logloc = (f'{logloc} read_back_val={valtypestr(read_back_val)}') + + if isinstance(read_back_val, dict) and not t.param_cls.get_name() in read_back_val.keys(): + raise ValueError(f'{logloc}: expected to find name {t.param_cls.get_name()!r} in read_back_val') + + expect_val = t.expect_val + if not isinstance(expect_val, dict): + expect_val = { t.param_cls.get_name(): expect_val } + if read_back_val != expect_val: + raise ValueError(f'{logloc}: expected {expect_val=!r}:{type(t.expect_val).__name__}') + + ok = logloc.replace(' clean_val', '\n\tclean_val' + ).replace(' read_back_val', '\n\tread_back_val' + ).replace('=', '=\t' + ) + output = f'\nok: {ok}' + outputs.append(output) + print(output) + + except Exception as e: + raise RuntimeError(f'Error while testing UPP {upp_fname} {test_idx=}: {e}') from e + + output = '\n'.join(outputs) + '\n' + xo_name = 'test_configurable_parameters' + if update_expected_output: + with resources.path(xo, xo_name) as xo_path: + with open(xo_path, 'w', encoding='utf-8') as f: + f.write(output) + else: + xo_str = resources.read_text(xo, xo_name) + if xo_str != output: + at = 0 + while at < len(output): + if output[at] == xo_str[at]: + at += 1 + continue + break + + raise RuntimeError(f'output differs from expected output at position {at}: "{output[at:at+20]}" != "{xo_str[at:at+20]}"') + + +class TestValidateVal(unittest.TestCase): + """validate_val() tests for various ConfigurableParameter subclasses.""" + + def _ok(self, cls, val, expected=None): + result = cls.validate_val(val) + if expected is not None: + self.assertEqual(result, expected) + return result + + def _err(self, cls, val): + with self.assertRaises(ValueError): + cls.validate_val(val) + + # --- Iccid --- + + def test_iccid_18digits_adds_luhn(self): + result = self._ok(p13n.Iccid, '998877665544332211') + self.assertIsInstance(result, str) + self.assertEqual(len(result), 19) + self.assertTrue(result.isdecimal()) + + def test_iccid_19digits_passthrough(self): + result = self._ok(p13n.Iccid, '9988776655443322110') + self.assertIsInstance(result, str) + self.assertEqual(len(result), 19) + + def test_iccid_too_short(self): + self._err(p13n.Iccid, '12345678901234567') # 17 digits + + def test_iccid_too_long(self): + self._err(p13n.Iccid, '1' * 21) + + def test_iccid_non_digits(self): + self._err(p13n.Iccid, '99887766554433221X') + + # --- Imsi --- + + def test_imsi_valid_short(self): + self._ok(p13n.Imsi, '001010', '001010') + + def test_imsi_valid_long(self): + self._ok(p13n.Imsi, '001010123456789', '001010123456789') + + def test_imsi_too_short(self): + self._err(p13n.Imsi, '12345') # 5 digits, min is 6 + + def test_imsi_too_long(self): + self._err(p13n.Imsi, '1' * 16) + + def test_imsi_non_digits(self): + self._err(p13n.Imsi, '00101A123456789') + + # --- Pin1 --- + + def test_pin1_4digits(self): + # DecimalHexParam encodes each digit as its ASCII byte, then rpad to 8 bytes with 0xff + self._ok(p13n.Pin1, '1234', b'1234\xff\xff\xff\xff') + + def test_pin1_8digits(self): + self._ok(p13n.Pin1, '12345678', b'12345678') + + def test_pin1_too_short(self): + self._err(p13n.Pin1, '123') + + def test_pin1_too_long(self): + self._err(p13n.Pin1, '123456789') + + def test_pin1_non_digits(self): + self._err(p13n.Pin1, '123A') + + # --- Puk1 --- + + def test_puk1_8digits(self): + self._ok(p13n.Puk1, '12345678', b'12345678') + + def test_puk1_wrong_length(self): + self._err(p13n.Puk1, '1234567') # 7 digits + self._err(p13n.Puk1, '123456789') # 9 digits + + def test_puk1_non_digits(self): + self._err(p13n.Puk1, '1234567X') + + # --- K (BinaryParam) --- + + def test_k_valid_hex_str(self): + self._ok(p13n.K, '000102030405060708090a0b0c0d0e0f', + b'\x00\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0a\x0b\x0c\x0d\x0e\x0f') + + def test_k_valid_bytes(self): + raw = bytes(range(16)) + self._ok(p13n.K, raw, raw) + + def test_k_wrong_length(self): + self._err(p13n.K, '00' * 15) # 15 bytes, allow_len requires 16 or 32 + + def test_k_non_hex(self): + self._err(p13n.K, 'gg' * 16) + + def test_k_odd_hex_digits(self): + self._err(p13n.K, '0' * 31) # odd number of hex digits + + +class TestEnumParam(unittest.TestCase): + """Tests for the EnumParam machinery, using AlgorithmID as the concrete subclass.""" + + # --- validate_val --- + + def test_validate_by_name_exact(self): + self.assertEqual(p13n.AlgorithmID.validate_val('Milenage'), 1) + self.assertEqual(p13n.AlgorithmID.validate_val('TUAK'), 2) + self.assertEqual(p13n.AlgorithmID.validate_val('usim_test'), 3) + + def test_validate_by_int(self): + self.assertEqual(p13n.AlgorithmID.validate_val(1), 1) + self.assertEqual(p13n.AlgorithmID.validate_val(2), 2) + self.assertEqual(p13n.AlgorithmID.validate_val(3), 3) + + def test_validate_fuzzy_case(self): + self.assertEqual(p13n.AlgorithmID.validate_val('milenage'), 1) + self.assertEqual(p13n.AlgorithmID.validate_val('MILENAGE'), 1) + self.assertEqual(p13n.AlgorithmID.validate_val('tuak'), 2) + + def test_validate_fuzzy_hyphen_underscore(self): + # 'usim-test' has a hyphen; enum member is 'usim_test' — must fuzzy-match + self.assertEqual(p13n.AlgorithmID.validate_val('usim-test'), 3) + + def test_validate_invalid_name(self): + with self.assertRaises(ValueError): + p13n.AlgorithmID.validate_val('unknown') + + def test_validate_invalid_int(self): + with self.assertRaises(ValueError): + p13n.AlgorithmID.validate_val(99) + + def test_validate_returns_int(self): + result = p13n.AlgorithmID.validate_val('Milenage') + self.assertIsInstance(result, int) + self.assertNotIsInstance(result, enum.Enum) + + # --- map_name_to_val --- + + def test_map_name_exact(self): + self.assertEqual(p13n.AlgorithmID.map_name_to_val('Milenage'), 1) + + def test_map_name_fuzzy(self): + self.assertEqual(p13n.AlgorithmID.map_name_to_val('milenage'), 1) + self.assertEqual(p13n.AlgorithmID.map_name_to_val('usim-test'), 3) + + def test_map_name_strict_raises(self): + with self.assertRaises(ValueError): + p13n.AlgorithmID.map_name_to_val('unknown', strict=True) + + def test_map_name_nonstrict_returns_none(self): + self.assertIsNone(p13n.AlgorithmID.map_name_to_val('unknown', strict=False)) + + # --- map_val_to_name --- + + def test_map_val_known(self): + self.assertEqual(p13n.AlgorithmID.map_val_to_name(1), 'Milenage') + self.assertEqual(p13n.AlgorithmID.map_val_to_name(2), 'TUAK') + self.assertEqual(p13n.AlgorithmID.map_val_to_name(3), 'usim_test') + + def test_map_val_unknown_nonstrict(self): + self.assertIsNone(p13n.AlgorithmID.map_val_to_name(99)) + + def test_map_val_unknown_strict(self): + with self.assertRaises(ValueError): + p13n.AlgorithmID.map_val_to_name(99, strict=True) + + # --- name_normalize --- + + def test_name_normalize(self): + self.assertEqual(p13n.AlgorithmID.name_normalize('Milenage'), 'Milenage') + self.assertEqual(p13n.AlgorithmID.name_normalize('milenage'), 'Milenage') + self.assertEqual(p13n.AlgorithmID.name_normalize('usim-test'), 'usim_test') + + # --- clean_name_str --- + + def test_clean_name_str(self): + self.assertEqual(p13n.AlgorithmID.clean_name_str('usim-test'), 'usimtest') + self.assertEqual(p13n.AlgorithmID.clean_name_str('usim_test'), 'usimtest') + self.assertEqual(p13n.AlgorithmID.clean_name_str('Milenage'), 'milenage') + self.assertEqual(p13n.AlgorithmID.clean_name_str('foo bar!'), 'foobar') + + +if __name__ == "__main__": + if '-u' in sys.argv: + update_expected_output = True + sys.argv.remove('-u') + unittest.main() diff --git a/tests/unittests/xo/test_configurable_parameters b/tests/unittests/xo/test_configurable_parameters new file mode 100644 index 0000000..38b4f38 --- /dev/null +++ b/tests/unittests/xo/test_configurable_parameters @@ -0,0 +1,336 @@ + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Imsi(val= '123456':str) + clean_val= '123456':str + read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Imsi(val= 123456:int) + clean_val= '123456':str + read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Imsi(val= '123456789012345':str) + clean_val= '123456789012345':str + read_back_val= {'IMSI': '123456789012345', 'IMSI-ACC': '0020'}:{str, hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Imsi(val= 123456789012345:int) + clean_val= '123456789012345':str + read_back_val= {'IMSI': '123456789012345', 'IMSI-ACC': '0020'}:{str, hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Puk1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PUK1': '12345678'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Puk2(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PUK2': '12345678'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Pin1(val= '1234':str) + clean_val= b'1234\xff\xff\xff\xff':bytearray + read_back_val= {'PIN1': '1234'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Pin1(val= '123456':str) + clean_val= b'123456\xff\xff':bytearray + read_back_val= {'PIN1': '123456'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Pin1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PIN1': '12345678'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Adm1(val= '1234':str) + clean_val= b'1234\xff\xff\xff\xff':bytearray + read_back_val= {'ADM1': '1234'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Adm1(val= '123456':str) + clean_val= b'123456\xff\xff':bytearray + read_back_val= {'ADM1': '123456'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Adm1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'ADM1': '12345678'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der AlgorithmID(val= 'Milenage':str) + clean_val= 1:int + read_back_val= {'Algorithm': 'Milenage'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der AlgorithmID(val= 'TUAK':str) + clean_val= 2:int + read_back_val= {'Algorithm': 'TUAK'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der AlgorithmID(val= 'usim-test':str) + clean_val= 3:int + read_back_val= {'Algorithm': 'usim_test'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der K(val= '01020304050607080910111213141516':str) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytearray) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Opc(val= '01020304050607080910111213141516':str) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytearray) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Imsi(val= '123456':str) + clean_val= '123456':str + read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Imsi(val= 123456:int) + clean_val= '123456':str + read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Imsi(val= '123456789012345':str) + clean_val= '123456789012345':str + read_back_val= {'IMSI': '123456789012345', 'IMSI-ACC': '0020'}:{str, hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Imsi(val= 123456789012345:int) + clean_val= '123456789012345':str + read_back_val= {'IMSI': '123456789012345', 'IMSI-ACC': '0020'}:{str, hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Puk1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PUK1': '12345678'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Puk2(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PUK2': '12345678'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Pin1(val= '1234':str) + clean_val= b'1234\xff\xff\xff\xff':bytearray + read_back_val= {'PIN1': '1234'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Pin1(val= '123456':str) + clean_val= b'123456\xff\xff':bytearray + read_back_val= {'PIN1': '123456'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Pin1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PIN1': '12345678'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Adm1(val= '1234':str) + clean_val= b'1234\xff\xff\xff\xff':bytearray + read_back_val= {'ADM1': '1234'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Adm1(val= '123456':str) + clean_val= b'123456\xff\xff':bytearray + read_back_val= {'ADM1': '123456'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Adm1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'ADM1': '12345678'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der AlgorithmID(val= 'Milenage':str) + clean_val= 1:int + read_back_val= {'Algorithm': 'Milenage'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der AlgorithmID(val= 'TUAK':str) + clean_val= 2:int + read_back_val= {'Algorithm': 'TUAK'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der AlgorithmID(val= 'usim-test':str) + clean_val= 3:int + read_back_val= {'Algorithm': 'usim_test'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der K(val= '01020304050607080910111213141516':str) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytearray) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Opc(val= '01020304050607080910111213141516':str) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytearray) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Imsi(val= '123456':str) + clean_val= '123456':str + read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Imsi(val= 123456:int) + clean_val= '123456':str + read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Imsi(val= '123456789012345':str) + clean_val= '123456789012345':str + read_back_val= {'IMSI': '123456789012345', 'IMSI-ACC': '0020'}:{str, hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Imsi(val= 123456789012345:int) + clean_val= '123456789012345':str + read_back_val= {'IMSI': '123456789012345', 'IMSI-ACC': '0020'}:{str, hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Puk1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PUK1': '12345678'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Puk2(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PUK2': '12345678'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Pin1(val= '1234':str) + clean_val= b'1234\xff\xff\xff\xff':bytearray + read_back_val= {'PIN1': '1234'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Pin1(val= '123456':str) + clean_val= b'123456\xff\xff':bytearray + read_back_val= {'PIN1': '123456'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Pin1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PIN1': '12345678'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Adm1(val= '1234':str) + clean_val= b'1234\xff\xff\xff\xff':bytearray + read_back_val= {'ADM1': '1234'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Adm1(val= '123456':str) + clean_val= b'123456\xff\xff':bytearray + read_back_val= {'ADM1': '123456'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Adm1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'ADM1': '12345678'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der AlgorithmID(val= 'Milenage':str) + clean_val= 1:int + read_back_val= {'Algorithm': 'Milenage'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der AlgorithmID(val= 'TUAK':str) + clean_val= 2:int + read_back_val= {'Algorithm': 'TUAK'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der AlgorithmID(val= 'usim-test':str) + clean_val= 3:int + read_back_val= {'Algorithm': 'usim_test'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der K(val= '01020304050607080910111213141516':str) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytearray) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Opc(val= '01020304050607080910111213141516':str) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytearray) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Imsi(val= '123456':str) + clean_val= '123456':str + read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Imsi(val= 123456:int) + clean_val= '123456':str + read_back_val= {'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Imsi(val= '123456789012345':str) + clean_val= '123456789012345':str + read_back_val= {'IMSI': '123456789012345', 'IMSI-ACC': '0020'}:{str, hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Imsi(val= 123456789012345:int) + clean_val= '123456789012345':str + read_back_val= {'IMSI': '123456789012345', 'IMSI-ACC': '0020'}:{str, hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Puk1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PUK1': '12345678'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Puk2(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PUK2': '12345678'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Pin1(val= '1234':str) + clean_val= b'1234\xff\xff\xff\xff':bytearray + read_back_val= {'PIN1': '1234'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Pin1(val= '123456':str) + clean_val= b'123456\xff\xff':bytearray + read_back_val= {'PIN1': '123456'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Pin1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'PIN1': '12345678'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Adm1(val= '1234':str) + clean_val= b'1234\xff\xff\xff\xff':bytearray + read_back_val= {'ADM1': '1234'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Adm1(val= '123456':str) + clean_val= b'123456\xff\xff':bytearray + read_back_val= {'ADM1': '123456'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Adm1(val= '12345678':str) + clean_val= b'12345678':bytearray + read_back_val= {'ADM1': '12345678'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der AlgorithmID(val= 'Milenage':str) + clean_val= 1:int + read_back_val= {'Algorithm': 'Milenage'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der AlgorithmID(val= 'TUAK':str) + clean_val= 2:int + read_back_val= {'Algorithm': 'TUAK'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der AlgorithmID(val= 'usim-test':str) + clean_val= 3:int + read_back_val= {'Algorithm': 'usim_test'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der K(val= '01020304050607080910111213141516':str) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der K(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytearray) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'K': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Opc(val= '01020304050607080910111213141516':str) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der Opc(val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytearray) + clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes + read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia55f0d11f8197ca15a948a83a34b3488acf1a0b4 Gerrit-Change-Number: 40823 Gerrit-PatchSet: 12 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: ConfigurableParameter: do not magically overwrite the 'name' attribute
by laforge 22 Jun '26

22 Jun '26

Attention is currently required from: fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41918?usp=email ) Change subject: ConfigurableParameter: do not magically overwrite the 'name' attribute ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169 Gerrit-Change-Number: 41918 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 08:01:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcap[master]: client: fix off-by-one in wrapped pcap stats counter
by laforge 22 Jun '26

22 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42839?usp=email ) Change subject: client: fix off-by-one in wrapped pcap stats counter ...................................................................... client: fix off-by-one in wrapped pcap stats counter When a libpcap stats counter (ps_recv/ps_drop/ps_ifdrop) wraps around UINT_MAX, get_psbl_wrapped_ctr() computed the delta as (UINT_MAX - old_val) + new_val, omitting the single increment that takes the counter from UINT_MAX through zero. Add the missing +1 so the reported delta matches the real number of increments. Change-Id: I66581910dbd1e955831a6ff913042059ad4994a7 AI-Assisted: yes (Claude) --- M src/osmo_client_core.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo_client_core.c b/src/osmo_client_core.c index daa5fd6..dbc2588 100644 --- a/src/osmo_client_core.c +++ b/src/osmo_client_core.c @@ -204,6 +204,7 @@ */ if (old_val > new_val) { ret = P_CAP_UINT_MAX() - old_val; + ret += 1; /* the wrap from UINT_MAX through zero is one increment */ ret += new_val; return ret; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I66581910dbd1e955831a6ff913042059ad4994a7 Gerrit-Change-Number: 42839 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-pcap[master]: client: vty: do not print NULL tls hostname
by laforge 22 Jun '26

22 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42840?usp=email ) Change subject: client: vty: do not print NULL tls hostname ...................................................................... client: vty: do not print NULL tls hostname conn->tls_hostname defaults to NULL and can be cleared via "no tls hostname". Writing it unconditionally emitted a "tls hostname (null)" line, producing a config that does not re-parse. Guard it like the other optional tls fields. Change-Id: I5b920337409d8c9fa1edb8d47177882cf0a6c4e7 AI-Assisted: yes (Claude) --- M src/osmo_client_vty.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_client_vty.c b/src/osmo_client_vty.c index 127e52f..6648417 100644 --- a/src/osmo_client_vty.c +++ b/src/osmo_client_vty.c @@ -74,7 +74,8 @@ { if (conn->tls_on) { vty_out(vty, "%s enable tls%s", indent, VTY_NEWLINE); - vty_out(vty, "%s tls hostname %s%s", indent, conn->tls_hostname, VTY_NEWLINE); + if (conn->tls_hostname) + vty_out(vty, "%s tls hostname %s%s", indent, conn->tls_hostname, VTY_NEWLINE); vty_out(vty, "%s %stls verify-cert%s", indent, conn->tls_verify ? "" : "no ", VTY_NEWLINE); if (conn->tls_capath) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I5b920337409d8c9fa1edb8d47177882cf0a6c4e7 Gerrit-Change-Number: 42840 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-pcap[master]: server: fix NULL deref of file_hdr_msg when store is disabled
by laforge 22 Jun '26

22 Jun '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42848?usp=email ) Change subject: server: fix NULL deref of file_hdr_msg when store is disabled ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: o re-add pespin and my +1 to v1 that is identical except commitlog msg. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I419e1b66d07307c3e49294984887c153cd8494c3 Gerrit-Change-Number: 42848 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 07:59:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcap[master]: server: vty: validate rotate-localtime modulus against the new interval
by laforge 22 Jun '26

22 Jun '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42847?usp=email ) Change subject: server: vty: validate rotate-localtime modulus against the new interval ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: o re-add pespin and my +1 to v1 that is identical except commitlog msg. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I0b367d4e255db3208b41e12adec682026b99cc18 Gerrit-Change-Number: 42847 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 07:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcap[master]: tls: do not treat GNUTLS_E_AGAIN/INTERRUPTED as fatal on read
by laforge 22 Jun '26

22 Jun '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42846?usp=email ) Change subject: tls: do not treat GNUTLS_E_AGAIN/INTERRUPTED as fatal on read ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: o re-add pespin and my +1 to v1 that is identical except commitlog msg. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: If2f842b202dd08c07dffe3770c51cf0ce886beee Gerrit-Change-Number: 42846 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 07:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026