Attention is currently required from: osmith.
dexter has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42863?usp=email )
Change subject: gitignore: add build dir
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42863?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Iea8f79b4094ed79f64b0ed6d6e34212ebaea0c43
Gerrit-Change-Number: 42863
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Jun 2026 11:08:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
dexter has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42862?usp=email )
Change subject: contrib/jenkins: build with -Werror
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42862?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I8a8a7bc8a10e8d86a09fbd289b00641c19c3be6e
Gerrit-Change-Number: 42862
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Jun 2026 11:08:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
dexter has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42861?usp=email )
Change subject: utils: ignore Waddress in IPA_STR_FROM_ASN
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
So the compiler sees that IPA_STR_FROM_ASN is always used correctly and than warns that the assert will always be true?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42861?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ia2ef30880dd3e5b2ab90eedd0046a95a22614a81
Gerrit-Change-Number: 42861
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Jun 2026 11:07:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
dexter has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42857?usp=email )
Change subject: contrib/jenkins: new script
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42857?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Id5f282fd1e3403be3b5d2fcb962c2dda62bae905
Gerrit-Change-Number: 42857
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Jun 2026 10:59:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/42861?usp=email
to look at the new patch set (#2).
Change subject: utils: ignore Waddress in IPA_STR_FROM_ASN
......................................................................
utils: ignore Waddress in IPA_STR_FROM_ASN
When building with -Werror, GCC complains about this assert in the macro:
#define IPA_STR_FROM_ASN(asn1_obj) ({ \
char *__str; \
assert(asn1_obj); \ <----------------------
__str = IPA_ALLOC_N((asn1_obj)->size + 1); \
assert(__str); \
memcpy(__str, (asn1_obj)->buf, (asn1_obj)->size); \
__str[(asn1_obj)->size] = '\0'; \
__str; \
})
For example:
…/src/ipa/libipa/es10b_get_eim_cfg_data.c:48:21: error: the comparison will always evaluate as ‘true’ for the address of ‘eimId’ will never be NULL [-Werror=address]
48 | IPA_STR_FROM_ASN(&res->res->eimConfigurationDataList.list.array[i]->eimId);
Add pragmas to ignore the error, so it can still assert if somebody
should pass NULL to the macro.
Change-Id: Ia2ef30880dd3e5b2ab90eedd0046a95a22614a81
---
M src/ipa/libipa/utils.h
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/61/42861/2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42861?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ia2ef30880dd3e5b2ab90eedd0046a95a22614a81
Gerrit-Change-Number: 42861
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42858?usp=email )
Change subject: contrib/jenkins: new script
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42858?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I0305c3196896667f4963853099d0767e0acbdb30
Gerrit-Change-Number: 42858
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 22 Jun 2026 10:50:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No