June 2026 - gerrit-log - lists.osmocom.org

[XS] Change in onomondo-ipa[master]: activation_code: fix missing const for item_end
by osmith 22 Jun '26

22 Jun '26

Attention is currently required from: osmith. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42859?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: activation_code: fix missing const for item_end ...................................................................... activation_code: fix missing const for item_end Fix for: …/src/ipa/libipa/activation_code.c: In function ‘ipa_activation_code_parse’: …/src/ipa/libipa/activation_code.c:62:26: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] 62 | item_end = strchr(item + 1, '$'); | ^ Change-Id: Idcdd06f57da0e7c05ea184c56cadfc6de85514e6 --- M src/ipa/libipa/activation_code.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/59/42859/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Idcdd06f57da0e7c05ea184c56cadfc6de85514e6 Gerrit-Change-Number: 42859 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: gitignore: add build dir
by osmith 22 Jun '26

22 Jun '26

Attention is currently required from: osmith. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42863?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gitignore: add build dir ...................................................................... gitignore: add build dir Change-Id: Iea8f79b4094ed79f64b0ed6d6e34212ebaea0c43 --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/63/42863/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Iea8f79b4094ed79f64b0ed6d6e34212ebaea0c43 Gerrit-Change-Number: 42863 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in onomondo-ipa[master]: contrib/jenkins: new script
by osmith 22 Jun '26

22 Jun '26

Attention is currently required from: dexter, osmith. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42858?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by dexter, Verified+1 by Jenkins Builder Change subject: contrib/jenkins: new script ...................................................................... contrib/jenkins: new script Add a script for build verifications on https://jenkins.osmocom.org. Related: SYS#8103 Change-Id: I0305c3196896667f4963853099d0767e0acbdb30 --- A contrib/jenkins.sh 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/58/42858/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42858?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I0305c3196896667f4963853099d0767e0acbdb30 Gerrit-Change-Number: 42858 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: utils: ignore Waddress in IPA_STR_FROM_ASN
by osmith 22 Jun '26

22 Jun '26

Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42861?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: utils: ignore Waddress in IPA_STR_FROM_ASN ...................................................................... utils: ignore Waddress in IPA_STR_FROM_ASN When building with -Werror, GCC complains about this assert in the macro: #define IPA_STR_FROM_ASN(asn1_obj) ({ \ char *__str; \ assert(asn1_obj); \ <---------------------- __str = IPA_ALLOC_N((asn1_obj)->size + 1); \ assert(__str); \ memcpy(__str, (asn1_obj)->buf, (asn1_obj)->size); \ __str[(asn1_obj)->size] = '\0'; \ __str; \ }) For example: …/src/ipa/libipa/es10b_get_eim_cfg_data.c:48:21: error: the comparison will always evaluate as ‘true’ for the address of ‘eimId’ will never be NULL [-Werror=address] 48 | IPA_STR_FROM_ASN(&res->res->eimConfigurationDataList.list.array[i]->eimId); Add pragmas to ignore the error, so it can still assert if somebody should pass NULL to the macro. Change-Id: Ia2ef30880dd3e5b2ab90eedd0046a95a22614a81 --- M src/ipa/libipa/utils.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/61/42861/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ia2ef30880dd3e5b2ab90eedd0046a95a22614a81 Gerrit-Change-Number: 42861 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: contrib/jenkins: build with -Werror
by osmith 22 Jun '26

22 Jun '26

Attention is currently required from: dexter, osmith. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42862?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by dexter, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: contrib/jenkins: build with -Werror ...................................................................... contrib/jenkins: build with -Werror Now that all warnings are fixed, let's build with Werror in CI. Change-Id: I8a8a7bc8a10e8d86a09fbd289b00641c19c3be6e --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/62/42862/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I8a8a7bc8a10e8d86a09fbd289b00641c19c3be6e Gerrit-Change-Number: 42862 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: utils: ignore Waddress in IPA_STR_FROM_ASN
by osmith 22 Jun '26

22 Jun '26

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42861?usp=email ) Change subject: utils: ignore Waddress in IPA_STR_FROM_ASN ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > So the compiler sees that IPA_STR_FROM_ASN is always used correctly and than warns that the assert w […] yes -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ia2ef30880dd3e5b2ab90eedd0046a95a22614a81 Gerrit-Change-Number: 42861 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 11:58:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: contrib/jenkins: new script
by osmith 22 Jun '26

22 Jun '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42857?usp=email ) Change subject: contrib/jenkins: new script ...................................................................... contrib/jenkins: new script Add a script for build verifications on https://jenkins.osmocom.org. Related: SYS#8103 Change-Id: Id5f282fd1e3403be3b5d2fcb962c2dda62bae905 --- A contrib/jenkins.sh 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..e39a69a --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,5 @@ +#!/bin/sh -ex +# Build script for https://jenkins.osmocom.org/ + +rebar3 compile +rebar3 eunit -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42857?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Id5f282fd1e3403be3b5d2fcb962c2dda62bae905 Gerrit-Change-Number: 42857 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/gerrit-verifications: add onomondo-{eim,ipa}
by dexter 22 Jun '26

22 Jun '26

Attention is currently required from: osmith. dexter has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42864?usp=email ) Change subject: jobs/gerrit-verifications: add onomondo-{eim,ipa} ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: To me this looks correct, but I am not an expert in this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib07ed316d80cbb857c34aede03e3d4468c3be578 Gerrit-Change-Number: 42864 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 11:18:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in onomondo-ipa[master]: contrib/jenkins: new script
by dexter 22 Jun '26

22 Jun '26

Attention is currently required from: osmith. dexter has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42858?usp=email ) Change subject: contrib/jenkins: new script ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/onomondo-ipa/+/42858/comment/8614a6fb_b7056064… : PS1, Line 6: cmake -DENABLE_SANITIZE=ON ../ I would add -DSHOW_ASN_OUTPUT=ON as well since we also want to include the code that formats that output in the build verification. -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42858?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I0305c3196896667f4963853099d0767e0acbdb30 Gerrit-Change-Number: 42858 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 11:15:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in onomondo-ipa[master]: activation_code: fix missing const for item_end
by dexter 22 Jun '26

22 Jun '26

Attention is currently required from: osmith. dexter has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42859?usp=email ) Change subject: activation_code: fix missing const for item_end ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Idcdd06f57da0e7c05ea184c56cadfc6de85514e6 Gerrit-Change-Number: 42859 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 11:13:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026