June 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: Transceiver52M: fix viterbi-eq soft bits on platforms where char is u...
by pespin 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, manawyrm. pespin has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email ) Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Looks good to me as-is, but I would consider using `sbit_t` (self-explaining) or `int8_t`. Agree with fixeria. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 Gerrit-Change-Number: 42822 Gerrit-PatchSet: 1 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Comment-Date: Tue, 09 Jun 2026 15:20:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: Transceiver52M: fix viterbi-eq soft bits on platforms where char is u...
by fixeria 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, manawyrm. fixeria has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email ) Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Looks good to me as-is, but I would consider using `sbit_t` (self-explaining) or `int8_t`. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 Gerrit-Change-Number: 42822 Gerrit-PatchSet: 1 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Comment-Date: Tue, 09 Jun 2026 12:43:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix compare ignoring non-TCAP messages and remove ...
by laforge 09 Jun '26

09 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42821?usp=email ) Change subject: tcap_as_loadshare: Fix compare ignoring non-TCAP messages and remove assert ...................................................................... tcap_as_loadshare: Fix compare ignoring non-TCAP messages and remove assert The previous check in asp_loadshare_tcap_sccp() was was never true because it checked msg class twice instead of class and type. Also remove the OSMO_ASSERT in send_back_udts() limiting the function to CL/DT messages. Related: SYS#5432 Change-Id: I0831b289e4e4e94fd1b719e6c7164c3dd87c9f88 --- M src/tcap_as_loadshare.c 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index a9783f5..f3fd2f9 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -419,8 +419,6 @@ struct osmo_mtp_transfer_param new_mtp; uint32_t rctx; - OSMO_ASSERT(orig_sua->hdr.msg_class == SUA_MSGC_CL && orig_sua->hdr.msg_type == SUA_CL_CLDT); - if (!xua_msg_get_u32p(orig_sua, SUA_IEI_PROTO_CLASS, &spare_proto)) return -EINVAL; @@ -487,8 +485,9 @@ goto out_free_msgb; } + /* TODO: (How) should we route UDTS (CL/DR) messages containing TCAP? */ /* TCAP uses only connectionless SCCP messages */ - if (sua->hdr.msg_class != SUA_MSGC_CL && sua->hdr.msg_class != SUA_CL_CLDT) { + if (!(sua->hdr.msg_class == SUA_MSGC_CL && sua->hdr.msg_type == SUA_CL_CLDT)) { /* ignoring packets */ rc = -EPROTONOSUPPORT; goto out_free_sua; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0831b289e4e4e94fd1b719e6c7164c3dd87c9f88 Gerrit-Change-Number: 42821 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Fix compare ignoring non-TCAP messages and remove ...
by laforge 09 Jun '26

09 Jun '26

Attention is currently required from: daniel. laforge has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42821?usp=email ) Change subject: tcap_as_loadshare: Fix compare ignoring non-TCAP messages and remove assert ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0831b289e4e4e94fd1b719e6c7164c3dd87c9f88 Gerrit-Change-Number: 42821 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jun 2026 12:29:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: Transceiver52M: fix viterbi-eq soft bits on platforms where char is u...
by laforge 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, fixeria, manawyrm. laforge has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email ) Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 Gerrit-Change-Number: 42822 Gerrit-PatchSet: 1 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Jun 2026 12:28:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: 7816fsm: state_chg before card_uart_tx in tpdu_s_procedure_action
by laforge 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, jolly, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42781?usp=email ) Change subject: 7816fsm: state_chg before card_uart_tx in tpdu_s_procedure_action ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Id66f836452674209e25dc3ee4c37d616de30001b Gerrit-Change-Number: 42781 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 12:26:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: Transceiver52M: fix viterbi-eq soft bits on platforms where char is u...
by manawyrm 09 Jun '26

09 Jun '26

manawyrm has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email ) Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ...................................................................... Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned The viterbi-eq demodulator stores soft bits into chars. "char" is signed on x86/amd64 but unsigned on arm64. On arm64 the stored byte 0x81 (== -127) is read back as +129, so after the sign flip and vectorSlicer() clamp every soft bit collapses to 0.0. The same issue also appears to be present in the MS code path, so it was (blindly) fixed there as well. The MS fixes are untested! Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/grgsm_vitac/grgsm_vitac.cpp M Transceiver52M/grgsm_vitac/grgsm_vitac.h M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_lower.cpp M Transceiver52M/ms/ms_upper.h M utils/va-test/burst-gen.cpp 7 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/22/42822/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 17bf148..7b915d6 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -623,7 +623,7 @@ std::complex<float> chan_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR]; float ncmax; const unsigned burst_len_bits = 148 + 8; - char demodded_softbits[burst_len_bits]; + signed char demodded_softbits[burst_len_bits]; SoftVector *bits = new SoftVector(burst_len_bits); if (type == CorrType::TSC) { diff --git a/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp b/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp index 2016541..db8fa34 100644 --- a/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp +++ b/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp @@ -77,7 +77,7 @@ template <unsigned int burst_size> NO_UBSAN static void detect_burst_generic(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, - char *output_binary, int ss) + signed char *output_binary, int ss) { std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR); unsigned int stop_states[2] = { 4, 12 }; @@ -98,22 +98,22 @@ output_binary[i] = output[i] > 0 ? -127 : 127; // pre flip bits! } -NO_UBSAN void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary, +NO_UBSAN void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, signed char *output_binary, int ss) { return detect_burst_generic<BURST_SIZE>(input, chan_imp_resp, burst_start, output_binary, ss); } -NO_UBSAN void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary, +NO_UBSAN void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, signed char *output_binary, int ss) { return detect_burst_generic<8 + 41 + 36 + 3>(input, chan_imp_resp, burst_start, output_binary, ss); } -NO_UBSAN void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary) +NO_UBSAN void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, signed char *output_binary) { return detect_burst_nb(input, chan_imp_resp, burst_start, output_binary, 3); } -NO_UBSAN void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary) +NO_UBSAN void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, signed char *output_binary) { return detect_burst_ab(input, chan_imp_resp, burst_start, output_binary, 3); } diff --git a/Transceiver52M/grgsm_vitac/grgsm_vitac.h b/Transceiver52M/grgsm_vitac/grgsm_vitac.h index c1e470c..db1081f 100644 --- a/Transceiver52M/grgsm_vitac/grgsm_vitac.h +++ b/Transceiver52M/grgsm_vitac/grgsm_vitac.h @@ -63,10 +63,10 @@ int process_vita_burst(gr_complex *input, int tsc, unsigned char *output_binary); int process_vita_sc_burst(gr_complex *input, int tsc, unsigned char *output_binary, int *offset); -void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary, int ss); -void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary, int ss); -void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary); -void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary); +void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, signed char *output_binary, int ss); +void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, signed char *output_binary, int ss); +void detect_burst_nb(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, signed char *output_binary); +void detect_burst_ab(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, signed char *output_binary); void gmsk_mapper(const unsigned char *input, int nitems, gr_complex *gmsk_output, gr_complex start_point); gr_complex correlate_sequence(const gr_complex *sequence, int length, const gr_complex *input); diff --git a/Transceiver52M/ms/ms.h b/Transceiver52M/ms/ms.h index 2ad78de..515345b 100644 --- a/Transceiver52M/ms/ms.h +++ b/Transceiver52M/ms/ms.h @@ -129,7 +129,7 @@ GSM::Time gsmts; union { blade_sample_type burst[ONE_TS_BURST_LEN]; - char sch_bits[148]; + signed char sch_bits[148]; }; }; diff --git a/Transceiver52M/ms/ms_rx_lower.cpp b/Transceiver52M/ms/ms_rx_lower.cpp index d894e96..8d53eb7 100644 --- a/Transceiver52M/ms/ms_rx_lower.cpp +++ b/Transceiver52M/ms/ms_rx_lower.cpp @@ -123,7 +123,7 @@ gain_check = (gain_check + 1) % avgburst_num; } -static char sch_demod_bits[148]; +static signed char sch_demod_bits[148]; bool ms_trx::handle_sch_or_nb() { @@ -174,7 +174,7 @@ } detect_burst_nb(&ss[start], &channel_imp_resp[0], 0, sch_demod_bits); - auto sch_decode_success = decode_sch(sch_demod_bits, is_first_sch_acq); + auto sch_decode_success = decode_sch((char *)sch_demod_bits, is_first_sch_acq); #if 0 auto burst = new signalVector(buf_len, 50); const auto corr_type = is_first_sch_acq ? sch_detect_type::SCH_DETECT_BUFFER : sch_detect_type::SCH_DETECT_FULL; diff --git a/Transceiver52M/ms/ms_upper.h b/Transceiver52M/ms/ms_upper.h index 06f7c54..5a410c7 100644 --- a/Transceiver52M/ms/ms_upper.h +++ b/Transceiver52M/ms/ms_upper.h @@ -28,7 +28,7 @@ class upper_trx : public ms_trx { volatile bool mOn; - char demodded_softbits[444]; + signed char demodded_softbits[444]; // void driveControl(); bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset); diff --git a/utils/va-test/burst-gen.cpp b/utils/va-test/burst-gen.cpp index bdd0c4b..d73d0f4 100644 --- a/utils/va-test/burst-gen.cpp +++ b/utils/va-test/burst-gen.cpp @@ -291,7 +291,7 @@ std::cerr << "demod test va:" << std::endl; std::complex<float> chan_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR]; float ncmax; - char demodded_softbits[444]; + signed char demodded_softbits[444]; // demod at known offset { @@ -376,7 +376,7 @@ if (rs.ct == CorrType::RACH) { std::complex<float> chan_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR]; float ncmax; - char demodded_softbits[444]; + signed char demodded_softbits[444]; int normal_burst_start = 0; normal_burst_start = get_access_imp_resp(conved_beg, &chan_imp_resp[0], &ncmax, 0); normal_burst_start = std::max(normal_burst_start, 0); @@ -414,7 +414,7 @@ } else { std::complex<float> chan_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR]; float ncmax; - char demodded_softbits[444]; + signed char demodded_softbits[444]; auto normal_burst_start = get_norm_chan_imp_resp(conved_beg, &chan_imp_resp[0], &ncmax, tsc); detect_burst_nb(conved_beg, &chan_imp_resp[0], normal_burst_start + 0, demodded_softbits); @@ -431,7 +431,7 @@ } struct estim_burst_params ebp; - char demodded_softbits[444]; + signed char demodded_softbits[444]; complex *rx_sigproc_cfloat = reinterpret_cast<complex *>(conved_beg); signalVector sv(rx_sigproc_cfloat, 0, rs.convolved->size(), dummy_alloc, dummy_free); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 Gerrit-Change-Number: 42822 Gerrit-PatchSet: 1 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>

1 0

[M] Change in osmo-ccid-firmware[master]: libosmo_emb: type-safe tearfree_u64_t wrapper for LDRD/STRD access
by Jenkins Builder 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42784?usp=email ) Change subject: libosmo_emb: type-safe tearfree_u64_t wrapper for LDRD/STRD access ...................................................................... Patch Set 2: (2 comments) File ccid_host/libosmo_emb.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42784/comment/a6d7c033_8c… : PS2, Line 9: typedef struct { do not add new typedefs File sysmoOCTSIM/libosmo_emb.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42784/comment/c5327606_84… : PS2, Line 19: typedef struct { do not add new typedefs -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I458bfaf53e27c51882c7a8c1326e51d12943b0bb Gerrit-Change-Number: 42784 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Jun 2026 11:50:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ccid-firmware[master]: 7816fsm: reset stale cuart state on FSM RESET entry
by jolly 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. jolly has uploaded a new patch set (#2) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42779?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: 7816fsm: reset stale cuart state on FSM RESET entry ...................................................................... 7816fsm: reset stale cuart state on FSM RESET entry Reset paths reached without power-cycling (WTIME_EXP, HW_ERR, CARD_REMOVAL during a warm reset) leave the cuart with stale tx_busy, rx_threshold and wtime_etu from the prior transaction. The next ATR then hits card_uart_tx tx_busy assertion, or the ATR receive stalls because the 33-byte ATR can never reach a multi-byte rx_threshold left from a TPDU. The new card_uart_tx_abort() clears tx_busy + rx_after_tx_compl + WT, without driving a synthetic TX_COMPLETE through the FSM. iso7816_3_reset_onenter is the right place to do this alongside rx_threshold=1 and wtime_etu=default, this mirrors what card_uart_ctrl(POWER_*=0) already does, but for the warm-reset paths that don't touch power. Change-Id: Iac8bd7f4f0eecccc9acce149277a4f5016fec7c1 --- M ccid_common/ccid_slot_fsm.c M ccid_common/cuart.c M ccid_common/cuart.h M ccid_common/iso7816_fsm.c 4 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/79/42779/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iac8bd7f4f0eecccc9acce149277a4f5016fec7c1 Gerrit-Change-Number: 42779 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: reject invalid bClockCommand
by jolly 09 Jun '26

09 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. jolly has uploaded a new patch set (#2) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42778?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ccid: reject invalid bClockCommand ...................................................................... ccid: reject invalid bClockCommand Change-Id: I34dedcaaaf3cd67e22b207016f08e745736dd625 --- M ccid_common/ccid_device.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/78/42778/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I34dedcaaaf3cd67e22b207016f08e745736dd625 Gerrit-Change-Number: 42778 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026