June 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-pcap[master]: server: do not abort process on short conn message
by laforge 23 Jun '26

23 Jun '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42841?usp=email ) Change subject: server: do not abort process on short conn message ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ia102ff918ef8152d212e10a860f5dc70efec880b Gerrit-Change-Number: 42841 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jun 2026 08:17:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Check if reader times out after first status word
by laforge 23 Jun '26

23 Jun '26

Attention is currently required from: Hoernchen, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42856?usp=email ) Change subject: CCID: Check if reader times out after first status word ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic5b892e356c13808555d75746c48c6d8c96ec462 Gerrit-Change-Number: 42856 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 23 Jun 2026 08:16:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: utils/gsmtap-logsend: close infile before exit
by laforge 23 Jun '26

23 Jun '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/42866?usp=email ) Change subject: utils/gsmtap-logsend: close infile before exit ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I259cf951c52f7d859475f5f79c803692c29fbec3 Gerrit-Change-Number: 42866 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jun 2026 08:16:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: utils: fix typos
by laforge 23 Jun '26

23 Jun '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/42865?usp=email ) Change subject: utils: fix typos ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib8ede7cbfed9198f59fe2899fe4b68eac5ac9a23 Gerrit-Change-Number: 42865 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jun 2026 08:16:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: utils: fix typos
by osmith 23 Jun '26

23 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42865?usp=email ) Change subject: utils: fix typos ...................................................................... utils: fix typos Change-Id: Ib8ede7cbfed9198f59fe2899fe4b68eac5ac9a23 --- M utils/gsmtap-logsend.c M utils/osmo-config-merge.c 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/42865/1 diff --git a/utils/gsmtap-logsend.c b/utils/gsmtap-logsend.c index 97a838b..67114e7 100644 --- a/utils/gsmtap-logsend.c +++ b/utils/gsmtap-logsend.c @@ -101,7 +101,7 @@ gsmtap_fd = gsmtap_source_init_fd(dest_host, dest_port); if (gsmtap_fd < 0) { - fprintf(stderr, "Unable to create GSMTAP soicket: %s\n", strerror(errno)); + fprintf(stderr, "Unable to create GSMTAP socket: %s\n", strerror(errno)); exit(2); } diff --git a/utils/osmo-config-merge.c b/utils/osmo-config-merge.c index f7db945..d297d01 100644 --- a/utils/osmo-config-merge.c +++ b/utils/osmo-config-merge.c @@ -161,7 +161,7 @@ line_num++; chomp(line); int indent = count_indent(line); - bool coment = line_is_comment(&line[indent]); + bool comment = line_is_comment(&line[indent]); struct node *n; if (indent > cur_indent) { @@ -190,7 +190,7 @@ /* comments are not part of the indentation structure of the * file, hence commands after it are not to be affected by them: */ - if (!coment) { + if (!comment) { last = n; cur_indent = indent; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib8ede7cbfed9198f59fe2899fe4b68eac5ac9a23 Gerrit-Change-Number: 42865 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: utils/gsmtap-logsend: close infile before exit
by osmith 23 Jun '26

23 Jun '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42866?usp=email ) Change subject: utils/gsmtap-logsend: close infile before exit ...................................................................... utils/gsmtap-logsend: close infile before exit Related: SYS#8093 Change-Id: I259cf951c52f7d859475f5f79c803692c29fbec3 --- M utils/gsmtap-logsend.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/66/42866/1 diff --git a/utils/gsmtap-logsend.c b/utils/gsmtap-logsend.c index 67114e7..9365362 100644 --- a/utils/gsmtap-logsend.c +++ b/utils/gsmtap-logsend.c @@ -50,6 +50,7 @@ FILE *infile; char *line; int rc; + int ret = 0; while (1) { static const struct option long_options[] = { @@ -102,7 +103,8 @@ gsmtap_fd = gsmtap_source_init_fd(dest_host, dest_port); if (gsmtap_fd < 0) { fprintf(stderr, "Unable to create GSMTAP socket: %s\n", strerror(errno)); - exit(2); + ret = 2; + goto exit_close; } /* prepare all the data structures that don't change for each line */ @@ -133,7 +135,13 @@ rc = writev(gsmtap_fd, iov, ARRAY_SIZE(iov)); if (rc <= 0) { fprintf(stderr, "Short write on GSMTAP socket: %d (%s)\n", rc, strerror(errno)); - exit(1); + ret = 1; + goto exit_close; } } + +exit_close: + if (infile != stdin) + fclose(infile); + exit(ret); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I259cf951c52f7d859475f5f79c803692c29fbec3 Gerrit-Change-Number: 42866 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: euicc: extend get_profiles_info to retrieve all known tags
by laforge 22 Jun '26

22 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42057?usp=email ) Change subject: euicc: extend get_profiles_info to retrieve all known tags ...................................................................... euicc: extend get_profiles_info to retrieve all known tags get_profiles_info only request for the default tag list, but not all tags. Add --all to the function to request for all known tags. Change-Id: Ia6878519a480bd625bb1fa2567c1fd2e0e89b071 --- M pySim/euicc.py 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: neels: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/pySim/euicc.py b/pySim/euicc.py index 36e2d2a..2884c93 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -444,9 +444,28 @@ d = rn.to_dict() self._cmd.poutput_json(flatten_dict_lists(d['notification_sent_resp'])) - def do_get_profiles_info(self, _opts): + get_profiles_info_parser = argparse.ArgumentParser() + get_profiles_info_parser.add_argument('--all', action='store_true', help='Retrieve all known tags of a profile') + + @cmd2.with_argparser(get_profiles_info_parser) + def do_get_profiles_info(self, opts): """Perform an ES10c GetProfilesInfo function.""" - pi = CardApplicationISDR.store_data_tlv(self._cmd.lchan.scc, ProfileInfoListReq(), ProfileInfoListResp) + if opts.all: + tags = [nest.tag for nest in ProfileInfo.nested_collection_cls().nested] + u8tags = [] + # TODO: rework TagList to support 2 byte tags to not filter it into u8 tags + for tag in tags: + if tag <= 255: + u8tags.append(tag) + elif tag <= 65535: + u8tags.append(tag >> 8) + u8tags.append(tag & 0xff) + # Ignoring 3 byte tags + req = ProfileInfoListReq(children=[TagList(decoded=u8tags)]) + else: + req = ProfileInfoListReq() + + pi = CardApplicationISDR.store_data_tlv(self._cmd.lchan.scc, req, ProfileInfoListResp) d = pi.to_dict() self._cmd.poutput_json(flatten_dict_lists(d['profile_info_list_resp'])) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42057?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia6878519a480bd625bb1fa2567c1fd2e0e89b071 Gerrit-Change-Number: 42057 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: euicc: get_profiles_info: add additional tags
by laforge 22 Jun '26

22 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42058?usp=email ) Change subject: euicc: get_profiles_info: add additional tags ...................................................................... euicc: get_profiles_info: add additional tags Add definitions for ProfileOwner (decoded), Notification Configuration Info, SM-DP+ proprietary data, Profile Policy Rules. Change-Id: I727dbe34d87a42bb3b526bd7a8accd687d20a208 --- M pySim/euicc.py 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: dexter: Looks good to me, approved neels: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/euicc.py b/pySim/euicc.py index 2884c93..0a6c054 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -226,9 +226,28 @@ _construct = GreedyBytes class ProfileClass(BER_TLV_IE, tag=0x95): _construct = Enum(Int8ub, test=0, provisioning=1, operational=2) +class ProfilePolicyRules(BER_TLV_IE, tag=0x99): + _construct = GreedyBytes +class NotificationConfigurationInfo(BER_TLV_IE, tag=0xb6): + _construct = GreedyBytes + +# ProfileOwner +class ProfileOwnerPLMN(BER_TLV_IE, tag=0x80): + _construct = PlmnAdapter(Bytes(3)) +class ProfileOwnerGID1(BER_TLV_IE, tag=0x81): + _construct = GreedyBytes +class ProfileOwnerGID2(BER_TLV_IE, tag=0x82): + _construct = GreedyBytes +class ProfileOwner(BER_TLV_IE, tag=0xb7, nested=[ProfileOwnerPLMN, ProfileOwnerGID1, ProfileOwnerGID2]): + _construct = GreedyBytes + +class SMDPPProprietaryData(BER_TLV_IE, tag=0xb8): + _construct = GreedyBytes + class ProfileInfo(BER_TLV_IE, tag=0xe3, nested=[Iccid, IsdpAid, ProfileState, ProfileNickname, ServiceProviderName, ProfileName, IconType, Icon, - ProfileClass]): # FIXME: more IEs + ProfileClass, ProfilePolicyRules, NotificationConfigurationInfo, + ProfileOwner, SMDPPProprietaryData]): pass class ProfileInfoSeq(BER_TLV_IE, tag=0xa0, nested=[ProfileInfo]): pass -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I727dbe34d87a42bb3b526bd7a8accd687d20a208 Gerrit-Change-Number: 42058 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: euicc: get_profiles_info: add additional tags
by laforge 22 Jun '26

22 Jun '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/42058?usp=email ) Change subject: euicc: get_profiles_info: add additional tags ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I727dbe34d87a42bb3b526bd7a8accd687d20a208 Gerrit-Change-Number: 42058 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 22 Jun 2026 17:02:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: add comment about not updating existing key_usage_qualifier
by fixeria 22 Jun '26

22 Jun '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42263?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: add comment about not updating existing key_usage_qualifier ...................................................................... add comment about not updating existing key_usage_qualifier Change-Id: Ie23ae5fde17be6b37746784bf1601b4d0874397a Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 5565f6f..b81da3c 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -691,6 +691,11 @@ ) pe.add_key(key) else: + # A key of this KVN and ID already exists in the profile. + + # Keep the key_usage_qualifier as it was in the profile, so skip this here: + # key.key_usage_qualifier = cls.key_usage_qual + key.key_components = set_components @classmethod -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie23ae5fde17be6b37746784bf1601b4d0874397a Gerrit-Change-Number: 42263 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026