June 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: SmspTpScAddr: fix SMSP record length and alpha_id padding
by fixeria 22 Jun '26

22 Jun '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email ) Change subject: SmspTpScAddr: fix SMSP record length and alpha_id padding ...................................................................... SmspTpScAddr: fix SMSP record length and alpha_id padding apply_val() was re-encoding the SMSP with the minimum total_len of 28, which produces a 28-byte body with no alpha_id field. After a DER round-trip, the profile machinery re-pads the body to the original record length using the template's fill pattern, which may not be 0xFF. Those non-0xFF fill bytes end up in the alpha_id area, and GSM 7-bit decoding then fails with a KeyError when the modified profile is read back. Fix by: - setting alpha_id = '' so the field is present but empty - setting f_smsp.rec_len = 42 (28 fixed bytes + 14 bytes of alpha_id padding) so the re-encoded body carries 0xFF-padded alpha_id space and the efFileSize in the fileDescriptor stays consistent - passing total_len=f_smsp.rec_len to encode_record_bin() so the alpha_id area is actually padded to that length Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 20 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 86c71f5..5565f6f 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -612,10 +612,28 @@ ef_smsp_dec['tp_sc_addr']['ton_npi']['type_of_number'] = 'international' if international else 'unknown' # ensure the parameter_indicators.tp_sc_addr is True ef_smsp_dec['parameter_indicators']['tp_sc_addr'] = True - # re-encode into the File body - f_smsp.body = ef_smsp.encode_record_bin(ef_smsp_dec, 1) + + # alpha_id padding: to make room for a human readable SMSC name that can be provisioned to the profile later + # on, alpha_id needs to be empty but padded 0xff to some length. + # - alpha_id is optional, setting alpha_id = '' ensures the IE is present. + # - the length of the file is 28+Y where Y is the length of the alpha_id -- here the intended length of our padding + # (see 3GPP TS 31.102 4.2.27 EF.SMSP). So if we want a maximum length of alpha_id = 14, we set the total + # file size to 28+14 = 42. + # - this file size has to go in two places: encode_record_bin() needs to know the length to encode the right + # length of fillFileContent. + # - the f_smsp needs to show the right file size in the PES, as in + # 'ef-smsp': [('fileDescriptor', {'efFileSize': '2a', ... + # (where 2a == 42) + # - To generate the right amount of fillFileContent, pass total_len=42 to encode_record_bin(). + # - To show the right size in the PES, set f_smsp.rec_len = 42 + ef_smsp_dec['alpha_id'] = '' + f_smsp.rec_len = 42 + + # re-encode into the File body. + # #print("SMSP (new): %s" % f_smsp.body) # re-generate the pe.decoded member from the File instance + f_smsp.body = ef_smsp.encode_record_bin(ef_smsp_dec, 1, total_len=f_smsp.rec_len) pe.file2pe(f_smsp) @classmethod -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Gerrit-Change-Number: 42674 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[M] Change in pysim[master]: test_configurable_parameters.py: add tests for new parameters
by fixeria 22 Jun '26

22 Jun '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42262?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: test_configurable_parameters.py: add tests for new parameters ...................................................................... test_configurable_parameters.py: add tests for new parameters For: SmspTpScAddr MilenageRotation MilenageXoringConstants TuakNrOfKeccak Change-Id: Iecbea14fe31a9ee08d871dcde7f295d26d7bd001 Jenkins: skip-card-test --- M tests/unittests/test_configurable_parameters.py M tests/unittests/xo/test_configurable_parameters 2 files changed, 209 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/unittests/test_configurable_parameters.py b/tests/unittests/test_configurable_parameters.py index ea826ae..7f9c8b0 100755 --- a/tests/unittests/test_configurable_parameters.py +++ b/tests/unittests/test_configurable_parameters.py @@ -202,6 +202,71 @@ val=io.BytesIO(b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16'), expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', expect_val='01020304050607080910111213141516'), + + Paramtest(param_cls=p13n.SmspTpScAddr, + val='+1234567', + expect_clean_val=(True, '1234567'), + expect_val='+1234567'), + Paramtest(param_cls=p13n.SmspTpScAddr, + val=1234567, + expect_clean_val=(False, '1234567'), + expect_val='1234567'), + + Paramtest(param_cls=p13n.TuakNumberOfKeccak, + val='123', + expect_clean_val=123, + expect_val='123'), + Paramtest(param_cls=p13n.TuakNumberOfKeccak, + val=123, + expect_clean_val=123, + expect_val='123'), + + Paramtest(param_cls=p13n.MilenageRotationConstants, + val='0a 0b 0c 01 02', + expect_clean_val=b'\x0a\x0b\x0c\x01\x02', + expect_val='0a0b0c0102'), + Paramtest(param_cls=p13n.MilenageRotationConstants, + val=b'\x0a\x0b\x0c\x01\x02', + expect_clean_val=b'\x0a\x0b\x0c\x01\x02', + expect_val='0a0b0c0102'), + Paramtest(param_cls=p13n.MilenageRotationConstants, + val=bytearray(b'\x0a\x0b\x0c\x01\x02'), + expect_clean_val=b'\x0a\x0b\x0c\x01\x02', + expect_val='0a0b0c0102'), + + Paramtest(param_cls=p13n.MilenageXoringConstants, + val='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' + ' bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' + ' cccccccccccccccccccccccccccccccc' + ' 11111111111111111111111111111111' + ' 22222222222222222222222222222222', + expect_clean_val=b'\xaa' * 16 + + b'\xbb' * 16 + + b'\xcc' * 16 + + b'\x11' * 16 + + b'\x22' * 16, + expect_val='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' + 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' + 'cccccccccccccccccccccccccccccccc' + '11111111111111111111111111111111' + '22222222222222222222222222222222'), + Paramtest(param_cls=p13n.MilenageXoringConstants, + val=b'\xaa' * 16 + + b'\xbb' * 16 + + b'\xcc' * 16 + + b'\x11' * 16 + + b'\x22' * 16, + expect_clean_val=b'\xaa' * 16 + + b'\xbb' * 16 + + b'\xcc' * 16 + + b'\x11' * 16 + + b'\x22' * 16, + expect_val='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' + 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' + 'cccccccccccccccccccccccccccccccc' + '11111111111111111111111111111111' + '22222222222222222222222222222222'), + ] for sdkey_cls in ( diff --git a/tests/unittests/xo/test_configurable_parameters b/tests/unittests/xo/test_configurable_parameters index 6f8c679..d64e7ba 100644 --- a/tests/unittests/xo/test_configurable_parameters +++ b/tests/unittests/xo/test_configurable_parameters @@ -127,6 +127,42 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.1A_NoBERTLV.der SmspTpScAddr(val= '+1234567':str) + clean_val= (True, '1234567'):tuple + read_back_val= {'SMSP-TP-SC-ADDR': '+1234567'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der SmspTpScAddr(val= 1234567:int) + clean_val= (False, '1234567'):tuple + read_back_val= {'SMSP-TP-SC-ADDR': '1234567'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der TuakNumberOfKeccak(val= '123':str) + clean_val= 123:int + read_back_val= {'KECCAK-N': '123'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der TuakNumberOfKeccak(val= 123:int) + clean_val= 123:int + read_back_val= {'KECCAK-N': '123'}:{str} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der MilenageRotationConstants(val= '0a 0b 0c 01 02':str) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der MilenageRotationConstants(val= b'\n\x0b\x0c\x01\x02':bytes) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der MilenageRotationConstants(val= b'\n\x0b\x0c\x01\x02':bytearray) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der MilenageXoringConstants(val= 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb cccccccccccccccccccccccccccccccc 11111111111111111111111111111111 22222222222222222222222222222222':str) + clean_val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes + read_back_val= {'MilenageXOR': 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbcccccccccccccccccccccccccccccccc1111111111111111111111111111111122222222222222222222222222222222'}:{hexstr} + +ok: TS48v5_SAIP2.1A_NoBERTLV.der MilenageXoringConstants(val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes) + clean_val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes + read_back_val= {'MilenageXOR': 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbcccccccccccccccccccccccccccccccc1111111111111111111111111111111122222222222222222222222222222222'}:{hexstr} + ok: TS48v5_SAIP2.1A_NoBERTLV.der SdKeyScp02Kvn20AesDek(val= '01020304050607080910111213141516':str) clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'SCP02-KVN20-AES-DEK': '01020304050607080910111213141516'}:{hexstr} @@ -783,6 +819,42 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der SmspTpScAddr(val= '+1234567':str) + clean_val= (True, '1234567'):tuple + read_back_val= {'SMSP-TP-SC-ADDR': '+1234567'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der SmspTpScAddr(val= 1234567:int) + clean_val= (False, '1234567'):tuple + read_back_val= {'SMSP-TP-SC-ADDR': '1234567'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der TuakNumberOfKeccak(val= '123':str) + clean_val= 123:int + read_back_val= {'KECCAK-N': '123'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der TuakNumberOfKeccak(val= 123:int) + clean_val= 123:int + read_back_val= {'KECCAK-N': '123'}:{str} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der MilenageRotationConstants(val= '0a 0b 0c 01 02':str) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der MilenageRotationConstants(val= b'\n\x0b\x0c\x01\x02':bytes) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der MilenageRotationConstants(val= b'\n\x0b\x0c\x01\x02':bytearray) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der MilenageXoringConstants(val= 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb cccccccccccccccccccccccccccccccc 11111111111111111111111111111111 22222222222222222222222222222222':str) + clean_val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes + read_back_val= {'MilenageXOR': 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbcccccccccccccccccccccccccccccccc1111111111111111111111111111111122222222222222222222222222222222'}:{hexstr} + +ok: TS48v5_SAIP2.3_BERTLV_SUCI.der MilenageXoringConstants(val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes) + clean_val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes + read_back_val= {'MilenageXOR': 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbcccccccccccccccccccccccccccccccc1111111111111111111111111111111122222222222222222222222222222222'}:{hexstr} + ok: TS48v5_SAIP2.3_BERTLV_SUCI.der SdKeyScp02Kvn20AesDek(val= '01020304050607080910111213141516':str) clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'SCP02-KVN20-AES-DEK': '01020304050607080910111213141516'}:{hexstr} @@ -1439,6 +1511,42 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.1B_NoBERTLV.der SmspTpScAddr(val= '+1234567':str) + clean_val= (True, '1234567'):tuple + read_back_val= {'SMSP-TP-SC-ADDR': '+1234567'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der SmspTpScAddr(val= 1234567:int) + clean_val= (False, '1234567'):tuple + read_back_val= {'SMSP-TP-SC-ADDR': '1234567'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der TuakNumberOfKeccak(val= '123':str) + clean_val= 123:int + read_back_val= {'KECCAK-N': '123'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der TuakNumberOfKeccak(val= 123:int) + clean_val= 123:int + read_back_val= {'KECCAK-N': '123'}:{str} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der MilenageRotationConstants(val= '0a 0b 0c 01 02':str) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der MilenageRotationConstants(val= b'\n\x0b\x0c\x01\x02':bytes) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der MilenageRotationConstants(val= b'\n\x0b\x0c\x01\x02':bytearray) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der MilenageXoringConstants(val= 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb cccccccccccccccccccccccccccccccc 11111111111111111111111111111111 22222222222222222222222222222222':str) + clean_val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes + read_back_val= {'MilenageXOR': 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbcccccccccccccccccccccccccccccccc1111111111111111111111111111111122222222222222222222222222222222'}:{hexstr} + +ok: TS48v5_SAIP2.1B_NoBERTLV.der MilenageXoringConstants(val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes) + clean_val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes + read_back_val= {'MilenageXOR': 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbcccccccccccccccccccccccccccccccc1111111111111111111111111111111122222222222222222222222222222222'}:{hexstr} + ok: TS48v5_SAIP2.1B_NoBERTLV.der SdKeyScp02Kvn20AesDek(val= '01020304050607080910111213141516':str) clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'SCP02-KVN20-AES-DEK': '01020304050607080910111213141516'}:{hexstr} @@ -2095,6 +2203,42 @@ clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'OPc': '01020304050607080910111213141516'}:{hexstr} +ok: TS48v5_SAIP2.3_NoBERTLV.der SmspTpScAddr(val= '+1234567':str) + clean_val= (True, '1234567'):tuple + read_back_val= {'SMSP-TP-SC-ADDR': '+1234567'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der SmspTpScAddr(val= 1234567:int) + clean_val= (False, '1234567'):tuple + read_back_val= {'SMSP-TP-SC-ADDR': '1234567'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der TuakNumberOfKeccak(val= '123':str) + clean_val= 123:int + read_back_val= {'KECCAK-N': '123'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der TuakNumberOfKeccak(val= 123:int) + clean_val= 123:int + read_back_val= {'KECCAK-N': '123'}:{str} + +ok: TS48v5_SAIP2.3_NoBERTLV.der MilenageRotationConstants(val= '0a 0b 0c 01 02':str) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der MilenageRotationConstants(val= b'\n\x0b\x0c\x01\x02':bytes) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der MilenageRotationConstants(val= b'\n\x0b\x0c\x01\x02':bytearray) + clean_val= b'\n\x0b\x0c\x01\x02':bytes + read_back_val= {'MilenageRotation': '0a0b0c0102'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der MilenageXoringConstants(val= 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb cccccccccccccccccccccccccccccccc 11111111111111111111111111111111 22222222222222222222222222222222':str) + clean_val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes + read_back_val= {'MilenageXOR': 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbcccccccccccccccccccccccccccccccc1111111111111111111111111111111122222222222222222222222222222222'}:{hexstr} + +ok: TS48v5_SAIP2.3_NoBERTLV.der MilenageXoringConstants(val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes) + clean_val= b'\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xaa\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xbb\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\xcc\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11""""""""""""""""':bytes + read_back_val= {'MilenageXOR': 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbcccccccccccccccccccccccccccccccc1111111111111111111111111111111122222222222222222222222222222222'}:{hexstr} + ok: TS48v5_SAIP2.3_NoBERTLV.der SdKeyScp02Kvn20AesDek(val= '01020304050607080910111213141516':str) clean_val= b'\x01\x02\x03\x04\x05\x06\x07\x08\t\x10\x11\x12\x13\x14\x15\x16':bytes read_back_val= {'SCP02-KVN20-AES-DEK': '01020304050607080910111213141516'}:{hexstr} -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iecbea14fe31a9ee08d871dcde7f295d26d7bd001 Gerrit-Change-Number: 42262 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: saip SmspTpScAddr.get_values_from_pes: allow empty values
by fixeria 22 Jun '26

22 Jun '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42267?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: saip SmspTpScAddr.get_values_from_pes: allow empty values ...................................................................... saip SmspTpScAddr.get_values_from_pes: allow empty values Change-Id: Ibbdd08f96160579238b50699091826883f2e9f5a Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index b81da3c..782e8e2 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -644,19 +644,11 @@ ef_smsp_dec = ef_smsp.decode_record_bin(f_smsp.body, 1) tp_sc_addr = ef_smsp_dec.get('tp_sc_addr', None) - if not tp_sc_addr: - continue digits = tp_sc_addr.get('call_number', None) - if not digits: - continue ton_npi = tp_sc_addr.get('ton_npi', None) - if not ton_npi: - continue international = ton_npi.get('type_of_number', None) - if international is None: - continue international = (international == 'international') yield { cls.name: cls.tuple_to_str((international, digits)) } -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42267?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibbdd08f96160579238b50699091826883f2e9f5a Gerrit-Change-Number: 42267 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: saip: add numeric_base indicator to ConfigurableParameter
by fixeria 22 Jun '26

22 Jun '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42268?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: saip: add numeric_base indicator to ConfigurableParameter ...................................................................... saip: add numeric_base indicator to ConfigurableParameter By default, numeric_base = None, to indicate that there are no explicit limitations on the number space. For parameters that are definitely decimal, set numeric_base = 10. For definitely hexadecimal, set numeric_base = 16. Do the same for ConfigurableParameter as well as ParamSource, so callers can match them up: if a parameter is numeric_base = 10, then omit sources that are numeric_base = 16, and vice versa. Change-Id: Ib0977bbdd9a85167be7eb46dd331fedd529dae01 Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 782e8e2..efde37a 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -71,6 +71,7 @@ min_len: minimum length of an input str; min_len = 4 max_len: maximum length of an input str; max_len = 8 allow_len: permit only specific lengths; allow_len = (8, 16, 32) + numeric_base: indicate hex / decimal, if any; numeric_base = None; numeric_base = 10; numeric_base = 16 Subclasses may change the meaning of these by overriding validate_val(), for example that the length counts resulting bytes instead of a hexstring length. Most subclasses will be covered by the default validate_val(). @@ -126,6 +127,7 @@ allow_len = None # a list of specific lengths example_input = None default_source = None # a param_source.ParamSource subclass + numeric_base = None # or 10 or 16 def __init__(self, input_value=None): self.input_value = input_value # the raw input value as given by caller @@ -301,6 +303,7 @@ """ allow_types = (str, int) allow_chars = '0123456789' + numeric_base = 10 @classmethod def validate_val(cls, val): @@ -346,6 +349,7 @@ class IntegerParam(ConfigurableParameter): allow_types = (str, int) allow_chars = '0123456789' + numeric_base = 10 # two integers, if the resulting int should be range limited min_val = None @@ -378,6 +382,7 @@ allow_types = (str, io.BytesIO, bytes, bytearray, int) allow_chars = '0123456789abcdefABCDEF' strip_chars = ' \t\r\n' + numeric_base = 16 default_source = param_source.RandomHexDigitSource @classmethod @@ -551,6 +556,7 @@ name = 'SMSP-TP-SC-ADDR' allow_chars = '+0123456789' strip_chars = ' \t\r\n' + numeric_base = 10 max_len = 21 # '+' and 20 digits min_len = 1 example_input = '+49301234567' -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42268?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib0977bbdd9a85167be7eb46dd331fedd529dae01 Gerrit-Change-Number: 42268 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: SmspTpScAddr: fix SMSP record length and alpha_id padding
by neels 22 Jun '26

22 Jun '26

Attention is currently required from: fixeria, laforge. neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email ) Change subject: SmspTpScAddr: fix SMSP record length and alpha_id padding ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/42674/comment/a9d01739_e5a257fc?usp=em… : PS5, Line 637: ef_smsp_dec['alpha_id'] = '' > With (I0ec99b2648b22c56f9145345e4cd8776f9217701, already merged), setting the alpha id is optional. […] that's correct. The original patch was written in parallel with dexter's work on "upstream" improvement, i left it in there so it would work with both old and new (for flexible rebasing of the branch used in esim-mgr production). the alpha_id line is now redundant. maybe the comment above that also needs tweaking to be accurate? (but it would also be ok to merge as-is, i have no strong onion) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Gerrit-Change-Number: 42674 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 14:30:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: SmspTpScAddr: fix SMSP record length and alpha_id padding
by dexter 22 Jun '26

22 Jun '26

Attention is currently required from: fixeria, laforge, neels. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email ) Change subject: SmspTpScAddr: fix SMSP record length and alpha_id padding ...................................................................... Patch Set 7: Code-Review+2 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/42674/comment/354878f2_81013728?usp=em… : PS5, Line 638: f_smsp.rec_len = 42 > So, all in all, should it be `38` or `42`? […] I think 42 should work fine as long as f_smsp.rec_len = 42 is set. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Gerrit-Change-Number: 42674 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 13:26:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: SmspTpScAddr: fix SMSP record length and alpha_id padding
by fixeria 22 Jun '26

22 Jun '26

Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email ) Change subject: SmspTpScAddr: fix SMSP record length and alpha_id padding ...................................................................... Patch Set 7: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/42674/comment/018545c8_8adaff7d?usp=em… : PS5, Line 638: f_smsp.rec_len = 42 > The size of 38 is the default that TCA suggests. […] So, all in all, should it be `38` or `42`? Personally I like the Ultimate Question of Life, the Universe, and Everything :) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Gerrit-Change-Number: 42674 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 13:04:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: contrib/jenkins: build with -Werror
by osmith 22 Jun '26

22 Jun '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42862?usp=email ) Change subject: contrib/jenkins: build with -Werror ...................................................................... contrib/jenkins: build with -Werror Now that all warnings are fixed, let's build with Werror in CI. Change-Id: I8a8a7bc8a10e8d86a09fbd289b00641c19c3be6e --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index dcff415..6db4296 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -4,6 +4,7 @@ mkdir build cd build cmake \ + -DCMAKE_COMPILE_WARNING_AS_ERROR=ON \ -DENABLE_SANITIZE=ON \ -DSHOW_ASN_OUTPUT=ON \ ../ -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I8a8a7bc8a10e8d86a09fbd289b00641c19c3be6e Gerrit-Change-Number: 42862 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: gitignore: add build dir
by osmith 22 Jun '26

22 Jun '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42863?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gitignore: add build dir ...................................................................... gitignore: add build dir Change-Id: Iea8f79b4094ed79f64b0ed6d6e34212ebaea0c43 --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 5d00c85..1e00c3b 100644 --- a/.gitignore +++ b/.gitignore @@ -94,3 +94,5 @@ # Application src/ipa/ipa +# CMake builddir +build/ -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Iea8f79b4094ed79f64b0ed6d6e34212ebaea0c43 Gerrit-Change-Number: 42863 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: contrib/jenkins: build with -Werror
by fixeria 22 Jun '26

22 Jun '26

Attention is currently required from: dexter, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42862?usp=email ) Change subject: contrib/jenkins: build with -Werror ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I8a8a7bc8a10e8d86a09fbd289b00641c19c3be6e Gerrit-Change-Number: 42862 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 12:59:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026