Attention is currently required from: fixeria, laforge. neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email ) Change subject: SmspTpScAddr: fix SMSP record length and alpha_id padding ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/42674/comment/a9d01739_e5a257fc?usp=ema... : PS5, Line 637: ef_smsp_dec['alpha_id'] = ''

With (I0ec99b2648b22c56f9145345e4cd8776f9217701, already merged), setting the alpha id is optional. […] that's correct. The original patch was written in parallel with dexter's work on "upstream" improvement, i left it in there so it would work with both old and new (for flexible rebasing of the branch used in esim-mgr production). the alpha_id line is now redundant. maybe the comment above that also needs tweaking to be accurate? (but it would also be ok to merge as-is, i have no strong onion)

-- To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Gerrit-Change-Number: 42674 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2026 14:30:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pmaier@sysmocom.de>