fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42263?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: add comment about not updating existing key_usage_qualifier ...................................................................... add comment about not updating existing key_usage_qualifier Change-Id: Ie23ae5fde17be6b37746784bf1601b4d0874397a Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 5565f6f..b81da3c 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -691,6 +691,11 @@ ) pe.add_key(key) else: + # A key of this KVN and ID already exists in the profile. + + # Keep the key_usage_qualifier as it was in the profile, so skip this here: + # key.key_usage_qualifier = cls.key_usage_qual + key.key_components = set_components @classmethod -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie23ae5fde17be6b37746784bf1601b4d0874397a Gerrit-Change-Number: 42263 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org>