Attention is currently required from: fixeria, laforge.
neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email )
Change subject: SmspTpScAddr: fix SMSP record length and alpha_id padding ......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/42674/comment/a9d01739_e5a257fc?usp=ema... : PS5, Line 637: ef_smsp_dec['alpha_id'] = ''
With (I0ec99b2648b22c56f9145345e4cd8776f9217701, already merged), setting the alpha id is optional. […]
that's correct. The original patch was written in parallel with dexter's work on "upstream" improvement, i left it in there so it would work with both old and new (for flexible rebasing of the branch used in esim-mgr production). the alpha_id line is now redundant. maybe the comment above that also needs tweaking to be accurate? (but it would also be ok to merge as-is, i have no strong onion)