Attention is currently required from: laforge, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email )
Change subject: Add test case to verify proper DSCP settings
......................................................................
Patch Set 8:
(1 comment)
File tests/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/fcfdcd88_b6da2… :
PS7, Line 1: SUBDIRS = xua m2ua ss7 vty dscp
> AFAIU the vty test will now use the binary from dscp directory, hence dscp needs to go before it: "d […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092
Gerrit-Change-Number: 42809
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Jun 2026 12:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email )
Change subject: Add DSCP configuration support for each individual ASP
......................................................................
Patch Set 7:
(1 comment)
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808/comment/395d3e00_28acc… :
PS6, Line 420: asp->cfg.ip_dscp = atoi(argv[0]);
> In here you are missing: […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ia125a392eec5605553809774162675b5249b8494
Gerrit-Change-Number: 42808
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Jun 2026 12:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email )
Change subject: Add DSCP configuration support for server transport role
......................................................................
Patch Set 4:
(3 comments)
File src/ss7_xua_srv_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/a218a8f9_4bca7… :
PS3, Line 152: "ip-dscp " IP_DSCP_RANGE_STR,
> Please also change the names of the functions and commands inside DEFUN_ATTR to adapt to the new nam […]
Done
File src/ss7_xua_srv_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/4970a1cc_bd109… :
PS4, Line 167: NO_STR "Reset IP DSCP of Listener to default\n",
> The NO_STR usually means we write the next param the same way as in the positive case iirc.
Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/63c214c0_6ed27… :
PS4, Line 256: vty_out(vty, " ip-dscp %u%s", xs->cfg.ip_dscp, VTY_NEWLINE);
> the fact that this (with non-matching name) passes build verification also shows that the vty test i […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e
Gerrit-Change-Number: 42807
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Jun 2026 12:16:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817?usp=email )
Change subject: Add VTY test for "listen" node of osmo-stp VTY config
......................................................................
Add VTY test for "listen" node of osmo-stp VTY config
Change-Id: Ia1ceb5f0374f47ff269b557be30fc4d59550d1a6
---
M tests/vty/osmo_stp_test.vty
1 file changed, 46 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/17/42817/1
diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty
index 513c549..e34460b 100644
--- a/tests/vty/osmo_stp_test.vty
+++ b/tests/vty/osmo_stp_test.vty
@@ -388,6 +388,52 @@
OsmoSTP(config-cs7-asp)# no shutdown
OsmoSTP(config-cs7-asp)# exit
% NOTE: Skipping automatic restart of ASP since an explicit '[no] shutdown' command was entered
+OsmoSTP(config-cs7)# listen m3ua 2905
+OsmoSTP(config-cs7-listen)# list
+...
+ help
+ list [with-flags]
+ show vty-attributes
+ show vty-attributes (application|library|global)
+ write terminal
+ write file [PATH]
+ write memory
+ write
+ show running-config
+ exit
+ end
+ local-ip (A.B.C.D|X:X::X:X)
+ no local-ip (A.B.C.D|X:X::X:X)
+ init-ip-dscp <0-63>
+ no init-ip-dscp
+ accept-asp-connections (pre-configured|dynamic-permitted)
+ sctp-param init (num-ostreams|max-instreams) <0-65535>
+ no sctp-param init (num-ostreams|max-instreams)
+...
+
+OsmoSTP(config-cs7-listen)# ?
+...
+ help Description of the interactive help system
+ list Print command list
+ show Show running system information
+ write Write running configuration to memory, network, or terminal
+ exit Exit current mode and down to previous mode
+ end End current mode and change to enable mode.
+ local-ip Configure the Local IP Address for xUA
+ no Negate a command or set its defaults
+ init-ip-dscp Specify IP DSCP of Listener
+ accept-asp-connections Define what kind of ASP connections to accept
+ sctp-param Configure SCTP parameters
+...
+
+OsmoSTP(config-cs7-listen)# no ?
+...
+ local-ip Configure the Local IP Address for xUA
+ init-ip-dscp Specify IP DSCP of Listener
+ sctp-param Configure SCTP parameters
+...
+
+OsmoSTP(config-cs7-listen)# exit
OsmoSTP(config-cs7)# as my-ass m3ua
OsmoSTP(config-cs7-as)# list
...
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ia1ceb5f0374f47ff269b557be30fc4d59550d1a6
Gerrit-Change-Number: 42817
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly, laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by Jenkins Builder
Change subject: Add DSCP configuration support for each individual ASP
......................................................................
Add DSCP configuration support for each individual ASP
Introduce VTY command to configure the Differentiated Services Code
Point (DSCP) values for each Application Server Process.
If the ASP connection has the role "server", it will inherit the DSCP
settings of the listener, unless it is configured at the ASP connection.
Related: SYS#8071
Change-Id: Ia125a392eec5605553809774162675b5249b8494
---
M src/ss7_asp.c
M src/ss7_asp.h
M src/ss7_asp_vty.c
M src/ss7_xua_srv.c
M tests/vty/osmo_stp_test.vty
M tests/vty/ss7_asp_test.vty
6 files changed, 59 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/08/42808/7
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ia125a392eec5605553809774162675b5249b8494
Gerrit-Change-Number: 42808
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: Add DSCP configuration support for server transport role
......................................................................
Add DSCP configuration support for server transport role
Introduce VTY command to configure the Differentiated Services Code
Point (DSCP) values for transport "role" server.
The configured DSCP value is applied to the listener socket. Incoming
socket connections will then automatically inherit these DSCP settings
from the listener socket.
It is not (yet) possible to configure DSCP values for individual active
server connections. The setting applies globally via the listener.
A later patch will allow DSCP configuration of each individual ASP.
Related: SYS#8071
Depends: libosmo-netif.git Change-Id Ic70422ec73c753b61843444582f8665ca42e7a6d
Change-Id: I35eab3672157c318616f51ee3042243aed263d4e
---
M TODO-RELEASE
M src/ss7_vty.h
M src/ss7_xua_srv.c
M src/ss7_xua_srv.h
M src/ss7_xua_srv_vty.c
5 files changed, 46 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/42807/5
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e
Gerrit-Change-Number: 42807
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly, laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add test case to verify proper DSCP settings
......................................................................
Add test case to verify proper DSCP settings
Related: SYS#8071
Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092
---
M .gitignore
M configure.ac
M tests/Makefile.am
A tests/dscp/Makefile.am
A tests/dscp/dscp_test.ok
A tests/dscp/get_tos_diag.c
A tests/dscp/osmo-stp-dscp.cfg
M tests/testsuite.at
M tests/vty/vty_test_runner.py
9 files changed, 201 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/42809/8
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092
Gerrit-Change-Number: 42809
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: Hoernchen, jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42794?usp=email )
Change subject: CCID: Add test to verify a working Simtrace setup
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42794?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I19264bc257024e9028996e417ff23bbbaebf5f92
Gerrit-Change-Number: 42794
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 04 Jun 2026 08:20:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes