June 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-trx[master]: trx-usrp1: make single daughterboard VTY configurable
by laforge 03 Jun '26

03 Jun '26

Attention is currently required from: tempest. laforge has posted comments on this change by tempest. ( https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email ) Change subject: trx-usrp1: make single daughterboard VTY configurable ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I618fdcc7fec1ca1e87249992798c265430c177a0 Gerrit-Change-Number: 42811 Gerrit-PatchSet: 4 Gerrit-Owner: tempest <jackleea1b(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tempest <jackleea1b(a)gmail.com> Gerrit-Comment-Date: Wed, 03 Jun 2026 21:23:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ccid-firmware[master]: libosmo_emb: type-safe tearfree_u64_t wrapper for LDRD/STRD access
by laforge 03 Jun '26

03 Jun '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42784?usp=email ) Change subject: libosmo_emb: type-safe tearfree_u64_t wrapper for LDRD/STRD access ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > The whole point of c++ templates/c11 generics is that types are never automatically converted and ty […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I458bfaf53e27c51882c7a8c1326e51d12943b0bb Gerrit-Change-Number: 42784 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jun 2026 18:12:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ccid-firmware[master]: libosmo_emb: type-safe tearfree_u64_t wrapper for LDRD/STRD access
by Hoernchen 03 Jun '26

03 Jun '26

Attention is currently required from: laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42784?usp=email ) Change subject: libosmo_emb: type-safe tearfree_u64_t wrapper for LDRD/STRD access ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Looking at the patch, I don't really see what it gains us? There appears to be no code that we can […] The whole point of c++ templates/c11 generics is that types are never automatically converted and types have to match so this patch ensures you get compile time errors if you try to call the functions with unaligned data that is not our struct. Things the compiler can check at compile time should be loaded off to the compiler, in particular unexpected requirements like alignment. Many parts of the firmware could be much safer and easier to understand by introducing generics + TS 25755/gcc >8 __cleanup__ defer. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I458bfaf53e27c51882c7a8c1326e51d12943b0bb Gerrit-Change-Number: 42784 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 03 Jun 2026 16:17:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ccid-firmware[master]: 7816fsm: Handle unexpected procedure bytes gracefully
by Hoernchen 03 Jun '26

03 Jun '26

Attention is currently required from: laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email ) Change subject: 7816fsm: Handle unexpected procedure bytes gracefully ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > so what do we do about the clang-format linter? If even Patches by the proponent of this are failing […] I didn't bother formatting it because we never commited the updated rules nor the guards around the bespoke code blocks that should not be touched both in https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42355 , so of course it fails. Updating the formatting patches is just re-running clang format and updating the 3 commits, while merging it first would likely cause a mess trying to get this changeset merged... -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic53814540775f902fce644a5565a7bd2f177a7fe Gerrit-Change-Number: 42776 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 03 Jun 2026 15:58:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: move podman_extra to testsrcdir.cfg
by pespin 03 Jun '26

03 Jun '26

Attention is currently required from: fixeria, jolly, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42816?usp=email ) Change subject: testenv: move podman_extra to testsrcdir.cfg ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I fail to see why this option has to be set (inconditionally) for all .cfg files. I can imagine for instnace only in testenv frameRelay one wants to pass something. So why removing it from setting it in specific testenv_.cfg? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12e187726673e1ca1b1ecfff6b34b1803127be86 Gerrit-Change-Number: 42816 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jun 2026 13:47:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: move titan_min to testsrcdir.cfg
by pespin 03 Jun '26

03 Jun '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42815?usp=email ) Change subject: testenv: move titan_min to testsrcdir.cfg ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42815?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife12e3b3294ce16ebedee1b7998d3b89856f0328 Gerrit-Change-Number: 42815 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jun 2026 13:45:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: introduce testsrcdir.cfg
by pespin 03 Jun '26

03 Jun '26

Attention is currently required from: fixeria, jolly, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42814?usp=email ) Change subject: testenv: introduce testsrcdir.cfg ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42814/comment/94394168_46cd… : PS2, Line 7: testenv: introduce testsrcdir.cfg I find the "testsrcdir" confusing. Did you think about using simply "testenv_common" or "testenv_shared" or similar? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8eceea7b874ce1352e2cc9780b77d2a8e694cd28 Gerrit-Change-Number: 42814 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jun 2026 13:44:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Add test case to verify proper DSCP settings
by pespin 03 Jun '26

03 Jun '26

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email ) Change subject: Add test case to verify proper DSCP settings ...................................................................... Patch Set 7: (2 comments) File tests/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/b5cb4f5c_493b4… : PS7, Line 1: SUBDIRS = xua m2ua ss7 vty dscp AFAIU the vty test will now use the binary from dscp directory, hence dscp needs to go before it: "dscp vty". File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/b6e9dfbc_b7a91… : PS7, Line 32: AT_CHECK([python3 -u $abs_top_builddir/tests/vty/vty_test_runner.py -w $abs_top_builddir -p $abs_srcdir -v TestDSCP],, [ignore], [ignore]) Why not launching automatically as part of tests/vty/Makefile.am, see target "vty-python-test"? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 Gerrit-Change-Number: 42809 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 03 Jun 2026 13:41:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: Add DSCP configuration support for each individual ASP
by pespin 03 Jun '26

03 Jun '26

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email ) Change subject: Add DSCP configuration support for each individual ASP ...................................................................... Patch Set 6: Code-Review-1 (1 comment) File src/ss7_asp_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808/comment/54dd74d3_e45f7… : PS6, Line 420: asp->cfg.ip_dscp = atoi(argv[0]); In here you are missing: Check if ASP is server/client, then check if server/client is already created; in that case call _set_ip_dscp() on it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia125a392eec5605553809774162675b5249b8494 Gerrit-Change-Number: 42808 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 03 Jun 2026 13:32:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: Add DSCP configuration support for server transport role
by pespin 03 Jun '26

03 Jun '26

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email ) Change subject: Add DSCP configuration support for server transport role ...................................................................... Patch Set 4: (3 comments) File src/ss7_xua_srv_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/d855b1a2_441d3… : PS3, Line 152: "ip-dscp " IP_DSCP_RANGE_STR, > Done Please also change the names of the functions and commands inside DEFUN_ATTR to adapt to the new name. File src/ss7_xua_srv_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/1e025753_5d309… : PS4, Line 167: NO_STR "Reset IP DSCP of Listener to default\n", The NO_STR usually means we write the next param the same way as in the positive case iirc. https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/ca6be987_1207f… : PS4, Line 256: vty_out(vty, " ip-dscp %u%s", xs->cfg.ip_dscp, VTY_NEWLINE); You missed updating the name here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e Gerrit-Change-Number: 42807 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 03 Jun 2026 13:28:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026