Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42780?usp=email )
Change subject: 7816fsm: fail PPS on invalid first byte in PPS_S_WAIT_PPSX
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42780?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I5b74b8443a98224c0c95a664a886066495d8b64a
Gerrit-Change-Number: 42780
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jun 2026 08:50:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42779?usp=email )
Change subject: 7816fsm: reset stale cuart state on FSM RESET entry
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42779?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Iac8bd7f4f0eecccc9acce149277a4f5016fec7c1
Gerrit-Change-Number: 42779
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jun 2026 08:49:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42777?usp=email )
Change subject: cuart: Fix waiting time to be per-byte instead of total timeout
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42777?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ic00040b88e1b204db3f4f3edad09878aa28d35a1
Gerrit-Change-Number: 42777
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jun 2026 08:48:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email )
Change subject: 7816fsm: Handle unexpected procedure bytes gracefully
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
so what do we do about the clang-format linter? If even Patches by the proponent of this are failing, I would argue let's do away with it. It was an interesting experiment, but by now I think it is the single most delaying/blocking factor getting patches merge to this repo.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ic53814540775f902fce644a5565a7bd2f177a7fe
Gerrit-Change-Number: 42776
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jun 2026 08:47:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42771?usp=email )
Change subject: pySim/ts_51_011: rewrite comment for better understanding
......................................................................
pySim/ts_51_011: rewrite comment for better understanding
The comment reads like that we were applying TS 102.221 here, but we only
mean our internal decoding format. The spec that actually matters here is
TS 51.011. Let's rephrase the comment so that this becomes more clear.
Related: OS#7018
Change-Id: Ie0184eea25f4d9f4baf9ab137c53a926edba2bf8
---
M pySim/ts_51_011.py
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py
index 89ff824..4cad049 100644
--- a/pySim/ts_51_011.py
+++ b/pySim/ts_51_011.py
@@ -1263,9 +1263,11 @@
@staticmethod
def decode_select_response(resp_hex: str) -> object:
- # we try to build something that resembles a dict resulting from the TLV decoder
- # of TS 102.221 (FcpTemplate), so that higher-level code only has to deal with one
- # format of SELECT response
+ """
+ Decode the select response to a dict representation, similar to the one of TS 102.221 (see ts_102_221.py,
+ class FcpTemplate), so that higher-level code only has to deal with one respresentation. See also
+ 3GPP TS 51.011, section 9.2.1
+ """
resp_bin = h2b(resp_hex)
struct_of_file_map = {
0: 'transparent',
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42771?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie0184eea25f4d9f4baf9ab137c53a926edba2bf8
Gerrit-Change-Number: 42771
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42812?usp=email )
Change subject: jobs/octsim_osmo-ccid-firmware: add timeout arg
......................................................................
jobs/octsim_osmo-ccid-firmware: add timeout arg
For testing the hook scripts (see next patch), it is useful to have a
shorter timeout for some test runs. Make it configurable.
Related: SYS#8011
Change-Id: I3bac142a9e2e5f144ad52ea7c36c05ffbad6f5d1
---
M jobs/octsim_osmo-ccid-firmware.yml
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
jolly: Looks good to me, but someone else must approve
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml
index dc6ea35..e0617e7 100644
--- a/jobs/octsim_osmo-ccid-firmware.yml
+++ b/jobs/octsim_osmo-ccid-firmware.yml
@@ -16,12 +16,16 @@
name: EMAIL_NOTIFICATIONS
description: For failed build notifications, set to empty to disable
default: 'jenkins-notifications(a)lists.osmocom.org jsteiger(a)sysmocom.de acouzens(a)sysmocom.de'
+ - string:
+ name: TIMEOUT
+ description: Abort the tests after this time in case they hang
+ default: '30m'
builders:
- shell: |
export PYTHONUNBUFFERED=1
cd ./tests
mkdir -p sysmo-octsim/dl
- timeout 30m ./run-tests
+ timeout $TIMEOUT ./run-tests
scm:
- git:
url: https://gerrit.osmocom.org/osmo-ccid-firmware
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42812?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I3bac142a9e2e5f144ad52ea7c36c05ffbad6f5d1
Gerrit-Change-Number: 42812
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>