Attention is currently required from: fixeria, jolly, laforge, osmith.
Hello Jenkins Builder, fixeria, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/42813?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by jolly, Code-Review+2 by laforge
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: jobs/osmo-ccid-firmware: run hooks for logs
......................................................................
jobs/osmo-ccid-firmware: run hooks for logs
Run the start-hook.sh / stop-hook.sh scripts that store pcscd logs and a
usbmon capture. The jenkins node is configured to allow running these
two scripts with sudo as jenkins user. Store the resulting files as
artifacts.
Related: SYS#8011
Change-Id: Id0d9a39fda24813572b979588c0ca22918829ad4
---
M jobs/gerrit-osmo-ccid-firmware-hwtest.yml
M jobs/octsim_osmo-ccid-firmware.yml
2 files changed, 19 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/13/42813/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id0d9a39fda24813572b979588c0ca22918829ad4
Gerrit-Change-Number: 42813
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, laforge.
tempest has posted comments on this change by tempest. ( https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email )
Change subject: trx-usrp1: make single daughterboard VTY configurable
......................................................................
Patch Set 4:
(1 comment)
File CommonLibs/trx_vty.c:
https://gerrit.osmocom.org/c/osmo-trx/+/42811/comment/c8044c99_7bd09da1?usp… :
PS2, Line 643: if (strcmp("disable", argv[0]) == 0)
: trx->cfg.usrp1_singledb = false;
:
: if (strcmp("enable", argv[0]) == 0)
:
> ```suggestion […]
looks good, was following the formatting of the other enable/disable options in trx_vty.c but this works too
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I618fdcc7fec1ca1e87249992798c265430c177a0
Gerrit-Change-Number: 42811
Gerrit-PatchSet: 4
Gerrit-Owner: tempest <jackleea1b(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Jun 2026 19:07:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, tempest.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: trx-usrp1: make single daughterboard VTY configurable
......................................................................
trx-usrp1: make single daughterboard VTY configurable
Adds the usrp1-singledb enable/disable option to specify the
daughterboard configuration on USRP1 devices. This will allow users
to use single-daughterboard devices without compliling from source to
use the --with-singledb configure option.
Also removed some daughterboard configuration related code that
wasn't being used.
More info in the modified trx-backends.adoc
Change-Id: I618fdcc7fec1ca1e87249992798c265430c177a0
---
M CommonLibs/config_defs.h
M CommonLibs/trx_vty.c
M Transceiver52M/device/usrp1/USRPDevice.cpp
M configure.ac
M doc/manuals/chapters/trx-backends.adoc
5 files changed, 27 insertions(+), 39 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/42811/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42811?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I618fdcc7fec1ca1e87249992798c265430c177a0
Gerrit-Change-Number: 42811
Gerrit-PatchSet: 4
Gerrit-Owner: tempest <jackleea1b(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tempest <jackleea1b(a)gmail.com>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42793?usp=email )
Change subject: CCID: Integrate SIMTRACE emulation into test cases
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42793?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia27dd5198edb188bc73196ac3fbd6d56ba75812e
Gerrit-Change-Number: 42793
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 02 Jun 2026 16:42:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42805?usp=email )
Change subject: CCID: Check response of reader with empty SIM carrier
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42805?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifebdcce8f9dd9a51de5a5cb6cf223041d5c38622
Gerrit-Change-Number: 42805
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 02 Jun 2026 16:41:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42804?usp=email )
Change subject: CCID: Check if reader sends request TPDU with maximum size
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42804?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7c1cb52b578c19d6c0ec1493e45f6ed9c43735b4
Gerrit-Change-Number: 42804
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 02 Jun 2026 16:41:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42802?usp=email )
Change subject: CCID: Check if reader restarts WWT upon NULL procedure byte
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42802?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4eb09e86f88df19d96e9ec55872654352ca2ebd5
Gerrit-Change-Number: 42802
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 02 Jun 2026 16:40:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes