Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42723?usp=email )
Change subject: ansible/README: mention how to update coverity
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42723?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Icab33640e0b8c62c5808d918efb6877bc1fdf1f6
Gerrit-Change-Number: 42723
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 May 2026 08:03:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Timur Davydov, laforge, pespin.
fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email )
Change subject: build: remove unused sys/timerfd.h include
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
File src/osmo-bts-trx/scheduler_trx.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42689/comment/48376847_429df94c?usp… :
PS2, Line 31: #ifdef HAVE_SYS_TIMERFD_H
: #include <sys/timerfd.h>
: #e
> Yes, it makes sense. I moved this check after including btsconfig. […]
Done
File src/osmo-bts-trx/scheduler_trx.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42689/comment/b7426eb3_3427e3b2?usp… :
PS3, Line 56: #endif
> Right, the code builds fine without this header. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a
Gerrit-Change-Number: 42689
Gerrit-PatchSet: 4
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Fri, 01 May 2026 20:06:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Timur Davydov.
fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42688?usp=email )
Change subject: build: make linux/if_packet.h usage optional
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42688?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8a02b0676e65fa4b6191073c84e0646a2e67a010
Gerrit-Change-Number: 42688
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Fri, 01 May 2026 20:06:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge.
Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: transceiver: add optional WebSDR device support
......................................................................
Patch Set 14:
(11 comments)
File Transceiver52M/Transceiver.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/4c4251d4_c875ea30?usp… :
PS14, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/bef8c136_54a26538?usp… :
PS14, Line 247: TIMESTAMP ts, unsigned samples_skipped);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/fd5a2644_dc403ce3?usp… :
PS14, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/2aa25e5f_6afce343?usp… :
PS14, Line 265: ssize_t driveReceiveFIFOBurst(size_t chan, char *burstBuffer, size_t burstBufferLen);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/769dedc9_d9014aaf?usp… :
PS14, Line 271: @brief modulation and sorting of GSM bursts from GSM core
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/c593fd7e_e09db41c?usp… :
PS14, Line 272: @param chan channel number
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/0da03343_dbbe50f2?usp… :
PS14, Line 273: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/40b7def4_14d68ef0?usp… :
PS14, Line 274: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/3bbbfb12_4b8f708f?usp… :
PS14, Line 277: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0);
please, no spaces at the start of a line
File Transceiver52M/radioInterface.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/1acdf759_69917528?usp… :
PS14, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/42d14bdd_c341db88?usp… :
PS14, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts);
please, no spaces at the start of a line
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
Gerrit-Change-Number: 42411
Gerrit-PatchSet: 14
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Fri, 01 May 2026 17:18:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge.
Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: transceiver: add optional WebSDR device support
......................................................................
Patch Set 13:
(11 comments)
File Transceiver52M/Transceiver.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/50af2c7f_9167f601?usp… :
PS13, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/cef744e3_929fdb44?usp… :
PS13, Line 247: TIMESTAMP ts, unsigned samples_skipped);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/ca4b6089_df896ea2?usp… :
PS13, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/708ca7cc_52e73852?usp… :
PS13, Line 265: ssize_t driveReceiveFIFOBurst(size_t chan, char *burstBuffer, size_t burstBufferLen);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/2df0e11d_3abab7ef?usp… :
PS13, Line 271: @brief modulation and sorting of GSM bursts from GSM core
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/3f2312e8_cd8255d2?usp… :
PS13, Line 272: @param chan channel number
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/072637b2_405a1539?usp… :
PS13, Line 273: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/963dbe30_b593e0d8?usp… :
PS13, Line 274: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/fa3ce151_d2a503ba?usp… :
PS13, Line 277: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0);
please, no spaces at the start of a line
File Transceiver52M/radioInterface.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/46122e20_0bc9d26d?usp… :
PS13, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/162668db_7e780ab5?usp… :
PS13, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts);
please, no spaces at the start of a line
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
Gerrit-Change-Number: 42411
Gerrit-PatchSet: 13
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Fri, 01 May 2026 17:14:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email
to look at the new patch set (#4).
Change subject: build: detect pthread_setname_np and sched_* APIs, guard usage
......................................................................
build: detect pthread_setname_np and sched_* APIs, guard usage
Add configure checks for pthread_setname_np and sched_* functions.
Wrap their usage with HAVE_* guards to avoid build failures on
platforms where they are unavailable.
Return -ENOTSUP for unsupported scheduler operations.
Improves portability across non-Linux and restricted environments
(e.g. WebAssembly).
Change-Id: Ic3f1492544439d88c5e6683330c6696de1c2f85b
---
M CommonLibs/Threads.cpp
M Transceiver52M/device/ipc/ipc-driver-test.c
M Transceiver52M/ms/l1ctl_server_cb.cpp
M Transceiver52M/ms/ms_rx_lower.cpp
M Transceiver52M/ms/ms_trxcon_if.cpp
M Transceiver52M/ms/ms_upper.cpp
M Transceiver52M/ms/threadsched.cpp
M Transceiver52M/ms/uhd_specific.h
M Transceiver52M/osmo-trx.cpp
M configure.ac
10 files changed, 62 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/54/42654/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f1492544439d88c5e6683330c6696de1c2f85b
Gerrit-Change-Number: 42654
Gerrit-PatchSet: 4
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>