May 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: nokia bts-reset-timer: raise the maximum to 300 s
by laforge 04 May '26

04 May '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42715?usp=email ) Change subject: nokia bts-reset-timer: raise the maximum to 300 s ...................................................................... nokia bts-reset-timer: raise the maximum to 300 s The previous vty tuning range for this timer (allowing up to 100 s) is not sufficient for Flexi Multiradio BTS, where we need 120 s minimum or 130 s for some margin. Raise the upper limit for vty config of this parameter to 5 min, which should be long enough to not require further revisiting. Change-Id: Ie5b784c9cce56e27800084471a7fb0b867cc0c69 --- M src/osmo-bsc/bts_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index d289bcf..3afa0cc 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -431,7 +431,7 @@ DEFUN_ATTR(cfg_bts_nokia_site_bts_reset_timer_cnf, cfg_bts_nokia_site_bts_reset_timer_cnf_cmd, - "nokia_site bts-reset-timer <15-100>", + "nokia_site bts-reset-timer <15-300>", NOKIA_STR "The amount of time between BTS_RESET is sent " "and the BTS is being bootstrapped\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie5b784c9cce56e27800084471a7fb0b867cc0c69 Gerrit-Change-Number: 42715 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-bsc[master]: nokia: make Rx diversity configurable
by laforge 04 May '26

04 May '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email ) Change subject: nokia: make Rx diversity configurable ...................................................................... nokia: make Rx diversity configurable The config structure sent to the BTS with BTS_CONF_DATA includes an IE that enables or disables Rx diversity. In the original code this setting was hard-coded to enabled state; make it configurable via vty. Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_nokia_site.c M src/osmo-bsc/bts_vty.c 4 files changed, 28 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 48b84af..f05f41c 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -506,7 +506,8 @@ bts_reset_timer_cnf, /* timer for BTS RESET */ did_reset:1, /* we received a RESET ACK */ wait_reset:2, /* we are waiting for reset to complete */ - hopping_mode:1; /* hopping type selection for Nokia */ + hopping_mode:1, /* hopping type selection for Nokia */ + rx_diversity:1; /* enable Rx diversity */ struct osmo_timer_list reset_timer; /* segmented OML Rx buffer */ struct { diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 77721fb..2ec4865 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -747,6 +747,8 @@ case GSM_BTS_TYPE_NOKIA_SITE: /* Set default BTS reset timer */ bts->nokia.bts_reset_timer_cnf = 15; + /* Enable Rx diversity by default, for backward compat */ + bts->nokia.rx_diversity = 1; case _NUM_GSM_BTS_TYPE: break; } diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 3b06d4b..e66f238 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -1210,6 +1210,8 @@ break; } } + /* enable or disable Rx diversity */ + fu_config[len + 7] = bts->nokia.rx_diversity; len += sizeof(bts_config_2); /* set extended cell radius for each TRX */ diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index cbf00d0..d289bcf 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -474,6 +474,26 @@ return CMD_SUCCESS; } +DEFUN_USRATTR(cfg_bts_nokia_site_rx_div, + cfg_bts_nokia_site_rx_div_cmd, + X(BSC_VTY_ATTR_RESTART_ABIS_OML_LINK), + "nokia_site rx-diversity (0|1)", + NOKIA_STR + "Rx diversity feature\n" + "Disable Rx diversity\n" "Enable Rx diversity\n") +{ + struct gsm_bts *bts = vty->index; + + if (!is_nokia_bts(bts)) { + vty_out(vty, "%% BTS is not of Nokia type%s", VTY_NEWLINE); + return CMD_WARNING; + } + + bts->nokia.rx_diversity = atoi(argv[0]); + + return CMD_SUCCESS; +} + #define OML_STR "Organization & Maintenance Link\n" #define IPA_STR "A-bis/IP Specific Options\n" @@ -4720,6 +4740,7 @@ bts->nokia.no_loc_rel_cnf, VTY_NEWLINE); vty_out(vty, " nokia_site bts-reset-timer %d%s", bts->nokia.bts_reset_timer_cnf, VTY_NEWLINE); vty_out(vty, " nokia_site hopping-mode %s%s", get_value_string(nokia_hopping_mode_strs, bts->nokia.hopping_mode), VTY_NEWLINE); + vty_out(vty, " nokia_site rx-diversity %d%s", bts->nokia.rx_diversity, VTY_NEWLINE); /* fall through: Nokia requires "oml e1" parameters also */ default: @@ -4948,6 +4969,7 @@ install_element(BTS_NODE, &cfg_bts_nokia_site_no_loc_rel_cnf_cmd); install_element(BTS_NODE, &cfg_bts_nokia_site_bts_reset_timer_cnf_cmd); install_element(BTS_NODE, &cfg_bts_nokia_site_hopping_mode_cmd); + install_element(BTS_NODE, &cfg_bts_nokia_site_rx_div_cmd); install_element(BTS_NODE, &cfg_bts_stream_id_cmd); install_element(BTS_NODE, &cfg_bts_deprecated_stream_id_cmd); install_element(BTS_NODE, &cfg_bts_oml_e1_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 Gerrit-Change-Number: 42714 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: csaba.sipos <metro4(a)freemail.hu> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: rsl: don't send legacy Chan Ident IE for Nokia BTS
by laforge 04 May '26

04 May '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42717?usp=email ) Change subject: rsl: don't send legacy Chan Ident IE for Nokia BTS ...................................................................... rsl: don't send legacy Chan Ident IE for Nokia BTS The description of CHAN ACTIV command message in TS 48.058 section 8.4.1 lists Channel Identification as an optional IE, with a note that reads "Included if compatibility with phase1 is required." This note may have been misinterpreted as referring to compatibility with Phase 1 phones - but since this network-internal Abis detail is invisible to phones, the real intent of GSM spec authors here must have been compatibility with Phase 1 BTS. Previous versions of OsmoBSC would always include this IE, and it appears that all previously supported BTS models would simply ignore it. However, newer Nokia BTS models (observed on Flexi Multiradio at least) dislike this IE and return CHAN ACTIV NACK with an optional IE error cause if it is included. To avoid changing OsmoBSC behavior for other users, let us conditionalize removal of this legacy IE on Nokia BTS for now. This change has been tested on InSite, MetroSite and Flexi Multiradio - no adverse effects on previously supported *Site models. Change-Id: Ibce7a841907ac87ae378ded3ddb174d38b70b7b7 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 46 insertions(+), 19 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 42a164a..4627914 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -577,6 +577,31 @@ msgb_put_u8(msg, tsc); } +static void add_phase1_chan_ident(struct msgb *msg, const struct gsm48_chan_desc *cd) +{ + uint8_t *len; + + /* + * This Channel Identification IE is a Phase1 backward compatibility + * measure. It contains the GSM48 Channel Description and the + * Mobile Allocation. TS 48.058 section 9.3.5 asks for MA + * to have a length of zero. We are using msgb_l3len() to calculate + * the length of both messages. + */ + msgb_v_put(msg, RSL_IE_CHAN_IDENT); + len = msgb_put(msg, 1); + msgb_tv_fixed_put(msg, GSM48_IE_CHANDESC_2, sizeof(*cd), (const uint8_t *) cd); + + /* See 3GPP TS 48.058 (version 15.0.0), section 9.3.5 "Channel Identification". + * The 3GPP TS 24.008 "Mobile Allocation" shall for compatibility reasons + * be included but empty, i.e. the length shall be zero. */ + msgb_tlv_put(msg, GSM48_IE_MA_AFTER, 0, NULL); + + /* update the calculated size */ + msg->l3h = len + 1; + *len = msgb_l3len(msg); +} + /* Chapter 8.4.1 */ int rsl_tx_chan_activ(struct gsm_lchan *lchan, uint8_t act_type, uint8_t ho_ref) { @@ -585,7 +610,6 @@ struct abis_rsl_dchan_hdr *dh; struct msgb *msg; int rc; - uint8_t *len; struct rsl_ie_chan_mode cm; struct gsm48_chan_desc cd; @@ -625,25 +649,28 @@ msgb_tlv_put(msg, RSL_IE_CHAN_MODE, sizeof(cm), (uint8_t *) &cm); - /* - * The Channel Identification is needed for Phase1 phones - * and it contains the GSM48 Channel Description and the - * Mobile Allocation. The GSM 08.58 asks for the Mobile - * Allocation to have a length of zero. We are using the - * msgb_l3len to calculate the length of both messages. + /* The description of CHAN ACTIV command message in TS 48.058 + * section 8.4.1 lists Channel Identification as an optional IE, + * with a note that reads "Included if compatibility with phase1 + * is required." This note may have been misinterpreted as + * referring to compatibility with Phase 1 phones - but since + * this network-internal Abis detail is invisible to phones, + * the real intent of GSM spec authors here must have been + * compatibility with Phase 1 BTS. + * + * Previous versions of OsmoBSC would always include this IE, + * and it appears that all previously supported BTS models + * would simply ignore it. However, newer Nokia BTS models + * (observed on Flexi Multiradio at least) dislike this IE + * and return CHAN ACTIV NACK with an optional IE error cause + * if it is included. + * + * To avoid changing OsmoBSC behavior for other users, + * let us conditionalize removal of this legacy IE on + * Nokia BTS for now. */ - msgb_v_put(msg, RSL_IE_CHAN_IDENT); - len = msgb_put(msg, 1); - msgb_tv_fixed_put(msg, GSM48_IE_CHANDESC_2, sizeof(cd), (const uint8_t *) &cd); - - /* See 3GPP TS 48.058 (version 15.0.0), section 9.3.5 "Channel Identification". - * The 3GPP TS 24.008 "Mobile Allocation" shall for compatibility reasons - * be included but empty, i.e. the length shall be zero. */ - msgb_tlv_put(msg, GSM48_IE_MA_AFTER, 0, NULL); - - /* update the calculated size */ - msg->l3h = len + 1; - *len = msgb_l3len(msg); + if (!is_nokia_bts(bts)) + add_phase1_chan_ident(msg, &cd); if (lchan->encr.alg_a5_n > 0) { uint8_t encr_info[MAX_A5_KEY_LEN+2]; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibce7a841907ac87ae378ded3ddb174d38b70b7b7 Gerrit-Change-Number: 42717 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-bsc[master]: rsl: don't send legacy Chan Ident IE for Nokia BTS
by laforge 04 May '26

04 May '26

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42717?usp=email ) Change subject: rsl: don't send legacy Chan Ident IE for Nokia BTS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibce7a841907ac87ae378ded3ddb174d38b70b7b7 Gerrit-Change-Number: 42717 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 04 May 2026 09:14:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia: respond to BTS_COMMISS_TEST_REQ
by laforge 04 May '26

04 May '26

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42716?usp=email ) Change subject: nokia: respond to BTS_COMMISS_TEST_REQ ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42716?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2710c3cdb38a9e5b37e40ca5584237a730a902 Gerrit-Change-Number: 42716 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 04 May 2026 09:14:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: nokia bts-reset-timer: raise the maximum to 300 s
by laforge 04 May '26

04 May '26

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42715?usp=email ) Change subject: nokia bts-reset-timer: raise the maximum to 300 s ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie5b784c9cce56e27800084471a7fb0b867cc0c69 Gerrit-Change-Number: 42715 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 04 May 2026 09:14:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia: make Rx diversity configurable
by laforge 04 May '26

04 May '26

Attention is currently required from: csaba.sipos, falconia, fixeria, pespin. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email ) Change subject: nokia: make Rx diversity configurable ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42714/comment/ec97f158_51bcd286?usp… : PS3, Line 1214: fu_config[len + 7] = bts->nokia.rx_diversity; > @pespin@sysmocom. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 Gerrit-Change-Number: 42714 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: csaba.sipos <metro4(a)freemail.hu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 May 2026 09:14:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: server: add a client timeout test
by laforge 04 May '26

04 May '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email ) Change subject: remsim: server: add a client timeout test ...................................................................... remsim: server: add a client timeout test 1. Connect to the server 2. Don't answer to IPA PINGs 3. Server closes the connection 4. Client reconnects 5. Older server versions will crash Related: OS#6957 Change-Id: Iec52d3ce229c2ab84ab0ff9d8dbbff59b7f3fbd9 --- M remsim/REMSIM_Tests.ttcn M remsim/RemsimServer_Tests.ttcn 2 files changed, 64 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/remsim/REMSIM_Tests.ttcn b/remsim/REMSIM_Tests.ttcn index b97dea1..92c932c 100644 --- a/remsim/REMSIM_Tests.ttcn +++ b/remsim/REMSIM_Tests.ttcn @@ -14,6 +14,7 @@ import from RSPRO all; import from RSPRO_Types all; import from IPA_Types all; +import from IPA_CodecPort all; import from IPA_Emulation all; @@ -43,6 +44,8 @@ type component rspro_client_CT { var RSPRO_Client rspro[NUM_CLIENT]; port IPA_RSPRO_PT RSPRO[NUM_CLIENT]; + port IPA_CFG_PT IPACFG[NUM_CLIENT]; + port IPA_SP_PT IPAPORT[NUM_CLIENT]; }; private altstep as_ignore_id_ack(integer i := 0) runs on rspro_client_CT { @@ -68,6 +71,8 @@ map(clnt.vc_IPA:IPA_PORT, system:IPA_CODEC_PT); connect(clnt.vc_IPA:IPA_RSPRO_PORT, self:RSPRO[i]); + connect(clnt.vc_IPA:CFG_PORT, self:IPACFG[i]); + connect(clnt.vc_IPA:IPA_SP_PORT, self:IPAPORT[i]); clnt.vc_IPA.start(IPA_Emulation.main_client(dst_host, dst_port, "", 10000+i, clnt.ccm_pars)); @@ -96,6 +101,8 @@ runs on rspro_client_CT { clnt.vc_IPA.stop; disconnect(clnt.vc_IPA:IPA_RSPRO_PORT, self:RSPRO[i]); + disconnect(clnt.vc_IPA:CFG_PORT, self:IPACFG[i]); + disconnect(clnt.vc_IPA:IPA_SP_PORT, self:IPAPORT[i]); unmap(clnt.vc_IPA:IPA_PORT, system:IPA_CODEC_PT); } diff --git a/remsim/RemsimServer_Tests.ttcn b/remsim/RemsimServer_Tests.ttcn index 23ea8cb..5850d29 100644 --- a/remsim/RemsimServer_Tests.ttcn +++ b/remsim/RemsimServer_Tests.ttcn @@ -22,6 +22,7 @@ import from Misc_Helpers all; import from IPA_Emulation all; +import from IPA_Types all; import from HTTPmsg_Types all; import from HTTPmsg_PortType all; @@ -177,6 +178,61 @@ setverdict(pass); } +/* A client connects and stops answering to IPA PING/PONGs. + Do a re-connect. Older version of the server will crash. */ +testcase TC_connect_client_ipa_ping_timeout_reconnect() runs on test_CT { + var ComponentIdentity rspro_id := valueof(ts_CompId(remsimClient, "foobar")); + var JsRoot js; + timer T := 60.0; + + f_init(); + g_T_guard.start(90.0); + f_rsres_init(); + f_rspro_init(rspro[0], mp_server_ip, mp_server_port, rspro_id, 0); + rspro[0].rspro_client_slot := valueof(ts_ClientSlot(13,1)); + + js := f_rsres_get("/api/backend/v1/clients"); + if (not match(js.clients, JsClients:{})) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Initial state not empty"); + } + f_rspro_connect_client(0); + js := f_rsres_get("/api/backend/v1/clients"); + if (not match(js.clients[0], tr_JsClient(CONNECTED_CLIENT, rspro[0].rspro_id))) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Non-matching JSON response"); + } + + /* stop answering IPA Ping */ + var IpaCcmMsgtype ipa_ping_msg := IPAC_MSGT_PING; + var octetstring ipa_ping_data := int2oct(enum2int(ipa_ping_msg), 1); + + f_ipa_cfg_chg_ccm_enabled(IPACFG[0], false); + T.start; + alt { + [] IPAPORT[0].receive(t_ASP_IPA_UD(IPAC_PROTO_CCM, ipa_ping_data)) { + log("Received PING. Not answering it."); + repeat; + } + [] RSPRO[0].receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_DOWN)) {} + [] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timed out. Server did not close the connection."); + } + } + + /* connect a second time with the same Client ID */ + f_rspro_init(rspro[1], mp_server_ip, mp_server_port, rspro_id, 1); + rspro[1].rspro_client_slot := valueof(ts_ClientSlot(13,1)); + f_rspro_connect_client(1); + + /* expect the first connection still to be active */ + js := f_rsres_get("/api/backend/v1/clients"); + if (not match(js.clients[0], tr_JsClient(CONNECTED_CLIENT, rspro_id))) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Non-matching JSON response"); + } + + setverdict(pass); +} + + testcase TC_connect_bank() runs on test_CT { var ComponentIdentity rspro_id := valueof(ts_CompId(remsimBankd, "foobar")); var JsRoot js; @@ -597,6 +653,7 @@ execute( TC_connect_and_nothing() ); execute( TC_connect_client() ); execute( TC_connect_client_duplicate() ); + execute( TC_connect_client_ipa_ping_timeout_reconnect() ); /* crashs on version < 1.1.3 (fixed by 00dcb6b47ca6) */ execute( TC_connect_bank() ); execute( TC_connect_bank_duplicate() ); execute( TC_slotmap_add() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iec52d3ce229c2ab84ab0ff9d8dbbff59b7f3fbd9 Gerrit-Change-Number: 42154 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: server: add a client timeout test
by laforge 04 May '26

04 May '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email ) Change subject: remsim: server: add a client timeout test ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iec52d3ce229c2ab84ab0ff9d8dbbff59b7f3fbd9 Gerrit-Change-Number: 42154 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 04 May 2026 09:12:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: ansible/coverity: upgrade to 2024.12.1
by osmith 04 May '26

04 May '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42722?usp=email ) Change subject: ansible/coverity: upgrade to 2024.12.1 ...................................................................... ansible/coverity: upgrade to 2024.12.1 Related: OS#7005 Change-Id: If4f117adcaec67a79f5ee715e063621c7c897e57 --- M ansible/roles/install-coverity/defaults/main.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/ansible/roles/install-coverity/defaults/main.yml b/ansible/roles/install-coverity/defaults/main.yml index 1176fab..d565d00 100644 --- a/ansible/roles/install-coverity/defaults/main.yml +++ b/ansible/roles/install-coverity/defaults/main.yml @@ -1,4 +1,4 @@ --- -coverity_version: 2024.6.1 +coverity_version: 2024.12.1 coverity_installer_file: "cov-analysis-linux64-{{ coverity_version }}.tar.gz" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If4f117adcaec67a79f5ee715e063621c7c897e57 Gerrit-Change-Number: 42722 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026