May 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ccid-firmware[master]: ccid: Handle the TPDU-length = 4 case according to CCID spec
by jolly 04 May '26

04 May '26

Attention is currently required from: laforge. jolly has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42317?usp=email ) Change subject: ccid: Handle the TPDU-length = 4 case according to CCID spec ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > this needs testing first. […] just tested it with a CCID test (TTCN3) and it works as expected. it does not freeze anymore as i experienced today. other CCID tests do not fail. (the new test case will be submitted soon.) -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia27962bda526af3373b36d637e2b548aa01a3346 Gerrit-Change-Number: 42317 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 04 May 2026 16:48:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Clarify name of tcap asp selection function
by daniel 04 May '26

04 May '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42687?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: tcap_as_loadshare: Clarify name of tcap asp selection function ...................................................................... tcap_as_loadshare: Clarify name of tcap asp selection function Change-Id: I327ad282d2689be2bcf7d3da23026717923c9325 --- M src/tcap_as_loadshare.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified lynxis lazus: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index c414c70..1d6ebd9 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -252,7 +252,9 @@ return NULL; } -static struct osmo_ss7_asp *find_asp_no_tcap_range(struct osmo_ss7_as *as) + +/* Select a TCAP-enabled ASP in round-robin fashion */ +static struct osmo_ss7_asp *select_asp_tcap_enabled_rr(struct osmo_ss7_as *as) { struct ss7_as_asp_assoc *assoc; @@ -526,7 +528,7 @@ rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_SELECTED); } else { /* if no ASP found for this TCAP, try to find a non-tcap-range ASP as fallback*/ - asp = find_asp_no_tcap_range(as); + asp = select_asp_tcap_enabled_rr(as); if (asp) rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); else { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I327ad282d2689be2bcf7d3da23026717923c9325 Gerrit-Change-Number: 42687 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Use tcap_trans_track_begin instead of *_entry_create
by daniel 04 May '26

04 May '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42685?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: tcap_as_loadshare: Use tcap_trans_track_begin instead of *_entry_create ...................................................................... tcap_as_loadshare: Use tcap_trans_track_begin instead of *_entry_create *_begin checks for a matching entry and reuses that (with an updated timestamp). This avoids duplicate entries in the tcap cache. Related: SYS#5423 Change-Id: Icbaab976ed8207843129291494176679db574304 --- M src/tcap_as_loadshare.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 635fd73..c549610 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -350,7 +350,7 @@ return -8; } - tcap_trans_track_entry_create(as, asp, &calling_addr, &parsed.otid, &called_addr, NULL); + tcap_trans_track_begin(as, asp, &calling_addr, &parsed.otid, &called_addr, NULL); break; case TCAP_TCMessage_PR_continue: if (!((rc & OTID_SET) && (rc & DTID_SET))) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icbaab976ed8207843129291494176679db574304 Gerrit-Change-Number: 42685 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Don't fill in PC from M3UA
by daniel 04 May '26

04 May '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email ) Change subject: tcap_as_loadshare: Don't fill in PC from M3UA ...................................................................... tcap_as_loadshare: Don't fill in PC from M3UA Filling in the point codes from M3UA breaks down on asymmetric MTP paths where the reply is sent from a different PC than the original message was addressed to. If both calling and called_addr are not point codes then the compare in tcap_trans_track_entry_find() will ignore them. It still matches on otid/dtid. Related: SYS#5423 Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 --- M src/tcap_as_loadshare.c 1 file changed, 0 insertions(+), 24 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index f7ae3b8..635fd73 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -330,18 +330,6 @@ return 0; } - /* TCAP transaction tracking requires point codes */ - if (!(calling_addr.presence & OSMO_SCCP_ADDR_T_PC)) { - /* use M3UA OPC instead */ - calling_addr.pc = opc; - calling_addr.presence |= OSMO_SCCP_ADDR_T_PC; - } - if (!(called_addr.presence & OSMO_SCCP_ADDR_T_PC)) { - /* use M3UA DPC instead */ - called_addr.pc = dpc; - called_addr.presence |= OSMO_SCCP_ADDR_T_PC; - } - /* retrieve the SCCP payload (actual encoded TCAP data) */ ie_data = xua_msg_find_tag(sua, SUA_IEI_DATA); if (!ie_data) @@ -505,18 +493,6 @@ goto out_free_sua; } - /* TCAP transaction tracking requires point codes */ - if (!(calling_addr.presence & OSMO_SCCP_ADDR_T_PC)) { - /* use M3UA OPC instead */ - calling_addr.pc = mtp->opc; - calling_addr.presence |= OSMO_SCCP_ADDR_T_PC; - } - if (!(called_addr.presence & OSMO_SCCP_ADDR_T_PC)) { - /* use M3UA DPC instead */ - called_addr.pc = mtp->dpc; - called_addr.presence |= OSMO_SCCP_ADDR_T_PC; - } - /* retrieve the SCCP payload (TCAP data) */ ie_data = xua_msg_find_tag(sua, SUA_IEI_DATA); if (!ie_data) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails
by daniel 04 May '26

04 May '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email ) Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ...................................................................... tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails Related: SYS#5423 Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 --- M src/tcap_as_loadshare.c 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index c549610..c414c70 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -548,6 +548,12 @@ } asp = tcap_trans_track_continue(as, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); + if (!asp) { + LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for dtid %u/otid %u, using tcap route", parsed.dtid, parsed.otid); + asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); + if (asp) + tcap_trans_track_entry_create(as, asp, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); + } rc = asp ? 0 : -ENOKEY; break; case TCAP_TCMessage_PR_abort: @@ -559,6 +565,10 @@ } asp = tcap_trans_track_end(as, &called_addr, &parsed.dtid, &calling_addr, NULL); + if (!asp) { + LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for dtid %u/otid %u, using tcap route", parsed.dtid, parsed.otid); + asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); + } rc = asp ? 0 : -ENOKEY; break; case TCAP_TCMessage_PR_unidirectional: -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails
by lynxis lazus 04 May '26

04 May '26

Attention is currently required from: daniel, fixeria, pespin. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email ) Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 May 2026 16:04:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Don't fill in PC from M3UA
by lynxis lazus 04 May '26

04 May '26

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email ) Change subject: tcap_as_loadshare: Don't fill in PC from M3UA ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 May 2026 16:04:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: Fix: Reject TPDUs fromm host with less than 5 bytes
by jolly 04 May '26

04 May '26

Attention is currently required from: Hoernchen. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42724?usp=email ) Change subject: Fix: Reject TPDUs fromm host with less than 5 bytes ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Patchset: PS1: This is untested! -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iba01c29fb0aa3ab2ce7270bf12cb29c8ba59b389 Gerrit-Change-Number: 42724 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 May 2026 12:49:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-bts[master]: trx, bts: add optional WebSDR backend (callback-based transport)
by Timur Davydov 04 May '26

04 May '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email to look at the new patch set (#11). Change subject: trx, bts: add optional WebSDR backend (callback-based transport) ...................................................................... trx, bts: add optional WebSDR backend (callback-based transport) Introduce WebSDR backend enabled via ENABLE_WEBSDR, adding an alternative callback-based transport alongside existing socket-based TRX/OSMUX I/O Implement: - TRX control via osmotrxlib_process_command() - TRXD data via apitrx_tx_call()/trx_data_read() - clock handling via apibts_clock_ind() and external timers - Osmux integration via ws_osmux_* helpers Adapt scheduler to support API-based burst submission and external timer callbacks in WebSDR mode Disable signal handling, stats and socket I/O when building with ENABLE_WEBSDR Add WebSDR API entrypoint, Emscripten build target and example configuration Enables running BTS/TRX stack in WebAssembly environments Change-Id: Idebd588f33afd85021813ad5821391781db683a9 --- M .gitignore A doc/examples/trx/osmo-bts-trx-websdr.cfg M src/common/main.c M src/common/osmux.c M src/osmo-bts-trx/Makefile.am M src/osmo-bts-trx/main.c A src/osmo-bts-trx/osmo-bts-trx-websdr.c A src/osmo-bts-trx/osmo-bts-trx-websdr.h M src/osmo-bts-trx/scheduler_trx.c M src/osmo-bts-trx/trx_if.c M src/osmo-bts-trx/trx_vty.c 11 files changed, 723 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/03/42703/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9 Gerrit-Change-Number: 42703 Gerrit-PatchSet: 11 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in osmo-bts[master]: build: make sched_* usage optional
by pespin 04 May '26

04 May '26

Attention is currently required from: Timur Davydov, laforge. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email ) Change subject: build: make sched_* usage optional ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906 Gerrit-Change-Number: 42690 Gerrit-PatchSet: 7 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 04 May 2026 12:38:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log May 2026